{"id":2230705,"url":"http://patchwork.ozlabs.org/api/patches/2230705/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/patch/20260429-winbond-v6-18-rc1-cont-read-v3-6-0f38b3c229ad@bootlin.com/","project":{"id":56,"url":"http://patchwork.ozlabs.org/api/projects/56/?format=json","name":"OpenBMC development","link_name":"openbmc","list_id":"openbmc.lists.ozlabs.org","list_email":"openbmc@lists.ozlabs.org","web_url":"http://github.com/openbmc/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260429-winbond-v6-18-rc1-cont-read-v3-6-0f38b3c229ad@bootlin.com>","list_archive_url":null,"date":"2026-04-29T17:56:43","name":"[v3,06/11] mtd: spinand: Use secondary ops for continuous reads","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"adeb3a25293b60fa0d0c29566797c572c3a2382a","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openbmc/patch/20260429-winbond-v6-18-rc1-cont-read-v3-6-0f38b3c229ad@bootlin.com/mbox/","series":[{"id":502171,"url":"http://patchwork.ozlabs.org/api/series/502171/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/list/?series=502171","date":"2026-04-29T17:56:37","name":"mtd: spinand: Winbond continuous read support","version":3,"mbox":"http://patchwork.ozlabs.org/series/502171/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230705/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230705/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=ufpsxmOn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1871-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org; arc=none smtp.remote-ip=185.246.85.4","lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=ufpsxmOn;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com\n (client-ip=185.246.85.4; helo=smtpout-03.galae.net;\n envelope-from=miquel.raynal@bootlin.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ZTR4N6Lz1yGq\n\tfor ; Thu, 30 Apr 2026 10:16:11 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g5ZSc1YnFz2yqP;\n\tThu, 30 Apr 2026 10:15:28 +1000 (AEST)","from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g5QHQ13BDz2ykf\n\tfor ; Thu, 30 Apr 2026 04:06:57 +1000 (AEST)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id BC5E34E42B6F;\n\tWed, 29 Apr 2026 17:58:00 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 8FE375FD43;\n\tWed, 29 Apr 2026 17:58:00 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 6862E1072B175;\n\tWed, 29 Apr 2026 19:57:54 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777486023;\n\tcv=none;\n b=B7blr6PZ3ReuexVMBG/ULIOyvazYMGjnN+v/B0Xi/Fx3MdmpyQu09Y0LXn5/BR440ZFYB/J+tsghfx9Gw+hr2Nzk4+9EqYjTufp13icW00euUovvUi0iYQYX2AeRwMrMzxoFJWEmS6MQ7K0DrV4xV+ooqmq0TIB3fleadWH7jcN27XxmRKvnNXsmrCwnBQoiNa+sJ9gS3+UDh0jUxe+WDsNUhnti+FNB0nZ1bMbY/8AKmHINWqLIs/bBI4YPmeAxVBhFNPrihlCnP4PSb6mHHvD2iTGth1GVqdNGwgbG2E7CnRHCkH8X6g/puOZq/smWM4eKB4dw4JCNVGf1pr3b/A==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777486023; c=relaxed/relaxed;\n\tbh=5kdA1IC/RYXviplmXjfBx2K4qGRHF5L/z4JMU8G7heo=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=OsWfnZEWQ0Ga9tO4136q643UvvGCQVbJQbCrgO85amhuFId0OhIabtWgR392s7awYl5qiwxNWiCLtfBUwQm8LtjUxbuGvZrz68gbHmtQlh6aNl6aisOvCeiO+C0sTHZZ1RvxjpGVylZshGiKjZ+/EowE0jHdA4rvtfBzOZepcaxsgbPgS9UTN/Y0dS/Lpj0xWSi5QRRErykeWJEjJuGP+4V6synrhXpvNbPEX2kr5YmeDnw8p6cqQc02vArZy2VWq3U6wTt/E0WhDOz/sIRVzN293GKlY7F/7eYipIs2CIHHqSpPozmXNhPW8KHdnMl+rRvLp6U6D7gO49WfCagkNA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=ufpsxmOn; dkim-atps=neutral;\n spf=pass (client-ip=185.246.85.4; helo=smtpout-03.galae.net;\n envelope-from=miquel.raynal@bootlin.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=bootlin.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1777485478; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=5kdA1IC/RYXviplmXjfBx2K4qGRHF5L/z4JMU8G7heo=;\n\tb=ufpsxmOnbM4aWlTqONbvM/hU0uS6dcXEqlxSHSr1HWYBIfGT90YPkgaK0cuFSbVDO2ePk8\n\tpWi3bwyR8ypZOab+t1cJA74MjXfz7fLvozJ6V7qmbhj3f34ty/OOJYwRbTAzFsAix386Ly\n\tD1FsPPSsy7tCoNaMLBxBDPlrFb/XK+/uCgMaGjsQ2R+B/RuAlAGmsUx5DuKH7qOrDHX7rD\n\txayotK3EyInONV8I9cHKvaHPdCz3+n8OX+quL0wUzfkGZxlSYM7f+O8L+6M140LefKPS6/\n\t+pSdGDvUfdVqb0jYh6gv0v4c1CPJTYtO1hzRdfUdURt2Ao08UPOejiDAM7KKqQ==","From":"Miquel Raynal ","Date":"Wed, 29 Apr 2026 19:56:43 +0200","Subject":"[PATCH v3 06/11] mtd: spinand: Use secondary ops for continuous\n reads","X-Mailing-List":"openbmc@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-6-0f38b3c229ad@bootlin.com>","References":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","In-Reply-To":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","To":"Mark Brown , Richard Weinberger ,\n Vignesh Raghavendra , Michael Walle ,\n Miquel Raynal ,\n Takahiro Kuwano ,\n Lorenzo Bianconi , Ray Liu ,\n Chin-Ting Kuo , =?utf-8?q?C=C3=A9dric_Le_Goa?=\n\t=?utf-8?q?ter?= , Joel Stanley ,\n Andrew Jeffery ,\n Avi Fishman , Tomer Maimon ,\n Tali Perry , Patrick Venture ,\n Nancy Yuen , Benjamin Fair ,\n Maxime Coquelin ,\n Alexandre Torgue , =?utf-8?q?Jonathan_Neusch?=\n\t=?utf-8?q?=C3=A4fer?= ","Cc":"Pratyush Yadav ,\n Thomas Petazzoni ,\n Steam Lin , Santhosh Kumar K ,\n linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org,\n linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,\n linux-stm32@st-md-mailman.stormreply.com","X-Mailer":"b4 0.14.3","X-Last-TLS-Session-Version":"TLSv1.3","X-Spam-Status":"No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"In case a chip supports continuous reads, but uses a slightly different\ncache operation for these, it may provide a secondary operation template\nwhich will be used only during continuous cache read operations.\n\nFrom a vendor driver point of view, enabling this feature implies\nproviding a new set of templates for these continuous read\noperations. The core will automatically pick the fastest variant,\ndepending on the hardware capabilities.\n\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/spi/core.c | 61 ++++++++++++++++++++++++++++++++++++++++++++-\n include/linux/mtd/spinand.h | 12 +++++++++\n 2 files changed, 72 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c\nindex a66510747b31..45c3afb9cceb 100644\n--- a/drivers/mtd/nand/spi/core.c\n+++ b/drivers/mtd/nand/spi/core.c\n@@ -489,6 +489,11 @@ static int spinand_read_from_cache_op(struct spinand_device *spinand,\n \n \trdesc = spinand->dirmaps[req->pos.plane].rdesc;\n \n+\tif (spinand->op_templates->cont_read_cache && req->continuous)\n+\t\trdesc->info.op_tmpl = &rdesc->info.secondary_op_tmpl;\n+\telse\n+\t\trdesc->info.op_tmpl = &rdesc->info.primary_op_tmpl;\n+\n \tif (nand->ecc.engine->integration == NAND_ECC_ENGINE_INTEGRATION_PIPELINED &&\n \t req->mode != MTD_OPS_RAW)\n \t\trdesc->info.op_tmpl->data.ecc = true;\n@@ -1221,6 +1226,7 @@ static struct spi_mem_dirmap_desc *spinand_create_rdesc(\n \t\t * its spi controller, use regular reading\n \t\t */\n \t\tspinand->cont_read_possible = false;\n+\t\tmemset(&info->secondary_op_tmpl, 0, sizeof(info->secondary_op_tmpl));\n \n \t\tinfo->length = nanddev_page_size(nand) +\n \t\t\t nanddev_per_page_oobsize(nand);\n@@ -1237,11 +1243,24 @@ static int spinand_create_dirmap(struct spinand_device *spinand,\n \tstruct nand_device *nand = spinand_to_nand(spinand);\n \tstruct spi_mem_dirmap_info info = { 0 };\n \tstruct spi_mem_dirmap_desc *desc;\n-\tbool enable_ecc = false;\n+\tbool enable_ecc = false, secondary_op = false;\n \n \tif (nand->ecc.engine->integration == NAND_ECC_ENGINE_INTEGRATION_PIPELINED)\n \t\tenable_ecc = true;\n \n+\tif (spinand->cont_read_possible && spinand->op_templates->cont_read_cache)\n+\t\tsecondary_op = true;\n+\n+\t/*\n+\t * Continuous read implies that only the main data is retrieved, backed\n+\t * by an on-die ECC engine. It is not possible to use a pipelind ECC\n+\t * engine with continuous read.\n+\t */\n+\tif (enable_ecc && secondary_op) {\n+\t\tsecondary_op = false;\n+\t\tspinand->cont_read_possible = false;\n+\t}\n+\n \t/* The plane number is passed in MSB just above the column address */\n \tinfo.offset = plane << fls(nand->memorg.pagesize);\n \n@@ -1259,6 +1278,10 @@ static int spinand_create_dirmap(struct spinand_device *spinand,\n \t/* Read descriptor */\n \tinfo.primary_op_tmpl = *spinand->op_templates->read_cache;\n \tinfo.primary_op_tmpl.data.ecc = enable_ecc;\n+\tif (secondary_op) {\n+\t\tinfo.secondary_op_tmpl = *spinand->op_templates->cont_read_cache;\n+\t\tinfo.secondary_op_tmpl.data.ecc = enable_ecc;\n+\t}\n \tdesc = spinand_create_rdesc(spinand, &info);\n \tif (IS_ERR(desc))\n \t\treturn PTR_ERR(desc);\n@@ -1607,6 +1630,33 @@ int spinand_match_and_init(struct spinand_device *spinand,\n \t\tif (ret)\n \t\t\treturn ret;\n \n+\t\tif (info->op_variants.cont_read_cache) {\n+\t\t\top = spinand_select_op_variant(spinand, SSDR,\n+\t\t\t\t\t\t info->op_variants.cont_read_cache);\n+\t\t\tif (op) {\n+\t\t\t\tconst struct spi_mem_op *read_op;\n+\n+\t\t\t\tread_op = spinand->ssdr_op_templates.read_cache;\n+\n+\t\t\t\t/*\n+\t\t\t\t * Sometimes the fastest continuous read variant may not\n+\t\t\t\t * be supported. In this case, prefer to use the fastest\n+\t\t\t\t * read from cache variant and disable continuous reads.\n+\t\t\t\t */\n+\t\t\t\tif (read_op->cmd.buswidth > op->cmd.buswidth ||\n+\t\t\t\t (read_op->cmd.dtr && !op->cmd.dtr) ||\n+\t\t\t\t read_op->addr.buswidth > op->addr.buswidth ||\n+\t\t\t\t (read_op->addr.dtr && !op->addr.dtr) ||\n+\t\t\t\t read_op->data.buswidth > op->data.buswidth ||\n+\t\t\t\t (read_op->data.dtr && !op->data.dtr))\n+\t\t\t\t\tspinand->cont_read_possible = false;\n+\t\t\t\telse\n+\t\t\t\t\tspinand->ssdr_op_templates.cont_read_cache = op;\n+\t\t\t} else {\n+\t\t\t\tspinand->cont_read_possible = false;\n+\t\t\t}\n+\t\t}\n+\n \t\t/* I/O variants selection with octo-spi DDR commands (optional) */\n \n \t\tret = spinand_init_odtr_instruction_set(spinand);\n@@ -1629,6 +1679,15 @@ int spinand_match_and_init(struct spinand_device *spinand,\n \t\t\t\t\t info->op_variants.update_cache);\n \t\tspinand->odtr_op_templates.update_cache = op;\n \n+\t\tif (info->op_variants.cont_read_cache) {\n+\t\t\top = spinand_select_op_variant(spinand, ODTR,\n+\t\t\t\t\t\t info->op_variants.cont_read_cache);\n+\t\t\tif (op)\n+\t\t\t\tspinand->odtr_op_templates.cont_read_cache = op;\n+\t\t\telse\n+\t\t\t\tspinand->cont_read_possible = false;\n+\t\t}\n+\n \t\treturn 0;\n \t}\n \ndiff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h\nindex 896e9b5de0c4..4ff3f3383d46 100644\n--- a/include/linux/mtd/spinand.h\n+++ b/include/linux/mtd/spinand.h\n@@ -576,6 +576,7 @@ enum spinand_bus_interface {\n * @op_variants.read_cache: variants of the read-cache operation\n * @op_variants.write_cache: variants of the write-cache operation\n * @op_variants.update_cache: variants of the update-cache operation\n+ * @op_variants.cont_read_cache: variants of the continuous read-cache operation\n * @vendor_ops: vendor specific operations\n * @select_target: function used to select a target/die. Required only for\n *\t\t multi-die chips\n@@ -600,6 +601,7 @@ struct spinand_info {\n \t\tconst struct spinand_op_variants *read_cache;\n \t\tconst struct spinand_op_variants *write_cache;\n \t\tconst struct spinand_op_variants *update_cache;\n+\t\tconst struct spinand_op_variants *cont_read_cache;\n \t} op_variants;\n \tconst struct spinand_op_variants *vendor_ops;\n \tint (*select_target)(struct spinand_device *spinand,\n@@ -629,6 +631,14 @@ struct spinand_info {\n \t\t.update_cache = __update,\t\t\t\t\\\n \t}\n \n+#define SPINAND_INFO_OP_VARIANTS_WITH_CONT(__read, __write, __update, __cont_read) \\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\t.read_cache = __read,\t\t\t\t\t\\\n+\t\t.write_cache = __write,\t\t\t\t\t\\\n+\t\t.update_cache = __update,\t\t\t\t\\\n+\t\t.cont_read_cache = __cont_read,\t\t\t\t\\\n+\t}\n+\n #define SPINAND_INFO_VENDOR_OPS(__ops)\t\t\t\t\t\\\n \t.vendor_ops = __ops\n \n@@ -700,6 +710,7 @@ struct spinand_dirmap {\n * @read_cache: read cache op template\n * @write_cache: write cache op template\n * @update_cache: update cache op template\n+ * @cont_read_cache: continuous read cache op template (optional)\n */\n struct spinand_mem_ops {\n \tstruct spi_mem_op reset;\n@@ -714,6 +725,7 @@ struct spinand_mem_ops {\n \tconst struct spi_mem_op *read_cache;\n \tconst struct spi_mem_op *write_cache;\n \tconst struct spi_mem_op *update_cache;\n+\tconst struct spi_mem_op *cont_read_cache;\n };\n \n /**\n","prefixes":["v3","06/11"]}