{"id":2230698,"url":"http://patchwork.ozlabs.org/api/patches/2230698/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430000524.56046-23-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430000524.56046-23-richard.henderson@linaro.org>","list_archive_url":null,"date":"2026-04-30T00:05:05","name":"[v2,22/40] fpu: Return struct from parts{64, 128}_pick_nan_muladd","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"988b8910d948c4c55fd3e700d954187bd6072bae","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430000524.56046-23-richard.henderson@linaro.org/mbox/","series":[{"id":502170,"url":"http://patchwork.ozlabs.org/api/series/502170/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502170","date":"2026-04-30T00:04:48","name":"fpu: Export some internals for targets","version":2,"mbox":"http://patchwork.ozlabs.org/series/502170/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230698/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230698/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=O7BHsI/2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ZMM3YDtz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 10:10:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIEvt-00009P-PC; Wed, 29 Apr 2026 20:07:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIEv8-0007jZ-9Y\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:06:24 -0400","from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIEv6-0001q5-L9\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:06:21 -0400","by mail-pf1-x42e.google.com with SMTP id\n d2e1a72fcca58-82cf636dac8so171848b3a.3\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 17:06:19 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-834ed7ef7a8sm2928667b3a.47.2026.04.29.17.06.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 17:06:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777507579; x=1778112379; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NyGaCW7gD91Dm1boSLyd8Ffs2ydc5g5SItzum+VAxMU=;\n b=O7BHsI/2VsG94d+eA6rMgvYxb0gYMQsUzALdIEbJkt3LKDeWhAVITYermOJtlZaWLM\n yxMIHXWABOR3W9+60yyzOIh7ZB2LCH+Sg1j/JaXB1CKLG/wJOMS/LuVv6gK/ElmpImdv\n tUvRLwTmvtBCZY8g5ilxWn/RcI5ZQ8tWejPMvuLhxNy94Rwz/GCTXVSfncyO7yJg9cZw\n 9QYV880p3CY/0JnC9mtsQ3e5cbrZFgFHXvjQsMPGHiJXtDkaTBOKz2+0p589g1r8T0Pi\n 4MUOCM1nxg9I8cviVY9zoSpIygmOHcVKAuohFakiEw7ZUg5cyvzQjj+gkUdCR1HTUzxn\n tmaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777507579; x=1778112379;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=NyGaCW7gD91Dm1boSLyd8Ffs2ydc5g5SItzum+VAxMU=;\n b=MfeNTfVsIOVH/7PXKbTiGlFL8+miO2tPzbWnShdqakBDQU9L5VrjrA33gP1wBbFMLG\n htXLSD18v9y6hzvVzfJ05CrRDJ1O2F6fYSPbkFQMaJTKcUz6hbrFD+lHjF0gPx1zqBBD\n hOJaHctWRRaZrw+5qPwVYJ9gZq82BwLy4+Is80gRDlCI0sLYZAhbAh+E9n81X06V5SOi\n 5x4FXmQGoeocIZYpAxWCkKTe5N8zj4gHKqsr7jaHXvltLJ4zH9l+ZEVm9X9oPTl3UDgs\n KP4Q4lDxQ5bg0RvHnoF966N9sh2+cWqQQn/+eiNHLYuN5JJtlI6y2r3gG7Z0SDJyXBng\n nRlg==","X-Gm-Message-State":"AOJu0YxEGh4hSL8TRKA+jusXjBVzAtejaK9ZeVIrUOvA1Zr8CXiS+FbU\n dN70c4tJET2p8FIpVUNHVVNlJa4j/o9O194Gdd4CtMqzVfb6tJ1gT9yLBhhHeesHiCM3sA0JHOW\n stwIgckE=","X-Gm-Gg":"AeBDievg2vPrwod5uFKkqNNxEA+KxMIXW6vt071XkMzO8kbycgrmq0nJMsHaFehjt4q\n A5kdBZXC45trLR/VG3udxICMv2zQxMOOmmYNniWwgcHjqBZ/P6iGCFX2Ga/wEjP6d8ll8JHKEwm\n Om9mdtXBR4Wj9dAO7cWqLJKsm/LpAtO6EAFdYUmfTUmhc9X11HNu7HFJKDSMKMYBwWxrq4kmjOu\n G7mvMpPp+bpAFDDJXfJFsC1t1IeH3APFhUzDr0w1cn+k4RaO+KqpMYakvJFlT6qkRT2tP6qe1G2\n 1f73I2sKd/av8RJKZiTRnpH+KF154yqsQtQDt5vV7zCT4v49WFa1+d6kV1sC42yA7R29k2/FFDW\n c2w9t3imCGrZMHtNcX6drE0+ODhbBRSH0+vEbRtINFUpryzoqy6oRuTJ9Iw8qrAUh968kVX7+rT\n AHfjnIve+TyEIdyJLTkd2sO9Ov8v5Wzgd0U/BOhY7x","X-Received":"by 2002:a05:6a00:a10:b0:82c:e9cc:f62f with SMTP id\n d2e1a72fcca58-834fdb07d83mr765930b3a.7.1777507578755;\n Wed, 29 Apr 2026 17:06:18 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"philmd@linaro.org","Subject":"[PATCH v2 22/40] fpu: Return struct from parts{64,\n 128}_pick_nan_muladd","Date":"Thu, 30 Apr 2026 10:05:05 +1000","Message-ID":"<20260430000524.56046-23-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430000524.56046-1-richard.henderson@linaro.org>","References":"<20260430000524.56046-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42e;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat-parts.c.inc | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)","diff":"diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 7d4b40022b..211ecdf114 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -114,13 +114,15 @@ FloatPartsN partsN(pick_nan)(const FloatPartsN *a, const FloatPartsN *b,\n     return *ret;\n }\n \n-static FloatPartsN *partsN(pick_nan_muladd)(FloatPartsN *a, FloatPartsN *b,\n-                                            FloatPartsN *c, float_status *s,\n-                                            int ab_mask, int abc_mask)\n+static FloatPartsN partsN(pick_nan_muladd)(const FloatPartsN *a,\n+                                           const FloatPartsN *b,\n+                                           const FloatPartsN *c,\n+                                           float_status *s,\n+                                           int ab_mask, int abc_mask)\n {\n     bool infzero = (ab_mask == float_cmask_infzero);\n     bool have_snan = (abc_mask & float_cmask_snan);\n-    FloatPartsN *ret;\n+    const FloatPartsN *ret;\n \n     if (unlikely(have_snan)) {\n         float_raise(float_flag_invalid | float_flag_invalid_snan, s);\n@@ -160,7 +162,7 @@ static FloatPartsN *partsN(pick_nan_muladd)(FloatPartsN *a, FloatPartsN *b,\n         }\n         ret = c;\n     } else {\n-        FloatPartsN *val[R_3NAN_1ST_MASK + 1] = { a, b, c };\n+        const FloatPartsN *val[R_3NAN_1ST_MASK + 1] = { a, b, c };\n         Float3NaNPropRule rule = s->float_3nan_prop_rule;\n \n         assert(rule != float_3nan_prop_none);\n@@ -179,13 +181,12 @@ static FloatPartsN *partsN(pick_nan_muladd)(FloatPartsN *a, FloatPartsN *b,\n     }\n \n     if (is_snan(ret->cls)) {\n-        *ret = partsN(silence_nan)(ret, s);\n+        return partsN(silence_nan)(ret, s);\n     }\n-    return ret;\n+    return *ret;\n \n  default_nan:\n-    *a = partsN(default_nan)(s);\n-    return a;\n+    return partsN(default_nan)(s);\n }\n \n /*\n@@ -698,7 +699,8 @@ static FloatPartsN *partsN(muladd_scalbn)(FloatPartsN *a, FloatPartsN *b,\n      * off to the target-specific pick-a-NaN routine.\n      */\n     if (unlikely(abc_mask & float_cmask_anynan)) {\n-        return partsN(pick_nan_muladd)(a, b, c, s, ab_mask, abc_mask);\n+        *a = partsN(pick_nan_muladd)(a, b, c, s, ab_mask, abc_mask);\n+        return a;\n     }\n \n     if (flags & float_muladd_negate_c) {\n","prefixes":["v2","22/40"]}