{"id":2230668,"url":"http://patchwork.ozlabs.org/api/patches/2230668/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430000524.56046-14-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430000524.56046-14-richard.henderson@linaro.org>","list_archive_url":null,"date":"2026-04-30T00:04:56","name":"[v2,13/40] fpu: Return struct from parts{64,128}_silence_nan","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cc155488278cd061a6483d1eec7617f96762cf62","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430000524.56046-14-richard.henderson@linaro.org/mbox/","series":[{"id":502170,"url":"http://patchwork.ozlabs.org/api/series/502170/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502170","date":"2026-04-30T00:04:48","name":"fpu: Export some internals for targets","version":2,"mbox":"http://patchwork.ozlabs.org/series/502170/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230668/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230668/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kok9QKUY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ZGb5kDCz1yHZ\n\tfor ; Thu, 30 Apr 2026 10:06:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIEur-0006h3-3i; Wed, 29 Apr 2026 20:06:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIEun-0006Zr-RH\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:06:01 -0400","from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIEum-0001mP-6l\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:06:01 -0400","by mail-pf1-x429.google.com with SMTP id\n d2e1a72fcca58-83177129e28so158489b3a.1\n for ; Wed, 29 Apr 2026 17:05:59 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-834ed7ef7a8sm2928667b3a.47.2026.04.29.17.05.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 17:05:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777507559; x=1778112359; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wWJrfKmeP7SU5fQs6ar9lmfrjUnpO5JxKfUBv73woWo=;\n b=kok9QKUYCty4WSAnnlToL1tgECkUvtkYo8c5jYwlZKLNdrj0slteMxaQO90971MryH\n VRd2g49iQiFcqnpM+jX3xF1SkVe5bSRPBHu6WtikgmMoxgnHvbja9gqr8ej+M0/zGxdM\n 2E2TIsInrHMpVBvcaQmECJdPm7FRgV05Crl2MXtOQJZ8BxFddvDFfLrNR509U/lEvJAG\n TSf9y9ZknlDzNMIBjr6e9Xz+TsqlBEptjwsFtxIiQRSXryhSsl/616XP/UYw5RKe7HLI\n r/nBvOZtctDgXitduC/qKURU9GrcoALRN/Q0tG42jZsotZEXGErGsYGLXQp71GMpM1DN\n Jztw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777507559; x=1778112359;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=wWJrfKmeP7SU5fQs6ar9lmfrjUnpO5JxKfUBv73woWo=;\n b=kl9oV0hWrZ/9eUmdhUgMSS2oevVYyEEQOiZkLrAK5spNJ5vmANgmlhG5bAqHpbrCJY\n ioJ4mw6Pk9/KIWD51LhCXVpu177nr+Hq1Cuqmvq4zIZbsjCLmsy4KC0/eVo9pvWx+J/p\n 9Gn9Kp2/iP6DMPMGUVGBLAQmUQNVH1pU++p8RZjW7gI6Ijdpak0NPMJJEEa+xtYUTFRt\n 1wzQYmUG0FRAHBWSWELj1kswB6NSckmv35k7MSJMzJ3JNZINHEgA8MWBxj2TBgb5pXnf\n KYvZR9UOMSzL9cgsK71+iy9Ta6ifwHwPtc+HrglzUd+rkHs09QpFSoG/j2CT2+OsqPcW\n lXsw==","X-Gm-Message-State":"AOJu0Yw7Jndq6tMf1h0b6RTWLwOTIPY7L5TgIl0Cjn3elN8soPHivhuI\n JL/6OV4lSlM8d07KohzvH5Tp0B1RvoIAbQgxGGXYn82KAv9FMEMWODzp3aC8JdULGYhlWUM7MpG\n 6l/2zTN8=","X-Gm-Gg":"AeBDietDzcZDGgsT8RNfQCgym/YlZH/XxYmZYAmyA00AzHRTvJ3ZcTf6TuJKbA15La0\n tIF8T1+1PBRk+Pmk92REoc7PSObfNbeRX3HyUSOA1Q2ohlP3po2+BNQP0nKseeGYvKIM+/inOQs\n w/VwE+ByhaTBeSFUgvtoQ0VZyWFjaf3bHe2qJyg6NTgjQP5XL0mt41RZbpvh3WB4LFlG+TuPZNn\n soF7Rx5CAMi0uh/QV4JOkQogVJ4N1pkVZ/rNveGmbclAYY94l6/412oZoI0btvT5C51iiVZ7OiX\n H5NLchWeOw+KKTy6m5oQuYib6UTZ2n678K06IbLG/oJFN6wI9OzU7LZUV9nfA9BRConVxkf7OCn\n WfFN5IES2qbM8/9/dnqi7aHFsomUHn3jOVK7jVOboe7LQC982wdOeEujHVhENgHqDbVL37cdZh6\n Q0dAHy3dd0XOJMTEMBUhKL4PyoGODpJLKZNwinwLWp","X-Received":"by 2002:a05:6a00:4503:b0:82d:5da9:adbf with SMTP id\n d2e1a72fcca58-834fdccc01fmr870255b3a.41.1777507558546;\n Wed, 29 Apr 2026 17:05:58 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"philmd@linaro.org","Subject":"[PATCH v2 13/40] fpu: Return struct from parts{64,128}_silence_nan","Date":"Thu, 30 Apr 2026 10:04:56 +1000","Message-ID":"<20260430000524.56046-14-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430000524.56046-1-richard.henderson@linaro.org>","References":"<20260430000524.56046-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::429;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Richard Henderson \n---\n fpu/softfloat.c | 10 +++++-----\n fpu/softfloat-parts.c.inc | 6 +++---\n fpu/softfloat-specialize.c.inc | 20 ++++++++++++++------\n 3 files changed, 22 insertions(+), 14 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex fa8913a288..9c1e6fdce4 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -4634,7 +4634,7 @@ float16 float16_silence_nan(float16 a, float_status *status)\n FloatParts64 p = unpack_raw64(&float16_params, a);\n \n p.frac <<= float16_params.frac_shift;\n- parts64_silence_nan(&p, status);\n+ p = parts64_silence_nan(&p, status);\n p.frac >>= float16_params.frac_shift;\n return pack_raw64(&p, &float16_params);\n }\n@@ -4644,7 +4644,7 @@ float32 float32_silence_nan(float32 a, float_status *status)\n FloatParts64 p = unpack_raw64(&float32_params, a);\n \n p.frac <<= float32_params.frac_shift;\n- parts64_silence_nan(&p, status);\n+ p = parts64_silence_nan(&p, status);\n p.frac >>= float32_params.frac_shift;\n return pack_raw64(&p, &float32_params);\n }\n@@ -4654,7 +4654,7 @@ float64 float64_silence_nan(float64 a, float_status *status)\n FloatParts64 p = unpack_raw64(&float64_params, a);\n \n p.frac <<= float64_params.frac_shift;\n- parts64_silence_nan(&p, status);\n+ p = parts64_silence_nan(&p, status);\n p.frac >>= float64_params.frac_shift;\n return pack_raw64(&p, &float64_params);\n }\n@@ -4664,7 +4664,7 @@ bfloat16 bfloat16_silence_nan(bfloat16 a, float_status *status)\n FloatParts64 p = unpack_raw64(&bfloat16_params, a);\n \n p.frac <<= bfloat16_params.frac_shift;\n- parts64_silence_nan(&p, status);\n+ p = parts64_silence_nan(&p, status);\n p.frac >>= bfloat16_params.frac_shift;\n return pack_raw64(&p, &bfloat16_params);\n }\n@@ -4674,7 +4674,7 @@ float128 float128_silence_nan(float128 a, float_status *status)\n FloatParts128 p = float128_unpack_raw(a);\n \n frac128_shl(&p, float128_params.frac_shift);\n- parts128_silence_nan(&p, status);\n+ p = parts128_silence_nan(&p, status);\n frac128_shr(&p, float128_params.frac_shift);\n return float128_pack_raw(&p);\n }\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex ed7080d886..4733755f35 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -23,7 +23,7 @@ static void partsN(return_nan)(FloatPartsN *a, float_status *s)\n if (s->default_nan_mode) {\n *a = partsN(default_nan)(s);\n } else {\n- partsN(silence_nan)(a, s);\n+ *a = partsN(silence_nan)(a, s);\n }\n break;\n case float_class_qnan:\n@@ -109,7 +109,7 @@ static FloatPartsN *partsN(pick_nan)(FloatPartsN *a, FloatPartsN *b,\n }\n \n if (is_snan(ret->cls)) {\n- partsN(silence_nan)(ret, s);\n+ *ret = partsN(silence_nan)(ret, s);\n }\n return ret;\n }\n@@ -179,7 +179,7 @@ static FloatPartsN *partsN(pick_nan_muladd)(FloatPartsN *a, FloatPartsN *b,\n }\n \n if (is_snan(ret->cls)) {\n- partsN(silence_nan)(ret, s);\n+ *ret = partsN(silence_nan)(ret, s);\n }\n return ret;\n \ndiff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc\nindex dd65432813..2723bf5e61 100644\n--- a/fpu/softfloat-specialize.c.inc\n+++ b/fpu/softfloat-specialize.c.inc\n@@ -179,16 +179,24 @@ static uint64_t parts_silence_nan_frac(uint64_t frac, float_status *status)\n return frac;\n }\n \n-static void parts64_silence_nan(FloatParts64 *p, float_status *status)\n+static FloatParts64 parts64_silence_nan(const FloatParts64 *p,\n+ float_status *status)\n {\n- p->frac = parts_silence_nan_frac(p->frac, status);\n- p->cls = float_class_qnan;\n+ FloatParts64 r = *p;\n+\n+ r.frac = parts_silence_nan_frac(r.frac, status);\n+ r.cls = float_class_qnan;\n+ return r;\n }\n \n-static void parts128_silence_nan(FloatParts128 *p, float_status *status)\n+static FloatParts128 parts128_silence_nan(const FloatParts128 *p,\n+ float_status *status)\n {\n- p->frac_hi = parts_silence_nan_frac(p->frac_hi, status);\n- p->cls = float_class_qnan;\n+ FloatParts128 r = *p;\n+\n+ r.frac_hi = parts_silence_nan_frac(r.frac_hi, status);\n+ r.cls = float_class_qnan;\n+ return r;\n }\n \n /*----------------------------------------------------------------------------\n","prefixes":["v2","13/40"]}