{"id":2230652,"url":"http://patchwork.ozlabs.org/api/patches/2230652/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/177750475157.3021974.6858117535916205046@talencesecurity.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<177750475157.3021974.6858117535916205046@talencesecurity.com>","list_archive_url":null,"date":"2026-04-29T23:19:11","name":"[v2,2/2] netfilter: ip6_tables: guard ip6t_unregister_table_pre_exit against NULL ops","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"511ce41d6be4c8c50dcea65417ca4e6b1255d1e6","submitter":{"id":93179,"url":"http://patchwork.ozlabs.org/api/people/93179/?format=json","name":"Tristan Madani","email":"tristmd@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/177750475157.3021974.6858117535916205046@talencesecurity.com/mbox/","series":[{"id":502165,"url":"http://patchwork.ozlabs.org/api/series/502165/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502165","date":"2026-04-29T23:18:45","name":"netfilter: fix NULL ops dereference in iptable lazy init","version":2,"mbox":"http://patchwork.ozlabs.org/series/502165/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230652/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230652/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Hnc4IVGS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12311-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"Hnc4IVGS\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.54","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5YDp31cBz1yHZ\n\tfor ; Thu, 30 Apr 2026 09:20:10 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 70816300F186\n\tfor ; Wed, 29 Apr 2026 23:19:23 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 326ED39DBE1;\n\tWed, 29 Apr 2026 23:19:16 +0000 (UTC)","from mail-wr1-f54.google.com (mail-wr1-f54.google.com\n [209.85.221.54])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E49399001\n\tfor ; Wed, 29 Apr 2026 23:19:14 +0000 (UTC)","by mail-wr1-f54.google.com with SMTP id\n ffacd0b85a97d-43d43e09de5so146046f8f.1\n for ;\n Wed, 29 Apr 2026 16:19:14 -0700 (PDT)","from debian ([2001:41d0:303:db6b::])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b3d48517sm7502180f8f.5.2026.04.29.16.19.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 16:19:12 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777504755; cv=none;\n b=cbVubn9IYlIZolWJenXLMKTuSgH7Qt18BzviFlkoHiSGF0d5D2lI07fuEiPZHJhlcgkppsbs7ILRpVHsxvtNAdedUvLczNOUH+G35yJiYxr/pmpjqWHuI5ucvuCzlBEg7n3C07BBKJEfvmkXe5Urc63iVsFrZcTktxZtcy/xJDI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777504755; c=relaxed/simple;\n\tbh=vnf9u5bZr2Jh4vHEhpzns0hJLI6h1CacL4VAyx/kSbw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=J/mXdQQGk+EP4Ll7ZWGke1TVdZr3VJLUyd/5BjZLMgywbWhMx9yJN7xY6rnXvXfe1k+6jY2OznJD5nXatpXYB514EIbNcMDqzeBeO471arq+8yD+nkOFWMLnPqA8Sdkmc/RuIrhjLyZkMDBf7sAxaJj/cIyOrF5tTrxUG6kMipg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=Hnc4IVGS; arc=none smtp.client-ip=209.85.221.54","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777504753; x=1778109553;\n darn=vger.kernel.org;\n h=mime-version:content-transfer-encoding:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Xg4uL55KM0rpFJAt2ymSaCICrZWf1oCpfyBNCgcrMb4=;\n b=Hnc4IVGS5eyTt3dBGI3jm2Yi6bpyGq2/IUGR094lMMJWJAtbIgU/AOcylkkxkIsEvz\n Dfss/BJgqLchl9JUobzRcrZ/hzevpBuKHvo5Qtt5BL6Ha9wZgK6iZh7huH5HQ4QizekW\n 6wfl2WkpR6hreV1/2kHsZxbrwaQpi3TphNw/dgR716Vz06x0TF0VfHIlMWs/DGvGw61G\n UVLQu2Ahx/yphAhkflW72+qQdlyef0tjbrqq7B1RqzWv7rd67inn/DiHm6cEy/oKnvQ4\n iq1GElBXS9UIav1DK2Cj5W0W71i6HVJEfPDJDJbt1OgXhDcI+GaXZdwJf7DKa1WHB27R\n TtrA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777504753; x=1778109553;\n h=mime-version:content-transfer-encoding:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Xg4uL55KM0rpFJAt2ymSaCICrZWf1oCpfyBNCgcrMb4=;\n b=dK83S+GBNMBIv//DO1hjpBBB3pWzkMbG7sJ900/IcXB5SfxGcl+cn4unKrQe5ewDA0\n jfA17M6RHJxplj+5dE+QbGo1XtC7wYLdqE4jfH1qzDB/7Zkl2ktnoixfRMesjruU3WeI\n L9S0qJxXHw3w0tal6O5AXhlBH4zM9z15F7HoxZRAZHkbSKOXXjCPiTfbqG8iTip894mn\n RP2DVDlPZ3cD53KxAv4L3fPOXPY4EQ99v5wgMgw4PtmtOC4ZwQqFPFcU/2QqXETsMRvw\n E3MPn6JSeCNO1y24FOBkiVt8CakK93ZZ5Qu7gskQ0AYNVBfsHxVVbLQb9hz3UqIwlmUa\n kFPA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8O5VpiiRiVm5+ILVzgq9fqs6kq9sXkXzN6FTkcm+vQbTTFSVTTg2lIb3uxZj2eJ3reG6vdK3wEE0kR7yvlswg=@vger.kernel.org","X-Gm-Message-State":"AOJu0YySap7K1KVo7lTvuX0JbeQgTa8dEDChVZx+F0HF+pEnrL5eEogr\n\tXaFZhj/O5fMI86koSOYRT4EgMZTtu8S5w7eouiSg9JFw/dPpEZFQ3mM=","X-Gm-Gg":"AeBDies2biooxS6lwX+060LKNFIZkwqBhojPmtL9GMt1OyhlAtV4l20/W0OOtg3XZTJ\n\t51fwTZJq9WuxRcnHLGoL9M/vFe8cgk/H0VruyqdssGEO+PlBlz1CM2edQC9G++Bmd6oeb5ONagQ\n\tcOEjy4JDVCmQEj+24wavj0XnNcixUQGMAiwnJ2cFIrBpTiK0+WsLgaY7SrWIPbcfWwyB7qfv22O\n\tv5yAVg5ug6DEYf0fPzaybSmC8Rz5rYjxKznNa/Pg8j2p6edErttaZrsr47EiMxS17/7Oxw52pvZ\n\tf4dfH8hoiW8cFys7Q8BMtB08IhXR9y2q1ApM2FdMIgjyMcxD6XYtVUJA/3oA+Krb2GS1cgzKKc3\n\tinwfuu0Ux5PUIqrUWO+qT8D+PqS6tcSsfKpKobZA0x+uVs0HkisERIaFDTBDUPYDHX+2Fl5y7Ca\n\tTQkHXwfC3vJBVZyg==","X-Received":"by 2002:a05:6000:611:b0:43e:a81d:c475 with SMTP id\n ffacd0b85a97d-4493cf2d583mr611329f8f.6.1777504752636;\n Wed, 29 Apr 2026 16:19:12 -0700 (PDT)","From":"Tristan Madani ","X-Google-Original-From":"Tristan Madani ","To":"Pablo Neira Ayuso ","Cc":"Phil Sutter , Florian Westphal ,\n netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,\n stable@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH v2 2/2] netfilter: ip6_tables: guard\n ip6t_unregister_table_pre_exit against NULL ops","Date":"Wed, 29 Apr 2026 23:19:11 -0000","Message-ID":"<177750475157.3021974.6858117535916205046@talencesecurity.com>","In-Reply-To":"<177750472539.3004201.15967003942391945312@talencesecurity.com>","References":"<20260429175613.1459342-1-tristmd@gmail.com>\n <177750472539.3004201.15967003942391945312@talencesecurity.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0"},"content":"Same race as the ipv4 counterpart: ip6t_register_table() adds the\ntable to the per-netns list before assigning new_table->ops.\ncleanup_net can find the table with a NULL ops pointer and crash in\nnf_unregister_net_hooks().\n\nGuard against this by checking table->ops before the call.\n\nFixes: ee177a54413a (\"netfilter: ip6_tables: Use xt_register_table()\")\nCc: stable@vger.kernel.org\nSigned-off-by: Tristan Madani \n---\n net/ipv6/netfilter/ip6_tables.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c\nindex XXXXXXX..XXXXXXX 100644\n--- a/net/ipv6/netfilter/ip6_tables.c\n+++ b/net/ipv6/netfilter/ip6_tables.c\n@@ -1804,7 +1804,7 @@ void ip6t_unregister_table_pre_exit(struct net *net, const char *name)\n {\n \tstruct xt_table *table = xt_find_table(net, NFPROTO_IPV6, name);\n\n-\tif (table)\n+\tif (table && table->ops)\n \t\tnf_unregister_net_hooks(net, table->ops, hweight32(table->valid_hooks));\n }\n\n","prefixes":["v2","2/2"]}