{"id":2230630,"url":"http://patchwork.ozlabs.org/api/patches/2230630/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-34-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260429222445.26301-34-richard.henderson@linaro.org>","list_archive_url":null,"date":"2026-04-29T22:24:30","name":"[PULL,33/48] fpu: Return struct from float4_e2m1_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc12500b43674fedc8c9c78952cd9f4dbce838f9","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-34-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230630/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230630/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=c+Qls06m;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X5l0xzGz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 08:28:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIDMK-0002w7-6x; Wed, 29 Apr 2026 18:26:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDMI-0002hJ-Jv\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:26:18 -0400","from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDMG-0005Gp-Vq\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:26:18 -0400","by mail-pj1-x102a.google.com with SMTP id\n 98e67ed59e1d1-35fb166b0c6so737194a91.0\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 15:26:16 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.26.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:26:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501575; x=1778106375; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7O4hKnrM8IFMNxLNYNqBPp5uIxhITOfd/CNA0UapkwA=;\n b=c+Qls06mKIvA6OKpaUIGg9JSLpqCtAeQP9eerTgp5Memp2Qnb0Y6MWWXmyfGxdJgiY\n Uz25IZ760ePGskruOvr7y5IvfW7MHGzL6y07/xRB9o1F6jd6xA6v9INctzVIaGWd0Emq\n rFIo1v1k+uj4ayrqiqG0mBqN14ysYvTN+gw//righnPMMEATxCA6joEF+e6BFa8vWez/\n TK9B9MB36zATxij3Ur1oKrby2fVSV+S5kU0hnhXXj5IJFP9VSZs5b3jkftkCmhzGaTyI\n 59jiyH2Jrs2ky+PEh3qFVKd5lkFlahZUIOOgd3N7B13pCoCBbZTbpxIHk3oAF+wn380Y\n 3oTw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501575; x=1778106375;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7O4hKnrM8IFMNxLNYNqBPp5uIxhITOfd/CNA0UapkwA=;\n b=KcaO0YWtOJJhM45T8XGdPeIFzaxSgbWaYVtgC2Z0pxdBEOYP4lSFaBY1YaEIsRyizs\n IbTQznp/+OgvAu5zrU0ZQW+ErjbUNfy1p/2ef5Zq5P/fDZ6uCOD8WhzAwMVDI60WjZ9L\n KgYfdViFPZQrTZtU++XESSTHORtAqbDtQKr63AY/VTHwefXTDre29+IVF4SvyWIuZIqn\n f3/uk931G0B6lt87rEA3OztOyZ+wCLlitC3y86D/39XrVHuB8Pv63b3XVH+fPcR0mzOk\n MsL2yFSMl45f4i9U01RnwCGbYza8IRbWzrATS2py2euaSTLSt4FrnxMG5eldBZOBwoGq\n 0Fbw==","X-Gm-Message-State":"AOJu0Yz287gL1z8vh00hNom9zDExkOmtotsuzshu8isjTc/FsB/fsFQN\n VrwQTiBRiF0B6f0vNfpoWExbw8hOiHh3Eq+wMGoBUZtD/CDRBPPhdBDMaHI6lQN+d2uuk1OGQsX\n lmUudnOA=","X-Gm-Gg":"AeBDievgZ2mpdfDRH8S5kD1ymzEu9++AgkzBOSILpp61AaOB8XdFG9K1yzJUmQNx6tW\n uhJh8CoJeRwPPI3rvEDKGFe4uRSzIBvKwqgGPNcCU5vyMqPWoMlYPWhhjAts0n5kMkRIR2RQfgJ\n 28z/KExwx5DqmsQnKoreNAq5IC8gne/V15AFsOjLGwRM+oOhp3kENl+XLQ3TM8oiwbcUdwTGhXM\n NR0LC68dvHXkTDdRSfnAogAhj9PWP91PUwHfwK4HeR3CQ3LV6OB3vIpc+4ALodGSCPLJU+UWnMF\n gf0dvtrQ2AFwq5dI2K2J0rGkofS8A1zTIEFtiqkQUVBHYC0f80aA7aXWn0cXqFS0KfZ07ecDRib\n Tk+PqmnnToUyruKAb8t4lmAMdC2pOcGfXD8gCm+Cm6KzmB7THtmpz52UMi17wJLNos9iZtMBpX/\n zhB9jOrSeeY2QYT19+llCpzXFJpbCbuiAFMIycz5nx","X-Received":"by 2002:a17:90b:52:b0:35d:a31e:6b04 with SMTP id\n 98e67ed59e1d1-364c44b5c8bmr8676a91.3.1777501575367;\n Wed, 29 Apr 2026 15:26:15 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","Subject":"[PULL 33/48] fpu: Return struct from float4_e2m1_unpack_canonical","Date":"Thu, 30 Apr 2026 08:24:30 +1000","Message-ID":"<20260429222445.26301-34-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Inline float4_e2m1_unpack_raw at the same time.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 17 +++++------------\n 1 file changed, 5 insertions(+), 12 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 99b1cce894..c1d0140484 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -646,11 +646,6 @@ static FloatParts64 unpack_raw64(const FloatFmt *fmt, uint64_t raw)\n     };\n }\n \n-static void QEMU_FLATTEN float4_e2m1_unpack_raw(FloatParts64 *p, float4_e2m1 f)\n-{\n-    *p = unpack_raw64(&float4_e2m1_params, f);\n-}\n-\n static void QEMU_FLATTEN float8_e4m3_unpack_raw(FloatParts64 *p, float8_e4m3 f)\n {\n     *p = unpack_raw64(&float8_e4m3_params, f);\n@@ -1473,11 +1468,11 @@ static const uint16_t rsqrt_tab[128] = {\n  * Pack/unpack routines with a specific FloatFmt.\n  */\n \n-static void float4_e2m1_unpack_canonical(FloatParts64 *p, float4_e2m1 f,\n-                                         float_status *s)\n+static FloatParts64 float4_e2m1_unpack_canonical(float4_e2m1 f, float_status *s)\n {\n-    float4_e2m1_unpack_raw(p, f);\n-    parts64_canonicalize(p, s, &float4_e2m1_params);\n+    FloatParts64 p = unpack_raw64(&float4_e2m1_params, f);\n+    parts64_canonicalize(&p, s, &float4_e2m1_params);\n+    return p;\n }\n \n static void float8_e4m3_unpack_canonical(FloatParts64 *p, float8_e4m3 f,\n@@ -2699,9 +2694,7 @@ static void parts_float_to_float_widen(FloatParts128 *a, FloatParts64 *b,\n \n float8_e4m3 float4_e2m1_to_float8_e4m3(float4_e2m1 a, float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float4_e2m1_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float4_e2m1_unpack_canonical(a, s);\n     parts64_float_to_float(&p, s);\n     return float8_e4m3_round_pack_canonical(&p, s, false);\n }\n","prefixes":["PULL","33/48"]}