{"id":2230623,"url":"http://patchwork.ozlabs.org/api/patches/2230623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-38-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260429222445.26301-38-richard.henderson@linaro.org>","list_archive_url":null,"date":"2026-04-29T22:24:34","name":"[PULL,37/48] fpu: Return struct from float16a_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"171b5b73a2dfeb86015dacd3293b83df5c056f0b","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-38-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230623/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230623/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=WnDVjkcg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X5P6zzfz1yHZ\n\tfor ; Thu, 30 Apr 2026 08:28:41 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDMU-000421-1m; Wed, 29 Apr 2026 18:26:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDMS-0003wA-DC\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:26:28 -0400","from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIDMQ-0005Kp-Si\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:26:28 -0400","by mail-pj1-x1033.google.com with SMTP id\n 98e67ed59e1d1-362bb3260f1so144333a91.2\n for ; Wed, 29 Apr 2026 15:26:26 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.26.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:26:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501585; x=1778106385; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jv5RFKdPLv46ih/w2n/zKnqzkDwNcWDPMIdbZftxxbA=;\n b=WnDVjkcg7W5a4+gLxXdbwUpl9S6+53e/vp6l3zx8zswAb9om4UzuIEd/h6+2bLEmqZ\n LHY3OONhiWlZ8DGtti8aO95NAVTEFdfY7uTesSJ3o1gXHagRtSrEUhSIXKv1u9ciSCYs\n V313KJAwwBh2f8sod5Q4SKSykwFcFpxRS2BsTCJfdGuLhly7e4ogplV2O43ctz77nmWH\n 0/A6uC4rfVJhPUtE6/wE4wvhOfux3uYPsM4J6B9GeZAyeWFxyeVNM4qNNCo7kGVNNyvV\n VxWs34ikO283jIH+VdsNacqPFigtLu64MSRG1xtsuk1i4sw/IOEZyhx2CwTZ2Hpqpnxu\n cfPA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501585; x=1778106385;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=jv5RFKdPLv46ih/w2n/zKnqzkDwNcWDPMIdbZftxxbA=;\n b=UEyQPPJ+bDckSNfDtlihI2PMfwoOuMSszQ92FZ7tribuylHvy3oaRRYyJM2cgDdGtR\n 49K41Ydm6uFXbfnymSQUf3HDWxMRIEvw7FoGb68IWUUqJYpHOnqAFtRF7xSFQYvsV/jz\n g4lP75KWtYUT5Fe/jJUK1NKcCwgRJSWjs80qlPCUxByzxD1CGGU5qqK54+F1t9UTnFDV\n SUnubMPyPCVLBjee9ps7f/pHzryWjKqYVbd2PakmqMQPGXEWORngTKI7758D9QhTKvMU\n MfyS5ICyl1skuCAt0nTNl5EPCY7697FkFOd//EU80DD+L/36qLCm0W25nJ53gbJxnSw6\n 6isA==","X-Gm-Message-State":"AOJu0YwCwKY2MGxfVm3Nw3Qx2fPfwmYtm5wem8gC9YwLATCWnziOs1TR\n 6SOvvUHbDGaC3+Pokq/1c0YmZsc/mrg8y03PGPzhskh47eoY4wKUoD5hC9SK//WYbmdFjQoolxC\n xEkgp8as=","X-Gm-Gg":"AeBDieuCHMX40qD7nKCbVioyy5lQgE7YmNmPyvNSZoicvnER8tIuJCCAGNriJ0anvNZ\n ySSNSyGoT0UDBCMdD6hT9OVPHsFASw75J6GQaPYwGpxUiZoIUI/t1RAKIrCzDLr4ttN6EQmcgVM\n dQP/uN6RFwwNS1r5sdQIpgyQwjLZRb4H5I86MkEkJbxw1Rm3+PwSOrsUv8IbeJl7PrHG2WCxC+3\n V64/yaxT/ZI1REFxOYx1mo18K1/jwDH/rDHpo2P9iJmiwN1xdDLW/SUnTLCMDXeu+KtaHcZh6A5\n wo73mOz+FEcUDl3lFAbGk9vOleQSM4raBVva3I0wAGgrDc9a9NvRQ7VuorC0vH7o9DT+sya1RrZ\n syz21T2MkT6cRx9Tgy4igxeZVvgMrP00ddf/6hb8mTX3hhhh5A/ikqXfaBefjyZiAW8Azlf0kXT\n wMLsa8AE2+aFC+Uvhrx7c98WTe6BQpS4dPcIIlO2Un","X-Received":"by 2002:a17:90b:4b04:b0:35f:b1ad:fdfc with SMTP id\n 98e67ed59e1d1-364c3189552mr177313a91.27.1777501585355;\n Wed, 29 Apr 2026 15:26:25 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 37/48] fpu: Return struct from float16a_unpack_canonical","Date":"Thu, 30 Apr 2026 08:24:34 +1000","Message-ID":"<20260429222445.26301-38-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1033;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Reviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex cdf95a8517..dee5dcd0d2 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -1474,17 +1474,18 @@ static FloatParts64 float8_e5m2_unpack_canonical(float8_e5m2 f, float_status *s)\n return p;\n }\n \n-static void float16a_unpack_canonical(FloatParts64 *p, float16 f,\n- float_status *s, const FloatFmt *params)\n+static FloatParts64 float16a_unpack_canonical(float16 f, float_status *s,\n+ const FloatFmt *params)\n {\n- *p = unpack_raw64(&float16_params, f);\n- parts64_canonicalize(p, s, params);\n+ FloatParts64 p = unpack_raw64(&float16_params, f);\n+ parts64_canonicalize(&p, s, params);\n+ return p;\n }\n \n static void float16_unpack_canonical(FloatParts64 *p, float16 f,\n float_status *s)\n {\n- float16a_unpack_canonical(p, f, s, &float16_params);\n+ *p = float16a_unpack_canonical(f, s, &float16_params);\n }\n \n static void bfloat16_unpack_canonical(FloatParts64 *p, bfloat16 f,\n@@ -2701,9 +2702,8 @@ bfloat16 float8_e5m2_to_bfloat16(float8_e5m2 a, float_status *s)\n float32 float16_to_float32(float16 a, bool ieee, float_status *s)\n {\n const FloatFmt *fmt16 = ieee ? &float16_params : &float16_params_ahp;\n- FloatParts64 p;\n+ FloatParts64 p = float16a_unpack_canonical(a, s, fmt16);\n \n- float16a_unpack_canonical(&p, a, s, fmt16);\n parts64_float_to_float(&p, s);\n return float32_round_pack_canonical(&p, s);\n }\n@@ -2711,9 +2711,8 @@ float32 float16_to_float32(float16 a, bool ieee, float_status *s)\n float64 float16_to_float64(float16 a, bool ieee, float_status *s)\n {\n const FloatFmt *fmt16 = ieee ? &float16_params : &float16_params_ahp;\n- FloatParts64 p;\n+ FloatParts64 p = float16a_unpack_canonical(a, s, fmt16);\n \n- float16a_unpack_canonical(&p, a, s, fmt16);\n parts64_float_to_float(&p, s);\n return float64_round_pack_canonical(&p, s);\n }\n","prefixes":["PULL","37/48"]}