{"id":2230620,"url":"http://patchwork.ozlabs.org/api/patches/2230620/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-16-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260429222445.26301-16-richard.henderson@linaro.org>","list_archive_url":null,"date":"2026-04-29T22:24:12","name":"[PULL,15/48] fpu: Drop parts_modrem","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cc275de44e02d8c520c60914bbc8ee3196bd4926","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-16-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230620/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230620/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=UM+xqS09;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X566Ncvz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 08:28:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIDLi-0000Jo-Du; Wed, 29 Apr 2026 18:25:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDLa-0000FN-QY\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:35 -0400","from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDLY-0004t5-VS\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:34 -0400","by mail-pj1-x102b.google.com with SMTP id\n 98e67ed59e1d1-3614826eca4so214696a91.1\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 15:25:31 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501531; x=1778106331; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5bEIML70BacSThny8hKO0eQqyV855mB1fb4MsnF2gNA=;\n b=UM+xqS097SxcJHKNi9wR3yntki1O+hdnzo2wjoLIcSofKuck58HFAORtPehyJG8qRy\n TYO6L/fEWIzP6QlcPYDmQ3RNpLw6VhoTrrINIpMr9/dy1GUoBDiPKZhmXOKk3L0lq0da\n ndunB9RQMpo6yT/Rcp/AZR3Xp/C5jMg8bGm6KNlbmdxjMaTpqv4uV1pw+K1akMw0yUGS\n nfcfM4NSY7tbI+tAHJ0iH4xc51fTMfvtWBbxGzDyV7ifzvIkUcFsPligXYkbDpucwK4l\n 6rQE07o3XRQGTudHyVI3BjH5lIIbhPQ1EGjVKSUnTKyHwTBcxqXQFG5nydDkTxsKrapa\n NItw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501531; x=1778106331;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=5bEIML70BacSThny8hKO0eQqyV855mB1fb4MsnF2gNA=;\n b=qIdFuc6W8pwQgciw/0IqTTXRQrTIYaFKu7+IIeQtSkhOMK60IDe9Wg0CpNU0yX4O5y\n ErGC8OxY/yIHNVABnvkFyLQ1fPO1lfI5DwQkhF7N3k0FPod3TYxBgMbfxGLwhsdYyGE+\n yGz1CNe09ZMNPUoAK/kv6rNg/weCPgoDIcnuHz41gy4d+u6RA/yWGFz+9QowebBdlaQ0\n dcZ9ooUPcVxBvTTU/hBllRZV13SxRzViydBZgILk6Mq12iyp5bCDmuJ0M+aIiITEY5le\n JIdE5Jndt0S7k4l/oTzD9k9Ch4ZZfe19EQLR+R5jJwM++RU0NFygSRLAcS4YmvHj+amW\n s3ag==","X-Gm-Message-State":"AOJu0Yx5VVYhBLC7En9CibnLZSdsX7OUVjAeak9PDIoaF4I6/9wpa3Fm\n Wl2AFpJ7X9kD5Jkzp1AdedRRpaC3dyoDpbfRPxleITo0YrP1GwX6vS9mKIavZX4X4S2ZU5U+5dE\n pbqc3b9Y=","X-Gm-Gg":"AeBDievFSGlzNEs7GRGivnOSksg0K0t8wC1CmMWZUFQtAhe7YMxuy1D7Dae9y2eEI7z\n 3iwafBURmxmaSmI2kgUWVsGshMpWuMjJ1N6YDyVOm3nQGylu09igqK3QvxnGZtvNgBt04jF6P2O\n tAvJWdcnoZL4e/oMEznxd6nfvM59XqbXg4efYsTGbJKwWsftmkUC6Whd8mbT+8FgKWXyKlo/dsY\n /IpeRW7iefwvQzPlkr5GTfpIC1n7x1gd8FP51WeC+tot9iSsxWaJohc2NXVSFybc5SBHknH/Jpk\n CF1XodW+1zIJ8V2dgAoqxZjG42w0iP57Ea6WEb7B3up1WI6znJ4d3yoUatUSSyhHXPTyuxCyewZ\n 4qoVFKZQF2SBZeXuqMona9r6qqRe2TabeOoSDYMPpJQP6ZmWC7agVkb+yMJFAIOjdAXaOn68x8g\n 32B7aZ3hThjnzOoZTsa80QaUG55XV8YZ3HnkEEkjk0","X-Received":"by 2002:a17:90b:3b4f:b0:361:423d:203d with SMTP id\n 98e67ed59e1d1-364c301f2a1mr175762a91.8.1777501530156;\n Wed, 29 Apr 2026 15:25:30 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","Subject":"[PULL 15/48] fpu: Drop parts_modrem","Date":"Thu, 30 Apr 2026 08:24:12 +1000","Message-ID":"<20260429222445.26301-16-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102b;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_modrem at each call site.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 16 ++++------------\n 1 file changed, 4 insertions(+), 12 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex b885eae629..91d8e48ce4 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,14 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n                   FloatParts128 *: parts128_##NAME, \\\n                   FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_modrem(FloatParts64 *a, FloatParts64 *b,\n-                                    uint64_t *mod_quot, float_status *s);\n-static FloatParts128 *parts128_modrem(FloatParts128 *a, FloatParts128 *b,\n-                                      uint64_t *mod_quot, float_status *s);\n-\n-#define parts_modrem(A, B, Q, S) \\\n-    PARTS_GENERIC_64_128(modrem, A)(A, B, Q, S)\n-\n static void parts64_sqrt(FloatParts64 *a, float_status *s, const FloatFmt *f);\n static void parts128_sqrt(FloatParts128 *a, float_status *s, const FloatFmt *f);\n \n@@ -2642,7 +2634,7 @@ float32 float32_rem(float32 a, float32 b, float_status *status)\n \n     float32_unpack_canonical(&pa, a, status);\n     float32_unpack_canonical(&pb, b, status);\n-    pr = parts_modrem(&pa, &pb, NULL, status);\n+    pr = parts64_modrem(&pa, &pb, NULL, status);\n \n     return float32_round_pack_canonical(pr, status);\n }\n@@ -2653,7 +2645,7 @@ float64 float64_rem(float64 a, float64 b, float_status *status)\n \n     float64_unpack_canonical(&pa, a, status);\n     float64_unpack_canonical(&pb, b, status);\n-    pr = parts_modrem(&pa, &pb, NULL, status);\n+    pr = parts64_modrem(&pa, &pb, NULL, status);\n \n     return float64_round_pack_canonical(pr, status);\n }\n@@ -2664,7 +2656,7 @@ float128 float128_rem(float128 a, float128 b, float_status *status)\n \n     float128_unpack_canonical(&pa, a, status);\n     float128_unpack_canonical(&pb, b, status);\n-    pr = parts_modrem(&pa, &pb, NULL, status);\n+    pr = parts128_modrem(&pa, &pb, NULL, status);\n \n     return float128_round_pack_canonical(pr, status);\n }\n@@ -2688,7 +2680,7 @@ floatx80 floatx80_modrem(floatx80 a, floatx80 b, bool mod,\n         !floatx80_unpack_canonical(&pb, b, status)) {\n         return floatx80_default_nan(status);\n     }\n-    pr = parts_modrem(&pa, &pb, mod ? quotient : NULL, status);\n+    pr = parts128_modrem(&pa, &pb, mod ? quotient : NULL, status);\n \n     return floatx80_round_pack_canonical(pr, status);\n }\n","prefixes":["PULL","15/48"]}