{"id":2230618,"url":"http://patchwork.ozlabs.org/api/patches/2230618/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-14-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260429222445.26301-14-richard.henderson@linaro.org>","list_archive_url":null,"date":"2026-04-29T22:24:10","name":"[PULL,13/48] fpu: Drop parts_muladd_scalbn","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"67750548f93199b89dc0daa15785af5a8444784d","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-14-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230618/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230618/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kNKiDoVT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X4c6QV4z1yJr\n\tfor ; Thu, 30 Apr 2026 08:28:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDLh-0000Hk-OX; Wed, 29 Apr 2026 18:25:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLU-0000BL-Ql\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:33 -0400","from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLS-0004qc-OB\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:28 -0400","by mail-pj1-x102f.google.com with SMTP id\n 98e67ed59e1d1-35d95017a68so153354a91.3\n for ; Wed, 29 Apr 2026 15:25:26 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501525; x=1778106325; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BNhUQubv0Ujs2Q4sfxENZ0/GvrdtYcMc/gJ6VN/sHJ4=;\n b=kNKiDoVTgTiCEqFWyyq3ctUlLd7yJOL88mT8PoWV7DSePx+NaIOxQ8AD41RfEOBSjk\n VRbEHeuq/okx+wOrb1Uf6l4VVBC4t9kq0ittWmljLszrVyOu8O8OHijAOK6umZihwpT2\n cApjqf/MD4IjDt1y6TqPIqD+HYXrfXqp7kor5Lm5gxqDW8BA4wUBSTCw50oJxzwG0Npp\n TWtlXx5eLJ0mEYINyk/sGLn6IoypK48k60sn3efTLjXVHXEj5eoUMdxGYExeRE1hq57s\n rqwcwfBeKuXVC1JdPx2VuNF+jx+MSOsxtq8ZpOWBQK9/4SnQBdyvhLDtB3+OgI76WiE9\n zm2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501525; x=1778106325;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=BNhUQubv0Ujs2Q4sfxENZ0/GvrdtYcMc/gJ6VN/sHJ4=;\n b=QtqDKEdMpoSG9Lov2XVGpgYWEaVS9OLKhgLlTDC9DxQNfE+xRr2S4bg8+U+RmhHB9q\n X9GiXjqID7Hld3d7KGG+dffyQBtsLx7tzLewkedU5wInlLHUhiRnys7TViBzNeFBuV1F\n Wi33rUWA9F5d2zKhgyPKSN7eMmrr5m8D8YNv2d+l+KAQl3mbjpA10MhaeFIqRVdVh5nn\n cj9CgymDdfDJ5b3Slqq+0S/rAS9iuUBYyKTLkefXHcY31miis4ncf1wFKay7iY0d8oBO\n g573WrSxqQey6OiJ+xrdbjjvJyizYO9l4JxgNpLsG6nmrwGz6OqTCLNs4HITtPQSdRmb\n hBFw==","X-Gm-Message-State":"AOJu0Yz73RoqbAv8vT5uQuopPvoXQuG6ZA/6f0I1cmzSrQmCuO5whGXa\n p/QF0YFJy0YZ8U1mAN2igde3f37++nHA6g1zpyRNk/Mx5tbKTeeGNM+ex515osIs6aWvfGgN7Kh\n odomq3nQ=","X-Gm-Gg":"AeBDieuFC/moTv9yYwJPQZDryK2LsxsqC36aAHBcgN/ncC50KUOwqrqUt7zCqt4hSJ5\n a/XM9DINskb1YQ3V541n7OjLLfQGxJLn9YENGjLOfv1ShFklgGw38U8EOP1Iw5dNNwg8Rjjz0Po\n oS7/gnCJfx9EtTKYIKuQf+eIaABN89YsFZiIOiQpu0BoAssWJ3m8W4UPv/bWE4MHeUY8go9e8h4\n UojZn638DvsWMh8Ybxi+wNEWmZ+2zO6uT/6l6qsU+YwWDvSO4WDvlSuRj8dyYneIZVTZX01pSFI\n dgAsMqzVmm6cL2USF2Y2xja1AgsI718niPKzk/qI8tjS95IXLGWJGMN3Vm3oV+aaSnhSPmHJpdX\n HdvIwIXJLGw7uU0vmkF+3EL8D7I7nTHt43L3uqrbATsMPX0gh82exOVmO/9T58/k+jWJu0WB/F6\n Y96Hpzq1iKgwrsLxNCAbouHlkO3miPaRlUOcoxyiIl","X-Received":"by 2002:a17:90b:264b:b0:35d:a380:6d1a with SMTP id\n 98e67ed59e1d1-364c2f2e00bmr184565a91.2.1777501525236;\n Wed, 29 Apr 2026 15:25:25 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 13/48] fpu: Drop parts_muladd_scalbn","Date":"Thu, 30 Apr 2026 08:24:10 +1000","Message-ID":"<20260429222445.26301-14-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102f;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_muladd_scalbn at each call site.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 28 +++++++++-------------------\n 1 file changed, 9 insertions(+), 19 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 8adc73c863..aa62fea47d 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,16 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_muladd_scalbn(FloatParts64 *a, FloatParts64 *b,\n- FloatParts64 *c, int scale,\n- int flags, float_status *s);\n-static FloatParts128 *parts128_muladd_scalbn(FloatParts128 *a, FloatParts128 *b,\n- FloatParts128 *c, int scale,\n- int flags, float_status *s);\n-\n-#define parts_muladd_scalbn(A, B, C, Z, Y, S) \\\n- PARTS_GENERIC_64_128(muladd_scalbn, A)(A, B, C, Z, Y, S)\n-\n static FloatParts64 *parts64_div(FloatParts64 *a, FloatParts64 *b,\n float_status *s);\n static FloatParts128 *parts128_div(FloatParts128 *a, FloatParts128 *b,\n@@ -2256,7 +2246,7 @@ float16_muladd_scalbn(float16 a, float16 b, float16 c,\n float16_unpack_canonical(&pa, a, status);\n float16_unpack_canonical(&pb, b, status);\n float16_unpack_canonical(&pc, c, status);\n- pr = parts_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n+ pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n /* Round before applying negate result. */\n parts64_uncanon(pr, status, &float16_params, false);\n@@ -2281,7 +2271,7 @@ float32_muladd_scalbn(float32 a, float32 b, float32 c,\n float32_unpack_canonical(&pa, a, status);\n float32_unpack_canonical(&pb, b, status);\n float32_unpack_canonical(&pc, c, status);\n- pr = parts_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n+ pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n /* Round before applying negate result. */\n parts64_uncanon(pr, status, &float32_params, false);\n@@ -2300,7 +2290,7 @@ float64_muladd_scalbn(float64 a, float64 b, float64 c,\n float64_unpack_canonical(&pa, a, status);\n float64_unpack_canonical(&pb, b, status);\n float64_unpack_canonical(&pc, c, status);\n- pr = parts_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n+ pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n /* Round before applying negate result. */\n parts64_uncanon(pr, status, &float64_params, false);\n@@ -2459,7 +2449,7 @@ float64 float64r32_muladd(float64 a, float64 b, float64 c,\n float64_unpack_canonical(&pa, a, status);\n float64_unpack_canonical(&pb, b, status);\n float64_unpack_canonical(&pc, c, status);\n- pr = parts_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n+ pr = parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n parts64_uncanon(pr, status, &float32_params, false);\n@@ -2477,7 +2467,7 @@ bfloat16 QEMU_FLATTEN bfloat16_muladd(bfloat16 a, bfloat16 b, bfloat16 c,\n bfloat16_unpack_canonical(&pa, a, status);\n bfloat16_unpack_canonical(&pb, b, status);\n bfloat16_unpack_canonical(&pc, c, status);\n- pr = parts_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n+ pr = parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n parts64_uncanon(pr, status, &bfloat16_params, false);\n@@ -2495,7 +2485,7 @@ float128 QEMU_FLATTEN float128_muladd(float128 a, float128 b, float128 c,\n float128_unpack_canonical(&pa, a, status);\n float128_unpack_canonical(&pb, b, status);\n float128_unpack_canonical(&pc, c, status);\n- pr = parts_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n+ pr = parts128_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n parts128_uncanon(pr, status, &float128_params, false);\n@@ -5442,7 +5432,7 @@ float32 float32_exp2(float32 a, float_status *status)\n for (i = 0 ; i < 15 ; i++) {\n \n float64_unpack_canonical(&tp, float32_exp2_coefficients[i], status);\n- rp = *parts_muladd_scalbn(&tp, &xnp, &rp, 0, 0, status);\n+ rp = *parts64_muladd_scalbn(&tp, &xnp, &rp, 0, 0, status);\n xnp = *parts64_mul(&xnp, &xp, status);\n }\n \n@@ -5522,8 +5512,8 @@ static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b,\n \n /* Compute precise remainder */\n r_precise_buf = *b;\n- r_precise = parts_muladd_scalbn(&r_precise_buf, n, a, 0,\n- float_muladd_negate_product, status);\n+ r_precise = parts64_muladd_scalbn(&r_precise_buf, n, a, 0,\n+ float_muladd_negate_product, status);\n \n /* Round remainder to the target format */\n *r = *r_precise;\n","prefixes":["PULL","13/48"]}