{"id":2230616,"url":"http://patchwork.ozlabs.org/api/patches/2230616/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-17-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260429222445.26301-17-richard.henderson@linaro.org>","list_archive_url":null,"date":"2026-04-29T22:24:13","name":"[PULL,16/48] fpu: Drop parts_sqrt","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"621c043abbc0f422e417f33d2b9789f0af0e97b9","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-17-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230616/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230616/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=w73VUVb1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X4Y0R6Lz1yHZ\n\tfor ; Thu, 30 Apr 2026 08:27:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDLj-0000Mu-0l; Wed, 29 Apr 2026 18:25:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLb-0000Fp-V6\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:37 -0400","from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLa-0004tH-5i\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:35 -0400","by mail-pj1-x102e.google.com with SMTP id\n 98e67ed59e1d1-3614826eca4so214705a91.1\n for ; Wed, 29 Apr 2026 15:25:33 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501533; x=1778106333; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=31hLbn8oYXSK9jtgcJgE4cjWwvKE/+HfIVZoQKVefGU=;\n b=w73VUVb1qvqJfbYpl2yHW5sudG8qPRgqnVLnuHZbgAEargMpvFo1nxasJS9HGC5KmT\n NO7Iv0yvM70cffZH2NZsFRArP8pni468ejgt/m0CyQSCY7RbU8ak6BNpd10jCUTYKEOo\n xWoeRDxsPp5Gj8LdyafzUDQ2PcQP73GsZ0suCBKjcp7PFA4ZtRL5RE598C0t2ACs79xG\n 0rOKAiwGc22mjf499KEVkGaI7gmuSNKG4E46+qhCtCHIVA1fLY/0JJZhipNoYgRi4Q1+\n AQBWLI+NIqLykgyNatL1dOWmdOp+upaXtT7RxHCwmT9uchduUrYQdEfcMLtMlBAF1ksY\n 2S4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501533; x=1778106333;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=31hLbn8oYXSK9jtgcJgE4cjWwvKE/+HfIVZoQKVefGU=;\n b=e9+nCYoww8LmwQTgTEaM4RWAFaM6xLuofjPo+wQVH35Ysl//6iFn0ZFnJfhHxX7x5k\n bMhbpM/m6QEk5P20u4ueAIblzEfNKFUDZXUbL1oy0iC3UVDTtYQ2Lq4Mr6kp4V29gtp5\n g5W3j4iCH47rLz7EhylXWDNFCKqO03UVzCFJd3crokfWLRc17DMdCtJXRdCSd3qPGFTX\n zpV4JSdPY9dSPsMn+GSC55jdQwOuyBwBDCiElNo26V3hJLDIjqcobclfqU149SZuuBI1\n BG1uMOl8nRJ3NV1d9Mw9U86IQQLxMUCH7DwPsPJc/zhAPumRzSS7lGrwKutFS2ZdPV+L\n 1Nug==","X-Gm-Message-State":"AOJu0YwGtwdsDu4MzgC+qXTaETuFU+4CIunDySiz+WbIksMBrakSpq2h\n W0xYABSBWMzTjf3TCfLncqbfLfNkLQQyVHhezHguMDaEh42IPq7mspXUT9FbmTUjB4G+phcOjMb\n wM2+j1gQ=","X-Gm-Gg":"AeBDietUPlKupjHGuoqsyb0N4ZV7fWb198/VdMq4LDNCKbb3xKguuSlR3y/Pm45bs8X\n zNbzn/NFKCl8bgSNQp2DHEWKXjxGGzEA9gUgeKML1EuZNONKvgZqUYfvXG4POAaIYtOWzqjzLZC\n irTk8pGQXVnCdov4gnjz1uFaczEgeQMllGDnxtgrap+FZIK3oWXSEHjG/0oEO4q3jp6F+oAWws6\n IEar0LATIB8+aLGWGSdlygVwNC9WE4A2HAon9ly84e5Ysh6n6NDKxMp+YiMZcHb/6TlXnqB9fBX\n 6akqnjqqe+jd1huEd96QjGNM5xpdrEvXbYkoEYAspBcgcqeCa0jHuqse0Gm9E3i+wRjQv9SCC0O\n bnpnRz0lrZOikyHNuN1g9wFWMr/jm01iGV8GKFsNE3OTR/5Jvde4YCNPpHfJgw9UZd3GgqiO06Y\n mHvpo5Y6jcBhQxkfXjTzwwYKXxtUp8HpBb/7pA1tqb","X-Received":"by 2002:a17:90b:52cf:b0:35f:ccf6:69a5 with SMTP id\n 98e67ed59e1d1-364c31a6b14mr168341a91.20.1777501532584;\n Wed, 29 Apr 2026 15:25:32 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 16/48] fpu: Drop parts_sqrt","Date":"Thu, 30 Apr 2026 08:24:13 +1000","Message-ID":"<20260429222445.26301-17-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102e;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_sqrt at each call site.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 20 +++++++-------------\n 1 file changed, 7 insertions(+), 13 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 91d8e48ce4..0a6bc6d580 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,12 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static void parts64_sqrt(FloatParts64 *a, float_status *s, const FloatFmt *f);\n-static void parts128_sqrt(FloatParts128 *a, float_status *s, const FloatFmt *f);\n-\n-#define parts_sqrt(A, S, F) \\\n- PARTS_GENERIC_64_128(sqrt, A)(A, S, F)\n-\n static bool parts64_round_to_int_normal(FloatParts64 *a, FloatRoundMode rm,\n int scale, int frac_size);\n static bool parts128_round_to_int_normal(FloatParts128 *a, FloatRoundMode r,\n@@ -4757,7 +4751,7 @@ float16 QEMU_FLATTEN float16_sqrt(float16 a, float_status *status)\n FloatParts64 p;\n \n float16_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float16_params);\n+ parts64_sqrt(&p, status, &float16_params);\n return float16_round_pack_canonical(&p, status);\n }\n \n@@ -4767,7 +4761,7 @@ soft_f32_sqrt(float32 a, float_status *status)\n FloatParts64 p;\n \n float32_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float32_params);\n+ parts64_sqrt(&p, status, &float32_params);\n return float32_round_pack_canonical(&p, status);\n }\n \n@@ -4777,7 +4771,7 @@ soft_f64_sqrt(float64 a, float_status *status)\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float64_params);\n+ parts64_sqrt(&p, status, &float64_params);\n return float64_round_pack_canonical(&p, status);\n }\n \n@@ -4840,7 +4834,7 @@ float64 float64r32_sqrt(float64 a, float_status *status)\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float64_params);\n+ parts64_sqrt(&p, status, &float64_params);\n return float64r32_round_pack_canonical(&p, status);\n }\n \n@@ -4849,7 +4843,7 @@ bfloat16 QEMU_FLATTEN bfloat16_sqrt(bfloat16 a, float_status *status)\n FloatParts64 p;\n \n bfloat16_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &bfloat16_params);\n+ parts64_sqrt(&p, status, &bfloat16_params);\n return bfloat16_round_pack_canonical(&p, status);\n }\n \n@@ -4858,7 +4852,7 @@ float128 QEMU_FLATTEN float128_sqrt(float128 a, float_status *status)\n FloatParts128 p;\n \n float128_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float128_params);\n+ parts128_sqrt(&p, status, &float128_params);\n return float128_round_pack_canonical(&p, status);\n }\n \n@@ -4869,7 +4863,7 @@ floatx80 floatx80_sqrt(floatx80 a, float_status *s)\n if (!floatx80_unpack_canonical(&p, a, s)) {\n return floatx80_default_nan(s);\n }\n- parts_sqrt(&p, s, &floatx80_params[s->floatx80_rounding_precision]);\n+ parts128_sqrt(&p, s, &floatx80_params[s->floatx80_rounding_precision]);\n return floatx80_round_pack_canonical(&p, s);\n }\n \n","prefixes":["PULL","16/48"]}