{"id":2228703,"url":"http://patchwork.ozlabs.org/api/patches/2228703/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260427081713.3401874-3-hossu.alexandru@gmail.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260427081713.3401874-3-hossu.alexandru@gmail.com>","list_archive_url":null,"date":"2026-04-27T08:17:13","name":"[v4,2/2] staging: nvec: fix unconditional pm_power_off teardown","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6b43a8fd547ecf5a913384e2b749a3aadd59a46d","submitter":{"id":92777,"url":"http://patchwork.ozlabs.org/api/people/92777/?format=json","name":"Alexandru Hossu","email":"hossu.alexandru@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260427081713.3401874-3-hossu.alexandru@gmail.com/mbox/","series":[{"id":501604,"url":"http://patchwork.ozlabs.org/api/series/501604/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=501604","date":"2026-04-27T08:17:11","name":"staging: nvec: fix use-after-free and pm_power_off teardown","version":4,"mbox":"http://patchwork.ozlabs.org/series/501604/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228703/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228703/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=BOUhTCno;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13999-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"BOUhTCno\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.54","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3xR91yW0z1yHv\n\tfor ; Mon, 27 Apr 2026 18:23:33 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BBDAA3018AF3\n\tfor ; Mon, 27 Apr 2026 08:19:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4C48A39A075;\n\tMon, 27 Apr 2026 08:19:19 +0000 (UTC)","from mail-wr1-f54.google.com (mail-wr1-f54.google.com\n [209.85.221.54])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C9DBC37BE7D\n\tfor ; Mon, 27 Apr 2026 08:19:17 +0000 (UTC)","by mail-wr1-f54.google.com with SMTP id\n ffacd0b85a97d-44509921fbcso308986f8f.3\n for ;\n Mon, 27 Apr 2026 01:19:17 -0700 (PDT)","from ahossu.localdomain ([82.78.232.184])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc375dsm69920019f8f.14.2026.04.27.01.19.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 01:19:15 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777277959; cv=none;\n b=R73oogs2OPp5zzpqn7x+xddd1eSwAyxo7bzk35x/5pjTgSfEQoMZUl5C+Pi9IocPNpelRWT+Avdz0ry0X4AEnvEAo9/lY9C3pYBBptuaLdimHneaXobIqCezIfo7rr85Co9KQFvUWpV9R1B/IvbznZi16AOrrdmtfvvjV3sNDRo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777277959; c=relaxed/simple;\n\tbh=kA12S5ceLFq7aTYPKmMulJyt/Aty2VxK8Ge3SmlcZxg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=EFAceQsURNqiL4a/Zpg2HaW/LRoLL0JOtB3MdbwO1QIqedw6mw+RXda66iL63ptx4MUOxnBOLRwat6aSyqn86Qa0V99y9Ga/aXK0lJwxKgBlBfGI77gcI75OirFSNtpKgD7RBAH5LjFu7yvARh2hzrXa7/0Ni9mbq3soq+IHpNw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=BOUhTCno; arc=none smtp.client-ip=209.85.221.54","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777277956; x=1777882756;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BKuYbRG/YW/8TeEIKBYjuEmOZ3fK4A9BxisB2qvbDhg=;\n b=BOUhTCnoyMFnVqNbKkAWZ1WRXsoj3tRc0SZy6VB0Au1xxza3V47hQCEQx/DWWuXxJI\n aUufsx/jcGIBbxxABkfaOQdb2NpfYPf2BWyble2Dz7IgEius5Xir0xLFU4+06FQFXvfK\n iyALkDTIVcvrz1KcCfVHdfxaiDZEhBgZZg9jCwLarhM5T952QWGq1NnJ4o6fjtHuxulw\n 7WojWKF4CIO/6HG5ALXOAJ5qbkQv2OeqOrt/n2a8l5zgUEHWSo1hA0O4xTS1/8vnhGob\n J8oN14rTN1tvcfmh1AGGfOOmIIbe5K02HTkqe70JUj7Eozu3CZnbG0YkKlzNQt6LqXau\n xAyA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277956; x=1777882756;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=BKuYbRG/YW/8TeEIKBYjuEmOZ3fK4A9BxisB2qvbDhg=;\n b=I7w/2eKR+pL+oWSprX3QdcwzL6WSfdMwIhzbNvTlpHIEt6PFFuX7dqkahAlD3qPQvw\n 2sUKdr2B9cdcjGSDDM9TbAloF1rbNpwUcG9ZYnbc2ryeUWPNm35rJk5PqGgmivaAnJHp\n X7AR46Gq9WJNvoa6KaC3Esq112UnQroI5YWEf9wlwbLnhrsIZhxcrhNQoudeYlMTLYas\n odl3q1peRXIwKQY1DA9jsh0iZTzn8BSGdsPvpvBfJbDcB0LbPnPPmg5L2JQ7toAfG7r+\n rOl7OtUmJkW+/Q1Z03pw7ApjaSeUJRsegoZWEs2/i13dMVxTEVVhvShhkPFIIswl8fGp\n 6Nvg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8afe11izC+GxACkh879dSyLHpJtQZSgCM/lQn+1dBfZ+hOdJhYO4ws/bIeUWjjcCsbDzWDFWgyMqenKg==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yxa5Pcp8O3VGPy6QdRgCbyOav+9240A+8mS7DmGLggDteqRNnci\n\tdvR2+RCasE8Bd0eE9NmsNlCB+wXp6kyWO7rDTbps+fsoJU3mXsGuro6S","X-Gm-Gg":"AeBDievizURP6B9zU3lfOqpNT/1Pzq7Cj5xI/qq10coHuDcRXFOmQtYUt+uiI3Hi6v5\n\tQV/P2ILH8RXdDNWYZJ32WgR9dJ0NwlxHYFHU6H8MaqTPTmrfG1X48zQfg8EYLfB1x1em4ZFp5t9\n\ttdg3w+8pHYzgj/mGf7MM+5z1I92fMr92nIZP1IZoiiK8gWoyWaOBePZDLFDxjE2xiqUUnQxG6mm\n\tOqV5NV4886r6+S7mTSXjOQv4sFoMe+8L9EN8+YOOhwfsZh4y7P9T6fubkuNx+6NeQPOURH7YBsx\n\tWao/RKkunRPAU7idiAOBn7MhpxLWIXzVUBuDLfiGeGIbSutVO1M7iz0PVCB7gWizhg4hz8OqZYF\n\t3nEWgerCb2YVWT5H4TQvWr6iuebmuEjoV7282l7mTnG6sRp/G8fol99swcSL2eHhYok0PvYKBjq\n\t/a49YBJ9Os12ZN3m5TXTUFaRDeivvditRrq6JN0DvcbEOtViU+rlckamvKnsg+vGlPtogQTdr2Q\n\t7FKl6bUHWKTT7ejOfkJ4omSTl72tQiBxFSJuAheYQiEvlYctS85c7EiOOH4PL4JcZPIhxU=","X-Received":"by 2002:a05:6000:2dc4:b0:441:37b5:c2f6 with SMTP id\n ffacd0b85a97d-44137b5c365mr14126935f8f.23.1777277956084;\n Mon, 27 Apr 2026 01:19:16 -0700 (PDT)","From":"Alexandru Hossu ","To":"gregkh@linuxfoundation.org,\n\tlinux-staging@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org","Cc":"marvin24@gmx.de,\n\terror27@gmail.com,\n\tAlexandru Hossu ","Subject":"[PATCH v4 2/2] staging: nvec: fix unconditional pm_power_off teardown","Date":"Mon, 27 Apr 2026 10:17:13 +0200","Message-ID":"<20260427081713.3401874-3-hossu.alexandru@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427081713.3401874-1-hossu.alexandru@gmail.com>","References":"<20260427081713.3401874-1-hossu.alexandru@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"tegra_nvec_remove() unconditionally sets pm_power_off = NULL, even if\nnvec was not the one that registered it. This breaks any other driver\nthat may have set pm_power_off to its own handler.\n\nReplace the unconditional assignment with a guarded check so that\npm_power_off is only cleared if nvec was the one that set it.\n\nAlso remove the stale FIXME comment, as the guard addresses exactly\nwhat it was asking for.\n\nReviewed-by: Dan Carpenter \nSigned-off-by: Alexandru Hossu \n---\n drivers/staging/nvec/nvec.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c\nindex 2a3499dd4d63..88c416ee0381 100644\n--- a/drivers/staging/nvec/nvec.c\n+++ b/drivers/staging/nvec/nvec.c\n@@ -906,8 +906,8 @@ static void tegra_nvec_remove(struct platform_device *pdev)\n \tnvec_unregister_notifier(nvec, &nvec->nvec_status_notifier);\n \tcancel_work_sync(&nvec->rx_work);\n \tcancel_work_sync(&nvec->tx_work);\n-\t/* FIXME: needs check whether nvec is responsible for power off */\n-\tpm_power_off = NULL;\n+\tif (pm_power_off == nvec_power_off)\n+\t\tpm_power_off = NULL;\n }\n \n #ifdef CONFIG_PM_SLEEP\n","prefixes":["v4","2/2"]}