{"id":2228108,"url":"http://patchwork.ozlabs.org/api/patches/2228108/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260425-gtk-clipboard-v2-1-b098f3cf69cc@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260425-gtk-clipboard-v2-1-b098f3cf69cc@gmail.com>","list_archive_url":null,"date":"2026-04-25T09:53:40","name":"[v2,1/2] ui/gtk: Use non-blocking clipboard retrieval","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"401502484293310171c02691bef8431ac8dff5c0","submitter":{"id":4408,"url":"http://patchwork.ozlabs.org/api/people/4408/?format=json","name":"Jindřich Makovička","email":"makovick@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260425-gtk-clipboard-v2-1-b098f3cf69cc@gmail.com/mbox/","series":[{"id":501431,"url":"http://patchwork.ozlabs.org/api/series/501431/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501431","date":"2026-04-25T09:53:40","name":"Fix and re-enable GTK clipboard","version":2,"mbox":"http://patchwork.ozlabs.org/series/501431/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228108/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228108/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HxrWQBxP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2lXx1ghFz1yHv\n\tfor ; Sat, 25 Apr 2026 19:54:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGZhz-0002vz-Jt; Sat, 25 Apr 2026 05:53:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGZhv-0002vE-BN\n for qemu-devel@nongnu.org; Sat, 25 Apr 2026 05:53:51 -0400","from mail-wr1-x429.google.com ([2a00:1450:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGZht-0002B1-Ur\n for qemu-devel@nongnu.org; Sat, 25 Apr 2026 05:53:51 -0400","by mail-wr1-x429.google.com with SMTP id\n ffacd0b85a97d-43eb012ac4fso5177108f8f.0\n for ; Sat, 25 Apr 2026 02:53:49 -0700 (PDT)","from [192.168.0.10] ([2a03:ab00:1000:1b60:331a:b316:78f6:effc])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc0d51sm67574574f8f.10.2026.04.25.02.53.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 25 Apr 2026 02:53:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777110828; x=1777715628; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=KS523ZuLQajlqaW9nRPPvwWPNkbM/GgW7sZV4UtjmFI=;\n b=HxrWQBxPWuldQ/O+RqaBf1qhakajFXhtkAPA6UdGmKDbD+7180WhJhLjJW0klFgqMG\n W4CQkS1EBdXpj7jsLJ1DJBFO0XF2jTmK2ymNpoJFYqahN6AFGR9fETnABGF2EQHCZVjC\n WniRmfGvePUDCYhUmga+IlAum+0X1g+sMb3KA8D/LrtzT0XP8GLaSJzqKbsc6trkHVEM\n HgGwYmwMR6KYZlucsf+bZ/oUrMweWeICLPkIe2kg0J9zRNvjP+bVuwcNsgF2JSn8VHsU\n 83PHhe5Dy7bjjlbgJdhURT3isCXrFUHOBl7XFxswFzPxIBaL5xlWApi5GDrTtzZugcm1\n GQ9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777110828; x=1777715628;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=KS523ZuLQajlqaW9nRPPvwWPNkbM/GgW7sZV4UtjmFI=;\n b=So7bCQ8eCX5UW/TNu0oWiq1L7vfzn1Rxl5g8CUdCqO4YoPBPQYm4r/ETbT9mB2J5Gp\n EqXIU+Qib7zC3/N9evs2xONj2B3bmGwGgEnANS+b6VDpzr6QIw1Nu9jJRUkQLm3JsO1v\n Kurcs9TVkiXaveBDKVXa87dT0wRBq42S9qt4hF3FWCXivH61xcF/pg06q3w0oQR+rFKa\n jashThd6KA3HVLaUuV8kqZDA9CXmcuIXnSohBjlUqjYIE+wuHJgBWfhxxzpITKJGftkf\n bYgNWYsZwMNdn6FLxy9N6AMgJccmaV9pcsSkjMMpGc1PlasdPCIYCQHTYtuAAGVBREBC\n QNtw==","X-Gm-Message-State":"AOJu0YwUvv33dqJnqpWaQyH7gBPchpK7yiX2MoaAhTAlAS8rED09631r\n Z+/m7IaPmxtrQwZ4yZHkJVU9gzX8Y2p7EkY0oa2qtnvYwbDkVRbw/6U8","X-Gm-Gg":"AeBDievdrTXuXyBVIeP1FDLbCQbDoiI9+U3QlUDWz6vPlBOs7IURye7nAst0y9SanwY\n f2vbr2T90gub/hWdhfrVMtLz9XgUculuMZQor2f8cmf+Kr0QNKBclyjK+gpjRugojuc0PV4Xvps\n ZjR+k5bE3zzAJzE49IWGodrLuI6cT6ZLbMfEfByqbq130/k8GZz2mPowvPyduLxePbgqwmte+JF\n q37x/gXXWVc8lJM2H8puNgQqErlxwWVO4HLi0nEhl6TgElsaX8xaHF8p3Opz3EK+jjzRN7IgXB4\n pws0tpE6Nmhzp1LIIfO1UWAADtBXssykyVcaV9K0BlsuqLyJEAENjPOep/f2owYJdvDJU/PZPFA\n s6VaWpMoQmCPu3zZVUgc99FODkZaZcSbpHUWE9EcCERf5Ct/aa4896YhRVrC3Hd2GhXwqA5+0zy\n obkR+cxWHTMy+m4bCxZH/nYtY2zGseeEYF36r09qk=","X-Received":"by 2002:a05:6000:184d:b0:43d:e31:68d1 with SMTP id\n ffacd0b85a97d-43fe3dd958amr55703038f8f.21.1777110828404;\n Sat, 25 Apr 2026 02:53:48 -0700 (PDT)","From":"=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= ","Date":"Sat, 25 Apr 2026 11:53:40 +0200","Subject":"[PATCH v2 1/2] ui/gtk: Use non-blocking clipboard retrieval","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260425-gtk-clipboard-v2-1-b098f3cf69cc@gmail.com>","References":"<20260425-gtk-clipboard-v2-0-b098f3cf69cc@gmail.com>","In-Reply-To":"<20260425-gtk-clipboard-v2-0-b098f3cf69cc@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Jindrich Makovicka ","X-Mailer":"b4 0.14.3","Received-SPF":"pass client-ip=2a00:1450:4864:20::429;\n envelope-from=makovick@gmail.com; helo=mail-wr1-x429.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Jindrich Makovicka \n---\n ui/gtk-clipboard.c | 47 ++++++++++++++++++++++++++++++++++-------------\n 1 file changed, 34 insertions(+), 13 deletions(-)","diff":"diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c\nindex 65d89ec601..23d32947cc 100644\n--- a/ui/gtk-clipboard.c\n+++ b/ui/gtk-clipboard.c\n@@ -136,26 +136,50 @@ static void gd_clipboard_notify(Notifier *notifier, void *data)\n }\n }\n \n+static void\n+gd_clipboard_request_text_received_callback(GtkClipboard *clipboard,\n+ const gchar *text,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+ if (text) {\n+ qemu_clipboard_set_data(info->owner, info, QEMU_CLIPBOARD_TYPE_TEXT,\n+ strlen(text), text, true);\n+ }\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_clipboard_request(QemuClipboardInfo *info,\n QemuClipboardType type)\n {\n GtkDisplayState *gd = container_of(info->owner, GtkDisplayState, cbpeer);\n- char *text;\n \n switch (type) {\n case QEMU_CLIPBOARD_TYPE_TEXT:\n- text = gtk_clipboard_wait_for_text(gd->gtkcb[info->selection]);\n- if (text) {\n- qemu_clipboard_set_data(&gd->cbpeer, info, type,\n- strlen(text), text, true);\n- g_free(text);\n- }\n+ qemu_clipboard_info_ref(info);\n+ gtk_clipboard_request_text(gd->gtkcb[info->selection],\n+ gd_clipboard_request_text_received_callback,\n+ info);\n break;\n default:\n break;\n }\n }\n \n+static void\n+gd_clipboard_owner_change_text_received_callback(GtkClipboard *clipboard,\n+ const gchar *text,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+ if (text) {\n+ info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n+ }\n+\n+ qemu_clipboard_update(info);\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_owner_change(GtkClipboard *clipboard,\n GdkEvent *event,\n gpointer data)\n@@ -173,12 +197,9 @@ static void gd_owner_change(GtkClipboard *clipboard,\n switch (event->owner_change.reason) {\n case GDK_OWNER_CHANGE_NEW_OWNER:\n info = qemu_clipboard_info_new(&gd->cbpeer, s);\n- if (gtk_clipboard_wait_is_text_available(clipboard)) {\n- info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n- }\n-\n- qemu_clipboard_update(info);\n- qemu_clipboard_info_unref(info);\n+ gtk_clipboard_request_text(clipboard,\n+ gd_clipboard_owner_change_text_received_callback,\n+ info);\n break;\n default:\n qemu_clipboard_peer_release(&gd->cbpeer, s);\n","prefixes":["v2","1/2"]}