{"id":2228107,"url":"http://patchwork.ozlabs.org/api/patches/2228107/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260425-gtk-clipboard-v1-1-6bd99e708e14@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260425-gtk-clipboard-v1-1-6bd99e708e14@gmail.com>","list_archive_url":null,"date":"2026-04-25T09:38:31","name":"[1/2] ui/gtk: Use non-blocking clipboard retrieval","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"401502484293310171c02691bef8431ac8dff5c0","submitter":{"id":4408,"url":"http://patchwork.ozlabs.org/api/people/4408/?format=json","name":"Jindřich Makovička","email":"makovick@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260425-gtk-clipboard-v1-1-6bd99e708e14@gmail.com/mbox/","series":[{"id":501430,"url":"http://patchwork.ozlabs.org/api/series/501430/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501430","date":"2026-04-25T09:38:30","name":"Fix and re-enable GTK clipboard","version":1,"mbox":"http://patchwork.ozlabs.org/series/501430/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228107/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228107/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=DQwBF1cd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2lCf0VmNz1yHv\n\tfor ; Sat, 25 Apr 2026 19:39:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGZTG-000598-AI; Sat, 25 Apr 2026 05:38:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGZTC-00058O-Qz\n for qemu-devel@nongnu.org; Sat, 25 Apr 2026 05:38:39 -0400","from mail-wr1-x432.google.com ([2a00:1450:4864:20::432])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGZTB-0005zy-8Q\n for qemu-devel@nongnu.org; Sat, 25 Apr 2026 05:38:38 -0400","by mail-wr1-x432.google.com with SMTP id\n ffacd0b85a97d-43d7badbd7dso4258769f8f.2\n for ; Sat, 25 Apr 2026 02:38:36 -0700 (PDT)","from [192.168.0.10] ([2a03:ab00:1000:1b60:331a:b316:78f6:effc])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a18csm74965992f8f.20.2026.04.25.02.38.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 25 Apr 2026 02:38:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777109915; x=1777714715; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=KS523ZuLQajlqaW9nRPPvwWPNkbM/GgW7sZV4UtjmFI=;\n b=DQwBF1cdpNJ7X3gGxp/0T7KgDci8YTFf2yjND2VjMRKwwWlSHXlpGXgnuDrtWcIm7g\n bHZceUQkrfSNPBT6ykH7JrlaNX+zSxkhnhGDZjhwGsfrUMPEq+i2tvjPcFlTKd5vYs1H\n XBPq3gSh2LhJNQ9jrGtlIhKksiMpcUX4FWWzntShRudhb4qLFw4GVg8heIEfNEQbjYDc\n AHeDRpEls+y//XGAnpohQ8oeg8UCw+v0zaT+LgWtx6sJV/6LxNMjr93XXXUxCbWVCMu5\n pgmLIE/O/eI/QRvc2gslcKEgrf0NI67x4wDg5VfPs9PXxxAd3doXEVmxAKwJt+msNxTr\n gNHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777109915; x=1777714715;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=KS523ZuLQajlqaW9nRPPvwWPNkbM/GgW7sZV4UtjmFI=;\n b=bZAcJBbtDWTpB1YQVtgSTqQYCItqT06Iaeqo3yYwOIbovl9FqBIzbqlOn54Z0NfMvB\n kKLmDw9tFXzR3o0w4o3UvN5qmdi7Xx9wZkOwUH3loyS5SrfCTbjJOmj/9MhSWWC101Ph\n MsZUsADcgm4SwFgOmJVI3vJ7NL4qFw0mN4SA5n2uI/yizOT6VUelJOD85EID5PBWnsBJ\n nNe1H1ERfY19A9bc4p7r11csppZ1zgvTfLLDSfXvpyITDM68EMm2rK1U5pkhmtvtUeWf\n cs1OJlk3yS7ZBn4ZrPsvma/bNtvfk3FbPgQ3dfqFeb+vrzFhLe6+hHG08dUX4F6xidIj\n 2lsA==","X-Gm-Message-State":"AOJu0YyUpCB2kh9RI+AoY/mRMYQRwTwaYIgmCMwGbipau9FKnHtEC6Sf\n jU+yQuBgJ7Nn1nsWXkuEMoa/9xxdHWEKNj/EOEx1BdvDz3xXogMvQN5zgbc5s59mnqc=","X-Gm-Gg":"AeBDievsX1XT2g0meT2NKdJ3yfhdBig5Zx0r3DrFvqvQVoGWBkvv9jTtBaG/wdA3z/a\n 9sIIccKMoeXmzZGDbuTaMQ90wyHL2TKQQcHyHlSIbFW0lMowiXkAocjEprhdwhY++M9MBRAgrMU\n Xh9vJfWN47cBzadZCRxSltowLSeUdJo8s6TNdUh0hs1bs4227ATlj943yAgXTD3YcrqehBplQnN\n W12KbSFxgcdbbJaSBFGv4UvkSjCi6ILlx5xOsd1dOM+HnV5fA70JjMFeaqi4tQWRU1+jB5Uy0zd\n I+MPQDAt+7KehntNdf8QLEQb4dWzA8CrX7M5RWglCIRjJpAlcxX67aUHSzgtFu1jWwicumLq3O5\n /BRGEGxjjvz76KY/BNoAZooffBfZniK5T/rCrvZgajQL0dWNzfUsfyyHHwpBjoFw5+X3XNjkPH7\n J9gUKlyNbXXapVFeOvkCospa0abdtnXVtWD4gSF3Y=","X-Received":"by 2002:adf:ffd0:0:b0:43f:e413:f6fd with SMTP id\n ffacd0b85a97d-43fe413f7c0mr37696053f8f.0.1777109915063;\n Sat, 25 Apr 2026 02:38:35 -0700 (PDT)","From":"=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= ","Date":"Sat, 25 Apr 2026 11:38:31 +0200","Subject":"[PATCH 1/2] ui/gtk: Use non-blocking clipboard retrieval","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260425-gtk-clipboard-v1-1-6bd99e708e14@gmail.com>","References":"<20260425-gtk-clipboard-v1-0-6bd99e708e14@gmail.com>","In-Reply-To":"<20260425-gtk-clipboard-v1-0-6bd99e708e14@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Jindrich Makovicka ","X-Mailer":"b4 0.14.3","Received-SPF":"pass client-ip=2a00:1450:4864:20::432;\n envelope-from=makovick@gmail.com; helo=mail-wr1-x432.google.com","X-Spam_score_int":"-10","X-Spam_score":"-1.1","X-Spam_bar":"-","X-Spam_report":"(-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_GMAIL_RCVD=1,\n FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Jindrich Makovicka \n---\n ui/gtk-clipboard.c | 47 ++++++++++++++++++++++++++++++++++-------------\n 1 file changed, 34 insertions(+), 13 deletions(-)","diff":"diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c\nindex 65d89ec601..23d32947cc 100644\n--- a/ui/gtk-clipboard.c\n+++ b/ui/gtk-clipboard.c\n@@ -136,26 +136,50 @@ static void gd_clipboard_notify(Notifier *notifier, void *data)\n }\n }\n \n+static void\n+gd_clipboard_request_text_received_callback(GtkClipboard *clipboard,\n+ const gchar *text,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+ if (text) {\n+ qemu_clipboard_set_data(info->owner, info, QEMU_CLIPBOARD_TYPE_TEXT,\n+ strlen(text), text, true);\n+ }\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_clipboard_request(QemuClipboardInfo *info,\n QemuClipboardType type)\n {\n GtkDisplayState *gd = container_of(info->owner, GtkDisplayState, cbpeer);\n- char *text;\n \n switch (type) {\n case QEMU_CLIPBOARD_TYPE_TEXT:\n- text = gtk_clipboard_wait_for_text(gd->gtkcb[info->selection]);\n- if (text) {\n- qemu_clipboard_set_data(&gd->cbpeer, info, type,\n- strlen(text), text, true);\n- g_free(text);\n- }\n+ qemu_clipboard_info_ref(info);\n+ gtk_clipboard_request_text(gd->gtkcb[info->selection],\n+ gd_clipboard_request_text_received_callback,\n+ info);\n break;\n default:\n break;\n }\n }\n \n+static void\n+gd_clipboard_owner_change_text_received_callback(GtkClipboard *clipboard,\n+ const gchar *text,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+ if (text) {\n+ info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n+ }\n+\n+ qemu_clipboard_update(info);\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_owner_change(GtkClipboard *clipboard,\n GdkEvent *event,\n gpointer data)\n@@ -173,12 +197,9 @@ static void gd_owner_change(GtkClipboard *clipboard,\n switch (event->owner_change.reason) {\n case GDK_OWNER_CHANGE_NEW_OWNER:\n info = qemu_clipboard_info_new(&gd->cbpeer, s);\n- if (gtk_clipboard_wait_is_text_available(clipboard)) {\n- info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n- }\n-\n- qemu_clipboard_update(info);\n- qemu_clipboard_info_unref(info);\n+ gtk_clipboard_request_text(clipboard,\n+ gd_clipboard_owner_change_text_received_callback,\n+ info);\n break;\n default:\n qemu_clipboard_peer_release(&gd->cbpeer, s);\n","prefixes":["1/2"]}