{"id":2228106,"url":"http://patchwork.ozlabs.org/api/patches/2228106/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260425-gtk-clipboard-v1-2-6bd99e708e14@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260425-gtk-clipboard-v1-2-6bd99e708e14@gmail.com>","list_archive_url":null,"date":"2026-04-25T09:38:32","name":"[2/2] ui/gtk: Keep GTK clipboard enabled","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"31d05f42e743e5a8452563a734a75fb71d962e5a","submitter":{"id":4408,"url":"http://patchwork.ozlabs.org/api/people/4408/?format=json","name":"Jindřich Makovička","email":"makovick@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260425-gtk-clipboard-v1-2-6bd99e708e14@gmail.com/mbox/","series":[{"id":501430,"url":"http://patchwork.ozlabs.org/api/series/501430/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501430","date":"2026-04-25T09:38:30","name":"Fix and re-enable GTK clipboard","version":1,"mbox":"http://patchwork.ozlabs.org/series/501430/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228106/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228106/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=OVNUlNJM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2lCZ2BHXz1yJ2\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 19:39:20 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGZTH-00059d-Nv; Sat, 25 Apr 2026 05:38:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <makovick@gmail.com>)\n id 1wGZTE-00058j-9S\n for qemu-devel@nongnu.org; Sat, 25 Apr 2026 05:38:41 -0400","from mail-wr1-x433.google.com ([2a00:1450:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <makovick@gmail.com>)\n id 1wGZTC-00060z-DW\n for qemu-devel@nongnu.org; Sat, 25 Apr 2026 05:38:40 -0400","by mail-wr1-x433.google.com with SMTP id\n ffacd0b85a97d-43fe8bda8e9so4743607f8f.1\n for <qemu-devel@nongnu.org>; Sat, 25 Apr 2026 02:38:38 -0700 (PDT)","from [192.168.0.10] ([2a03:ab00:1000:1b60:331a:b316:78f6:effc])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a18csm74965992f8f.20.2026.04.25.02.38.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 25 Apr 2026 02:38:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777109917; x=1777714717; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=2dMq8uAY2hZDh7iH5qWRo1QMrdAHDTbtAcXk7hVbErE=;\n b=OVNUlNJMH15KtJQzOb/beX1miL1s8PB0AQr+TAZai80uHWbE/2gkxiPPfpJq6VHzbT\n mk779H3H3ZVDkgznnFV2J4y14Rypb+TDhUCBGlJHT8UnizHi35XPL0LnIPn2qRJoKjcM\n /6ZkXJp5UEW3QKEy23OpJbhZ0iX+dUlqhGllCEHRMb62Rl6iLdjufV1kcJfCtL55aLqH\n 8318xhPSwPWedUA8hdXuoT93ZiAKBNl38NxBQDPmAgAWrPbv+97yTVgvV0OEbXUWfURE\n u6SJq0DrERkmDrznbCZ6QLASNFQnRyO4X8gDXFi+S82O5tj7+i4pMkspggHTU/1+X6z+\n znuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777109917; x=1777714717;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=2dMq8uAY2hZDh7iH5qWRo1QMrdAHDTbtAcXk7hVbErE=;\n b=GbRYgQuZlKcfXqw/qNUiWyH1LHgsHQLX/YTDys2dao6oEOrXkrpA3q0Cz8gkRpGORI\n 8UBYksqiSEcCFvSixGvj7yHePbHGtUanWjWz4ng1aQLnsjtjI6GRD8uBztY8WFgZVVYx\n SsoBzlK19nlccTVXFh/KnUDrf+5+OQ1zq8+Kut8I148NHywRYqg0onsJBTkvSoW11LYX\n psa8n2UPnTYE4TxbtfxU6ooOhNGUQrhXKvusxBZKcBAx7C8PfW/u3DPHtxR679+9ALmB\n 1JtLQZHnj+uTNmPbV/YCD2RY4VdF9GIuZWafg/z4mVWxDUvapXmFJjwe8Ux9Sqsh5GCs\n S1XA==","X-Gm-Message-State":"AOJu0Yx9HeV3jDIlUHqUKo56kcJZhK80qSk+rPpuyhoSkNiPemw9DFG7\n /y+WHUV5JW6fqe3tTY/qGf9EXtybZX+r8CLIr6cgJGLh/LHQO287m/D4Dsd5bP953Yc=","X-Gm-Gg":"AeBDiev9nr3lx4Xpxm8NQCUDQYLGQXcAYIC/7d0TfGr1l66Y9+pxw97dRbCLjzTRWsy\n Tqqbj7C+KQd8ixC9Qb3HuvRVS5b67rU8jXst2G2Sb1z5xFQnYTNB24AfZV9q+Vp/4ONZszqw2Uc\n Hxbs3rZsI17EpMJceT6uDdqCSfWw0VsYFNX5HQ2NfDjFcZ9dg/hDGQb0HFjQg/X9Pj1K4dXEgZc\n JeiMCyA3rrEkFd1bZvY2i5b1N6yaufYwDEXFKYKDpwf7DG0hhTpG5KwS+NZyvB/YTQJZuVGWDlE\n sskBkrrfbyq3ejsqD8mZl3Nrf+qW/CvrcMVI/GkoUn7+Xgl2PDsY6JAIhxBUE4Bdni29OsZyq0t\n n8BLhpghxuYFtokAmK/xdp7Bee31ODuOAQvoRXt8PNeOMrconn1gizRNuQucxa8Pa/JH+wPDHpK\n 7mq+rju6bwHCOvIMDCL4BaUygaKZks1i4PAXbdTPc=","X-Received":"by 2002:a05:6000:40ca:b0:43e:a70d:763d with SMTP id\n ffacd0b85a97d-43fe3e14e43mr54017384f8f.46.1777109916564;\n Sat, 25 Apr 2026 02:38:36 -0700 (PDT)","From":"=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= <makovick@gmail.com>","Date":"Sat, 25 Apr 2026 11:38:32 +0200","Subject":"[PATCH 2/2] ui/gtk: Keep GTK clipboard enabled","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260425-gtk-clipboard-v1-2-6bd99e708e14@gmail.com>","References":"<20260425-gtk-clipboard-v1-0-6bd99e708e14@gmail.com>","In-Reply-To":"<20260425-gtk-clipboard-v1-0-6bd99e708e14@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n  Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n  Jindrich Makovicka <makovick@gmail.com>","X-Mailer":"b4 0.14.3","Received-SPF":"pass client-ip=2a00:1450:4864:20::433;\n envelope-from=makovick@gmail.com; helo=mail-wr1-x433.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Jindrich Makovicka <makovick@gmail.com>\n---\n meson.build       | 4 ----\n meson_options.txt | 2 --\n ui/gtk.c          | 2 --\n ui/meson.build    | 4 +---\n 4 files changed, 1 insertion(+), 11 deletions(-)","diff":"diff --git a/meson.build b/meson.build\nindex 096303f021..761c0436a3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1932,7 +1932,6 @@ endif\n gtk = not_found\n gtkx11 = not_found\n vte = not_found\n-have_gtk_clipboard = get_option('gtk_clipboard').enabled()\n \n if get_option('gtk') \\\n              .disable_auto_if(not have_system) \\\n@@ -1954,8 +1953,6 @@ if get_option('gtk') \\\n                        method: 'pkg-config',\n                        required: get_option('vte'))\n     endif\n-  elif have_gtk_clipboard\n-    error('GTK clipboard requested, but GTK not found')\n   endif\n endif\n \n@@ -2475,7 +2472,6 @@ if glusterfs.found()\n endif\n config_host_data.set('CONFIG_GTK', gtk.found())\n config_host_data.set('CONFIG_VTE', vte.found())\n-config_host_data.set('CONFIG_GTK_CLIPBOARD', have_gtk_clipboard)\n config_host_data.set('CONFIG_HEXAGON_IDEF_PARSER', get_option('hexagon_idef_parser'))\n config_host_data.set('CONFIG_LIBATTR', have_old_libattr)\n config_host_data.set('CONFIG_LIBCAP_NG', libcap_ng.found())\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 31d5916cfc..1d4523682b 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -267,8 +267,6 @@ option('vte', type : 'feature', value : 'auto',\n # of the guest VCPUs. See gitlab issue 1150:\n # https://gitlab.com/qemu-project/qemu/-/issues/1150\n \n-option('gtk_clipboard', type: 'feature', value : 'disabled',\n-       description: 'clipboard support for the gtk UI (EXPERIMENTAL, MAY HANG)')\n option('xkbcommon', type : 'feature', value : 'auto',\n        description: 'xkbcommon support')\n option('zstd', type : 'feature', value : 'auto',\ndiff --git a/ui/gtk.c b/ui/gtk.c\nindex 9ebe7e8df0..5e63c502ed 100644\n--- a/ui/gtk.c\n+++ b/ui/gtk.c\n@@ -2601,9 +2601,7 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)\n         opts->u.gtk.show_tabs) {\n         gtk_menu_item_activate(GTK_MENU_ITEM(s->show_tabs_item));\n     }\n-#ifdef CONFIG_GTK_CLIPBOARD\n     gd_clipboard_init(s);\n-#endif /* CONFIG_GTK_CLIPBOARD */\n \n     /* GTK's event polling must happen on the main thread. */\n     qemu_main = NULL;\ndiff --git a/ui/meson.build b/ui/meson.build\nindex 4e533d3046..6405e21d5d 100644\n--- a/ui/meson.build\n+++ b/ui/meson.build\n@@ -111,9 +111,7 @@ if gtk.found()\n \n   gtk_ss = ss.source_set()\n   gtk_ss.add(gtk, vte, pixman, files('gtk.c'))\n-  if have_gtk_clipboard\n-    gtk_ss.add(files('gtk-clipboard.c'))\n-  endif\n+  gtk_ss.add(files('gtk-clipboard.c'))\n   gtk_ss.add(when: x11, if_true: files('x_keymap.c'))\n   gtk_ss.add(when: opengl, if_true: files('gtk-gl-area.c'))\n   gtk_ss.add(when: [x11, opengl], if_true: files('gtk-egl.c'))\n","prefixes":["2/2"]}