{"id":2228018,"url":"http://patchwork.ozlabs.org/api/patches/2228018/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424192543.22614-4-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424192543.22614-4-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-24T19:25:35","name":"[PULL,v4,32/62] qom: Restrict compat properties API to system emulation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d1a98589e0b5cb8ab493dff7a48c2e7c3157040d","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424192543.22614-4-philmd@linaro.org/mbox/","series":[{"id":501401,"url":"http://patchwork.ozlabs.org/api/series/501401/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501401","date":"2026-04-24T19:25:34","name":null,"version":4,"mbox":"http://patchwork.ozlabs.org/series/501401/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228018/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228018/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=mhcCqhxn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2NJP1BYGz1yHv\n\tfor ; Sat, 25 Apr 2026 05:27:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGMAH-0003Eq-2W; Fri, 24 Apr 2026 15:26:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wGMAF-0003Ea-6W\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 15:26:11 -0400","from mail-wr1-x431.google.com ([2a00:1450:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wGMAC-0001OU-OI\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 15:26:10 -0400","by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-43fea39e066so6803055f8f.1\n for ; Fri, 24 Apr 2026 12:26:08 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4c221cdsm63339543f8f.0.2026.04.24.12.26.05\n for \n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 24 Apr 2026 12:26:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777058767; x=1777663567; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=ZJq2F34MQNBz6Mo/u+tAh3sHWBJqifVXBw7FR2rQkMU=;\n b=mhcCqhxn3nF9Ck0K3WyxucPCwfuVLZFxRBc8aeY3d9ZceTIwbBvsSOmNN38eSrgVEs\n BfEUQJ4dZv6fW9d12n9jcCVK8i9SaQoMprKa3WedYOjScLam5g9lXsyUQHN7Y1VkaJv1\n YF0KYcq45PZX5msLH3G+3nRmLqfUK6Mz7MIW0eDQiurdY63Kbv66S3EEkgCo+tWGI30L\n lbx+x8l8oMDqLHY9bu9CUHXUU2jOtwxneGrFgSlGJ6+G+SRhDUWtOvBEZWnAW5cTkZFU\n Y2UpNyhAQ6V30u3+MhAA81uEhEM6VDBXuH+75F3fmBYGNXmmPeZllF7hrilOGCxskaq/\n WtFg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777058767; x=1777663567;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=ZJq2F34MQNBz6Mo/u+tAh3sHWBJqifVXBw7FR2rQkMU=;\n b=RvDDd5pyPN4VGlpo0g/NUstzkELokJzCOgMhDSgHf+N49l6tnGgxbMo28NAkS7Xm0n\n HsE0KkU6A3XoOigyTSRktBF2JHZkNCW+tlAWc+t6qSv9xbV39YaLtYtAuxHX0Db59j4E\n cQM2uWC1DbYXLFMsxYUe1MPgTcZCCPcjw41/aRVMLBk2z19CTRd1Mw4BBlQjDOKdpH20\n v5xMAuXs29BanFfXCAn/RWnZ6nqlFEJ0DCug2QV99XYZkb8wZkBfUEdrMAEuYgjI7zSA\n p4/1rciV8aNDKHXrASOtBEA6eyeOD+CAebxc/nrAQMDMbw69jSNjJlOYRZjmIsg5reGY\n aIzg==","X-Gm-Message-State":"AOJu0Yxyc2hW6Bku4KqD3rjaepz9wmagdYid8ssrdaMh8uW/LjHLAUyw\n si0QYJ2umcqbblYfy9E+ulo0x/OARCOFG6K/i4YBpmR9uN0fctH9+3WaETFcZOqR5MK2H+wTqqC\n itnQPsIM=","X-Gm-Gg":"AeBDieuA8m24rfE++CnMCylbs/XLt5zGtnL/KovqEU5wnLHIMJaOzt2KcJma7Kyozx1\n mKUs2vjiRpkP4ubI+R4iLBICaf4nklTuz9kl1zvcfkLFV0W40ynjnO3MflG6gYBKwZHCmGlq8S1\n EvtxPakl65rXYU3BxqS+0Irebtb+g6vWF/gc5hQJFB7PDJyGq6yD6aHB9pX5qXvx01h3u7uktbt\n w9Iy+DvZHsrdWHoWXAahFOjiRAtHGBN6RA8gPI4mwdCOF3ttKWamziEQd3Ur6OxUv6KelqyYyMV\n ecN6jyiiAjwfcVw867tfRES8oaMeMMUc8y7bwCBhXEkqpAer988yTVrgO8hkqrnWSHhYE7D1B3n\n yvJHDtoHtews/IleTdCmBfaQITnJleFrht9OLh5NcZcgnUhC0BG5Vakuyq+AwQkAUy8c14n+8nM\n ETeHn9ffe/T39tir7/tlFbLOSyycPdUtBgIbjHfiOvs4MC9Mor/MDe+4IbCk6mRxtT5prHEIUU+\n hsa9VgBoU8=","X-Received":"by 2002:a05:6000:601:b0:43d:613:33de with SMTP id\n ffacd0b85a97d-43fe3dd3ed3mr52441782f8f.20.1777058766490;\n Fri, 24 Apr 2026 12:26:06 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Subject":"[PULL v4 32/62] qom: Restrict compat properties API to system\n emulation","Date":"Fri, 24 Apr 2026 21:25:35 +0200","Message-ID":"<20260424192543.22614-4-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260424192543.22614-1-philmd@linaro.org>","References":"<20260424192543.22614-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::431;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Move compat properties API definitions to their own file\nunit, compile it only when system emulation is configured.\nAdd a pair of stubs for user emulation.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Michael Tokarev \nMessage-Id: <20260325151728.45378-6-philmd@linaro.org>\n---\n MAINTAINERS | 1 +\n qom/compat-properties.c | 76 +++++++++++++++++++++++++++++++++++\n qom/object.c | 60 ---------------------------\n stubs/qom-compat-properties.c | 14 +++++++\n qom/meson.build | 3 ++\n stubs/meson.build | 1 +\n 6 files changed, 95 insertions(+), 60 deletions(-)\n create mode 100644 qom/compat-properties.c\n create mode 100644 stubs/qom-compat-properties.c","diff":"diff --git a/MAINTAINERS b/MAINTAINERS\nindex facc4b499a9..45d258f64fc 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -3533,6 +3533,7 @@ F: qapi/qom.json\n F: scripts/coccinelle/qom-parent-type.cocci\n F: scripts/qom-cast-macro-clean-cocci-gen.py\n F: qom/\n+F: stubs/qom-compat-properties.c\n F: tests/unit/check-qom-interface.c\n F: tests/unit/check-qom-proplist.c\n F: tests/qtest/qom-test.c\ndiff --git a/qom/compat-properties.c b/qom/compat-properties.c\nnew file mode 100644\nindex 00000000000..2110754155a\n--- /dev/null\n+++ b/qom/compat-properties.c\n@@ -0,0 +1,76 @@\n+/*\n+ * QEMU Object Model\n+ *\n+ * Copyright IBM, Corp. 2011\n+ *\n+ * Authors:\n+ * Anthony Liguori \n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qapi/error.h\"\n+#include \"qom/compat-properties.h\"\n+#include \"qom/qom-qobject.h\"\n+#include \"hw/core/qdev.h\"\n+\n+/*\n+ * Global property defaults\n+ * Slot 0: accelerator's global property defaults\n+ * Slot 1: machine's global property defaults\n+ * Slot 2: global properties from legacy command line option\n+ * Each is a GPtrArray of GlobalProperty.\n+ * Applied in order, later entries override earlier ones.\n+ */\n+static GPtrArray *object_compat_props[3];\n+\n+/*\n+ * Retrieve @GPtrArray for global property defined with options\n+ * other than \"-global\". These are generally used for syntactic\n+ * sugar and legacy command line options.\n+ */\n+void object_register_sugar_prop(const char *driver, const char *prop,\n+ const char *value, bool optional)\n+{\n+ GlobalProperty *g;\n+ if (!object_compat_props[2]) {\n+ object_compat_props[2] = g_ptr_array_new();\n+ }\n+ g = g_new0(GlobalProperty, 1);\n+ g->driver = g_strdup(driver);\n+ g->property = g_strdup(prop);\n+ g->value = g_strdup(value);\n+ g->optional = optional;\n+ g_ptr_array_add(object_compat_props[2], g);\n+}\n+\n+/*\n+ * Set machine's global property defaults to @compat_props.\n+ * May be called at most once.\n+ */\n+void object_set_machine_compat_props(GPtrArray *compat_props)\n+{\n+ assert(!object_compat_props[1]);\n+ object_compat_props[1] = compat_props;\n+}\n+\n+/*\n+ * Set accelerator's global property defaults to @compat_props.\n+ * May be called at most once.\n+ */\n+void object_set_accelerator_compat_props(GPtrArray *compat_props)\n+{\n+ assert(!object_compat_props[0]);\n+ object_compat_props[0] = compat_props;\n+}\n+\n+void object_apply_compat_props(Object *obj)\n+{\n+ int i;\n+\n+ for (i = 0; i < ARRAY_SIZE(object_compat_props); i++) {\n+ object_apply_global_props(obj, object_compat_props[i],\n+ i == 2 ? &error_fatal : &error_abort);\n+ }\n+}\ndiff --git a/qom/object.c b/qom/object.c\nindex d6500bcbbf4..f981e270440 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -480,66 +480,6 @@ bool object_apply_global_props(Object *obj, const GPtrArray *props,\n return true;\n }\n \n-/*\n- * Global property defaults\n- * Slot 0: accelerator's global property defaults\n- * Slot 1: machine's global property defaults\n- * Slot 2: global properties from legacy command line option\n- * Each is a GPtrArray of GlobalProperty.\n- * Applied in order, later entries override earlier ones.\n- */\n-static GPtrArray *object_compat_props[3];\n-\n-/*\n- * Retrieve @GPtrArray for global property defined with options\n- * other than \"-global\". These are generally used for syntactic\n- * sugar and legacy command line options.\n- */\n-void object_register_sugar_prop(const char *driver, const char *prop,\n- const char *value, bool optional)\n-{\n- GlobalProperty *g;\n- if (!object_compat_props[2]) {\n- object_compat_props[2] = g_ptr_array_new();\n- }\n- g = g_new0(GlobalProperty, 1);\n- g->driver = g_strdup(driver);\n- g->property = g_strdup(prop);\n- g->value = g_strdup(value);\n- g->optional = optional;\n- g_ptr_array_add(object_compat_props[2], g);\n-}\n-\n-/*\n- * Set machine's global property defaults to @compat_props.\n- * May be called at most once.\n- */\n-void object_set_machine_compat_props(GPtrArray *compat_props)\n-{\n- assert(!object_compat_props[1]);\n- object_compat_props[1] = compat_props;\n-}\n-\n-/*\n- * Set accelerator's global property defaults to @compat_props.\n- * May be called at most once.\n- */\n-void object_set_accelerator_compat_props(GPtrArray *compat_props)\n-{\n- assert(!object_compat_props[0]);\n- object_compat_props[0] = compat_props;\n-}\n-\n-void object_apply_compat_props(Object *obj)\n-{\n- int i;\n-\n- for (i = 0; i < ARRAY_SIZE(object_compat_props); i++) {\n- object_apply_global_props(obj, object_compat_props[i],\n- i == 2 ? &error_fatal : &error_abort);\n- }\n-}\n-\n static void object_class_property_init_all(Object *obj)\n {\n ObjectPropertyIterator iter;\ndiff --git a/stubs/qom-compat-properties.c b/stubs/qom-compat-properties.c\nnew file mode 100644\nindex 00000000000..2c955677bed\n--- /dev/null\n+++ b/stubs/qom-compat-properties.c\n@@ -0,0 +1,14 @@\n+/*\n+ * QEMU Object Model (compat properties stubs for user emulation)\n+ *\n+ * Copyright (c) Linaro\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qom/compat-properties.h\"\n+\n+void object_apply_compat_props(Object *obj)\n+{\n+}\ndiff --git a/qom/meson.build b/qom/meson.build\nindex 81922434309..bd6f4aadd78 100644\n--- a/qom/meson.build\n+++ b/qom/meson.build\n@@ -5,6 +5,9 @@ qom_ss.add(files(\n 'object_interfaces.c',\n 'qom-qobject.c',\n ))\n+if have_system\n+ qom_ss.add(files('compat-properties.c'))\n+endif\n \n qmp_ss.add(files('qom-qmp-cmds.c'))\n system_ss.add(files('qom-hmp-cmds.c'))\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 7189ff63ed5..f33b1d2a089 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -54,6 +54,7 @@ if have_user\n # Symbols that are used by hw/core.\n stub_ss.add(files('cpu-synchronize-state.c'))\n stub_ss.add(files('cpu-destroy-address-spaces.c'))\n+ stub_ss.add(files('qom-compat-properties.c'))\n \n # Stubs for QAPI events. Those can always be included in the build, but\n # they are not built at all for --disable-system builds.\n","prefixes":["PULL","v4","32/62"]}