{"id":2228017,"url":"http://patchwork.ozlabs.org/api/patches/2228017/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424192543.22614-7-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424192543.22614-7-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-24T19:25:38","name":"[PULL,v4,50/62] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and dead code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"81b1b56ec07fff1abd622c0930d3d764361a0cac","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424192543.22614-7-philmd@linaro.org/mbox/","series":[{"id":501401,"url":"http://patchwork.ozlabs.org/api/series/501401/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501401","date":"2026-04-24T19:25:34","name":null,"version":4,"mbox":"http://patchwork.ozlabs.org/series/501401/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228017/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228017/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=cgRtGdV/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2NJN62zCz1y2d\n\tfor ; Sat, 25 Apr 2026 05:27:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGMAa-0003ZA-BQ; Fri, 24 Apr 2026 15:26:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wGMAY-0003SQ-RD\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 15:26:30 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wGMAX-0001YB-89\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 15:26:30 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-4891c0620bcso53005165e9.1\n for ; Fri, 24 Apr 2026 12:26:28 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891df9e50asm329548175e9.0.2026.04.24.12.26.25\n for \n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 24 Apr 2026 12:26:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777058787; x=1777663587; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=a3W4eM2x/CLE97cGb/OjgAFNHt4NwclYuyxbReGj0M0=;\n b=cgRtGdV/ciEwWuxK9236giDFhg3pmo3ZEYEGhRO/E6ki3mVU42/dfFvQAFjCTRRsJl\n PPpARJCE525BqPn8fQctSJhvgZ7kSnP2VCedJGRjTu+ISC9dlA21u7+0SfYREs2fUGHg\n XUTemWzPc92vnLTEtrCA4ZkLPJWYlwQf+G91/CCd6huQJYFHS1x674OfdBMgy7AD/zni\n cF+Y3kkws++bV6IEjDCzAHgzxUJSoT1tLeOOlxbBko3X5I1y4v+f+kY2aIJT29kWcMOw\n ECP9KP8u0ND6jStpAe+ehBPuZyGbd2JCS/wiz+ixD2NsHazAwQwQ9Co+6ZZG9pXrvoYL\n zG0g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777058787; x=1777663587;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=a3W4eM2x/CLE97cGb/OjgAFNHt4NwclYuyxbReGj0M0=;\n b=tZ8ObJzmZTESZnU5BrzU3hOMoit5yyzuPNUAXlUCdDCOXKfB5ccflGGPyDI3SXxvPd\n PO5CYe3zMO8ktetCCUjArcoJRwPO2KvUc4m1Uyl27L2G2e9QZ8330o/xw0sqxkOG6t/4\n EBHdKz2ObGORLpbDRdVW3uo1jKMoQARmKYbRTyb0S2dpQ9F+lsxvGf/1ZP2mODxKdeNQ\n UuV4liHjlDz9zP+LH2XLjzMPZPtx4Eg1TaAv502nI1xRFVkU47bPfVseHKpv8AoZBMbp\n WqYl5FvWZ4frtCjr4bZ6YhwWV3QyzF3GJkaLlnHLUpN9Ti0dGSDnEhqK2kpGNA2VQ/Rm\n FyDg==","X-Gm-Message-State":"AOJu0Yxo9bFvRuLAqYtMM41cj2F56CgsAxNCDaX9Okl9ZB73mNDCHtZq\n 3a/eCdYA3rHYkfocLLNvNou0N2vZCvhMS1PGrlWA1ayYhwxTvxVniPr6cNgIGEUDI3rF1/LIV15\n f6jz6Xd4=","X-Gm-Gg":"AeBDiesEcZ2v8jUIQx542JYeRH5nrW+7Yov5kNj90CGfXYpUJvpky5HreDqH50lGGHH\n AQOE9xgVzE1PQlMqt75OiNutTQxbqMfOAXFLWR7mqMmEppz3BEurEqaGA5n7XHLc87uydEraOU7\n O8p3ZkEHY/iDgo16MJmM6cpRTIji1q3/3pP0ZYkiZ7/F1lbPwfhxOm54eknTT92QSR+/DNGWi2z\n ARlBYtDkectcgSHPakf9QdiAJInsONVLn0sV8TQtWb37TWj8z9trl3YVLZBCG9VtE78NXDGkG6r\n HWIy1ABfqe4HYjZyDTIRhYVZ/c+OlidL9ubltpiNFuImJUBSAwyMlQ0bwFK4ExubksHpfPe1Ngn\n HgiB/3YIqzHrZgBm/PmO5V779z7IUrvtt51ve31jh2gG/ieP26OwKi+r5DwPZabsJa3c4Nzi7Uq\n U+kp/007M8e7Spw/QK65gN3iA1B26HM/DtazQxCvixgkEyLKbBR4EFiQV4wyLsi3rYVUm6UWFIg\n hZ2K9UGapM=","X-Received":"by 2002:a05:600c:19d3:b0:489:1ae1:4eb9 with SMTP id\n 5b1f17b1804b1-4891ae14f23mr323790995e9.28.1777058787194;\n Fri, 24 Apr 2026 12:26:27 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Subject":"[PULL v4 50/62] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and\n dead code","Date":"Fri, 24 Apr 2026 21:25:38 +0200","Message-ID":"<20260424192543.22614-7-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260424192543.22614-1-philmd@linaro.org>","References":"<20260424192543.22614-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Jamin Lin \n\nThe EHCIfstn structure, defined according to EHCI spec section 3.7,\nis currently unused in the EHCI implementation. Remove it to reduce\nunused code and improve maintainability.\n\nAdditionally, drop a block of disabled (#if 0) code in\nehci_state_advqueue() that was never implemented. This code path\nis incomplete and has no functional impact.\n\nNo functional change.\n\nSigned-off-by: Jamin Lin \nReviewed-by: Cédric Le Goater \nMessage-ID: <20260424080508.53992-3-jamin_lin@aspeedtech.com>\nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/usb/hcd-ehci.h | 7 -------\n hw/usb/hcd-ehci.c | 6 ------\n 2 files changed, 13 deletions(-)","diff":"diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\nindex 0ae8c06331a..3aec0e047c9 100644\n--- a/hw/usb/hcd-ehci.h\n+++ b/hw/usb/hcd-ehci.h\n@@ -202,13 +202,6 @@ typedef struct EHCIqh {\n #define BUFPTR_SBYTES_SH 5\n } EHCIqh;\n \n-/* EHCI spec version 1.0 Section 3.7\n- */\n-typedef struct EHCIfstn {\n- uint32_t next; /* Standard next link pointer */\n- uint32_t backptr; /* Standard next link pointer */\n-} EHCIfstn;\n-\n enum async_state {\n EHCI_ASYNC_NONE = 0,\n EHCI_ASYNC_INITIALIZED,\ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 57f930b0998..23167bf96f3 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -1756,16 +1756,10 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n /* Section 4.10.2 - paragraph 3 */\n static int ehci_state_advqueue(EHCIQueue *q)\n {\n-#if 0\n /* TO-DO: 4.10.2 - paragraph 2\n * if I-bit is set to 1 and QH is not active\n * go to horizontal QH\n */\n- if (I-bit set) {\n- ehci_set_state(ehci, async, EST_HORIZONTALQH);\n- goto out;\n- }\n-#endif\n \n /*\n * want data and alt-next qTD is valid\n","prefixes":["PULL","v4","50/62"]}