{"id":2227979,"url":"http://patchwork.ozlabs.org/api/patches/2227979/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260424160259.2672722-2-johan@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260424160259.2672722-2-johan@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260424160259.2672722-2-johan@kernel.org/","date":"2026-04-24T16:02:57","name":"[v2,1/3] powerpc/ps3: switch to dynamic system bus root device","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4fd1b4a3cbe5f551518d02a990885821f99e4f52","submitter":{"id":64666,"url":"http://patchwork.ozlabs.org/api/people/64666/?format=json","name":"Johan Hovold","email":"johan@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260424160259.2672722-2-johan@kernel.org/mbox/","series":[{"id":501391,"url":"http://patchwork.ozlabs.org/api/series/501391/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501391","date":"2026-04-24T16:02:57","name":"powerpc: switch to dynamic root devices","version":2,"mbox":"http://patchwork.ozlabs.org/series/501391/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227979/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227979/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linuxppc-dev+bounces-20085-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kHPx5zDe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20085-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kHPx5zDe;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=johan@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2Hnp56Wxz1yDD\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 02:03:57 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g2Hnm0c8Lz2yjV;\n\tSat, 25 Apr 2026 02:03:56 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g2Hnl0Lb1z2yC9\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sat, 25 Apr 2026 02:03:55 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 1FA334096E;\n\tFri, 24 Apr 2026 16:03:52 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EAF7CC19425;\n\tFri, 24 Apr 2026 16:03:51 +0000 (UTC)","from johan by xi.lan with local (Exim 4.98.2)\n\t(envelope-from <johan@kernel.org>)\n\tid 1wGJ0P-0000000BDJd-3H6m;\n\tFri, 24 Apr 2026 18:03:49 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777046635;\n\tcv=none;\n b=i8hc7JEKSNfGv4IlLDrdyb/u5UMfw12rlp6iCyE2fE3vPREgzIHS94fnb4MaWm1BbXuyYxD5HXglbt4xEoGvGYu5KO6KgqG+pSLfSQipColRG3FgIRBGPVqAe1U1UXKbL3fEV/Vohnir4Xop38DECPeGO82nWCMKNs6F6flbUjSkSoz0YfPJVX5RiQHl6CHjydPMk93OhYWltwNM9CuheshbvzNZ5AkwtUDsmjmZ5bWxhg3YFckgObZQN7d27VxktHSb6/KBS4pD6cHtQezRvMupnXFqvhxVJv0xyGuGILqiADb8TfzHBWcgvfzVmrgqmruMx17FLlIQjJPUiacOXw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777046635; c=relaxed/relaxed;\n\tbh=P1nJG/WlxpA7oGG2+Q8e3ef+sd4zfXvCwzoI+e/Kg3c=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=AMsghu19jD53h/lEMJvs/FsfD6NrEa29mao2y/OsQdwGSId7ymXfCMPkqseiL02jueNesEpkBZCTvZd3tlsbCsCCsrDXu9pzZUWd3dH7QOrYitwys4yd6WjD7Ta9TiB3bh1CYYLZbuJMF8aWMfPqZYOtfzsfdTH6527L/hLxDGKrA89QLhYfUBkHC88Dl07dOOVscnoX6DdOZW+TsWA4Sj6I7J1YJG2Q06DfjIebOrKdIaJb9khLQLE+hafxuEDUvM8HMPjFOxqDViySYE8lyeheQIVtfiQE0A21kDMF6naHKhRt+usiR+x63xxIDQR8K/EbcvHkwjCa7rsiz7/1DA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kHPx5zDe; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=johan@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777046632;\n\tbh=OpjYnvUINC0m/fERNUlL4a3+lpA8IFC0Re5p9y/suRY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kHPx5zDeAWeJIGcgZA6QqcJE9toft/blPMdaDaFKnu4DQf+K7B8fuF1ef4m2JhmKb\n\t 9t2l4/TtcsBjz+6bsUaSGseDixTCFT3GOqugf+F7o9a7Oy7EWNkJQ2eSuy5v/eHeco\n\t a0Xm4Dfzos6CG+I9ttnvmRpAluFfu+zIxB9kA8hvrn6WRlHMB+Y8risu8KQMznvdfj\n\t obiDYVOKkAbBlUJjhpqk+qbGwF50onmRd1MvmeOdj+7fKoG7OG0PL8F28aIcOOCG2x\n\t WC6NeRazMriMZ7eREcgtG+C/AMlxpbGbstDeaV8oXVU1nSvZD2pZeN67z65FrHXayE\n\t kts7z/a9NB3iQ==","From":"Johan Hovold <johan@kernel.org>","To":"Geoff Levand <geoff@infradead.org>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>","Cc":"Nicholas Piggin <npiggin@gmail.com>,\n\tChristophe Leroy <chleroy@kernel.org>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org,\n\tJohan Hovold <johan@kernel.org>","Subject":"[PATCH v2 1/3] powerpc/ps3: switch to dynamic system bus root device","Date":"Fri, 24 Apr 2026 18:02:57 +0200","Message-ID":"<20260424160259.2672722-2-johan@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260424160259.2672722-1-johan@kernel.org>","References":"<20260424160259.2672722-1-johan@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Driver core expects devices to be dynamically allocated and will, for\nexample, complain loudly if a device that lacks a release function\nis ever freed.\n\nUse root_device_register() to allocate and register the root device\ninstead of open coding using a static device.\n\nSigned-off-by: Johan Hovold <johan@kernel.org>\n---\n arch/powerpc/platforms/ps3/system-bus.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c\nindex 0537a678a32f..4ead6ccea259 100644\n--- a/arch/powerpc/platforms/ps3/system-bus.c\n+++ b/arch/powerpc/platforms/ps3/system-bus.c\n@@ -20,9 +20,7 @@\n \n #include \"platform.h\"\n \n-static struct device ps3_system_bus = {\n-\t.init_name = \"ps3_system\",\n-};\n+static struct device *ps3_system_bus;\n \n /* FIXME: need device usage counters! */\n static struct {\n@@ -486,8 +484,8 @@ static int __init ps3_system_bus_init(void)\n \n \tmutex_init(&usage_hack.mutex);\n \n-\tresult = device_register(&ps3_system_bus);\n-\tBUG_ON(result);\n+\tps3_system_bus = root_device_register(\"ps3_system\");\n+\tBUG_ON(IS_ERR(ps3_system_bus));\n \n \tresult = bus_register(&ps3_system_bus_type);\n \tBUG_ON(result);\n@@ -744,7 +742,7 @@ int ps3_system_bus_device_register(struct ps3_system_bus_device *dev)\n \tstatic unsigned int dev_lpm_count;\n \n \tif (!dev->core.parent)\n-\t\tdev->core.parent = &ps3_system_bus;\n+\t\tdev->core.parent = ps3_system_bus;\n \tdev->core.bus = &ps3_system_bus_type;\n \tdev->core.release = ps3_system_bus_release_device;\n \n","prefixes":["v2","1/3"]}