{"id":2227930,"url":"http://patchwork.ozlabs.org/api/patches/2227930/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260424135824.2490F593A4@imap1.dmz-prg2.suse.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424135824.2490F593A4@imap1.dmz-prg2.suse.org>","list_archive_url":null,"date":"2026-04-24T13:58:19","name":"Some TLC to vect_create_new_slp_node APIs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b61e9f0ba1e3013937bb1bffe2b1442544e16509","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/people/4338/?format=json","name":"Richard Biener","email":"rguenther@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260424135824.2490F593A4@imap1.dmz-prg2.suse.org/mbox/","series":[{"id":501371,"url":"http://patchwork.ozlabs.org/api/series/501371/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501371","date":"2026-04-24T13:58:19","name":"Some TLC to vect_create_new_slp_node APIs","version":1,"mbox":"http://patchwork.ozlabs.org/series/501371/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227930/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227930/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=W0e9CkLy;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VIVcGCjF;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=W0e9CkLy;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VIVcGCjF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=W0e9CkLy;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VIVcGCjF;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=W0e9CkLy;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VIVcGCjF","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","sourceware.org; spf=pass smtp.mailfrom=suse.de","server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.130","smtp-out1.suse.de;\n\tnone"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2F2k30jzz1xvV\n\tfor ; Fri, 24 Apr 2026 23:59:58 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 279944BB5910\n\tfor ; Fri, 24 Apr 2026 13:59:56 +0000 (GMT)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n by sourceware.org (Postfix) with ESMTPS id 49AAD4BB591E\n for ; Fri, 24 Apr 2026 13:58:25 +0000 (GMT)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 3BEC46A8AA\n for ; Fri, 24 Apr 2026 13:58:24 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2490F593A4\n for ; Fri, 24 Apr 2026 13:58:24 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id hnptBwB362mqUwAAD6G6ig\n (envelope-from )\n for ; Fri, 24 Apr 2026 13:58:24 +0000"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 279944BB5910","OpenDKIM Filter v2.11.0 sourceware.org 49AAD4BB591E"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 49AAD4BB591E","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 49AAD4BB591E","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777039105; cv=none;\n b=KsEnCxQIkYz66P3JXNTCf6i6lil7pS/7G4sctsdRePWygHoFU5V7uvv5lwLWwE3PVvsTX/DWUhfSwITI0M9Av9WZ11LSvcfzGvgjZRIspiQ7XqAL3FHZ+jfz1mP1ufEMwErHX/RyB5DCtvGFOMWzzTO+MaGNO4xXxvaKnigYhVA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777039105; c=relaxed/simple;\n bh=b6LUctIGaFO+m2YqO7vSTd/J8NDmeVwAhhc1Or2Bl5I=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:MIME-Version:Message-Id;\n b=e7dAhtcjqfqbZtofvs4KDCs0y5XP3IdXnX+IOREfCPTBijQtLkchvXLqAN8v0lU/gibXe4tchzRiFUm7B2wcTe6zPr1pAqNs1uBd11kZS9yYapvsN+0564tPGgkJJ1q8XtqzcOZwhmFU0rgfzsQReO3BrRJUFiz5doee1GNMtWw=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777039104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=WNK97Uj+53IclOro9aRVO1Er02mGlU82VhJ0Ep+CAlY=;\n b=W0e9CkLy11QdjRBOzaya/tSKxV963cxLAasTbq28QhWCPQ1wFD/d23SAcAyeBYQYYJZ0m7\n gqt70mePPbZds5daBB9ih5USAbg/Gsufo37SHQg/rE8iFS/TL921/lmPH0zjDH5CJjaurl\n Aw3uzTZVv1VBjgtdi+/tJJEuC50ZbXA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777039104;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=WNK97Uj+53IclOro9aRVO1Er02mGlU82VhJ0Ep+CAlY=;\n b=VIVcGCjFr9H4181/ZM0cmsP9f2c75S7uxphOipD+dPdo0L2oE09ReoErJc15/ncWVO8AhJ\n 6s6Fw22gPN3siUDg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777039104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=WNK97Uj+53IclOro9aRVO1Er02mGlU82VhJ0Ep+CAlY=;\n b=W0e9CkLy11QdjRBOzaya/tSKxV963cxLAasTbq28QhWCPQ1wFD/d23SAcAyeBYQYYJZ0m7\n gqt70mePPbZds5daBB9ih5USAbg/Gsufo37SHQg/rE8iFS/TL921/lmPH0zjDH5CJjaurl\n Aw3uzTZVv1VBjgtdi+/tJJEuC50ZbXA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777039104;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:content-type:content-type;\n bh=WNK97Uj+53IclOro9aRVO1Er02mGlU82VhJ0Ep+CAlY=;\n b=VIVcGCjFr9H4181/ZM0cmsP9f2c75S7uxphOipD+dPdo0L2oE09ReoErJc15/ncWVO8AhJ\n 6s6Fw22gPN3siUDg=="],"Date":"Fri, 24 Apr 2026 15:58:19 +0200 (CEST)","From":"Richard Biener ","To":"gcc-patches@gcc.gnu.org","Subject":"[PATCH] Some TLC to vect_create_new_slp_node APIs","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Message-Id":"<20260424135824.2490F593A4@imap1.dmz-prg2.suse.org>","X-Spamd-Result":"default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_ALL(0.00)[];\n PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n TO_DN_NONE(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,\n imap1.dmz-prg2.suse.org:mid, tree-vect-slp.cc:url]","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"The following properly documents the overloads of vect_create_new_slp_node\nand adjusts callers in tree-vect-slp-patterns.cc\n\nBootstrapped and tested on x86_64-unknown-linux-gnu, pushed.\n\n\t* tree-vect-slp.cc (vect_create_new_slp_node): Assert that 'code'\n\tis either ERROR_MARK or VEC_PERM_EXPR. Document properly.\n\t* tree-vect-slp-patterns.cc (vect_build_swap_evenodd_node):\n\tUse lane_permutation_t.\n\t(vect_build_combine_node): Likewise. Pass VEC_PERM_EXPR\n\tas code.\n---\n gcc/tree-vect-slp-patterns.cc | 7 +++----\n gcc/tree-vect-slp.cc | 14 +++++++++-----\n 2 files changed, 12 insertions(+), 9 deletions(-)","diff":"diff --git a/gcc/tree-vect-slp-patterns.cc b/gcc/tree-vect-slp-patterns.cc\nindex 131ab90e2e5..5e765e23847 100644\n--- a/gcc/tree-vect-slp-patterns.cc\n+++ b/gcc/tree-vect-slp-patterns.cc\n@@ -274,7 +274,7 @@ static slp_tree\n vect_build_swap_evenodd_node (slp_tree node)\n {\n /* Attempt to linearise the permute. */\n- vec > zipped;\n+ lane_permutation_t zipped;\n zipped.create (SLP_TREE_LANES (node));\n \n for (unsigned x = 0; x < SLP_TREE_LANES (node); x+=2)\n@@ -953,7 +953,7 @@ vect_validate_multiplication (slp_tree_to_load_perm_map_t *perm_cache,\n static slp_tree\n vect_build_combine_node (slp_tree even, slp_tree odd, slp_tree rep)\n {\n- vec > perm;\n+ lane_permutation_t perm;\n perm.create (SLP_TREE_LANES (rep));\n \n for (unsigned x = 0; x < SLP_TREE_LANES (rep); x+=2)\n@@ -962,8 +962,7 @@ vect_build_combine_node (slp_tree even, slp_tree odd, slp_tree rep)\n perm.quick_push (std::make_pair (1, x+1));\n }\n \n- slp_tree vnode = vect_create_new_slp_node (2, SLP_TREE_CODE (even));\n- SLP_TREE_CODE (vnode) = VEC_PERM_EXPR;\n+ slp_tree vnode = vect_create_new_slp_node (2, VEC_PERM_EXPR);\n SLP_TREE_LANE_PERMUTATION (vnode) = perm;\n \n SLP_TREE_CHILDREN (vnode).create (2);\ndiff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc\nindex cec3c2b9589..942e300a448 100644\n--- a/gcc/tree-vect-slp.cc\n+++ b/gcc/tree-vect-slp.cc\n@@ -217,11 +217,13 @@ vect_free_slp_instance (slp_instance instance)\n }\n \n \n-/* Create an SLP node for SCALAR_STMTS. */\n+/* Create a SLP node with NOPS children with CODE, either VEC_PERM_EXPR\n+ for a permute node or else ERROR_MARK. */\n \n slp_tree\n vect_create_new_slp_node (unsigned nops, tree_code code)\n {\n+ gcc_assert (code == ERROR_MARK || code == VEC_PERM_EXPR);\n slp_tree node = new _slp_tree;\n SLP_TREE_SCALAR_STMTS (node) = vNULL;\n SLP_TREE_CHILDREN (node).create (nops);\n@@ -229,7 +231,8 @@ vect_create_new_slp_node (unsigned nops, tree_code code)\n SLP_TREE_CODE (node) = code;\n return node;\n }\n-/* Create an SLP node for SCALAR_STMTS. */\n+\n+/* Create a SLP node inplace at NODE for SCALAR_STMTS and NOPS children. */\n \n static slp_tree\n vect_create_new_slp_node (slp_tree node,\n@@ -243,7 +246,7 @@ vect_create_new_slp_node (slp_tree node,\n return node;\n }\n \n-/* Create an SLP node for SCALAR_STMTS. */\n+/* Create an SLP node for SCALAR_STMTS and NOPS children. */\n \n static slp_tree\n vect_create_new_slp_node (vec scalar_stmts, unsigned nops)\n@@ -251,7 +254,8 @@ vect_create_new_slp_node (vec scalar_stmts, unsigned nops)\n return vect_create_new_slp_node (new _slp_tree, scalar_stmts, nops);\n }\n \n-/* Create an SLP node for OPS. */\n+/* Create a vect_external_def SLP node inplace at NODE for scalar\n+ operands OPS. */\n \n static slp_tree\n vect_create_new_slp_node (slp_tree node, vec ops)\n@@ -262,7 +266,7 @@ vect_create_new_slp_node (slp_tree node, vec ops)\n return node;\n }\n \n-/* Create an SLP node for OPS. */\n+/* Create a vect_external_def SLP node for scalar operands OPS. */\n \n static slp_tree\n vect_create_new_slp_node (vec ops)\n","prefixes":[]}