{"id":2227904,"url":"http://patchwork.ozlabs.org/api/patches/2227904/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260424132342.3486635-7-amusil@redhat.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424132342.3486635-7-amusil@redhat.com>","list_archive_url":null,"date":"2026-04-24T13:23:41","name":"[ovs-dev,6/7] controller: Make sure that EVPN datapaths are kept across runs.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6a0af6e188a1fa48e2da3fbef449df6cf1e873d6","submitter":{"id":83634,"url":"http://patchwork.ozlabs.org/api/people/83634/?format=json","name":"Ales Musil","email":"amusil@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260424132342.3486635-7-amusil@redhat.com/mbox/","series":[{"id":501360,"url":"http://patchwork.ozlabs.org/api/series/501360/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=501360","date":"2026-04-24T13:23:35","name":"This series adds support for Equal-Cost Multi-Path (ECMP) FDB entries","version":1,"mbox":"http://patchwork.ozlabs.org/series/501360/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227904/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2227904/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aHYhXaEb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aHYhXaEb","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2DFZ70XBz1yD5\n\tfor ; Fri, 24 Apr 2026 23:24:18 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 64BBF42852;\n\tFri, 24 Apr 2026 13:24:17 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uJcegwZ5_UtP; Fri, 24 Apr 2026 13:24:16 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 7B8F842848;\n\tFri, 24 Apr 2026 13:24:16 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 16895C04FB;\n\tFri, 24 Apr 2026 13:24:16 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 10FCEC04FB\n for ; Fri, 24 Apr 2026 13:24:15 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 14B2F427CD\n for ; Fri, 24 Apr 2026 13:24:00 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pjcfGeOP9__0 for ;\n Fri, 24 Apr 2026 13:23:59 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id C1F2F427EE\n for ; Fri, 24 Apr 2026 13:23:58 +0000 (UTC)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-362--twITu6xM_6Wwcix_y2Piw-1; Fri,\n 24 Apr 2026 09:23:56 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 48F3518004A9\n for ; Fri, 24 Apr 2026 13:23:55 +0000 (UTC)","from amusil.redhat.com (unknown [10.44.32.61])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E00C3180047F; Fri, 24 Apr 2026 13:23:53 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7B8F842848","OpenDKIM Filter v2.11.0 smtp4.osuosl.org C1F2F427EE"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=amusil@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org C1F2F427EE","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777037037;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/6/0BZZ95I+d/wP/xuzP/LLjrLgTKzalyHQ270AKzfs=;\n b=aHYhXaEbgemy6oVE68qLkEHTzRuAB1rjwMVGCb2uQrm0eYcJkFFbOT1MWVKWqTNrOyW0cW\n vV7CqFYFHyFNMMSr6mCnnLOEJiJBXUq4FzY9zOOB/Lq6LpHsq1oKOzx2hsvgdPeWBZlX9I\n oKQryJhOSTNAuSKOmrrh7Dw7Th+Y9zA=","X-MC-Unique":"-twITu6xM_6Wwcix_y2Piw-1","X-Mimecast-MFC-AGG-ID":"-twITu6xM_6Wwcix_y2Piw_1777037035","To":"dev@openvswitch.org","Date":"Fri, 24 Apr 2026 15:23:41 +0200","Message-ID":"<20260424132342.3486635-7-amusil@redhat.com>","In-Reply-To":"<20260424132342.3486635-1-amusil@redhat.com>","References":"<20260424132342.3486635-1-amusil@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"dylqO5VCGjevd5e7hjLj3hHwKTjEfQ572KBZEMrpck4_1777037035","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [PATCH ovn 6/7] controller: Make sure that EVPN datapaths\n are kept across runs.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Ales Musil via dev ","Reply-To":"Ales Musil ","Cc":"dceara@redhat.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"There was an issue with using the EVPN datapaths in a different node\nas the data would be cleared before every engine run. Make sure they\nstay until the next proper run of the node.\n\nFixes: f15bfbe3545a (\"evpn-binding: Improve the evpn_datapath structure and optimize lookups.\")\nSigned-off-by: Ales Musil \n---\n controller/evpn-binding.c | 4 +++-\n controller/evpn-binding.h | 1 -\n controller/ovn-controller.c | 1 -\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/controller/evpn-binding.c b/controller/evpn-binding.c\nindex b176706c3..4da8020e1 100644\n--- a/controller/evpn-binding.c\n+++ b/controller/evpn-binding.c\n@@ -32,6 +32,7 @@ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);\n \n static void collect_evpn_datapaths(const struct hmap *local_datapaths,\n struct hmap *evpn_datapaths);\n+static void evpn_datapaths_clear(struct hmap *evpn_datapaths);\n \n struct evpn_tunnel {\n uint16_t dst_port;\n@@ -62,6 +63,7 @@ evpn_binding_run(const struct evpn_binding_ctx_in *b_ctx_in,\n struct hmapx stale_mc_groups = HMAPX_INITIALIZER(&stale_mc_groups);\n uint32_t hint = OVN_MIN_EVPN_KEY;\n \n+ evpn_datapaths_clear(b_ctx_out->datapaths);\n collect_evpn_datapaths(b_ctx_in->local_datapaths, b_ctx_out->datapaths);\n \n struct evpn_binding *binding;\n@@ -233,7 +235,7 @@ evpn_datapath_find(const struct hmap *evpn_datapaths, uint32_t vni)\n return NULL;\n }\n \n-void\n+static void\n evpn_datapaths_clear(struct hmap *evpn_datapaths)\n {\n struct evpn_datapath *edp;\ndiff --git a/controller/evpn-binding.h b/controller/evpn-binding.h\nindex 29b85fc16..521db9d6e 100644\n--- a/controller/evpn-binding.h\n+++ b/controller/evpn-binding.h\n@@ -93,7 +93,6 @@ void evpn_vtep_binding_list(struct unixctl_conn *conn, int argc,\n const char *argv[], void *data_);\n const struct evpn_datapath *evpn_datapath_find(\n const struct hmap *evpn_datapaths, uint32_t vni);\n-void evpn_datapaths_clear(struct hmap *evpn_datapaths);\n void evpn_datapaths_destroy(struct hmap *evpn_datapaths);\n void evpn_multicast_groups_destroy(struct hmap *multicast_groups);\n void evpn_multicast_group_list(struct unixctl_conn *conn, int argc,\ndiff --git a/controller/ovn-controller.c b/controller/ovn-controller.c\nindex de6975f98..6f7578582 100644\n--- a/controller/ovn-controller.c\n+++ b/controller/ovn-controller.c\n@@ -6550,7 +6550,6 @@ en_evpn_vtep_binding_clear_tracked_data(void *data_)\n struct ed_type_evpn_vtep_binding *data = data_;\n hmapx_clear(&data->updated_bindings);\n uuidset_clear(&data->removed_bindings);\n- evpn_datapaths_clear(&data->datapaths);\n hmapx_clear(&data->updated_multicast_groups);\n uuidset_clear(&data->removed_multicast_groups);\n }\n","prefixes":["ovs-dev","6/7"]}