{"id":2227814,"url":"http://patchwork.ozlabs.org/api/patches/2227814/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/3418418.1777024571@warthog.procyon.org.uk/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<3418418.1777024571@warthog.procyon.org.uk>","list_archive_url":null,"date":"2026-04-24T09:56:11","name":"smb: client: Fix error cleanup in smb_extract_iter_to_rdma()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a457b37e23424a0edff5d479cae9818f4b87b4bd","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/3418418.1777024571@warthog.procyon.org.uk/mbox/","series":[{"id":501333,"url":"http://patchwork.ozlabs.org/api/series/501333/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501333","date":"2026-04-24T09:56:11","name":"smb: client: Fix error cleanup in smb_extract_iter_to_rdma()","version":1,"mbox":"http://patchwork.ozlabs.org/series/501333/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227814/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227814/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Y4BXNqlq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11078-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"Y4BXNqlq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g27fF4Ytfz1xvV\n\tfor ; Fri, 24 Apr 2026 19:56:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 9951130156FC\n\tfor ; Fri, 24 Apr 2026 09:56:22 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6551D35A95A;\n\tFri, 24 Apr 2026 09:56:22 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F1627359A91\n\tfor ; Fri, 24 Apr 2026 09:56:20 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-wbknyXtUNnC4Ju8FXtvWGQ-1; Fri,\n 24 Apr 2026 05:56:16 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 1C49219540D1;\n\tFri, 24 Apr 2026 09:56:15 +0000 (UTC)","from warthog.procyon.org.uk (unknown [10.44.48.17])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 606561944CED;\n\tFri, 24 Apr 2026 09:56:12 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777024582; cv=none;\n b=Vje95XADGIFIwYls/M9a86VpEPmi65OpzoeuPaMjj6k++oVUIB7NGujgbUYHWK2WSpFRRYO0m7E/VJH5MPmikJ/xQCuDSbtixBteow3k7BjB2cA+dfWe93Y5aPz+5rhEJzEsyfktyIxIMd/Y3TMSA9Ig1/49LSJPbsQb+5K2yeg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777024582; c=relaxed/simple;\n\tbh=vDVy4HSCuAzyuVuqYNYZG/345V3jt15pH76kXLi/aj8=;\n\th=From:To:cc:Subject:MIME-Version:Content-Type:Date:Message-ID;\n b=GzibML7Wir6L79FIeRDgcAg+wdOeYqfROzDi5QLaVEwatXYAimKY0LUZdnNZzH8cZ+dddy5//jCfOW1PdTcFT9tiEskqb1JAliRrvxMs5akMKRSZXleD4i9hJCziEU4EB7bAggxxvYAhB8iVM0ghFwM381V1leHTPlTChRaDwS4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=Y4BXNqlq; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777024580;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding;\n\tbh=6oe4iP+qDM4VqrJwNPRfPMrmTeINxzNdTw84PQgwZL8=;\n\tb=Y4BXNqlqnXhR+6OZMlwe9eUK2qQPAtmXJ8okEaba8OF9MgZZcEfi3cFu2uIR+ZyKisSGkJ\n\txTGWfBjAMBXOC/tIJvogKrDiqcR2FNI9In7bqrMRhSSF3xAr/+JKUG0BUpv+krBwSPTZrL\n\tvPsauTxnhbCVc45dWK6+NaRzY4Z3+DA=","X-MC-Unique":"wbknyXtUNnC4Ju8FXtvWGQ-1","X-Mimecast-MFC-AGG-ID":"wbknyXtUNnC4Ju8FXtvWGQ_1777024575","Organization":"Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley\n\tPlace, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United\n\tKingdom.\n\tRegistered in England and Wales under Company Registration No. 3798903","From":"David Howells ","To":"Steve French ,\n Stefan Metzmacher ","cc":"dhowells@redhat.com, Paulo Alcantara ,\n Tom Talpey , linux-cifs@vger.kernel.org,\n linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,\n stable@vger.kernel.org","Subject":"[PATCH] smb: client: Fix error cleanup in smb_extract_iter_to_rdma()","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-ID":"<3418417.1777024571.1@warthog.procyon.org.uk>","Content-Transfer-Encoding":"quoted-printable","Date":"Fri, 24 Apr 2026 10:56:11 +0100","Message-ID":"<3418418.1777024571@warthog.procyon.org.uk>","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17"},"content":"Fix smb_extract_iter_to_rdma() to use pre-decrement, not post-decrement, so\nthat it cleans up the correct slots.\n\nFixes: e5fbdde43017 (\"cifs: Add a function to build an RDMA SGE list from an iterator\")\nCloses: https://sashiko.dev/#/patchset/20260326104544.509518-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Steve French \ncc: Stefan Metzmacher \ncc: Paulo Alcantara \ncc: Tom Talpey \ncc: linux-cifs@vger.kernel.org\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/smb/client/smbdirect.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c\nindex 7d5f66bdbb30..4978755c035c 100644\n--- a/fs/smb/client/smbdirect.c\n+++ b/fs/smb/client/smbdirect.c\n@@ -3394,7 +3394,7 @@ static ssize_t smb_extract_iter_to_rdma(struct iov_iter *iter, size_t len,\n \n \tif (ret < 0) {\n \t\twhile (rdma->nr_sge > before) {\n-\t\t\tstruct ib_sge *sge = &rdma->sge[rdma->nr_sge--];\n+\t\t\tstruct ib_sge *sge = &rdma->sge[--rdma->nr_sge];\n \n \t\t\tib_dma_unmap_single(rdma->device, sge->addr, sge->length,\n \t\t\t\t\t rdma->direction);\n","prefixes":[]}