{"id":2227807,"url":"http://patchwork.ozlabs.org/api/patches/2227807/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260424093919.500059-5-pvorel@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424093919.500059-5-pvorel@suse.cz>","list_archive_url":null,"date":"2026-04-24T09:39:19","name":"[4/4] checkpatch: Enable more checks, disable ENOSYS","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"342923f70ed3f446cda7d3118a470e585c85fb83","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/?format=json","name":"Petr Vorel","email":"pvorel@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260424093919.500059-5-pvorel@suse.cz/mbox/","series":[{"id":501330,"url":"http://patchwork.ozlabs.org/api/series/501330/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=501330","date":"2026-04-24T09:39:16","name":"checkpatch: Add .checkpatch.conf","version":1,"mbox":"http://patchwork.ozlabs.org/series/501330/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227807/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2227807/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=f+Zko5W2;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=1FXfn+AF;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=chbH1jWs;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=y3HfNIL9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=chbH1jWs;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=y3HfNIL9"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g27Hv52ZDz1xvV\n\tfor ; Fri, 24 Apr 2026 19:40:59 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 887753E2D75\n\tfor ; Fri, 24 Apr 2026 11:40:57 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D61D23E5349\n for ; Fri, 24 Apr 2026 11:39:47 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 58C1360062B\n for ; Fri, 24 Apr 2026 11:39:47 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 6F3AB5BD89;\n Fri, 24 Apr 2026 09:39:31 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 523FC593A5;\n Fri, 24 Apr 2026 09:39:31 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id IOkMElM662l0TQAAD6G6ig\n (envelope-from ); Fri, 24 Apr 2026 09:39:31 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777023572;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=L+hHt9yU3Wo5cjgrjeRucN82T2bI9K4EDpS5K/V0oDU=;\n b=f+Zko5W2pgkznRrEuVdyTLXVy+HFt1CoTlCDE2l1m/uM6Sj60xu/TLBgwHIojy7Ix87C9n\n JvPWxzdLZfujCaYAQdkfSKpGgtD/OZQwc/ysEvlBfSe10rChL/XNY9/uXcQXEYkeImPr68\n RsiJyNAHA51pWui+dhwdDwTHpqg0bfs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777023572;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=L+hHt9yU3Wo5cjgrjeRucN82T2bI9K4EDpS5K/V0oDU=;\n b=1FXfn+AFcKuXaA7HT/Bpk+M6oBT+lEvtwO0hPTRbRy2pn2D8zIkiLpt4weBKy3HQAU+Zyp\n 320vdd94bJyRyKCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777023571;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=L+hHt9yU3Wo5cjgrjeRucN82T2bI9K4EDpS5K/V0oDU=;\n b=chbH1jWswVpwx23Q1mCgGqKfb2FcFnKIk0yv8QlZsPBfgQPiEyMNdX5fvEIdegTIujO/vU\n P8TfbRqg3nsTeSZKc34rDH4Yqv1siyb4pYhyjIZLHOie3X8Ib3sgLkNqgIKM0zUjtSEd6v\n gXvIB3m6LMOIef13HB8VHVE5g1e5FJs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777023571;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=L+hHt9yU3Wo5cjgrjeRucN82T2bI9K4EDpS5K/V0oDU=;\n b=y3HfNIL9KoEy1gIDY5T234bErHn5nmT2rkQQ6xOJkBtybbg1VCb7scTUlNwtkLt+ECk9lT\n ZFQjhbT6QhUg08Dg=="],"From":"Petr Vorel ","To":"ltp@lists.linux.it","Date":"Fri, 24 Apr 2026 11:39:19 +0200","Message-ID":"<20260424093919.500059-5-pvorel@suse.cz>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260424093919.500059-1-pvorel@suse.cz>","References":"<20260424093919.500059-1-pvorel@suse.cz>","MIME-Version":"1.0","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_TLS_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:mid,suse.cz:dkim,suse.cz:email];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.cz:+]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.01","X-Spam-Level":"","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"6F3AB5BD89","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH 4/4] checkpatch: Enable more checks, disable ENOSYS","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"Use --spdx-cxx-comments (new feature from previous commit) to avoid\nfalse positive errors:\n tst_safe_clocks.h:1: WARNING: Improper SPDX comment style for 'tst_safe_clocks.h', please use '/*' instead\n tst_safe_clocks.h:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1\n\nDisable checks (via --ignore) to avoid false positive errors:\n* ENOSYS\n fallocate01.c:230: WARNING: ENOSYS means 'invalid syscall nr' and nothing else\n\nAdd new checks:\n* CONCATENATED_STRING\n lib/tst_test.c:200: CHECK: Concatenated strings should use spaces between elements\n\n* PARENTHESIS_ALIGNMENT\n lib/tst_kconfig.c:180: CHECK: Alignment should match open parenthesis\n\n* SPACING (https://www.kernel.org/doc/html/latest/process/coding-style.html#spaces)\n lib/tst_kconfig.c:383: CHECK: spaces preferred around that '-' (ctx:VxV)\n lib/tst_test.c:1900: CHECK: spaces preferred around that '/' (ctx:VxV)\n tst_minmax.h:15: CHECK: No space is necessary after a cast\n\n* SPLIT_STRING\n lib/tst_test.c:1951: WARNING: quoted string split across lines\n\n* UNNECESSARY_PARENTHESES\n lib/tst_test.c:802: CHECK: Unnecessary parentheses around toptions[i].arg\n\nSigned-off-by: Petr Vorel \n---\n .checkpatch.conf | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/.checkpatch.conf b/.checkpatch.conf\nindex 20b92aaca9..41b2a6ee18 100644\n--- a/.checkpatch.conf\n+++ b/.checkpatch.conf\n@@ -3,6 +3,9 @@\n \n -f --terse --no-summary\n \n+# allow // in headers\n+--spdx-cxx-comments\n+\n # enable more tests\n --strict\n \n@@ -10,4 +13,7 @@\n --ignore PREFER_KERNEL_TYPES,STRCPY,STRLCPY,STRNCPY\n \n # TODO: document reason\n---ignore CONST_STRUCT,VOLATILE,SPLIT_STRING,FILE_PATH_CHANGES,LONG_LINE,MACRO_ARG_REUSE,SPACING,MULTIPLE_ASSIGNMENTS,UNNECESSARY_PARENTHESES,PARENTHESIS_ALIGNMENT,CONCATENATED_STRING\n+--ignore CONST_STRUCT,VOLATILE,FILE_PATH_CHANGES,PREFER_KERNEL_TYPES,LONG_LINE,MACRO_ARG_REUSE,MULTIPLE_ASSIGNMENTS\n+\n+# ENOSYS is used in test error macros\n+--ignore ENOSYS\n","prefixes":["4/4"]}