{"id":2227656,"url":"http://patchwork.ozlabs.org/api/patches/2227656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424042946.3875690-2-frank.chang@sifive.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424042946.3875690-2-frank.chang@sifive.com>","list_archive_url":null,"date":"2026-04-24T04:29:45","name":"[v3,1/2] target/riscv: Add the implied rule for G extension","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1ff1acc7a94870c75d5004582f57dca63fc2cbb4","submitter":{"id":79604,"url":"http://patchwork.ozlabs.org/api/people/79604/?format=json","name":"Frank Chang","email":"frank.chang@sifive.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424042946.3875690-2-frank.chang@sifive.com/mbox/","series":[{"id":501299,"url":"http://patchwork.ozlabs.org/api/series/501299/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501299","date":"2026-04-24T04:29:44","name":"Add the implied rules for G and B extensions","version":3,"mbox":"http://patchwork.ozlabs.org/series/501299/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227656/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227656/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256\n header.s=google header.b=dxbB762t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g20Pr1dLMz1yDD\n\tfor ; Fri, 24 Apr 2026 14:30:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wG8Ay-0005Oa-Us; Fri, 24 Apr 2026 00:30:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG8Aw-0005Nm-WC\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 00:29:59 -0400","from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wG8Au-00028D-Qn\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 00:29:58 -0400","by mail-pf1-x42d.google.com with SMTP id\n d2e1a72fcca58-82f69adeecbso3127410b3a.2\n for ; Thu, 23 Apr 2026 21:29:56 -0700 (PDT)","from hsinchu16.internal.sifive.com ([210.176.154.34])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f8ebe92desm21712867b3a.44.2026.04.23.21.29.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 21:29:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=sifive.com; s=google; t=1777004995; x=1777609795; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Iqc7VTbeyjOi8/9VHDPDSeLdUciW2u+roO8j+QjxNso=;\n b=dxbB762t4j0udnGQ7lxFV1afKiO6rhywVks+CkwK+Q1/vTVbrz5/2b/UBsePyoCaIr\n dIs25D8nWy5dHV/KG+TCHd8bGLmw2I1oEpuJlmOFxH/JEc4KUQT/IbRwdFbjc/vzRlAb\n s9oZU8QZgmTXU2upMMHSvW6XvLNH/SGC3V8f+kzYwlVUMnwq5n4DnaSQIxfLWDbk8/Nj\n a9cBSFNA+aBR4x/PNdQc1m9ws2/l/LbIB0ZmIrXy54+oGhv9/8GHcaPFBwpWvMgda/P0\n F0X0rqj8wsoNdpP5xF85v3ReFj3kk3dR23jCL7kR3oNqx7TvpPneLqup3BOzidyaYlS4\n B+IQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777004995; x=1777609795;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Iqc7VTbeyjOi8/9VHDPDSeLdUciW2u+roO8j+QjxNso=;\n b=fXZKttxlLgV5dkPkIUV/EKWI0wKKwuJBAKghLq3W5PpaP/QQpIPvskWL72GPVf/7Ho\n mOB1Lzd902/h9hmsr9o2Iu+sRIcnXNBMcAeOo1tkbuPdHfjKKOq3Fjl4/8EyjixPQJks\n 54+/TmoYA9XwPrfiip4OynbrA2hIuuRm8SXj5pc4UKbntyeaRcYmVtYEe+YMsnjuCagP\n vYlUHXvrW/J06oP0v7DvMC22+IyIkDG7UPWJpaN0ZE0XgepyteCW5MsiI2gO+5frbrWw\n iauvgkB5Mla2kiri6Dh9QQWHr4H5Kz56N3wxQO9xu308ceuFNEdWAAJx9Mebu0YeV5hh\n wRxg==","X-Gm-Message-State":"AOJu0YzTh/e5wYZ2pWa57jhTfnNH7+AfglPCO97GLkIPPCWgkldCfLkD\n gSAY2je4bbJn9fXZQOlWc9/AjSNJNfL5A5ovB64BlCzdevuvdpEtlX7hYxBGD5ghXM8QANj6oAJ\n 18SgM3H0+qL+Suii4bOPFGnOWsUgKVuwZOrLStPUU5kbsu7WGSl7HAVM+L0DooEJFreAtObnbvZ\n g2LyU4DK049SiLRl9YHBtGfB6dt1svS/CbZMaL8K0FlMZ+JZnQ","X-Gm-Gg":"AeBDietPUud4YBTmkvnuiNSVZVbCNIaTOHEUNiCE7u9dt4cFETEaF982h5PY897r6J6\n 3lCivFOBj1iwg4WfNVJV0JXayDj1am52shuvDyJRrQ1c2YGoDhUj+EH0plNvMahCE2S1dRRIAdl\n n8z5eGrYJD+WDXhDQnp5EQb7iNVA+aE/aAtQVqzbzN24f5UUUdBXarUkZwf2MXrSxp7EPE9eAkh\n LbyI7UGJ/31vFZp+1skkYLRcl0o1TSSgTTjRFNF5ShEe1osMiunX9WhTNGedlQTgCY7uu9Xj6Xj\n M1E1h1DbTLLT94rPw9/J4LDfdncScQJiBi0lalBLKSDEXe1PtrUjLJ28vDk7jYUDoTJ0knXrm37\n cKqaKVFD6sw9t6GCvkkFGK/AKnGTM6D25fWrUBmQyMZEEq5YglzK+iJzoU41ebbqzG6TH0OJbec\n hPVRrRze2e/GoyVICAjBILm8CZk4xPXmyQAFCYhUkCKG1n9Y3Z9CW52JQTboZ0","X-Received":"by 2002:a05:6a00:1826:b0:82f:2384:212a with SMTP id\n d2e1a72fcca58-82f8c961ef5mr32139147b3a.26.1777004994884;\n Thu, 23 Apr 2026 21:29:54 -0700 (PDT)","From":"frank.chang@sifive.com","To":"qemu-devel@nongnu.org","Cc":"Palmer Dabbelt ,\n Alistair Francis ,\n Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu ,\n qemu-riscv@nongnu.org (open list:RISC-V TCG CPUs),\n Jim Shu , Frank Chang ","Subject":"[PATCH v3 1/2] target/riscv: Add the implied rule for G extension","Date":"Fri, 24 Apr 2026 12:29:45 +0800","Message-ID":"<20260424042946.3875690-2-frank.chang@sifive.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260424042946.3875690-1-frank.chang@sifive.com>","References":"<20260424042946.3875690-1-frank.chang@sifive.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42d;\n envelope-from=frank.chang@sifive.com; helo=mail-pf1-x42d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Jim Shu \n\nAdd the missing implied rule from G to imafd_zicsr_zifencei.\nWe can also remove the auto-enables in riscv_cpu_validate_g() as\nIMAFD, Zicsr, Zifencei extensions can be enabled by the implied rule.\n\nSigned-off-by: Jim Shu \nReviewed-by: Frank Chang \n---\n target/riscv/cpu.c | 14 +++++++++++++-\n target/riscv/tcg/tcg-cpu.c | 21 ++++-----------------\n 2 files changed, 17 insertions(+), 18 deletions(-)","diff":"diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c\nindex ce15a17c37d..f806d0536a0 100644\n--- a/target/riscv/cpu.c\n+++ b/target/riscv/cpu.c\n@@ -2248,6 +2248,18 @@ static RISCVCPUImpliedExtsRule RVV_IMPLIED = {\n },\n };\n \n+static RISCVCPUImpliedExtsRule RVG_IMPLIED = {\n+ .is_misa = true,\n+ .ext = RVG,\n+ .implied_misa_exts = RVI | RVM | RVA | RVF | RVD,\n+ .implied_multi_exts = {\n+ CPU_CFG_OFFSET(ext_zicsr),\n+ CPU_CFG_OFFSET(ext_zifencei),\n+\n+ RISCV_IMPLIED_EXTS_RULE_END\n+ },\n+};\n+\n static RISCVCPUImpliedExtsRule ZCB_IMPLIED = {\n .ext = CPU_CFG_OFFSET(ext_zcb),\n .implied_multi_exts = {\n@@ -2635,7 +2647,7 @@ static RISCVCPUImpliedExtsRule ZVFBFA_IMPLIED = {\n \n RISCVCPUImpliedExtsRule *riscv_misa_ext_implied_rules[] = {\n &RVA_IMPLIED, &RVD_IMPLIED, &RVF_IMPLIED,\n- &RVM_IMPLIED, &RVV_IMPLIED, NULL\n+ &RVM_IMPLIED, &RVV_IMPLIED, &RVG_IMPLIED, NULL\n };\n \n RISCVCPUImpliedExtsRule *riscv_multi_ext_implied_rules[] = {\ndiff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c\nindex f3f78088956..8247cf1b4c9 100644\n--- a/target/riscv/tcg/tcg-cpu.c\n+++ b/target/riscv/tcg/tcg-cpu.c\n@@ -545,30 +545,17 @@ static void riscv_cpu_validate_g(RISCVCPU *cpu)\n continue;\n }\n \n- if (!cpu_misa_ext_is_user_set(bit)) {\n- riscv_cpu_write_misa_bit(cpu, bit, true);\n- continue;\n- }\n-\n if (send_warn) {\n warn_report(warn_msg, riscv_get_misa_ext_name(bit));\n }\n }\n \n- if (!cpu->cfg.ext_zicsr) {\n- if (!cpu_cfg_ext_is_user_set(CPU_CFG_OFFSET(ext_zicsr))) {\n- cpu->cfg.ext_zicsr = true;\n- } else if (send_warn) {\n- warn_report(warn_msg, \"zicsr\");\n- }\n+ if (!cpu->cfg.ext_zicsr && send_warn) {\n+ warn_report(warn_msg, \"zicsr\");\n }\n \n- if (!cpu->cfg.ext_zifencei) {\n- if (!cpu_cfg_ext_is_user_set(CPU_CFG_OFFSET(ext_zifencei))) {\n- cpu->cfg.ext_zifencei = true;\n- } else if (send_warn) {\n- warn_report(warn_msg, \"zifencei\");\n- }\n+ if (!cpu->cfg.ext_zifencei && send_warn) {\n+ warn_report(warn_msg, \"zifencei\");\n }\n }\n \n","prefixes":["v3","1/2"]}