{"id":2227642,"url":"http://patchwork.ozlabs.org/api/patches/2227642/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260424031545.3777023-1-boolli@google.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424031545.3777023-1-boolli@google.com>","list_archive_url":null,"date":"2026-04-24T03:15:45","name":"[iwl-next] libie: log more info when virtchnl fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0e5fd990d1bb5f29f62213fe332b7127fab59b14","submitter":{"id":92373,"url":"http://patchwork.ozlabs.org/api/people/92373/?format=json","name":"Li Li","email":"boolli@google.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260424031545.3777023-1-boolli@google.com/mbox/","series":[{"id":501293,"url":"http://patchwork.ozlabs.org/api/series/501293/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501293","date":"2026-04-24T03:15:45","name":"[iwl-next] libie: log more info when virtchnl fails","version":1,"mbox":"http://patchwork.ozlabs.org/series/501293/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227642/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227642/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=GHOuximw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1ylq62nYz1yDD\n\tfor ; Fri, 24 Apr 2026 13:16:07 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id AD4DB40B8A;\n\tFri, 24 Apr 2026 03:16:05 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id XKO5kG68lIhv; Fri, 24 Apr 2026 03:16:05 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id DDB7040B70;\n\tFri, 24 Apr 2026 03:16:04 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id CD72D24D\n for ; Fri, 24 Apr 2026 03:16:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id B32AE4076B\n for ; Fri, 24 Apr 2026 03:16:03 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 461YgAp5rAY7 for ;\n Fri, 24 Apr 2026 03:16:03 +0000 (UTC)","from mail-dy1-x134a.google.com (mail-dy1-x134a.google.com\n [IPv6:2607:f8b0:4864:20::134a])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 0B45340594\n for ; Fri, 24 Apr 2026 03:16:02 +0000 (UTC)","by mail-dy1-x134a.google.com with SMTP id\n 5a478bee46e88-2bdf75bc88fso9463654eec.0\n for ; Thu, 23 Apr 2026 20:16:02 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org DDB7040B70","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0B45340594"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777000564;\n\tbh=SbAAeoe+lCfBByxTKPuDEe/gKzpl0DVHWMIRbJcx2qg=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=GHOuximwYIkOTb6QQhqY+yJBFWDg9UpoaFEUKokVyPIKFMpLUpFOeKOioaQLY4Z4O\n\t thyHrsbgOJkIPUnjvsUqaE0fh1q7qTbH/JeUHZRUhT7XXtLeEhjSqRZeEyULUWiH1T\n\t Lh4kUl7O3tttsRPTpXD+MaN+020r3ucXZ1hebKRvZDHLAVRH6KUQ1FrJ6HK3US8lut\n\t X4IEVVw/CKE5YWHsH7+j3DNEo/iLByVIJN1NhyaHcJNOiAMNgeDCLv/xktn5d9NyKB\n\t 2w6hJtxqyQkm5p2nkgASLc6HUaVpnFplXq3nAae1esg1pwLoWQzfobez+i8Tk5I8pN\n\t LLby39wFZrHzA==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::134a; helo=mail-dy1-x134a.google.com;\n envelope-from=3cedqaqykdzqreebbyweewbu.secydjub-myhut-bqdbyiji.eikeib.ehw@flex--boolli.bounces.google.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 0B45340594","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777000562; x=1777605362;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=SbAAeoe+lCfBByxTKPuDEe/gKzpl0DVHWMIRbJcx2qg=;\n b=OMcb5sZKNU1N3tMwZcBh4eqEpu7le5HfinfKI3WpGMfZ+w6QY/p5X5gOtNkCp21jT0\n hy0pA7ppCGyIlG6W1882Z56cpQFzNMKGlmwqFHSM6KRgybtrB8VB1f2jXCgbLUR5x3Kw\n FitxTxhIHh1F9Hs4j92c0CFngoRvW0MUTTxm6EPPtFzuOi8WgcEluBcCKkXaaZR/oK/V\n xuaemgJo8vNLc+g1Fe/t0IYLazQB/c1mptVlWX9dwx1q399zN6AUbuGj1NNldbWO1VVH\n mpdVbcGjK8+blCWdz4Oi6+XioNOkiXX9YetrTqPB8f2nNix1TAO2Vfpy+cHotp2HtHmw\n 479Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9rYwDrzb6evxvkNGw1Z54Q5DFZgYl1zv9eG8Tx1ENulx5zLYT95Y9KybR0RgGytJqEVoKLHRKWvzKCGHXtkmE=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YzxyRvUaodmPqDu5xsvLzSosh/W2v84DMJHcwc4AAcC9UGYkywu\n MGInsTx/TUsZF1g7sZwAbYyZFEZnWf3W0aSSuF7DnK9Si458mAfkbmMpjswsxSCXo14HiaQjQY2\n woooYKQ==","X-Received":"from dycog19.prod.google.com\n ([2002:a05:7301:9a93:b0:2dd:53c4:1b43])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7300:fb94:b0:2c4:61be:1d33\n with SMTP id 5a478bee46e88-2e464eaa230mr15160221eec.6.1777000561536; Thu, 23\n Apr 2026 20:16:01 -0700 (PDT)","Date":"Fri, 24 Apr 2026 03:15:45 +0000","Mime-Version":"1.0","X-Mailer":"git-send-email 2.54.0.rc2.544.gc7ae2d5bb8-goog","Message-ID":"<20260424031545.3777023-1-boolli@google.com>","To":"Tony Nguyen ,\n Przemek Kitszel ,\n \"David S. Miller\" ,\n Jakub Kicinski , Eric Dumazet ,\n intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny ,\n Anjali Singhai ,\n Sridhar Samudrala ,\n Brian Vazquez ,\n Li Li , emil.s.tantilov@intel.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1777000562; x=1777605362; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=SbAAeoe+lCfBByxTKPuDEe/gKzpl0DVHWMIRbJcx2qg=;\n b=HQWMn/4+CKFtL9eOGo/STby/r75C2iKt+loCn0R4B/jp7MnB/2EmLLuqHXxmy4fXLN\n Oin3rX/NSbF5vc0CqMbuREoypU+il8lrLg7BlKNyo0mPuvcqAfKMFUH7RdOjvsL0qzWN\n EUdTz4fvZj3eJML8LFHJaTKw89uHlFpSpDMD2qQM0nIRuFjfOmHWCXRISvgL27VArEkh\n wF7OINBz4/nCbiBqqqjzjHAG08YOErEvfa6xcaQjtwwEq8mKp/F0djCNZyCi1v01BvvN\n V/UFYS0+n5K7u+wkSYEK+P2Ky2XXalDwMR9tnp6PImlXb8lm1WypWgcDHBpQhOb+yf2e\n +gwQ==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=HQWMn/4+"],"Subject":"[Intel-wired-lan] [PATCH iwl-next] libie: log more info when\n virtchnl fails","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Li via Intel-wired-lan ","Reply-To":"Li Li ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Virtchnl failures can be hard to debug without logs. Logging the details\nof virtchnl transactions can be useful for debugging virtchnl-related\nissues.\n\nTested: Built and booted on a test machine.\n\nSigned-off-by: Li Li \n---\n drivers/net/ethernet/intel/libie/controlq.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c\nindex ebc05355e39d..7eaa77413621 100644\n--- a/drivers/net/ethernet/intel/libie/controlq.c\n+++ b/drivers/net/ethernet/intel/libie/controlq.c\n@@ -762,6 +762,16 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params,\n \tstatus = ctlq_msg->chnl_retval ? -EFAULT : 0;\n \n \txn = &xnm->ring[xn_index];\n+\n+\tif (ctlq_msg->chnl_retval) {\n+\t\tdev_err_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Non-zero virtchnl ret val (msg op: %u, ret val: %u, msg_cookie: %u, data_len: %u); xn op: %u, id: %u, cookie: %u\\n\",\n+\t\t\tctlq_msg->chnl_opcode, ctlq_msg->chnl_retval,\n+\t\t\tmsg_cookie, ctlq_msg->data_len, xn->virtchnl_opcode,\n+\t\t\txn->index, xn->cookie);\n+\t}\n+\n \tif (ctlq_msg->chnl_opcode != xn->virtchnl_opcode ||\n \t msg_cookie != xn->cookie)\n \t\treturn false;\n@@ -1011,6 +1021,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params)\n \t\tparams->recv_mem = xn->recv_mem;\n \t\tbreak;\n \tdefault:\n+\t\tdev_notice_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Transaction failed (op %u, xn state: %d, id: %u, cookie: %u, size: %zu)\\n\",\n+\t\t\tparams->chnl_opcode, xn->state, xn->index, xn->cookie,\n+\t\t\txn->recv_mem.iov_len);\n \t\tret = -EBADMSG;\n \t\tbreak;\n \t}\n","prefixes":["iwl-next"]}