{"id":2227633,"url":"http://patchwork.ozlabs.org/api/patches/2227633/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260424030345.1140665-1-aaron.ma@canonical.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424030345.1140665-1-aaron.ma@canonical.com>","list_archive_url":null,"date":"2026-04-24T03:03:45","name":"[v2] ice: wait for reset completion in ice_resume()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d26dbea0d874f71ac31b54cf1904775e9612b3d2","submitter":{"id":72035,"url":"http://patchwork.ozlabs.org/api/people/72035/?format=json","name":"Aaron Ma","email":"aaron.ma@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260424030345.1140665-1-aaron.ma@canonical.com/mbox/","series":[{"id":501289,"url":"http://patchwork.ozlabs.org/api/series/501289/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501289","date":"2026-04-24T03:03:45","name":"[v2] ice: wait for reset completion in ice_resume()","version":2,"mbox":"http://patchwork.ozlabs.org/series/501289/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227633/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227633/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=gqn7daAB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1yVF1JjJz1yDD\n\tfor ; Fri, 24 Apr 2026 13:04:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 775AA612C0;\n\tFri, 24 Apr 2026 03:04:16 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id z0AMxwdiZ2dl; Fri, 24 Apr 2026 03:04:15 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id F3DE4612BF;\n\tFri, 24 Apr 2026 03:04:14 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id B8BAB24D\n for ; Fri, 24 Apr 2026 03:04:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id AA2FB612BF\n for ; Fri, 24 Apr 2026 03:04:13 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id u1GOKvlnqeJq for ;\n Fri, 24 Apr 2026 03:04:13 +0000 (UTC)","from smtp-relay-internal-1.canonical.com\n (smtp-relay-internal-1.canonical.com [185.125.188.123])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E68FA61149\n for ; Fri, 24 Apr 2026 03:04:12 +0000 (UTC)","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 79D393F9CF\n for ; Fri, 24 Apr 2026 03:04:09 +0000 (UTC)","by mail-pl1-f197.google.com with SMTP id\n d9443c01a7336-2b241be0126so144373525ad.3\n for ; Thu, 23 Apr 2026 20:04:09 -0700 (PDT)","from localhost.localdomain ([103.155.100.1])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab0caa9sm206428625ad.40.2026.04.23.20.04.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 20:04:07 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org F3DE4612BF","OpenDKIM Filter v2.11.0 smtp3.osuosl.org E68FA61149"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776999855;\n\tbh=fE6/Ks26kVTyFQ0eNTbStdq7kzWJK58GKRv4GCZ9rSE=;\n\th=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=gqn7daABuuNRpRFn58B60NgOLtDkRl3ejVGMjKyjf/aPMUkbGvCq7fDSgRtn1voKU\n\t 7T9NoqXAGQBqS4eIxgJJ6aX/nCsyl3BZuajfhPIvMqcCSI2wGzqVrp7R/aOhZMKoM9\n\t JrWqBpy2GLtl8zX60qT35MkH97Rm/gDOUznYHLdWodZkI2GB0FpDQjxZ2GaI+ut+fM\n\t SqM5qPV10jq8WbiZFnsXm2PIhAFMLZeL+k3+WcHr+vy0qx6rk3dbtVJl2WykRdiCfv\n\t K3hUoxu5gyPzBJsBOOiF0v1HmOJNFmshFB5ArSrYEVizQd/8sBynaiSMTWjex1YTvH\n\t sQB4EBa9mxksg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.123;\n helo=smtp-relay-internal-1.canonical.com;\n envelope-from=aaron.ma@canonical.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org E68FA61149","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776999848; x=1777604648;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fE6/Ks26kVTyFQ0eNTbStdq7kzWJK58GKRv4GCZ9rSE=;\n b=MNrEPANCAZ1shpGbN3SwfaTeYpXmWg+OOtS/03aCuDD4XeoEw5RlonUhR8fz8FJVQL\n hhL7mz7s4vv5pi82LTdyKlpn5u4wAK61oUZqWStvXELJdemc6O2NVmOp5XjA8M8pr+sd\n YEBXX9SAmExyQ4KLlG/CpQrj+fmNkNschOJE1mEFddaVWRnwrG1JpZ+j83zwp3SWUlve\n Uky2ozl3KvfiWN5oO/BNHFFDugDbgviDnll/ERmlcWSaVzyaXvIMNd3i+ZaWMksD3yRR\n ZkN7ES7td13LkFTy9IyEhktx4+jPynEyVfN/zo1S0BXEDgY8JRQwT8l4KqyDWOYQjOAi\n wtxg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/UWDKB9sb2VygYIIFVxWJcqhPn8T0GFwSGESj8ubbMMeNvVQFqZN9WRTShERIgKcUu0n5YR3j3MEgzcMM8rC4=@lists.osuosl.org","X-Gm-Message-State":"AOJu0Yxl8oPEfU5QrfnwMcpvQTcfgFvo4vLduToRsASVTkoKaw1vPUf6\n EPyqaWgCZpz3PlujWSkbvMCp4il1bhw0jifEirHFLBV3g/xqyy53OsaVKc8sgNdqBFq9w1abZgr\n WanAXRWc6NLCeiOviQTfFmdyflZ/4T8n1INjYrjbGx6Q3xxU/SmrAK2Uy727v5rtH08S7kbXmBJ\n 8SVXVnAZhNEmc=","X-Gm-Gg":"AeBDietNdHV/zRGsvXJDMRgLZy+oN24YQXo+7NdURtuMWQK3eZgd0N4vxz5oh6KROgG\n TkBoMW2Y52X3dzds+lKbQZTONg7aJ1GBeFcxKM3pyA7cFlDZHqlNNJrx3hzJbuJx80mXHGFKOxS\n JTNiv83jluVfE3SS9zfCzTldnynjTNNf1JONrFfSN8sngQGr8koNEpMKFmacjOtTfMUVesJmiKZ\n 9D1G7tfYV3wsgbpI/f/EH8jaWeN1kz1/aSGlQDgXtQCZx7GVFdAYnj7+1gg5bzp0JWu6O6nazI3\n C0wajU5L2erMOfDVSwxEgEes850ATCSe3Sm7I2mXp0GLk2ntoTVKAEiyBElPD/swIZWTzyijao+\n 8evWOV1GvyeWAwqk1uKVM7/B2YEKvOJoZpJXtyVjhY9SnBBR2","X-Received":["by 2002:a17:902:ffce:b0:2b7:ade8:2407 with SMTP id\n d9443c01a7336-2b7ade826f8mr55540105ad.19.1776999848123;\n Thu, 23 Apr 2026 20:04:08 -0700 (PDT)","by 2002:a17:902:ffce:b0:2b7:ade8:2407 with SMTP id\n d9443c01a7336-2b7ade826f8mr55539845ad.19.1776999847810;\n Thu, 23 Apr 2026 20:04:07 -0700 (PDT)"],"To":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org","Cc":"Akeem G Abodunrin ,\n Jesse Brandeburg ,\n intel-wired-lan@lists.osuosl.org, Kohei Enju ","Date":"Fri, 24 Apr 2026 11:03:45 +0800","Message-ID":"<20260424030345.1140665-1-aaron.ma@canonical.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=canonical.com; s=20251003; t=1776999849;\n bh=fE6/Ks26kVTyFQ0eNTbStdq7kzWJK58GKRv4GCZ9rSE=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=eFBn2lKVreUFfWrnDbTwASagI0zYxXvEMBpF8AxQlaJDNqdlP+rsv+SFZxj7YV2qd\n INlS3eI0SmTGc+jEiOc119bfWdVY75w/T3vzW4zk2UY2zmRoSVD1zbXpPq6R0GYbAS\n toncHdfHEpo9F+kZwJvNucOe3uTpOgDuSG9N98Y/dSY3AhKgUb7eHzhw2pnCzTifbB\n nE2phv8ey3gfrpbD8HPvPL5c5fx0MfKGJFkJXygqkUOgnQjvsAUz1KnjazX3zf5YKi\n TuGt8FmFnNka7mbOaxgyqbl0yj1s9ZhIoZDlKCusppacNLC0qF2Cs08mLiIA8czdsr\n Nlyu1SanV1MPAkRtW5tNiW8ioNszq5DsPL7y9F2wEN/mQ1P4jwOTREsc+VtTQBg3+/\n NN8v6eT8dJnBDVe9+bcB9w4qSdLLTU00KxJjR6gGQ+sHnnfecgW9t7YtMMYzJm/Hur\n IpYG3LHizyd7KgRyTj8fxwm62Qcb9jmMHnwO6OYCLVdpPMdoDbjwOv+HbSY4xkD7la\n gaddGyugrtVDk8AeKdUWLRR9MaiRXVtXqMjRHlGtMXECmSBV5CW+1Ufu6Lck0s/Esj\n /f3X5Jj6ymbQQoZz4cI+pl+6nivpQ0jehqNsaLGH1L1Ay50EvRRVi6VFk2DtWDGi+w\n NysMQ3q6HDnXiKxQkFaOH3YM=","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=canonical.com","smtp3.osuosl.org;\n dkim=pass (4096-bit key,\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=eFBn2lKV"],"Subject":"[Intel-wired-lan] [PATCH v2] ice: wait for reset completion in\n ice_resume()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Aaron Ma via Intel-wired-lan ","Reply-To":"Aaron Ma ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"ice_resume() schedules an asynchronous PF reset and returns\nimmediately. The reset runs later in ice_service_task(). If\nuserspace tries to bring up the net device before the reset\nfinishes, ice_open() fails with -EBUSY:\n\n ice_resume()\n ice_schedule_reset() # sets ICE_PFR_REQ, returns\n ...\n ice_open()\n ice_is_reset_in_progress() # ICE_PFR_REQ still set, -EBUSY\n ...\n ice_service_task()\n ice_do_reset()\n ice_rebuild() # clears ICE_PFR_REQ, too late\n\nReproduced on E800 series NICs during suspend/resume with irdma\nenabled, where the aux device probe widens the race window.\n\nWait for the reset to complete before returning from ice_resume().\n\nFixes: 769c500dcc1e (\"ice: Add advanced power mgmt for WoL\")\nCc: stable@vger.kernel.org\nSigned-off-by: Aaron Ma \n---\nv2: reword comment to clarify best-effort semantics (Kohei Enju)\n\n drivers/net/ethernet/intel/ice/ice_main.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 5f92377d4dfc2..a81eb21ea87c1 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -5635,6 +5635,15 @@ static int ice_resume(struct device *dev)\n \t/* Restart the service task */\n \tmod_timer(&pf->serv_tmr, round_jiffies(jiffies + pf->serv_tmr_period));\n \n+\t/* Best-effort wait for the scheduled reset to finish so that the\n+\t * device is operational before returning. Without this, userspace\n+\t * (e.g. NetworkManager) may try to open the net device while the\n+\t * asynchronous reset is still in progress, hitting -EBUSY.\n+\t */\n+\tret = ice_wait_for_reset(pf, 10 * HZ);\n+\tif (ret)\n+\t\tdev_err(dev, \"Wait for reset failed during resume: %d\\n\", ret);\n+\n \treturn 0;\n }\n \n","prefixes":["v2"]}