{"id":2227628,"url":"http://patchwork.ozlabs.org/api/patches/2227628/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260424025547.3806072-6-songmuchun@bytedance.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260424025547.3806072-6-songmuchun@bytedance.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260424025547.3806072-6-songmuchun@bytedance.com/","date":"2026-04-24T02:55:45","name":"[v6,5/7] mm/mm_init: Fix pageblock migratetype for ZONE_DEVICE compound pages","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b6e308e63fb4e7c6d4568c035db57fd62573b213","submitter":{"id":78930,"url":"http://patchwork.ozlabs.org/api/people/78930/?format=json","name":"Muchun Song","email":"songmuchun@bytedance.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260424025547.3806072-6-songmuchun@bytedance.com/mbox/","series":[{"id":501285,"url":"http://patchwork.ozlabs.org/api/series/501285/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501285","date":"2026-04-24T02:55:40","name":"mm: fix vmemmap optimization accounting and initialization","version":6,"mbox":"http://patchwork.ozlabs.org/series/501285/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227628/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227628/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bytedance.com header.i=@bytedance.com\n header.a=rsa-sha256 header.s=google header.b=UAC1THZl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20031-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::62b\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=bytedance.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bytedance.com header.i=@bytedance.com\n header.a=rsa-sha256 header.s=google header.b=UAC1THZl;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=bytedance.com\n (client-ip=2607:f8b0:4864:20::62b; helo=mail-pl1-x62b.google.com;\n envelope-from=songmuchun@bytedance.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1yKN3BTMz1xvV\n\tfor ; Fri, 24 Apr 2026 12:56:40 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g1yK504Y5z2ySc;\n\tFri, 24 Apr 2026 12:56:25 +1000 (AEST)","from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n [IPv6:2607:f8b0:4864:20::62b])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g1yK40s71z2xls\n\tfor ; Fri, 24 Apr 2026 12:56:24 +1000 (AEST)","by mail-pl1-x62b.google.com with SMTP id\n d9443c01a7336-2b2429f98d0so43400045ad.2\n for ;\n Thu, 23 Apr 2026 19:56:24 -0700 (PDT)","from n232-176-004.byted.org ([36.110.163.102])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab20d33sm221668325ad.63.2026.04.23.19.56.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 19:56:21 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776999384;\n\tcv=none;\n b=Iz4b0bbi0gcou2Sdy5px1v73rs2AOdcc3/Mqua6znG1niW6QGfR7/c0GVUkQTY+ix6EDA08nsxq1ueTlsmTNukJEmz6esqw1kLwLY8JMYjiZH55025F1FSAYGySv/OHPfECW9AmpwvDqPLC1V1ZO3bE9mQ+U52GXjKhBcv75MhaqDqZTgZT+UuaAFxBx6WEq1S/7Yyxa7fj4RS+K0NkqPrLW2njtlWMzpghi4t9t/OjvdpTB/Knzt8JdIvncfAlLBgnCrtP3qrSGo6W4YiT6cxM/wOfeH7ojKtOc0IqJxB6qssHV1/Df8jmmfY2p7F8goU4YTUEb+EgftoBuR41+pg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776999384; c=relaxed/relaxed;\n\tbh=X8jAPi1Ug7YtuxDodtBim0VZYTDek6DS5vd5ro+n0/g=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=MT4ieh7bkIVeS0gfI4siroL1w1Zn5fxc09ufwMAM4ajvY9J5VLZ7bDFLmoWxZKSeKMF8ufmJDXAwIm/WLzRH1gfMKQ0ChvDdt2nvhbR8k+PlM3LlNCy2skKnTFkSMWfAUHiKzEkYJf2eGzaFQwggiKzo6HoYbbvh68L+GjCy4sz3Hw1bmXcJlFeDvKN0MaF61c12qFIkKlXJqZaPOMb/8QiGjYUqB6417OkqqNuqA/7jpxEvvTdJ8QiRFCKYyPvA64kpkzGEsmCtvdIPTeYHuUz6u5oMm+5BsuJZ3edBTKo3isqMug0RfuWm8aS73M+71PZFevnb6xI6cfhDo0kyTg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=bytedance.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=bytedance.com header.i=@bytedance.com\n header.a=rsa-sha256 header.s=google header.b=UAC1THZl; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::62b; helo=mail-pl1-x62b.google.com;\n envelope-from=songmuchun@bytedance.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=bytedance.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance.com; s=google; t=1776999382; x=1777604182;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=X8jAPi1Ug7YtuxDodtBim0VZYTDek6DS5vd5ro+n0/g=;\n b=UAC1THZli0W4+AQiKsDNGi7yho0X+6MT5k8nMOv1oNwgWd+hsAcXivlV2TCWfkxvR0\n lCL9kTZDiF5tTYWxvzGac8yOXyqnTZy6Iip5CMJvdBs2I39y+sphnFlhQowkxTjQ+ze3\n AkZ+qe2QvfIIhmPNi5z5JbhFOEoUWVXDZiIkd/x6r0APJiYDRzJHMFyvGopOcOIwjH/p\n e0a/JQgPyIERMS5nhBoQoBjiNrMsFMcUqJFnHzivdcOSFeyMDDP06iuGzVLP+fkMKJzF\n DzwLRYY9Le78swCabzM/HFN/UvMjKwnPQ1NVmCV+jr8ReB2WRHFhw30spVEe5fGlGx+0\n Wb2g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776999382; x=1777604182;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=X8jAPi1Ug7YtuxDodtBim0VZYTDek6DS5vd5ro+n0/g=;\n b=iZ1Fep6ha/L7hMkFH98G7epjY2J0umefpe2y/kUvOFXmEloMkiJdx5XmABtf098vzi\n u9epDthqre0MEhwXaQz+oHQXIPAMxbcA6rW7j5hvukiCiM4Ux9YZz0QrseBgBzM3xwzh\n IFZrl2UPOjjLYiCIfApUThq3f8g4D5sm+aRn4wtSC9GVy8fpG4FA8P1ZX1yJId12WdOM\n FBnwHVsYY7UvA168enqjHRkCFtlCX3DThnc7x9eGWyPU993Sxc83hAN2X76Ydt5qpJp6\n Wa9dDnckJsVIZw8JxY/pNi1xdCZNUgev/K1tvLAmazrm5S4Oqjep2964SO5Fi3KuD79B\n YhXQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+YHXUs7crcAW06MsqwkKNZCTL2jwaXkRoud7wP0SclTEUtfLIZDxftClvRUpmxf9gnVYPpOZvkZQDL418=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0YylzVeUjHz4Ny7Nm/7Z/ly9U0oruWn5oWVSpHi9LRdyvPELevrN\n\tlVMeRIz+LXdtMy/zIH7kf7ORbJ1IonOc9AOReaMpkAPzpHTGbPVGquWgo4/Bzpqoh54=","X-Gm-Gg":"AeBDieus5bTRE+6axDqympRGx1LGqYgD/y2slls2nEBKh+tpGLSAWfcnZZfMIaEB4f2\n\tIdPG2GhxXbM8se7yLi2e/mG2GFmBW6P3tSFxOrxCEHv4V7VNlw10v13J4qXHzAIOlScYqGwNukw\n\tMtdzxxmX3avVaeNJOSfYGrDG24GuEfYtZO8XBCCgDtQsBTZePK9ZZRO+/4OCUakhBLG/sUAihr3\n\tj30LqBr/wYLrMCitzyOP9tGRFrlkloCbRlWRTMXlCYuIdTnsp/WTua9IrYFmfLBKnZk4gqaTuSq\n\tL6ijfz3g8Sg2hL4nig7nXrzlYoVC+8cYcVZBgD2q916EpLnkAlVULtIqGq7VJ20WcXHa7aERezo\n\tVtSg/nuZ8QjH2/2xdy7s7TSP9Eed8oJ2QOpbjq0UOLMgoDzY096axztSuwfNQvPfQBOV/k2xnhY\n\t66Wjg1MdkzIXszT5upQRZXs3Ox6NqZSv4Y9HuPieYm0iy6i6kPo/lFUNw=","X-Received":"by 2002:a17:903:1a83:b0:2b0:61c2:8e83 with SMTP id\n d9443c01a7336-2b5f9f36f53mr299091855ad.20.1776999381981;\n Thu, 23 Apr 2026 19:56:21 -0700 (PDT)","From":"Muchun Song ","To":"Andrew Morton ,\n\tDavid Hildenbrand ,\n\tMuchun Song ,\n\tOscar Salvador ,\n\tMichael Ellerman ,\n\tMadhavan Srinivasan ","Cc":"Lorenzo Stoakes ,\n\t\"Liam R . Howlett\" ,\n\tVlastimil Babka ,\n\tMike Rapoport ,\n\tSuren Baghdasaryan ,\n\tMichal Hocko ,\n\tNicholas Piggin ,\n\tChristophe Leroy ,\n\taneesh.kumar@linux.ibm.com,\n\tjoao.m.martins@oracle.com,\n\tlinux-mm@kvack.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org,\n\tMuchun Song ,\n\tstable@vger.kernel.org","Subject":"[PATCH v6 5/7] mm/mm_init: Fix pageblock migratetype for ZONE_DEVICE\n compound pages","Date":"Fri, 24 Apr 2026 10:55:45 +0800","Message-Id":"<20260424025547.3806072-6-songmuchun@bytedance.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20260424025547.3806072-1-songmuchun@bytedance.com>","References":"<20260424025547.3806072-1-songmuchun@bytedance.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The memmap_init_zone_device() function only initializes the migratetype\nof the first pageblock of a compound page. If the compound page size\nexceeds pageblock_nr_pages (e.g., 1GB hugepages with 2MB pageblocks),\nsubsequent pageblocks in the compound page remain uninitialized.\n\nMove the migratetype initialization out of __init_zone_device_page()\nand into a separate pageblock_migratetype_init_range() function. This\niterates over the entire PFN range of the memory, ensuring that all\npageblocks are correctly initialized.\n\nAlso remove the stale confusing comment about MEMINIT_HOTPLUG above\nthe migratetype setting since it is an obsolete relic from commit\n966cf44f637e (\"mm: defer ZONE_DEVICE page initialization to the point\nwhere we init pgmap\") and no longer makes sense here.\n\nFixes: c4386bd8ee3a (\"mm/memremap: add ZONE_DEVICE support for compound pages\")\nCc: stable@vger.kernel.org\nSigned-off-by: Muchun Song \nReviewed-by: Mike Rapoport (Microsoft) \nReviewed-by: Oscar Salvador \nAcked-by: David Hildenbrand (Arm) \n---\n mm/mm_init.c | 34 +++++++++++++++++++---------------\n 1 file changed, 19 insertions(+), 15 deletions(-)","diff":"diff --git a/mm/mm_init.c b/mm/mm_init.c\nindex f9f8e1af921c..cfc76953e249 100644\n--- a/mm/mm_init.c\n+++ b/mm/mm_init.c\n@@ -674,6 +674,20 @@ static inline void fixup_hashdist(void)\n static inline void fixup_hashdist(void) {}\n #endif /* CONFIG_NUMA */\n \n+#ifdef CONFIG_ZONE_DEVICE\n+static __meminit void pageblock_migratetype_init_range(unsigned long pfn,\n+\t\tunsigned long nr_pages, int migratetype)\n+{\n+\tconst unsigned long end = pfn + nr_pages;\n+\n+\tfor (pfn = pageblock_align(pfn); pfn < end; pfn += pageblock_nr_pages) {\n+\t\tinit_pageblock_migratetype(pfn_to_page(pfn), migratetype, false);\n+\t\tif (IS_ALIGNED(pfn, PAGES_PER_SECTION))\n+\t\t\tcond_resched();\n+\t}\n+}\n+#endif\n+\n /*\n * Initialize a reserved page unconditionally, finding its zone first.\n */\n@@ -1011,21 +1025,6 @@ static void __ref __init_zone_device_page(struct page *page, unsigned long pfn,\n \tpage_folio(page)->pgmap = pgmap;\n \tpage->zone_device_data = NULL;\n \n-\t/*\n-\t * Mark the block movable so that blocks are reserved for\n-\t * movable at startup. This will force kernel allocations\n-\t * to reserve their blocks rather than leaking throughout\n-\t * the address space during boot when many long-lived\n-\t * kernel allocations are made.\n-\t *\n-\t * Please note that MEMINIT_HOTPLUG path doesn't clear memmap\n-\t * because this is done early in section_activate()\n-\t */\n-\tif (pageblock_aligned(pfn)) {\n-\t\tinit_pageblock_migratetype(page, MIGRATE_MOVABLE, false);\n-\t\tcond_resched();\n-\t}\n-\n \t/*\n \t * ZONE_DEVICE pages other than MEMORY_TYPE_GENERIC are released\n \t * directly to the driver page allocator which will set the page count\n@@ -1122,6 +1121,9 @@ void __ref memmap_init_zone_device(struct zone *zone,\n \n \t\t__init_zone_device_page(page, pfn, zone_idx, nid, pgmap);\n \n+\t\tif (IS_ALIGNED(pfn, PAGES_PER_SECTION))\n+\t\t\tcond_resched();\n+\n \t\tif (pfns_per_compound == 1)\n \t\t\tcontinue;\n \n@@ -1129,6 +1131,8 @@ void __ref memmap_init_zone_device(struct zone *zone,\n \t\t\t\t compound_nr_pages(altmap, pgmap));\n \t}\n \n+\tpageblock_migratetype_init_range(start_pfn, nr_pages, MIGRATE_MOVABLE);\n+\n \tpr_debug(\"%s initialised %lu pages in %ums\\n\", __func__,\n \t\tnr_pages, jiffies_to_msecs(jiffies - start));\n }\n","prefixes":["v6","5/7"]}