{"id":2227610,"url":"http://patchwork.ozlabs.org/api/patches/2227610/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424023904.261258-1-zhaoguohan@kylinos.cn/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424023904.261258-1-zhaoguohan@kylinos.cn>","list_archive_url":null,"date":"2026-04-24T02:39:04","name":"vfio: propagate IRQ notifier registration failure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7cce667c39a7b6356e6fff0f355d510c6868bb5f","submitter":{"id":92952,"url":"http://patchwork.ozlabs.org/api/people/92952/?format=json","name":"GuoHan Zhao","email":"zhaoguohan@kylinos.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424023904.261258-1-zhaoguohan@kylinos.cn/mbox/","series":[{"id":501281,"url":"http://patchwork.ozlabs.org/api/series/501281/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501281","date":"2026-04-24T02:39:04","name":"vfio: propagate IRQ notifier registration failure","version":1,"mbox":"http://patchwork.ozlabs.org/series/501281/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227610/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227610/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1xy90zz9z1y2d\n\tfor ; Fri, 24 Apr 2026 12:40:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wG6SQ-000260-UE; Thu, 23 Apr 2026 22:39:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG6SO-00025o-Jb; Thu, 23 Apr 2026 22:39:52 -0400","from mailgw.kylinos.cn ([124.126.103.232])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wG6SJ-00019I-Hp; Thu, 23 Apr 2026 22:39:52 -0400","from localhost.localdomain [(116.128.244.171)] by mailgw.kylinos.cn\n (envelope-from )\n (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256)\n with ESMTP id 1970397967; Fri, 24 Apr 2026 10:39:35 +0800"],"X-UUID":["d4a3ebce3f8611f1aa26b74ffac11d73-20260424","d4a3ebce3f8611f1aa26b74ffac11d73-20260424"],"X-CID-O-RULE":"Release_Ham","X-CID-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:345f9eab-8f65-428d-b72b-f10364ce9dd6,\n IP:15,\n URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-30,FILE:0,BULK:0,RULE:Release_Ham,ACTI\n ON:release,TS:-15","X-CID-INFO":"VERSION:1.3.12, REQID:345f9eab-8f65-428d-b72b-f10364ce9dd6, IP:15,\n UR\n L:0,TC:0,Content:0,EDM:0,RT:0,SF:-30,FILE:0,BULK:0,RULE:Release_Ham,ACTION\n :release,TS:-15","X-CID-META":"VersionHash:e7bac3a, CLOUDID:15b98f039f3999fd9d4ad30c698fc93a,\n BulkI\n D:2604241039377AJEGR2B,BulkQuantity:0,Recheck:0,SF:10|38|66|78|102|123|127\n |850|898,TC:nil,Content:0|15|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:ni\n l,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE\n :0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","X-User":"zhaoguohan@kylinos.cn","From":"zhaoguohan@kylinos.cn","To":"Tony Krowiak , Halil Pasic ,\n Jason Herne , Alex Williamson ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Cc":"Cornelia Huck , Eric Farman ,\n Matthew Rosato , qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org","Subject":"[PATCH] vfio: propagate IRQ notifier registration failure","Date":"Fri, 24 Apr 2026 10:39:04 +0800","Message-ID":"<20260424023904.261258-1-zhaoguohan@kylinos.cn>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=124.126.103.232;\n envelope-from=zhaoguohan@kylinos.cn; helo=mailgw.kylinos.cn","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: GuoHan Zhao \n\nvfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean\nup the fd handler and EventNotifier when vfio_device_irq_set_signaling()\nfails, but still return true to their callers.\n\nReturn false after cleanup so callers can handle the failed registration\npath instead of treating it as a successful notifier setup.\n\nSigned-off-by: GuoHan Zhao \n---\n hw/vfio/ap.c | 1 +\n hw/vfio/ccw.c | 1 +\n 2 files changed, 2 insertions(+)","diff":"diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c\nindex 276ae8c207bf..6e2a1223ea8d 100644\n--- a/hw/vfio/ap.c\n+++ b/hw/vfio/ap.c\n@@ -193,6 +193,7 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,\n errp)) {\n qemu_set_fd_handler(fd, NULL, NULL, vapdev);\n event_notifier_cleanup(notifier);\n+ return false;\n }\n \n return true;\ndiff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c\nindex ff6ab9a7408f..c3dc7c196235 100644\n--- a/hw/vfio/ccw.c\n+++ b/hw/vfio/ccw.c\n@@ -431,6 +431,7 @@ static bool vfio_ccw_register_irq_notifier(VFIOCCWDevice *vcdev,\n VFIO_IRQ_SET_ACTION_TRIGGER, fd, errp)) {\n qemu_set_fd_handler(fd, NULL, NULL, vcdev);\n event_notifier_cleanup(notifier);\n+ return false;\n }\n \n return true;\n","prefixes":[]}