{"id":2227567,"url":"http://patchwork.ozlabs.org/api/patches/2227567/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260423223230.47001-1-m32285159@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423223230.47001-1-m32285159@gmail.com>","list_archive_url":null,"date":"2026-04-23T22:32:30","name":"gpio: sim: Remove intermediate pointer variable and harden function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"47c117103082ad7d541569de078619dcb1f113da","submitter":{"id":93193,"url":"http://patchwork.ozlabs.org/api/people/93193/?format=json","name":"Maxwell Doose","email":"m32285159@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260423223230.47001-1-m32285159@gmail.com/mbox/","series":[{"id":501259,"url":"http://patchwork.ozlabs.org/api/series/501259/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=501259","date":"2026-04-23T22:32:30","name":"gpio: sim: Remove intermediate pointer variable and harden function","version":1,"mbox":"http://patchwork.ozlabs.org/series/501259/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227567/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227567/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FglnwS7R;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35441-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"FglnwS7R\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.49","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1rSt1Dykz1yDD\n\tfor ; Fri, 24 Apr 2026 08:32:46 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D9B243020A90\n\tfor ; Thu, 23 Apr 2026 22:32:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 12E59377023;\n\tThu, 23 Apr 2026 22:32:35 +0000 (UTC)","from mail-ot1-f49.google.com (mail-ot1-f49.google.com\n [209.85.210.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 69FCB328B7A\n\tfor ; Thu, 23 Apr 2026 22:32:33 +0000 (UTC)","by mail-ot1-f49.google.com with SMTP id\n 46e09a7af769-7dbe07d3ec3so3691469a34.0\n for ;\n Thu, 23 Apr 2026 15:32:33 -0700 (PDT)","from linuxescape.lan (23-88-128-2.fttp.usinternet.com.\n [23.88.128.2])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-42ff2b6b2cdsm2472021fac.1.2026.04.23.15.32.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 15:32:32 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776983554; cv=none;\n b=XYSGLU+tJgwbU164B3/qX8ed4UAhmWQcNw7UEev12poUapu2uRhmc7FgdCG8Iv4jICJ1calkrza+Aw1/52GLOrxyHUP8Z6LUhHmdsy9ASWSiDbsftq7PzFWbOhEIxVJKmB1wObxYpCVGqbxbYrxY09S5NZkZwlwQQ6LZUfA23/Q=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776983554; c=relaxed/simple;\n\tbh=/65LLKhf8fHmkiinSAqwH23iLQo4ufUYTqSFcN1S6EE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=C6aDH/m/yUdMl3L3VfOXt0aij3ur51sXIs1eDK1v0MRBx87T4y9Ew9Eloi4Vz3TgoOuRqrp8zYIarrFcTzXHOag7+IGjvkaFO2uvItbnXp4jBPODBT2hoqNM801cHNAuJr0qNxEJCulSYtI87y4Wsd4ocEc8Hun/jMN3+uL9oZs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=FglnwS7R; arc=none smtp.client-ip=209.85.210.49","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776983552; x=1777588352;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=DG9zEpUh2A48NeB6NntsKd5rpo1+3n1vamCAhwseVcM=;\n b=FglnwS7RiNLFnARc4cVHTcv0fNt9NsUv/+WIzmn38cLWBnaD5lz1Prxb1lrl24NAOI\n zoeBopxOD+uxwJzGqWLTzPM94y/YP7bSBKuMbMib2jpGvo3ks+OTXaf2P2c3HildiJ2p\n plmir/CVghl3G7dcJgxxxoxZB9R13+HppPSkemXan2sO0XIEpD+37Y6d5yrcFwAAwM7l\n FhPtnpGL5INOQGzTm8xo2BlhsTXdxM4lVexjsRYJOFEG9B/4sNSu8VPYnsX5i3ekmb4V\n iJy+ZEZYbgyL5pjw0d/LaoKlkWe0dzT2nJo96e0fllXq4UFo3aCym68A0wHCzbGl8cfZ\n S8dg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776983552; x=1777588352;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=DG9zEpUh2A48NeB6NntsKd5rpo1+3n1vamCAhwseVcM=;\n b=Y9mJCwZCxsVyXJZ86fQvOLIh0hh1eTmt3kOFfEO1cGobAwXrE5+iLby65Y1gdxyRJt\n r+tWR84m0SfmDJwJc8oy34vi4RE60jYCwXWU1nX0lzt1XxDfuF/+PTzRE+K/9yabyuYx\n LuEUICVnOR5uyHiInBYWW4Nes1SnLOCpm6kA0Dv8kQwtcdd/1LdXs1c2dSldfZw2mjMg\n XSnu9XJb+BSjd2lh1XjbLKcZj5mYDW0mme97xv6xpSjAJKOiQzMw4KjZ1miTb0vnxZBU\n Wv2lDWGgGG7rBuifTDKrkK5It8E62HldL9z/6sTO8cl/qpVEgmTyeTkZBAqdoM6kYIbW\n TIRA==","X-Gm-Message-State":"AOJu0Yxu3ikt+sKwkuA8ct/I/uqzBwNOoj6P59JDTA8JIulSyYBWRTA0\n\tZT6/VcD96End+VvOu3pzTWGzIadY2mgTLlnx9v1pVCnBA4+TVYmVA+EH","X-Gm-Gg":"AeBDieuelESw5rhP1+5dM62iWBmZ/fkDwWNfIoH3+Mput4oWn8QAv00gtGh29AnlAD1\n\tYg8v3gyqCySRPS+hn8m3i9c0FOLPipshrdv9h1a7WK/pvcr0vYR3Wukj8jpxKuSgdf0cX6AeS/Y\n\t4q1dIv/HjjkfaqJB4UJTnmPyt0Bao5n6/CQtqr3xj6CTmKOzu2moP8bXbU4viu5YqAFh5g4r7ev\n\tWasjJdcrWzq+X4nSdNB+APURSlA0+Revb3M2LkUPGyOPXxjMLFV3tCYHmXGJAt8ZNqq5ZOZiYsn\n\tbfQb6ulHDKSAGn2ohUr4eaAdKZVhhZsiJ4ThQl76LppZtDiqMyTWJlv4t2x/3b+GBQsF/XzXiGX\n\thUzHFsqvDcUmS9Ba4SbB+aPA7m26O0O8LIc7y6aw1W4sZj33FtTtLsakIE1xgR8elkn92UuOod2\n\thbtYQVCf65EpJOBCTio/v7W4loQLy6Z3+HdzeMsIqyu9qvURwFLY8gDXzo+vv0gZBLOiS+","X-Received":"by 2002:a05:6820:81cf:b0:68e:3db1:bdb9 with SMTP id\n 006d021491bc7-69462e6450cmr16334071eaf.22.1776983552280;\n Thu, 23 Apr 2026 15:32:32 -0700 (PDT)","From":"Maxwell Doose ","To":"linusw@kernel.org,\n\tbrgl@kernel.org","Cc":"linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] gpio: sim: Remove intermediate pointer variable and harden\n function","Date":"Thu, 23 Apr 2026 17:32:30 -0500","Message-ID":"<20260423223230.47001-1-m32285159@gmail.com>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Remove the *pdev intermediate variable and directly dereference the\npointer. While at it, replace sprintf() calls with sysfs_emit() to\nharden the driver.\n\nSigned-off-by: Maxwell Doose \n---\n drivers/gpio/gpio-sim.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c\nindex 13b87c8e6d0c..3c230f94eea2 100644\n--- a/drivers/gpio/gpio-sim.c\n+++ b/drivers/gpio/gpio-sim.c\n@@ -691,15 +691,13 @@ static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item,\n \t\t\t\t\t\t char *page)\n {\n \tstruct gpio_sim_device *dev = to_gpio_sim_device(item);\n-\tstruct platform_device *pdev;\n \n \tguard(mutex)(&dev->lock);\n \n-\tpdev = dev->probe_data.pdev;\n-\tif (pdev)\n-\t\treturn sprintf(page, \"%s\\n\", dev_name(&pdev->dev));\n+\tif (dev->probe_data.pdev)\n+\t\treturn sysfs_emit(page, \"%s\\n\", dev_name(&dev->probe_data.pdev->dev));\n \n-\treturn sprintf(page, \"gpio-sim.%d\\n\", dev->id);\n+\treturn sysfs_emit(page, \"gpio-sim.%d\\n\", dev->id);\n }\n \n CONFIGFS_ATTR_RO(gpio_sim_device_config_, dev_name);\n","prefixes":[]}