{"id":2227446,"url":"http://patchwork.ozlabs.org/api/patches/2227446/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423183212.468047-4-peterx@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423183212.468047-4-peterx@redhat.com>","list_archive_url":null,"date":"2026-04-23T18:32:12","name":"[3/3] qio: Fix qom-list-properties crash on net listener object","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"36f73db24906d1d1e46128925f7fc53fcc654de9","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/?format=json","name":"Peter Xu","email":"peterx@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423183212.468047-4-peterx@redhat.com/mbox/","series":[{"id":501234,"url":"http://patchwork.ozlabs.org/api/series/501234/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501234","date":"2026-04-23T18:32:10","name":"Three small fixes over qom-list-properties crash","version":1,"mbox":"http://patchwork.ozlabs.org/series/501234/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227446/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227446/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bmslIhkO;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=FvB+vSko;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1l8j1fYrz1yGs\n\tfor ; Fri, 24 Apr 2026 04:33:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFyqt-0003eQ-W4; Thu, 23 Apr 2026 14:32:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFyqr-0003dg-MO\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:37 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFyqq-0001Lm-58\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:37 -0400","from mail-qv1-f70.google.com (mail-qv1-f70.google.com\n [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-443-atrXGNEUPUOcnYAuEOsHfw-1; Thu, 23 Apr 2026 14:32:26 -0400","by mail-qv1-f70.google.com with SMTP id\n 6a1803df08f44-8aca4660827so202096256d6.3\n for ; Thu, 23 Apr 2026 11:32:25 -0700 (PDT)","from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02ae92fc8sm160665566d6.40.2026.04.23.11.32.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 11:32:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776969154;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Vc/pJGjkgyWmQP2xxj1GO1bV3g12ILLASq9+yGdKiXc=;\n b=bmslIhkO5jFNHPNc3qlPoOFhRg1+4qwESMDbfv5sQmcafrczyAQJ5gLeJC/NqjfeAoGarA\n gsFBr57OJ91BdHce/C/Do0AhkVU7pqM5ucYT7x39i4IZfNy54maeabp4YgHQpQ/BERs8B0\n GcY9MDjv+e9IhJrXvbHcyVyjiuC02rM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776969145; x=1777573945; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Vc/pJGjkgyWmQP2xxj1GO1bV3g12ILLASq9+yGdKiXc=;\n b=FvB+vSkohgwRYE+GYPX+t+mSNfuNnVmclrTraztq8sn7QSQdc7MRTpwV1LpAaNfDxZ\n dxtwAJE1wRtw5GJu4AfEFhOrmzZ+sfBQ8MvToNXL6+H1helXPEqVw86IwVEykMv5wB5A\n rX2+y2MmLeLEhEEFgQmFqsQeTNchYr3GG+7y9Urt+PO0NVXEy2+Pwk8rSJv9c2anRuiD\n YK/Fu0HYTvXdUmQeIRdnNj8XN9xaCdOQuw0J/vk8aQykxCV8BnVqSHykfwgFiVl/5v/I\n ney6zIMw2q39ioF6BLk3JXsg6EEiDM5gBv3x0sj8snpaKgxB0yYFXIqQy9jC9Z0OSsFI\n 9g+w=="],"X-MC-Unique":"atrXGNEUPUOcnYAuEOsHfw-1","X-Mimecast-MFC-AGG-ID":"atrXGNEUPUOcnYAuEOsHfw_1776969145","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776969145; x=1777573945;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Vc/pJGjkgyWmQP2xxj1GO1bV3g12ILLASq9+yGdKiXc=;\n b=VvAEp3pHximMr8QfT9Gnj/S8ORIdOQ+jvm2xYFS20R9Qz6eWunM2HLt7RMVnC39ux0\n w4Yo9hu5tFnTmGV1wiiAOF06e//VTpU3CrXob0Bx7SGSYOBdTVQlBNI7eN6cREliG0j3\n clLEcr0xTYOPMdvqLk5adyvHLToS+empl2P/GAwP4+kBVdPCVEFVt7D0+/xMod7uVjU8\n +qi+W+TkwTi6qAQkGMKUAaNSNVfxo/ECy1/lEe5R2OwnwBPaW0rlznJpWQfhW5MMu3DO\n NeUzZs+P8zjNDIKl85/mADCXakotkLRot/5o963sumUIwpJoFejzX+9bmv9vYTjiFTMQ\n WrXA==","X-Gm-Message-State":"AOJu0YxrwDf0wxXs4Uh89RxV6QXMvDaJPgg2nHIffpQC5QrwwTeXVKAb\n FH+hmWHzPpkvsvIjRwMeKcGwO00IM71/PAYvQlvBfHITs6V7FHNdHv5aNL5pNkdmuePuhxIbwRy\n 3cpAXemBabR0uulXO1rGIoMnAAu8PZD+bAkkhZHwAYuiCCeDGMem5wAHsmLWKb5yI0T04lovbvl\n /yW8xGjMF4wIqrI7zDs0mcR3F80hcjJddenW/AIA==","X-Gm-Gg":"AeBDiesp/gRil08oHpUooaL9p/oRkQon7wgP19JwcZ5o/9nBZSpq48J4KazS3km4ddM\n 3ulcUZShAjQ4hbWESLHUj/+t36fbC+lc+PG/rbjnTt4imoyPP0iQgocUa3Bm15cFLaWT7jUSjHY\n j1U96rQKcqS0Cty/aL7WCRo7F7foUa9B9jwh0yDjOwNDkfM6ub8kRQMKSAfpgz9VGjy/4WM3mI2\n qwybj0H3wOKKDb6uwxxLKMHPzZxLwIc7a7k2/qVI70ozhYNMADeUwIRWK8PV4fDf2NXuHaI8Yv6\n kRazfqQDSCNzW5g+48w9nMeY1HSmA0mizdBZemLXp9Wb15YvYgNm64GHltcP+6ZRMdcP6LUmUPG\n Ql3LlV/F4DO+ePsLVQBcJscdtvh/yc7N4BiYU0xKz0cuZHInkERv1ai0=","X-Received":["by 2002:a05:6214:20ad:b0:8a7:e3fd:4d8f with SMTP id\n 6a1803df08f44-8b027ff7df1mr414627306d6.8.1776969144877;\n Thu, 23 Apr 2026 11:32:24 -0700 (PDT)","by 2002:a05:6214:20ad:b0:8a7:e3fd:4d8f with SMTP id\n 6a1803df08f44-8b027ff7df1mr414626366d6.8.1776969144212;\n Thu, 23 Apr 2026 11:32:24 -0700 (PDT)"],"From":"Peter Xu ","To":"qemu-devel@nongnu.org","Cc":"Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Li Zhijian ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ,\n Fabiano Rosas , peterx@redhat.com,\n Zhang Chen , Juraj Marcin ,\n Jason Wang , Markus Armbruster ","Subject":"[PATCH 3/3] qio: Fix qom-list-properties crash on net listener object","Date":"Thu, 23 Apr 2026 14:32:12 -0400","Message-ID":"<20260423183212.468047-4-peterx@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423183212.468047-1-peterx@redhat.com>","References":"<20260423183212.468047-1-peterx@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The QIO net listener object will crash with raw object_new() then\ndereference the object, like what QMP command qom-list-properties would do.\nFix it by moving mutex init into instance_init().\n\nCc: Daniel P. Berrangé \nLink: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org\nReported-by: Markus Armbruster \nSigned-off-by: Peter Xu \n---\n io/net-listener.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)","diff":"diff --git a/io/net-listener.c b/io/net-listener.c\nindex 9410d72da9..a772756eb5 100644\n--- a/io/net-listener.c\n+++ b/io/net-listener.c\n@@ -35,11 +35,7 @@ struct QIONetListenerSource {\n \n QIONetListener *qio_net_listener_new(void)\n {\n- QIONetListener *listener;\n-\n- listener = QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER));\n- qemu_mutex_init(&listener->lock);\n- return listener;\n+ return QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER));\n }\n \n void qio_net_listener_set_name(QIONetListener *listener,\n@@ -440,6 +436,13 @@ qio_net_listener_get_local_address(QIONetListener *listener, size_t n,\n return qio_channel_socket_get_local_address(sioc, errp);\n }\n \n+static void qio_net_listener_init(Object *obj)\n+{\n+ QIONetListener *listener = QIO_NET_LISTENER(obj);\n+\n+ qemu_mutex_init(&listener->lock);\n+}\n+\n static void qio_net_listener_finalize(Object *obj)\n {\n QIONetListener *listener = QIO_NET_LISTENER(obj);\n@@ -462,6 +465,7 @@ static void qio_net_listener_finalize(Object *obj)\n static const TypeInfo qio_net_listener_info = {\n .parent = TYPE_OBJECT,\n .name = TYPE_QIO_NET_LISTENER,\n+ .instance_init = qio_net_listener_init,\n .instance_size = sizeof(QIONetListener),\n .instance_finalize = qio_net_listener_finalize,\n };\n","prefixes":["3/3"]}