{"id":2227419,"url":"http://patchwork.ozlabs.org/api/patches/2227419/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423170229.64655-7-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423170229.64655-7-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-23T17:02:18","name":"[06/16] system/cpu: Defer memory layout changes until vCPUs are realized","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4495be50e43ef386adc514fef4ed1f640d9a28c6","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423170229.64655-7-philmd@linaro.org/mbox/","series":[{"id":501223,"url":"http://patchwork.ozlabs.org/api/series/501223/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501223","date":"2026-04-23T17:02:12","name":"accel/hvf: Assorted collection of patches queued before v11 release","version":1,"mbox":"http://patchwork.ozlabs.org/series/501223/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227419/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227419/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=KTbvI8z2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1j9b1QVmz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 03:04:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFxSn-00013T-C6; Thu, 23 Apr 2026 13:03:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFxSV-0000pU-4o\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:03:24 -0400","from mail-wr1-x431.google.com ([2a00:1450:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFxSR-0005OO-VW\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 13:03:22 -0400","by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-43cff5dafc3so5585309f8f.1\n for <qemu-devel@nongnu.org>; Thu, 23 Apr 2026 10:03:19 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4dc24cfsm53790415f8f.16.2026.04.23.10.03.16\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 23 Apr 2026 10:03:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776963798; x=1777568598; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TO1pyTnO3mNIJGKSVSSCAJig7b0z6dQMkq6ZqngmlbM=;\n b=KTbvI8z2INyBy56nkEKkhQt8hCJrJYsdcsQCz0BwT0C7NHt6z60FLw5LiJbzuPGE0Y\n ChJbkSWGg1K5YTSshpC9akpMjjZqHAsrqyphDGIEopN+mxHN/CBfh3qLCTBmzefx0KTi\n nixIkULlii1BC3rT/rkND6nxw7tTB8dhn+Jln+i9fV9HPxY+7X7gQIrEq41d7hwwvI3M\n K/hyRirYXnl0vfgS/CqTjdfYa/Mtgny0gV6nUaV/ZbW/aqWYswkpda9gDZProL7gIRjW\n stwuA881d+K0wQOiOO3JAjhZ+6GX5m7P32WjS97tqTOXCwd+X0hIxFndeduse8tkVGwY\n apww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776963798; x=1777568598;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TO1pyTnO3mNIJGKSVSSCAJig7b0z6dQMkq6ZqngmlbM=;\n b=SAaXUK/t3BH3bZRo/owWiLoS04P/NAubWF76rBtl2bQ6uaCt2iWt1gMj8SgpU7QGQE\n SDsKIeU6epbwYWmUlwtQV1cgnQ6BNLOABDYbzGH7OWSPx/QueNIsnIB6lK1bClTKbr22\n dO4bMwBrbaij3r6mjyQA4fHz+S8wDOu/IzUCTQV4QK/WAbo/QQJAe2JU3ZoZrSkqXiOd\n 7h/VYaW/GIl0BpQGkvqQBd6HlZajgWiEGeMTq7jgq5x3DcYxDna5ZOxgaPrRtdsWPAdb\n WSH3chfLVAKMbfJwd7HyIR2vR4dX+EzP0sihEKYI9ORr1hVfcq0tFoq6oJMCSMKj1Pe6\n gBGQ==","X-Gm-Message-State":"AOJu0YyHOEX4k0Pug5jnwO7v8RxDJJNhvaTatOiIn94As2XFYuB72uY0\n 1yM+4/u8xmBRVDQtrCk2YTIqjhXyowpKshs+TI2mFZ+PR3P1EV0qXkgg1/ewihPEccqfXJt6fPI\n coNzneiI=","X-Gm-Gg":"AeBDiesCpUB2WF8Oe29acHvJY3uVRbdoWcmo4hcGS/Rpl/kh+nlO4XUL74bLJDqdMIA\n TCTA89NL3fvc8NWW8r5FknoDp5TNg1RsFGAcU1gdUk5Y0ZShX5RKNdWH5e+KllgT/YLYbv1LGf4\n T6d95OWF85MmQ+ODs6Pvb32/BOYWpzyKqJk7B6WPiP+cQqPmsYq6BRyZtD68SsQMOq/MC0QbPBq\n TZrJ5DHQxqoD01SSKE8UIchNqSMBaBqv/zCpdHbRFxGodP2vQD8b4pV5gpGIDVo4ZupV96oBx5X\n sZ1JlaMyC2dk135rzLUOEtiKg4tAlHTYj7iI3RbKr7vTq411OBiVOuiSG9KyKvL7hur399c82SN\n mS3YVxXIDPeFpkgq7BGmced+oBySTRidiUjTi2hNNJgqbE0mzzxX4nRDc8JAHCCa8Twf1VXtgv9\n jW8ZUD13yYe2Bpo6kQnOqFMm0h/aF+taNYuK/WR0DByb/2NuqgM5knc4JwNNIro/r2GO6/N9jpR\n KZcpXJEjs2j7q9Yan7vvA==","X-Received":"by 2002:a5d:5f89:0:b0:441:1c95:17e7 with SMTP id\n ffacd0b85a97d-4411c951810mr24411525f8f.15.1776963797790;\n Thu, 23 Apr 2026 10:03:17 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"Roman Bolshakov <rbolshakov@ddn.com>,\n Jonathan Cameron <jonathan.cameron@huawei.com>, Mads Ynddal <mads@ynddal.dk>,\n qemu-arm@nongnu.org, Mohamed Mediouni <mohamed@unpredictable.fr>,\n Peter Maydell <peter.maydell@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@csgraf.de>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Peter Xu <peterx@redhat.com>","Subject":"[PATCH 06/16] system/cpu: Defer memory layout changes until vCPUs are\n realized","Date":"Thu, 23 Apr 2026 19:02:18 +0200","Message-ID":"<20260423170229.64655-7-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423170229.64655-1-philmd@linaro.org>","References":"<20260423170229.64655-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::431;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"vCPUs are not really usable until fully realized. Do not attempt\nto commit memory changes in the middle of vCPU realization. Defer\nuntil realization is completed and vCPU fully operational.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n---\n system/physmem.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/system/physmem.c b/system/physmem.c\nindex 4e26f1a1d42..091a1da3458 100644\n--- a/system/physmem.c\n+++ b/system/physmem.c\n@@ -3089,6 +3089,14 @@ static void tcg_commit(MemoryListener *listener)\n     cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener);\n     cpu = cpuas->cpu;\n \n+    if (!qdev_is_realized(DEVICE(cpu))) {\n+        /*\n+         * The listener is also called during realize, before\n+         * all of the tcg machinery for run-on is initialized.\n+         */\n+        return;\n+    }\n+\n     /*\n      * Queueing the work function will kick the cpu back to\n      * the main loop, which will end the RCU critical section and reclaim\n","prefixes":["06/16"]}