{"id":2227411,"url":"http://patchwork.ozlabs.org/api/patches/2227411/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423163509.502729-1-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423163509.502729-1-pbonzini@redhat.com>","list_archive_url":null,"date":"2026-04-23T16:35:09","name":"[v2] tests: add test for json-streamer.c error recovery","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"079cd1fb50edd14f6e9184de9e5cb3bfd835d7a8","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423163509.502729-1-pbonzini@redhat.com/mbox/","series":[{"id":501219,"url":"http://patchwork.ozlabs.org/api/series/501219/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501219","date":"2026-04-23T16:35:09","name":"[v2] tests: add test for json-streamer.c error recovery","version":2,"mbox":"http://patchwork.ozlabs.org/series/501219/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227411/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227411/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=E1SxaozF;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=pOhOJiLP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1hYK4Kmjz1y2d\n\tfor ; Fri, 24 Apr 2026 02:36:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFx1U-0003e3-3l; Thu, 23 Apr 2026 12:35:28 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFx1P-0003dK-Er\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 12:35:23 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFx1L-00054y-Ps\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 12:35:22 -0400","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-112-7hUswZwnNCqx94iKzoxh2w-1; Thu, 23 Apr 2026 12:35:13 -0400","by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-488d56f87e8so56964895e9.0\n for ; Thu, 23 Apr 2026 09:35:13 -0700 (PDT)","from [192.168.1.84] ([93.56.170.76])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891cc7b2efsm185613685e9.0.2026.04.23.09.35.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 09:35:10 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776962117;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=AsJAWnCoNbs1oy2JrjrDhcMoGfn46TVOMFyDrJmHCAM=;\n b=E1SxaozFrXOoj94ump6iIa7CMKdozhci3EIpNmIqyQgNK+qabrsPfTEdEPP5ZtpRywekUZ\n GcCvRUnEpmhAp9atwrHmp3XnYSb0Ve8AQZLYky08zHHAK2X/xQJtiqRmFBLgxMftzioKU/\n bPcKUoZCcLuXX8bLHWa5uef91ygz6sI=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776962111; x=1777566911; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=AsJAWnCoNbs1oy2JrjrDhcMoGfn46TVOMFyDrJmHCAM=;\n b=pOhOJiLPsenHgsIAQId7C5hGvkPWY5NppKigTZZcvQ06kGPT5vfewqSzMECPnYLEqc\n fbfrImmMbffMqhiGWU8WdaMGH4YmtRUgKSKxWlfZYhD32kqEEpG7Z36EJUqmifMC2WX5\n FuPo2AM60D0DedPY1krYzEvKA09Xxcv5Sv9sDF1Q80EjBt54RREVhBgdSc2ULEZG78Lf\n E5x/ijWxBOMerF1Ae91hUKBvs3XoD7ZMZp6qZhOGwxetifbQ7tiCtXsn0UhbeK1b2sFK\n GuYvjtGw2jj21haCj9yoOu4S6Laa85lwyyAoX1n0+j4IxUluOmJGCP2tNI6iXJBvmXgn\n sZUw=="],"X-MC-Unique":"7hUswZwnNCqx94iKzoxh2w-1","X-Mimecast-MFC-AGG-ID":"7hUswZwnNCqx94iKzoxh2w_1776962112","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776962111; x=1777566911;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=AsJAWnCoNbs1oy2JrjrDhcMoGfn46TVOMFyDrJmHCAM=;\n b=sJD2JUKoq1zKhdBHm2U4Ujs4M9pHRhwI0wX8my0IUpsaNODUXU7lDfmx1Qel3a/5Lh\n 4dcz3alS25g4y7aMaH/D7NtS+sE1OyPeCLrDAjsgP061WbZJ52nnwq7G/Hol+lXpFvSU\n zre8XZk+HBl837ikFgufCog0Z+T2Z4qebTv6VDOqEltZfxnNaLd1fDiQ6gdwc6ShCsAp\n wyFSIxqI9sA33cFtBoydXhcCpvMQ6RlW4uB3pie7FBooGklJCC63gRd0JkAQc4eQQLZm\n bTahMNNNmhC1hdzJcT9dST+BckC95RpLSUW1DrecbmG3azDGta5rYW/yEB98YCIC3Pgj\n j3MA==","X-Gm-Message-State":"AOJu0YxGRJ9LomQv1Eg3uLEExUCjqJxtwwFkHHaQsWO0j2Ghy2b9+1Ta\n cx1kFN7iqeJDT83+mQEUYlVDdDLuqOpMeOGZ7OBmxbkxBCF8koHPDfR3gpYOdJ5Fl3fHSBHPSbM\n eKf7MjP3sakFCOYZk+NWoFYlTnXRRWF7dZWRdQVmkaCcpP/DsGKRq0Pe4ddjWsylA/pZXNM26bG\n Ru1EUyReZ3nyidiPulP6Bmpx1uslgSgujgjMG/o6Y2","X-Gm-Gg":"AeBDiev/0DfMWe/rkzaHeC7+zfO1WFZVyr9uEcwxgjxPvh8bUrwF2FPFQfFdEguf/Jl\n MInDT3QXaE9jORFElKSuuxP4joooHwn2I4CPaP/E4Jv9iboaQunZQSY0FPtvS9sI2hZDpYvPSs3\n 8CjU7t0AW2/FhezK3CIjIr5IGi8LuOkiWFviqIu8B8L2KwZZttEAr+ct+KXqyea1Ze4uS4mX5IM\n PBn8ZOhcTYiMkcZUzAQ+y35uBTF4LAHHY1jkCGXklEAeW/pChD5mrRHzBxj30H8vVcuFiFPjdwt\n N7+CsomRomIuIZeCYIBGgyhBJ35llgGOUL4y5uj/Ji7esbEHwBkPtf6oRk+OIw6TOmVqYG7/NOH\n C00xUWSWUmmahnCySXfJ4klSp62PfDrz3LnZemzNJ9fxYcnrluPdmosYS+8bWxMMyEcOV1eeJ15\n Jmz9OZxG6XpEdD0PbzRUXXlys1kdqQgaW71w==","X-Received":["by 2002:a05:600c:c4a8:b0:48a:52ee:5776 with SMTP id\n 5b1f17b1804b1-48a52ee579dmr236331745e9.11.1776962111364;\n Thu, 23 Apr 2026 09:35:11 -0700 (PDT)","by 2002:a05:600c:c4a8:b0:48a:52ee:5776 with SMTP id\n 5b1f17b1804b1-48a52ee579dmr236331195e9.11.1776962110743;\n Thu, 23 Apr 2026 09:35:10 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com","Subject":"[PATCH v2] tests: add test for json-streamer.c error recovery","Date":"Thu, 23 Apr 2026 18:35:09 +0200","Message-ID":"<20260423163509.502729-1-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Before rewriting the error recovery code to work in a push parsing\nsetup, make sure that we have tests for it.\n\nCover various cases of invalid JSON, to check that structural\nrecovery based on balanced brackets and braces works; and\nlexer-based recovery which documents \"\\f\" as a sure fire\nway to reset the lexer.\n\nSigned-off-by: Paolo Bonzini \n---\n tests/unit/check-json-parser.c | 159 +++++++++++++++++++++++++++++++++\n tests/unit/meson.build | 1 +\n 2 files changed, 160 insertions(+)\n create mode 100644 tests/unit/check-json-parser.c","diff":"diff --git a/tests/unit/check-json-parser.c b/tests/unit/check-json-parser.c\nnew file mode 100644\nindex 00000000000..5e833eac1f9\n--- /dev/null\n+++ b/tests/unit/check-json-parser.c\n@@ -0,0 +1,159 @@\n+/*\n+ * Unit tests for JSON Parser error recovery\n+ *\n+ * Copyright 2026 Red Hat\n+ * Author: Paolo Bonzini \n+ *\n+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.\n+ * See the COPYING.LIB file in the top-level directory.\n+ */\n+\n+/*\n+ * Missing tests:\n+ * - multiple JSON values in a single stream\n+ * - multiple invocations of json_message_parser_feed()\n+ * (does not really matter much because of how\n+ * json_lexer_feed() is implemented)\n+ * - most JSON types are only covered by check-json.c.\n+ */\n+\n+#include \"qemu/osdep.h\"\n+\n+#include \"qapi/error.h\"\n+#include \"qobject/qbool.h\"\n+#include \"qobject/json-parser.h\"\n+\n+typedef struct ParseResult {\n+ int errors;\n+ QObject *result;\n+} ParseResult;\n+\n+static void parse_emit(void *opaque, QObject *json, Error *err)\n+{\n+ ParseResult *r = opaque;\n+\n+ g_assert_cmpint(!json, !=, !err);\n+ if (err) {\n+ r->errors++;\n+ error_free(err);\n+ } else {\n+ g_assert_null(r->result);\n+ qobject_unref(r->result);\n+ r->result = json;\n+ }\n+}\n+\n+static ParseResult do_parse(const char *input)\n+{\n+ ParseResult r = { 0, NULL };\n+ JSONMessageParser parser;\n+\n+ json_message_parser_init(&parser, parse_emit, &r, NULL);\n+ json_message_parser_feed(&parser, input, strlen(input));\n+ json_message_parser_flush(&parser);\n+ json_message_parser_destroy(&parser);\n+ return r;\n+}\n+\n+static void check_result(const char *input, int expected_errors, QType expected_type)\n+{\n+ ParseResult r = do_parse(input);\n+\n+ g_assert_cmpint(r.errors, ==, expected_errors);\n+ g_assert_nonnull(r.result);\n+ g_assert_cmpint(qobject_type(r.result), ==, expected_type);\n+ qobject_unref(r.result);\n+}\n+\n+static void check_result_error(const char *input, int expected_errors)\n+{\n+ ParseResult r = do_parse(input);\n+\n+ g_assert_cmpint(r.errors, ==, expected_errors);\n+ g_assert_null(r.result);\n+}\n+\n+static void test_simple(void)\n+{\n+ check_result(\"false\", 0, QTYPE_QBOOL);\n+}\n+\n+static void test_whitespace(void)\n+{\n+ check_result(\" false\", 0, QTYPE_QBOOL);\n+}\n+\n+static void test_extra_closing_braces(void)\n+{\n+ check_result(\"}}false\", 2, QTYPE_QBOOL);\n+}\n+\n+static void test_bad_dict(void)\n+{\n+ check_result(\"{ 'abc' }false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_trailing_comma(void)\n+{\n+ check_result(\"[ 'abc', ]false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_lexer_recovery(void)\n+{\n+ check_result(\"\\f{}\", 1, QTYPE_QDICT);\n+ check_result(\"\\f[]\", 1, QTYPE_QLIST);\n+ check_result(\"\\f:false\", 2, QTYPE_QBOOL);\n+ check_result(\"\\f,false\", 2, QTYPE_QBOOL);\n+\n+ /*\n+ * Alphabetic characters do not start a new parsing. This is\n+ * slightly weird but it keeps the lexer simple and works well for\n+ * QMP (where valid input is a sequence of dictionaries).\n+ */\n+ check_result_error(\"\\ffalse\", 1);\n+ check_result_error(\"\\f'str'\", 1);\n+ check_result_error(\"\\f\\\"str\\\"\", 1);\n+}\n+\n+static void test_lexer_recovery_nested(void)\n+{\n+ check_result(\"{[{\\f{}\", 1, QTYPE_QDICT);\n+ check_result(\"{[{\\f[]\", 1, QTYPE_QLIST);\n+ check_result(\"{[{\\f:false\", 2, QTYPE_QBOOL);\n+ check_result(\"{[{\\f,false\", 2, QTYPE_QBOOL);\n+\n+ /*\n+ * As in test_lexer_recovery, these do not produce a successful\n+ * parse after \\f.\n+ */\n+ check_result_error(\"{[{\\ffalse\", 1);\n+ check_result_error(\"{[{\\f'str'\", 1);\n+ check_result_error(\"{[{\\f\\\"str\\\"\", 1);\n+}\n+\n+static void test_nested(void)\n+{\n+ check_result(\"[{'a']}false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_nested_multiple(void)\n+{\n+ check_result(\"[{'a']}[{'a']}false\", 2, QTYPE_QBOOL);\n+}\n+\n+int main(int argc, char **argv)\n+{\n+ g_test_init(&argc, &argv, NULL);\n+\n+ g_test_add_func(\"/json-parser/simple\", test_simple);\n+ g_test_add_func(\"/json-parser/whitespace\", test_whitespace);\n+ g_test_add_func(\"/json-parser/error-recovery/extra-closing-braces\", test_extra_closing_braces);\n+ g_test_add_func(\"/json-parser/error-recovery/bad-dict\", test_bad_dict);\n+ g_test_add_func(\"/json-parser/error-recovery/trailing-comma\", test_trailing_comma);\n+ g_test_add_func(\"/json-parser/error-recovery/lexer\", test_lexer_recovery);\n+ g_test_add_func(\"/json-parser/error-recovery/lexer/nested\", test_lexer_recovery_nested);\n+ g_test_add_func(\"/json-parser/error-recovery/nested\", test_nested);\n+ g_test_add_func(\"/json-parser/error-recovery/nested/multiple\", test_nested_multiple);\n+\n+ return g_test_run();\n+}\ndiff --git a/tests/unit/meson.build b/tests/unit/meson.build\nindex 41e8b06c339..03d36748c73 100644\n--- a/tests/unit/meson.build\n+++ b/tests/unit/meson.build\n@@ -10,6 +10,7 @@ tests = {\n 'check-qnull': [],\n 'check-qobject': [],\n 'check-qjson': [],\n+ 'check-json-parser': [],\n 'check-qlit': [],\n 'test-error-report': [],\n 'test-qobject-output-visitor': [testqapi],\n","prefixes":["v2"]}