{"id":2227375,"url":"http://patchwork.ozlabs.org/api/patches/2227375/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423-audio-v1-1-e1d6b65c76f9@rsg.ci.i.u-tokyo.ac.jp/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423-audio-v1-1-e1d6b65c76f9@rsg.ci.i.u-tokyo.ac.jp>","list_archive_url":null,"date":"2026-04-23T13:55:21","name":"[1/3] audio: Avoid unsigned sample wraparound","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"37b6263da130b36a7b4a808036c2c9ff608435f9","submitter":{"id":90980,"url":"http://patchwork.ozlabs.org/api/people/90980/?format=json","name":"Akihiko Odaki","email":"odaki@rsg.ci.i.u-tokyo.ac.jp"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423-audio-v1-1-e1d6b65c76f9@rsg.ci.i.u-tokyo.ac.jp/mbox/","series":[{"id":501200,"url":"http://patchwork.ozlabs.org/api/series/501200/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501200","date":"2026-04-23T13:55:20","name":"audio: Fix unsigned PCM conversion edge cases","version":1,"mbox":"http://patchwork.ozlabs.org/series/501200/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227375/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227375/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=rsg.ci.i.u-tokyo.ac.jp\n header.i=@rsg.ci.i.u-tokyo.ac.jp header.a=rsa-sha256 header.s=rs20250326\n header.b=Splkzpvc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1d2R0NHSz1yD5\n\tfor ; Thu, 23 Apr 2026 23:57:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFuY2-0005e4-KC; Thu, 23 Apr 2026 09:56:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFuX4-0005Wa-Kc\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 09:56:02 -0400","from www3579.sakura.ne.jp ([49.212.243.89])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFuWt-0000cC-AH\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 09:55:48 -0400","from h205.csg.ci.i.u-tokyo.ac.jp (h205.csg.ci.i.u-tokyo.ac.jp\n [133.11.54.205]) (authenticated bits=0)\n by www3579.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 63NDtV0M080520\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Thu, 23 Apr 2026 22:55:32 +0900 (JST)\n (envelope-from odaki@rsg.ci.i.u-tokyo.ac.jp)"],"DKIM-Signature":"a=rsa-sha256; bh=oydcHHZwPJ6rnQhHZzNlvgB8smp76GOsqhnu1TBs65U=;\n c=relaxed/relaxed; d=rsg.ci.i.u-tokyo.ac.jp;\n h=From:Message-Id:To:Subject:Date;\n s=rs20250326; t=1776952532; v=1;\n b=SplkzpvccfgF2rrjSYeFv3wooJTOzNAiA+rJGoc4weoj85i4ugTavO44LL3zCEbR\n 558HrWBAGUSMkbyh2yIFXdxcWtkiB0F2EJiWK1tNk+wQJPdHn0HjzA3QHuGVJc2S\n SYC5pi2xbd2FF8j5NkBK+IvQm571kk+GtgHpcOpC5UuNJ04IlJCAqvoMjZmyzOse\n BQbdzpEAOXwS36H7Ed/j8mmmLTFBQ3NHaAOhZql3qs5VV4CfyZ2fNhJCelwoYcpn\n Fe6QqciMfjslERxRe5ye9iVoakDGs+H7WKgOdtCiDOcLvqv7ubEidy2dplriF5Yn\n VYD2V15nQYg08FSdRRVIog==","From":"Akihiko Odaki ","Date":"Thu, 23 Apr 2026 22:55:21 +0900","Subject":"[PATCH 1/3] audio: Avoid unsigned sample wraparound","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260423-audio-v1-1-e1d6b65c76f9@rsg.ci.i.u-tokyo.ac.jp>","References":"<20260423-audio-v1-0-e1d6b65c76f9@rsg.ci.i.u-tokyo.ac.jp>","In-Reply-To":"<20260423-audio-v1-0-e1d6b65c76f9@rsg.ci.i.u-tokyo.ac.jp>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Akihiko Odaki ","X-Mailer":"b4 0.16-dev-16047","Received-SPF":"pass client-ip=49.212.243.89;\n envelope-from=odaki@rsg.ci.i.u-tokyo.ac.jp; helo=www3579.sakura.ne.jp","X-Spam_score_int":"-16","X-Spam_score":"-1.7","X-Spam_bar":"-","X-Spam_report":"(-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,\n DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When !defined(SIGNED), nv - HALF will wrap around if nv < HALF because\nnv and HALF are unsigned. Fix it by casting nv to mixeng_real, which is\nsigned.\n\nSigned-off-by: Akihiko Odaki \n---\n audio/mixeng_template.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/audio/mixeng_template.h b/audio/mixeng_template.h\nindex bc8509e423f6..881653c44bfb 100644\n--- a/audio/mixeng_template.h\n+++ b/audio/mixeng_template.h\n@@ -43,13 +43,13 @@ static inline mixeng_real glue (conv_, ET) (IN_T v)\n #ifdef SIGNED\n return nv * (2.f / ((mixeng_real)IN_MAX - IN_MIN));\n #else\n- return (nv - HALF) * (2.f / (mixeng_real)IN_MAX);\n+ return ((mixeng_real)nv - HALF) * (2.f / (mixeng_real)IN_MAX);\n #endif\n #else /* !RECIPROCAL */\n #ifdef SIGNED\n return nv / (((mixeng_real)IN_MAX - IN_MIN) / 2.f);\n #else\n- return (nv - HALF) / ((mixeng_real)IN_MAX / 2.f);\n+ return ((mixeng_real)nv - HALF) / ((mixeng_real)IN_MAX / 2.f);\n #endif\n #endif\n }\n","prefixes":["1/3"]}