{"id":2227301,"url":"http://patchwork.ozlabs.org/api/patches/2227301/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260423115550.444930-7-luca.ceresoli@bootlin.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423115550.444930-7-luca.ceresoli@bootlin.com>","list_archive_url":null,"date":"2026-04-23T11:55:50","name":"[v2,41/41] drm: renesas: shmobile: remove now-redundant call to drm_connector_attach_encoder()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a3e6fe8f6b0c50efd3b56ec91113870557008169","submitter":{"id":83908,"url":"http://patchwork.ozlabs.org/api/people/83908/?format=json","name":"Luca Ceresoli","email":"luca.ceresoli@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260423115550.444930-7-luca.ceresoli@bootlin.com/mbox/","series":[{"id":501167,"url":"http://patchwork.ozlabs.org/api/series/501167/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=501167","date":"2026-04-23T09:16:54","name":"drm/display: bridge-connector: attach encoder to the connector","version":2,"mbox":"http://patchwork.ozlabs.org/series/501167/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227301/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227301/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=WlStTxqG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13911-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=\"WlStTxqG\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.246.85.4","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bootlin.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1ZZ43rX9z1yCv\n\tfor ; Thu, 23 Apr 2026 22:06:20 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 04AA6302D08E\n\tfor ; Thu, 23 Apr 2026 11:59:31 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B58BD3EB815;\n\tThu, 23 Apr 2026 11:59:30 +0000 (UTC)","from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D81313EB813\n\tfor ; Thu, 23 Apr 2026 11:59:28 +0000 (UTC)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id 9B8784E42ACB;\n\tThu, 23 Apr 2026 11:59:27 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 69D61604EB;\n\tThu, 23 Apr 2026 11:59:27 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 5309B10460BF2;\n\tThu, 23 Apr 2026 13:59:09 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776945570; cv=none;\n b=YSB3kXRPoZMJVJlY7BCmGkyXk6/6XkSvvpmHf3jFQoVaTphxo090cjb75zGBqxtYd11IuElJbPFoJONa50Jxb/YjhTL5ChZNB1Jr49GNSQZzO6m84UMF5LeOLVE5hdo+lQG79+2gC4FgpRiiLM4Gx5Go87K58+lPc4LTgxrZuSk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776945570; c=relaxed/simple;\n\tbh=r400RnvBBwtf4yjnHfB5HfGRVqz7s/s46rjjt3dq68I=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=AO3SxlFRPAgdZwraW6ZS/cuTsBELMMFUOfm43CQejNjUEqGiDkD8mh8INyc3lepEDHOEjkGrx44nUjHIOQDbTv9CBSEDkPE12Njw/pr0oPqTZBHPJR2HHaGa7rr4kgGwISoRj5rG/LKS0TTIWEyJZio+OpDJ8wQpThnHd98AxI8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n spf=pass smtp.mailfrom=bootlin.com;\n dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=WlStTxqG; arc=none smtp.client-ip=185.246.85.4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1776945564; h=from:subject:date:message-id:to:cc:mime-version:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=0cIzziXQXBlswI5he/Z1p9UVN9gXfIafkur4yQLuNKM=;\n\tb=WlStTxqGzva9+UFSYhFfXw4/eyvnNhgwpre83ebDV7irThXx3jpNRYnWO16QrVNcMMUvPa\n\tFtqvwIEFzz1tDTi3nQMemL7s2ni2N5ABm2DKLe/xjA9s9AGh/vfXXFmQ+Ix5neYQpUggUE\n\tZkZ21Yrus5l3d9xGjFkYkOvTZpps9BvhfTY2TQgvgGgOjnl7ZVfUyrQEb88q3IfxCsNhlP\n\tOFyLzhp9rcJGWmKKtalqgU7Zg963yUOKfMu+Yf0/VXh1SnUEd9dPdKa1GHuQ5iAzalT8L2\n\tgWTTR+Ma0QEQnp454zzEqKiIy5BYmW0LpXZy4mqze37S9YM/iIdSVAQFxUomwQ==","From":"Luca Ceresoli ","To":"Andrzej Hajda ,\n Neil Armstrong , Robert Foss ,\n Laurent Pinchart ,\n Jonas Karlman , Jernej Skrabec ,\n Maarten Lankhorst ,\n Maxime Ripard , Thomas Zimmermann ,\n David Airlie , Simona Vetter ,\n Sasha Finkelstein , Janne Grunau ,\n Liu Ying , Douglas Anderson ,\n Laurentiu Palcu ,\n Lucas Stach , Frank Li ,\n Sascha Hauer ,\n Pengutronix Kernel Team ,\n Fabio Estevam , Philipp Zabel ,\n Paul Cercueil ,\n Anitha Chrisanthus ,\n Chun-Kuang Hu ,\n Matthias Brugger ,\n AngeloGioacchino Del Regno ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Rob Clark ,\n Dmitry Baryshkov , Abhinav Kumar ,\n Jessica Zhang , Sean Paul ,\n Marijn Suijten ,\n Tomi Valkeinen ,\n Sandy Huang ,\n =?utf-8?q?Heiko_St=C3=BCbner?= ,\n Andy Yan ,\n Thierry Reding ,\n Mikko Perttunen ,\n Jonathan Hunter ,\n Icenowy Zheng , Jingoo Han ,\n Inki Dae , Seung-Woo Kim ,\n Kyungmin Park ,\n Krzysztof Kozlowski , Alim Akhtar ,\n Laurent Pinchart ,\n Tomi Valkeinen ,\n Kieran Bingham ,\n Geert Uytterhoeven ,\n Magnus Damm , Biju Das ,\n Marek Vasut , Stefan Agner ,\n Jyri Sarha , Michal Simek ","Cc":"Hui Pu ,\n\tIan Ray ,\n\tThomas Petazzoni ,\n\tdri-devel@lists.freedesktop.org,\n\tlinux-kernel@vger.kernel.org,\n\tasahi@lists.linux.dev,\n\timx@lists.linux.dev,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-mips@vger.kernel.org,\n\tlinux-mediatek@lists.infradead.org,\n\tlinux-amlogic@lists.infradead.org,\n\tlinux-arm-msm@vger.kernel.org,\n\tfreedreno@lists.freedesktop.org,\n\tlinux-rockchip@lists.infradead.org,\n\tlinux-tegra@vger.kernel.org,\n\tlinux-samsung-soc@vger.kernel.org,\n\tlinux-renesas-soc@vger.kernel.org,\n\tLuca Ceresoli ","Subject":"[PATCH v2 41/41] drm: renesas: shmobile: remove now-redundant call to\n drm_connector_attach_encoder()","Date":"Thu, 23 Apr 2026 13:55:50 +0200","Message-ID":"<20260423115550.444930-7-luca.ceresoli@bootlin.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"\n <20260423-drm-bridge-connector-attach_encoder-v2-0-2ae6ca69b390@bootlin.com>","References":"\n <20260423-drm-bridge-connector-attach_encoder-v2-0-2ae6ca69b390@bootlin.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Last-TLS-Session-Version":"TLSv1.3"},"content":"shmob_drm_connector_create() can init the connector in two ways, based on\nthe 'if (sdev->pdata)':\n\n 1. manually in shmob_drm_connector_create(), or\n 2. delegating to drm_bridge_connector_init()\n\nWhichever branch is taken, drm_connector_attach_encoder() is called\nimmediately after to attach the connector to the encoder.\n\nNow drm_bridge_connector_init() calls drm_connector_attach_encoder() on the\nconnector so it is not needed anymore in case 2 and should be removed, but\nit is still needed in case 1. Move drm_connector_attach_encoder() from the\ncommon path to inside shmob_drm_connector_create() in order to get back to\na single drm_connector_attach_encoder() in both cases.\n\nSigned-off-by: Luca Ceresoli \n\n---\n\nChanges in v2:\n- rewrote completely, fixing potential ERR_PTR deref and ending up with\n a cleaner patch\n- also wrote more extensive commit message\n---\n .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 16 +++++++---------\n 1 file changed, 7 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c\nindex 5f460b38596c..815c770147ed 100644\n--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c\n+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c\n@@ -583,6 +583,13 @@ shmob_drm_connector_init(struct shmob_drm_device *sdev,\n \n \tdrm_connector_helper_add(connector, &connector_helper_funcs);\n \n+\tret = drm_connector_attach_encoder(connector, encoder);\n+\tif (ret < 0) {\n+\t\tdrm_connector_cleanup(connector);\n+\t\tkfree(scon);\n+\t\treturn ERR_PTR(ret);\n+\t}\n+\n \treturn connector;\n }\n \n@@ -594,7 +601,6 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev,\n \t\t\t struct drm_encoder *encoder)\n {\n \tstruct drm_connector *connector;\n-\tint ret;\n \n \tif (sdev->pdata)\n \t\tconnector = shmob_drm_connector_init(sdev, encoder);\n@@ -606,17 +612,9 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev,\n \t\treturn PTR_ERR(connector);\n \t}\n \n-\tret = drm_connector_attach_encoder(connector, encoder);\n-\tif (ret < 0)\n-\t\tgoto error;\n-\n \tconnector->dpms = DRM_MODE_DPMS_OFF;\n \n \tsdev->connector = connector;\n \n \treturn 0;\n-\n-error:\n-\tdrm_connector_cleanup(connector);\n-\treturn ret;\n }\n","prefixes":["v2","41/41"]}