{"id":2227277,"url":"http://patchwork.ozlabs.org/api/patches/2227277/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423105733.113046-2-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423105733.113046-2-armenon@redhat.com>","list_archive_url":null,"date":"2026-04-23T10:57:32","name":"[v4,1/2] migration/vmstate: Add VMState support for GByteArray","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"faeb17f4e7112c4d4f53bff94f239940fa249e7c","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423105733.113046-2-armenon@redhat.com/mbox/","series":[{"id":501181,"url":"http://patchwork.ozlabs.org/api/series/501181/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501181","date":"2026-04-23T10:57:32","name":"migration/vmstate: Add VMState support to safely migrate GByteArray","version":4,"mbox":"http://patchwork.ozlabs.org/series/501181/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227277/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227277/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ItDA64MI;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=rUhGkSzx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Y3q1QY3z1yHy\n\tfor ; Thu, 23 Apr 2026 20:58:29 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFrkp-0000rh-OK; Thu, 23 Apr 2026 06:57:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFrkn-0000r4-Qt\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:57:53 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFrkm-00050g-9R\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:57:53 -0400","from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-190-RCOdMmBONy6SjVUwxidOFw-1; Thu, 23 Apr 2026 06:57:50 -0400","by mail-pj1-f71.google.com with SMTP id\n 98e67ed59e1d1-35fbb5779e8so7516517a91.3\n for ; Thu, 23 Apr 2026 03:57:50 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.230])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-36140fc575bsm19835240a91.4.2026.04.23.03.57.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 03:57:48 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776941871;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7eIb8iAvGQk4TDjBMbdfb7Iw7V4QRw3ih4nqSU+64iY=;\n b=ItDA64MIcFACZGjxQtIK3lCpE7Qy4sDQDfsjPmWtIpzfK2dDZOZGpNuR1CTr89xlrpr21i\n f6dMdRjJLXJOB5hAUlDRdaLamG+Zsoz0E7yQVG+a6aK/UpmRl2FqZ5Vw7O10oRIIlKF0yA\n h3ho7Uiz9ZxQr3BXyL83zVpjnSRQFaM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776941869; x=1777546669; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7eIb8iAvGQk4TDjBMbdfb7Iw7V4QRw3ih4nqSU+64iY=;\n b=rUhGkSzx1LZArCeab0CIXP6uaWI9DtAou7dwQmNXSnwoKm1ryPFiMTSvXaXcLn2Al3\n 7NSY0iprYL81l41JNFFzJul/+f/FThHc4ZPJ5Jm8/ECw/kZseXcCbjHc5AzmFFE/7zWG\n GVPIQeGHC5BxQyhoUPqlMXIvV/Oj3k8X6P0co/CYQtYN/tePpy0gmIA9oehGUBdNhFT5\n 82Skv6khmYDASda/8UWhERlC5LSEkkAxYD4R//LCJooRN/var+rAjNuliLnQIQ/2vDpf\n giT7gI6ffLAQTXWoryP+jvSoKd1gy4CsyHPXIdk0Gg3ZRq8vq6k2ZVyebu03s1Mcap0b\n H+gQ=="],"X-MC-Unique":"RCOdMmBONy6SjVUwxidOFw-1","X-Mimecast-MFC-AGG-ID":"RCOdMmBONy6SjVUwxidOFw_1776941869","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776941869; x=1777546669;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7eIb8iAvGQk4TDjBMbdfb7Iw7V4QRw3ih4nqSU+64iY=;\n b=DBtStqIJXbp22EQmgML0KGfYdqOcJsrqrkXGnPRdgkj+pMyowLgJtiDGKcj+WjMfIL\n 8DfzrgN8VxO3o9diJK4MsQmt6idJn1niCS3ZXn8/FmeeuoA3TMM25HDyqTpSI6Ay0jz/\n 9WmPCebKxiLkOULR/Xr0nFStq8sw2jPq3cDJAT5mzEfXFOlVMDdYAhFw8hMfPDgag81h\n qKv5phgP2SL0MU8z84CNYk37qceHWCt0Vhx2ths3kPGuHGHruzkLf/hNWyEMPvNVqGVv\n vJzTzAJtRWMOvxaWzRjH1WzBrLob7eYm1QKlsW692j1VmU81saC/pOg1xlL0Rsb0RTNA\n z2iA==","X-Gm-Message-State":"AOJu0Yy+oTvDdnbHihmmzo4C/dnfiEsUj6fV4t6SYu5SEJ/iE2iJKXHz\n GiSJeRKcOlVFQvbcPW7CBe4rTw1VDdlPHwy8nnnruuSX4Vu+U5+/7yomYZo2mp8/3GxCt4td/EZ\n PRqwxzS03xnBi6CL/VfdnEc/xTEKzLaJWZ7aZhYGSKb16uEtIrWw0SN+CT3wBwwzbooVMeyQuLA\n Vv+0p6rhVlGaJd2mBqbkyfNaRYZn8aiKAkgqY3KVA=","X-Gm-Gg":"AeBDievhYeWW1huK1qTuKGYLmny2m778cWqjQ53AU5pQmKH9a9B0CR5SUFAURAxVflX\n zXuXEJM9BeDBOLhE7ylGWDoyrTvFlv45wOmQI+aBdqA0BcFXASTHyCyVuNNta6dreLQNE0MJ0JJ\n i09T7AZJs1h2YMuSnBg1FD7bb22mez2TrxGHlta0Wyr5ISZcoGrR9rXJjdX2Jh8gwWW4ms5uINO\n Vz7RGxDGAEvsD8WIOD9qYFujOaUJLtfVn/SxQsU/89AxRdqr+/XpEkXHc7MFL8STRXHfIdsyhbD\n tx3jUh4EbnX/P1L0fDqrmKeOL/A8XRd/kAGiSiwV4uGlB2H916tJ4OcXim16DTLZTYT9KH/zx9q\n CryDAgP975sxM+OJx2xMRooKxgpiWejYQo4bTy7TcMyFPSHRs6A5Yt2xNU+6D6qn2N1mj0yOuNg\n ==","X-Received":["by 2002:a17:90a:da8c:b0:35e:3afb:a3ff with SMTP id\n 98e67ed59e1d1-361403cbd7cmr27149010a91.3.1776941869025;\n Thu, 23 Apr 2026 03:57:49 -0700 (PDT)","by 2002:a17:90a:da8c:b0:35e:3afb:a3ff with SMTP id\n 98e67ed59e1d1-361403cbd7cmr27148978a91.3.1776941868443;\n Thu, 23 Apr 2026 03:57:48 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Fabiano Rosas ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Arun Menon ","Subject":"[PATCH v4 1/2] migration/vmstate: Add VMState support for GByteArray","Date":"Thu, 23 Apr 2026 16:27:32 +0530","Message-ID":"<20260423105733.113046-2-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423105733.113046-1-armenon@redhat.com>","References":"<20260423105733.113046-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\nIn GLib, GByteArray is an object managed by the library. Currently,\nmigrating a GByteArray requires treating it as a raw C struct and using\nVMSTATE_VBUFFER_ALLOC_UINT32. For example, see vmstate_vdba in\nui/vdagent.c\n\nQEMU cannot pretend that GByteArray is a C struct and simply use\nVMS_ALLOC to g_malloc() the buffer. This is because, VMS_ALLOC blindly\noverwrites the data pointer with a newly allocated buffer, thereby\nleaking the previous memory. Besides, GLib tracks the array's capacity\nin a hidden alloc field. Bypassing GLib APIs leave this capacity out of\nsync with the newly allocated buffer, potentially leading to heap buffer\noverflows during subsequent g_byte_array_append() calls.\n\nThis commit introduces VMSTATE_GBYTEARRAY which uses specific library\nAPI calls (g_byte_array_set_size()) to safely resize and populate the\nbuffer.\n\nSigned-off-by: Arun Menon \nSuggested-by: Marc-André Lureau \nReviewed-by: Marc-André Lureau \nReviewed-by: Peter Xu \n---\n include/migration/vmstate.h | 10 ++++++++++\n migration/vmstate-types.c | 28 ++++++++++++++++++++++++++++\n 2 files changed, 38 insertions(+)","diff":"diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex 62c2abd0c4..f503a40ec0 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -265,6 +265,7 @@ extern const VMStateInfo vmstate_info_bitmap;\n extern const VMStateInfo vmstate_info_qtailq;\n extern const VMStateInfo vmstate_info_gtree;\n extern const VMStateInfo vmstate_info_qlist;\n+extern const VMStateInfo vmstate_info_g_byte_array;\n \n #define type_check_2darray(t1,t2,n,m) ((t1(*)[n][m])0 - (t2*)0)\n /*\n@@ -892,6 +893,15 @@ extern const VMStateInfo vmstate_info_qlist;\n .start = offsetof(_type, _next), \\\n }\n \n+#define VMSTATE_GBYTEARRAY(_field, _state, _version) { \\\n+ .name = (stringify(_field)), \\\n+ .version_id = (_version), \\\n+ .size = sizeof(GByteArray), \\\n+ .info = &vmstate_info_g_byte_array, \\\n+ .flags = VMS_SINGLE, \\\n+ .offset = vmstate_offset_pointer(_state, _field, GByteArray), \\\n+}\n+\n /* _f : field name\n _f_n : num of elements field_name\n _n : num of elements\ndiff --git a/migration/vmstate-types.c b/migration/vmstate-types.c\nindex 89cb211472..b05d65d31e 100644\n--- a/migration/vmstate-types.c\n+++ b/migration/vmstate-types.c\n@@ -942,3 +942,31 @@ const VMStateInfo vmstate_info_qlist = {\n .get = get_qlist,\n .put = put_qlist,\n };\n+\n+static int get_g_byte_array(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field)\n+{\n+ GByteArray *byte_array = *(GByteArray **)pv;\n+ uint32_t len = qemu_get_be32(f);\n+\n+ g_byte_array_set_size(byte_array, len);\n+ qemu_get_buffer(f, byte_array->data, len);\n+ return 0;\n+}\n+\n+static int put_g_byte_array(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field, JSONWriter *vmdesc)\n+{\n+ GByteArray *byte_array = *(GByteArray **)pv;\n+\n+ qemu_put_be32(f, byte_array->len);\n+ qemu_put_buffer(f, byte_array->data, byte_array->len);\n+\n+ return 0;\n+}\n+\n+const VMStateInfo vmstate_info_g_byte_array = {\n+ .name = \"GByteArray\",\n+ .get = get_g_byte_array,\n+ .put = put_g_byte_array,\n+};\n","prefixes":["v4","1/2"]}