{"id":2227242,"url":"http://patchwork.ozlabs.org/api/patches/2227242/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423100612.27278-10-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423100612.27278-10-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-23T10:06:12","name":"[9/9] target/microblaze: Compile translate.c as common unit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7fb8331906e0257dbf4ab7f222b129129a8268cf","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423100612.27278-10-philmd@linaro.org/mbox/","series":[{"id":501173,"url":"http://patchwork.ozlabs.org/api/series/501173/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501173","date":"2026-04-23T10:06:03","name":"target/microblaze: Compile it once","version":1,"mbox":"http://patchwork.ozlabs.org/series/501173/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227242/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227242/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=osBPhgJ0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1X0S6QC9z1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 20:10:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFqyJ-00075S-Oz; Thu, 23 Apr 2026 06:07:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFqxw-0006w7-9O\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:07:27 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFqxr-0004Cz-SZ\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:07:24 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so52260335e9.2\n for <qemu-devel@nongnu.org>; Thu, 23 Apr 2026 03:07:19 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a18csm59413914f8f.20.2026.04.23.03.07.16\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 23 Apr 2026 03:07:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776938838; x=1777543638; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pAUwrUFoNwCxotOSaRCj0lyhRhgtkP0+vfDbYmh5aNM=;\n b=osBPhgJ0jG3p6e1JDfL8P0oOziYLdt/z3qwpC+hWiccKt9c9fDBNcB5C2zIWEAWi/+\n kDKehO74LEM34v1dB52U0TeKqdax0xg9HNqWKd7L7/xDZ7y/AslU2/V3rwbC5PI8qX6U\n 4A4laXJup5UkX92ezWjrvsG+MUZg9tkeqUaFh7Fk0mlkQ/TFz1LIx1ED/wunrliE6qZQ\n tIsTJuHw7+DRXrFCyoIRWlQJJOC8Yq9NqIu+S7+jg7VyfpCI6+I42GMnMrWh3wtfE6Jf\n IBmumqXWnvOYGtyJ3rRwNGb/ZjInPEeyYl6dp+vcQDhXxHieylPKvzhbLHPildzmQzNO\n RfSw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776938838; x=1777543638;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pAUwrUFoNwCxotOSaRCj0lyhRhgtkP0+vfDbYmh5aNM=;\n b=FhBWYlhyPMC9l04MFe49jH77zu75EpyJX8yq92m/J/fGtDQu5nAmQDs2e54RWAfjKN\n RRUv6bjgMb2rdcAXZN+VlBosd6D+gdXrjUe7jr0IIEGoReAz6PibCtGyQEYKmIC7iYw6\n jb+YhXa5Nut+xLbhZ+UtRpVueExe7JbiUOKY4vjkDLP6HIEnntvKhE6c/hamMKUN6EIw\n Sh1yecjqYxvhsGdt4OiqaD9xa6nDzeIe66ckyHwFIsAkNXnaGjDY2sX/3ni32XPIQncl\n 35CdA8oIc6dEvF5YhEuk6XpjfsF8Zxj3kKlqUtYAucnjzgtPd7m1PjRFG7ywC784y++j\n xfjw==","X-Gm-Message-State":"AOJu0YwxDC+N/BYDw3DF0CF2kNIzOWIWkaj1t7rlPEtK/IraREN/8Ksy\n f5WvUDdrrBHxlIRe8h6rHCkOWzADxQeBMyXoJ/q4X4rTwYDcx3EuWrmo41lo2IHs0WQE+UeagDT\n MPhpR1Sk=","X-Gm-Gg":"AeBDiesBtVIZ+EBM5hMxVb5V6ZDtbT4au7yClOSepUIMwwcIHs/ms/PY3b39Mp8COxG\n kgY25OvuvRmZq2w+wB0HXFl9NZAun9qiZpnAh0yQJtJAhtkdO5ErELdemWT/dNUJMu3yMMIcy4J\n TTZRhXBWHCl53WXEQ+/FuoUd0xgPl12b2AAEH8S9A7mb1ElTFnBIvb5iVHW/UvS49dFoAjGRIky\n Ws+bPYfxkPuQ+yDciu3DpHSbojQUh0EbSf4i6V7E58dGgkDpqzqINXDvFYl39880+mZmmg/ozzX\n nojmcGFoECh4FTjH0Z7l3m7RP2gsGN1AyAx75bhqdOrsF9rI/G7gf+8BX/QvSJFxGGpILs1uESB\n 3B+BFwBSbizVfymJklxBxjGyagTP1CaXBaxYDNBJxWLK59GglKFkZZe9UNxukx0CVKspeCA/ZZO\n MuxYK+6nnmMrW2JmqS+V5i1GvA+S6o9Lq+YTeZlE6Z1GS8ElARt4qtK3QTPB0cod3XYqB3SnUK5\n CKZlz7j7nA=","X-Received":"by 2002:a05:600c:3483:b0:488:af7f:775f with SMTP id\n 5b1f17b1804b1-488fb77d343mr354888205e9.18.1776938837685;\n Thu, 23 Apr 2026 03:07:17 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n Anton Johansson <anjo@rev.ng>,\n Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= <philmd@linaro.org>","Subject":"[PATCH 9/9] target/microblaze: Compile translate.c as common unit","Date":"Thu, 23 Apr 2026 12:06:12 +0200","Message-ID":"<20260423100612.27278-10-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423100612.27278-1-philmd@linaro.org>","References":"<20260423100612.27278-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In order do build translate.c as a common unit we need to\nreplace:\n\n  \"accel/tcg/cpu-ldst.h\" -> \"accel/tcg/cpu-ldst-common.h\"\n\nand:\n\n  #include \"tcg/tcg-op.h\" -> #include \"tcg/tcg-op-common.h\"\n                          -> #include \"tcg/tcg-op-mem.h\"\n\ntaking care to define TCG_ADDRESS_BITS, which is fixed\nfor these 32-bit targets.\n\nRemove the now empty microblaze_ss[] source set.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n target/microblaze/translate.c | 6 ++++--\n target/microblaze/meson.build | 7 +------\n 2 files changed, 5 insertions(+), 8 deletions(-)","diff":"diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c\nindex 6321b739ab4..f973c392aa2 100644\n--- a/target/microblaze/translate.c\n+++ b/target/microblaze/translate.c\n@@ -20,9 +20,11 @@\n \n #include \"qemu/osdep.h\"\n #include \"cpu.h\"\n-#include \"accel/tcg/cpu-ldst.h\"\n+#include \"accel/tcg/cpu-ldst-common.h\"\n #include \"accel/tcg/cpu-mmu-index.h\"\n-#include \"tcg/tcg-op.h\"\n+#define TCG_ADDRESS_BITS 32\n+#include \"tcg/tcg-op-common.h\"\n+#include \"tcg/tcg-op-mem.h\"\n #include \"exec/helper-proto.h\"\n #include \"exec/helper-gen.h\"\n #include \"exec/translator.h\"\ndiff --git a/target/microblaze/meson.build b/target/microblaze/meson.build\nindex 2ce50f35397..9c1ecd1cf1c 100644\n--- a/target/microblaze/meson.build\n+++ b/target/microblaze/meson.build\n@@ -1,16 +1,12 @@\n gen = decodetree.process('insns.decode')\n \n microblaze_common_ss = ss.source_set()\n+microblaze_common_ss.add(gen)\n microblaze_common_ss.add(files(\n   'cpu.c',\n   'gdbstub.c',\n   'helper.c',\n   'op_helper.c',\n-))\n-\n-microblaze_ss = ss.source_set()\n-microblaze_ss.add(gen)\n-microblaze_ss.add(files(\n   'translate.c',\n ))\n \n@@ -26,7 +22,6 @@ microblaze_system_ss.add(files(\n   'machine.c',\n ))\n \n-target_arch += {'microblaze': microblaze_ss}\n target_user_arch += {'microblaze': microblaze_user_ss}\n target_system_arch += {'microblaze': microblaze_system_ss}\n target_common_system_arch += {'microblaze': microblaze_common_system_ss}\n","prefixes":["9/9"]}