{"id":2227240,"url":"http://patchwork.ozlabs.org/api/patches/2227240/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423100612.27278-3-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423100612.27278-3-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-23T10:06:05","name":"[2/9] target/microblaze: Fix endianness used to disassemble","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"24cba13b7f0a2f3386d9ad891b867f12ef0bf8ad","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423100612.27278-3-philmd@linaro.org/mbox/","series":[{"id":501173,"url":"http://patchwork.ozlabs.org/api/series/501173/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501173","date":"2026-04-23T10:06:03","name":"target/microblaze: Compile it once","version":1,"mbox":"http://patchwork.ozlabs.org/series/501173/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227240/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227240/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CWOks+b1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1X0H4Lkfz1yCv\n\tfor ; Thu, 23 Apr 2026 20:10:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFqxE-0003pK-Po; Thu, 23 Apr 2026 06:06:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFqxC-0003Zs-40\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:06:38 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFqx7-0003vH-01\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:06:37 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-4891e86fabeso58798405e9.1\n for ; Thu, 23 Apr 2026 03:06:31 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a4b329542sm414784785e9.3.2026.04.23.03.06.27\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 23 Apr 2026 03:06:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776938789; x=1777543589; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NmMMDDayaPVt7OLJ+0hEHgEDaFx6/LPi13R0NCJedJY=;\n b=CWOks+b1Geu7IjXWAOjkTE7KewUCmBlu8qdBoV0t9zLGu88gd/VoFZp8LZBWzrqo9B\n NhVOutWY+mIjxQg4kF4O0kw6mrE0bc0IQ9SdtOfhireuBow2aUNT9UKIR5OvhlH3mQPj\n 4qBUhNEb1byz1dKC2PDX8rOhLr6G4CpmdwJVg5R9KN0Q+avlQuUa1qj1L/QqjVioTNtF\n Yh+nLn/e/dJ+oujLTlX6evoHNnNp0ikDdChTvYjPbZrnyZpvUlvkNgVxqAeouJbWSGXv\n e6SG4MA7ks1BfWyhaqGrnr1697T9QF5N64BInQW0DIjUEpI/FMmdvr/ARKrnPKGzjCwS\n oQZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776938789; x=1777543589;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=NmMMDDayaPVt7OLJ+0hEHgEDaFx6/LPi13R0NCJedJY=;\n b=XUM2wJ8WTcs2OYW6s+pDqaOfoDaNb8L8tb81N5ue13b/IvXZCOu7fHcPVJ5hsJMiST\n VjJblLXb0jUp/ZIv1MbmfiGVFfoBNUbDqXEecDlQ10Wc0VH/8CG6C381WZp04BE53j/c\n VSEB1MjZN14xKQ5pwifFFb2fVTQh05dzZ5oWqupXI0KPuv/bB4rcONwBl/eiOFbpwc33\n 3t1h11kY729fLbD42wVpQzS/HbMC/z/SruI1YZnm8OYpae6MyXPjPI31zk8KZwe4VSEY\n iyH9kU81trPlwtos+kIe+uDAH6MOiAlzgf8cP5EgnhV8DKFyNzVJi39R5e/OBsd/mcge\n 8TEQ==","X-Gm-Message-State":"AOJu0YyLLrNULij1kup3ukrNOFNUF7wXsKAcYeFDIyzuEFs69cAD8dtY\n WrFV37V9Sf1GeVEosfeYvO42gHOFbsIK9Bdj5tCOPGx9srsN3DKAmy7MznUVlSP/k1I2lKUsDJZ\n c0toIgNk=","X-Gm-Gg":"AeBDieumr3idPLMt0fVxzxXmm6hEIe0RRhFq1kIO751VxU1eUL6jVhQHGYEHCAHtqD+\n D0eD62+xe/fHAayr3glI/PxU5jUC7jxXYqpidpz2pdOjBKw7KGC46Eyq5MLmAx2o3W+pyTOFg5e\n 1ddoOkB55oJ+Z/hcGGvmkcQ719R0rjIMUZ6TvD3wtZgTiux3+LPX0SPiMBkvZGBo1gwoqiGZqvk\n d3RD1RK1POrorhFtFXJ8KyLZ31ybxJ2n+O8mO46B1EyCXadaSWPpRcsGAcr91Pq3YrumD2l7Rmq\n 1WRKRX9rRN+ok2rFKW54q66/lHW1wldBZGxLqMoVJ65ZbEs18eP/4wBtrUSZDK+0zK+qa4dD81u\n nYp5qw1Y8w+ehp5LnWZ044h11W502pf+lk8mv5OZi+cjGbqmuvHKNeEG7B/thGMDqddnj8enHL6\n NFqTAUjbesUHlV4NyRL2Q69ByXOKcqCcHOS5jMUxWUkW61uvk6GnJKsdZBrRwIiLOnadEz99zGd\n VVhaTTSJ3M=","X-Received":"by 2002:a05:600c:1e28:b0:483:7903:c3b1 with SMTP id\n 5b1f17b1804b1-488fb77fbf3mr374208715e9.20.1776938788818;\n Thu, 23 Apr 2026 03:06:28 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"\"Edgar E. Iglesias\" ,\n Pierrick Bouvier ,\n Anton Johansson ,\n Richard Henderson , =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= , qemu-stable@nongnu.org","Subject":"[PATCH 2/9] target/microblaze: Fix endianness used to disassemble","Date":"Thu, 23 Apr 2026 12:06:05 +0200","Message-ID":"<20260423100612.27278-3-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423100612.27278-1-philmd@linaro.org>","References":"<20260423100612.27278-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"MicroBlaze CPU model has a \"little-endian\" property, pointing to\nthe @endi internal field. Commit c36ec3a9655 (\"hw/microblaze:\nExplicit CPU endianness\") took care of having all MicroBlaze\nboards with an explicit default endianness (similarly with\ncommit 91fc6d8101d for linux-user binaries), so later commit\n415aae543ed (\"target/microblaze: Consider endianness while\ntranslating code\") could infer the endianness at runtime from\nthe @endi field, and not a compile time via the TARGET_BIG_ENDIAN\ndefinition. Doing so, we forgot to propagate that runtime change\nto the disassemble_info structure. Do it now to display the\nopcodes in correct endianness order.\n\nCc: qemu-stable@nongnu.org\nFixes: 415aae543ed (\"target/microblaze: Consider endianness while translating code\")\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/microblaze/cpu.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c\nindex ec513ae82d4..639f46b525e 100644\n--- a/target/microblaze/cpu.c\n+++ b/target/microblaze/cpu.c\n@@ -237,8 +237,8 @@ static void mb_disas_set_info(const CPUState *cpu, disassemble_info *info)\n {\n info->mach = bfd_arch_microblaze;\n info->print_insn = print_insn_microblaze;\n- info->endian = TARGET_BIG_ENDIAN ? BFD_ENDIAN_BIG\n- : BFD_ENDIAN_LITTLE;\n+ info->endian = MICROBLAZE_CPU(cpu)->cfg.endi ? BFD_ENDIAN_LITTLE\n+ : BFD_ENDIAN_BIG;\n }\n \n static void mb_cpu_realizefn(DeviceState *dev, Error **errp)\n","prefixes":["2/9"]}