{"id":2227092,"url":"http://patchwork.ozlabs.org/api/patches/2227092/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260423084123.657690-6-pvorel@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423084123.657690-6-pvorel@suse.cz>","list_archive_url":null,"date":"2026-04-23T08:41:21","name":"[v5,5/6] lib: Merge functionality of LTP_QUIET into LTP_REPRODUCIBLE_OUTPUT","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"bf06bb14eddadc511c1d2cce0dd580659bffe35c","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/?format=json","name":"Petr Vorel","email":"pvorel@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260423084123.657690-6-pvorel@suse.cz/mbox/","series":[{"id":501162,"url":"http://patchwork.ozlabs.org/api/series/501162/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=501162","date":"2026-04-23T08:41:17","name":"lib: LTP_DEBUG cleanup","version":5,"mbox":"http://patchwork.ozlabs.org/series/501162/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227092/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2227092/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=TkCFP9wU;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=Bb660Rq5;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=TkCFP9wU;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Bb660Rq5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TkCFP9wU;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Bb660Rq5"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1V3046p2z1yCv\n\tfor ; Thu, 23 Apr 2026 18:42:36 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 89A1B3E5376\n\tfor ; Thu, 23 Apr 2026 10:42:34 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id E57A53E2D79\n for ; Thu, 23 Apr 2026 10:41:43 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 87B41600958\n for ; Thu, 23 Apr 2026 10:41:42 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 99AA26A833;\n Thu, 23 Apr 2026 08:41:35 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6290E593B0;\n Thu, 23 Apr 2026 08:41:35 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id UOWaFj/b6Wl6fgAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 08:41:35 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776933695;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9baD9gSDr7FVLUAzvlku5cy+ZyjKuhqIfpcbeBt9tdo=;\n b=TkCFP9wUXpQYgnmvQ1p83L5NkjRG8bgZe2DapKEmEFV/2iQMc5oU5cJz8zJT2rozqfXP71\n YuRZvoPBak6x8BoefhY7a4vGQtq76vZ507MC89GU/0gtKedbiVdvKSnW9mZl9Z+xMhVtuO\n CrOHRk6SyP0JFGxozMEtzLdJFcA9ygY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776933695;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9baD9gSDr7FVLUAzvlku5cy+ZyjKuhqIfpcbeBt9tdo=;\n b=Bb660Rq5xCqROf2vGN+j26CwegcxQyC3kh3cLQ2l1t6/ygHGPrGHoKPpVkPlzyFnQ7Elbz\n dc2yQJYJqvwyLwBA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776933695;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9baD9gSDr7FVLUAzvlku5cy+ZyjKuhqIfpcbeBt9tdo=;\n b=TkCFP9wUXpQYgnmvQ1p83L5NkjRG8bgZe2DapKEmEFV/2iQMc5oU5cJz8zJT2rozqfXP71\n YuRZvoPBak6x8BoefhY7a4vGQtq76vZ507MC89GU/0gtKedbiVdvKSnW9mZl9Z+xMhVtuO\n CrOHRk6SyP0JFGxozMEtzLdJFcA9ygY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776933695;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9baD9gSDr7FVLUAzvlku5cy+ZyjKuhqIfpcbeBt9tdo=;\n b=Bb660Rq5xCqROf2vGN+j26CwegcxQyC3kh3cLQ2l1t6/ygHGPrGHoKPpVkPlzyFnQ7Elbz\n dc2yQJYJqvwyLwBA=="],"From":"Petr Vorel ","To":"ltp@lists.linux.it","Date":"Thu, 23 Apr 2026 10:41:21 +0200","Message-ID":"<20260423084123.657690-6-pvorel@suse.cz>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423084123.657690-1-pvorel@suse.cz>","References":"<20260423084123.657690-1-pvorel@suse.cz>","MIME-Version":"1.0","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-1.51 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[];\n NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[];\n NEURAL_HAM_SHORT(-0.20)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[];\n TO_MATCH_ENVRCPT_ALL(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n ARC_NA(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n TO_DN_SOME(0.00)[];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n FREEMAIL_CC(0.00)[suse.cz,gmail.com,suse.com,redhat.com];\n RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:mid,suse.cz:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_FIVE(0.00)[6];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[];\n DKIM_TRACE(0.00)[suse.cz:+];\n R_RATELIMIT(0.00)[to_ip_from(RLmduujpsdff44oyku5bsyor5h)];\n FREEMAIL_ENVRCPT(0.00)[gmail.com]","X-Rspamd-Queue-Id":"99AA26A833","X-Spam-Score":"-1.51","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH v5 5/6] lib: Merge functionality of LTP_QUIET into\n LTP_REPRODUCIBLE_OUTPUT","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Martin Cermak ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"LTP_REPRODUCIBLE_OUTPUT=1 environment variable was added in 5894abc5f to\nhelp valgrind to use LTP for testing. It discards the actual content of\nthe messages printed by the test (removes everything after printing\nTINFO/TPASS/TFAIL/... flag).\n\nLater LTP_QUIET=1 was added which suppresses printing TCONF, TINFO, and\nTDEBUG messages.\n\nValgrind project uses both variables but no need to handle them\nseparately. Therefore merge functionality of LTP_QUIET into\nLTP_REPRODUCIBLE_OUTPUT.\n\nLTP_QUIET was not even documented in HTML doc.\n\nAlso fix help description, because TWARN was not skipped, although doc\nclaimed to do.\n\nImplements: https://github.com/linux-test-project/ltp/issues/1306\nSigned-off-by: Petr Vorel \n---\nChanges v4->v5:\n* Remove wrongly stated TWARN (error on code on master)\n* Fix missing new lines in help (AI)\n* Use single fprintf (Li)\n\n doc/users/setup_tests.rst | 5 +++--\n lib/tst_test.c | 16 +++++-----------\n 2 files changed, 8 insertions(+), 13 deletions(-)","diff":"diff --git a/doc/users/setup_tests.rst b/doc/users/setup_tests.rst\nindex 6f1d996e18..491a5b003a 100644\n--- a/doc/users/setup_tests.rst\n+++ b/doc/users/setup_tests.rst\n@@ -43,8 +43,9 @@ users.\n Shell language: ``TST_NEEDS_DEVICE=1``.\n \n * - LTP_REPRODUCIBLE_OUTPUT\n- - When set to ``1`` or ``y`` discards the actual content of the messages\n- printed by the test (suitable for a reproducible output).\n+ - When set to ``1`` or ``y`` uppress printing TCONF, TINFO and TDEBUG\n+ messages and discards the actual content of the other messages printed\n+ by the test (suitable for a reproducible output).\n \n * - LTP_SINGLE_FS_TYPE\n - Specifies single filesystem to run the test on instead all supported\ndiff --git a/lib/tst_test.c b/lib/tst_test.c\nindex 12f7489d4e..a0b55049ff 100644\n--- a/lib/tst_test.c\n+++ b/lib/tst_test.c\n@@ -68,7 +68,6 @@ static int iterations = 1;\n static float duration = -1;\n static float timeout_mul = -1;\n static int reproducible_output;\n-static int quiet_output;\n \n struct context {\n \tint32_t lib_pid;\n@@ -307,7 +306,7 @@ static void print_result(const char *file, const int lineno, int ttype,\n \t\tres = \"TBROK\";\n \tbreak;\n \tcase TCONF:\n-\t\tif (quiet_output)\n+\t\tif (reproducible_output)\n \t\t\treturn;\n \t\tres = \"TCONF\";\n \tbreak;\n@@ -315,12 +314,12 @@ static void print_result(const char *file, const int lineno, int ttype,\n \t\tres = \"TWARN\";\n \tbreak;\n \tcase TINFO:\n-\t\tif (quiet_output)\n+\t\tif (reproducible_output)\n \t\t\treturn;\n \t\tres = \"TINFO\";\n \tbreak;\n \tcase TDEBUG:\n-\t\tif (quiet_output)\n+\t\tif (reproducible_output)\n \t\t\treturn;\n \t\tres = \"TDEBUG\";\n \tbreak;\n@@ -676,8 +675,8 @@ static void print_help(void)\n \tfprintf(stderr, \"LTP_DEV Path to the block device to be used (for .needs_device)\\n\");\n \tfprintf(stderr, \"LTP_DEV_FS_TYPE Filesystem used for testing (default: %s)\\n\", DEFAULT_FS_TYPE);\n \tfprintf(stderr, \"LTP_DEBUG Print debug messages (set 1(y) or 2)\\n\");\n-\tfprintf(stderr, \"LTP_REPRODUCIBLE_OUTPUT Values 1 or y discard the actual content of the messages printed by the test\\n\");\n-\tfprintf(stderr, \"LTP_QUIET Values 1 or y will suppress printing TCONF, TWARN, TINFO, and TDEBUG messages\\n\");\n+\tfprintf(stderr, \"LTP_REPRODUCIBLE_OUTPUT Values 1 or y suppress printing TCONF, TINFO and TDEBUG messages and\\n\"\n+\t\t\t\" discards the actual content of all other messages\\n\");\n \tfprintf(stderr, \"LTP_SINGLE_FS_TYPE Specifies filesystem instead all supported (for .all_filesystems)\\n\");\n \tfprintf(stderr, \"LTP_FORCE_SINGLE_FS_TYPE Testing only. The same as LTP_SINGLE_FS_TYPE but ignores test skiplist.\\n\");\n \tfprintf(stderr, \"LTP_TIMEOUT_MUL Timeout multiplier (must be a number >=1)\\n\");\n@@ -1398,7 +1397,6 @@ static void do_setup(int argc, char *argv[])\n {\n \tchar *tdebug_env = getenv(\"LTP_DEBUG\");\n \tchar *reproducible_env = getenv(\"LTP_REPRODUCIBLE_OUTPUT\");\n-\tchar *quiet_env = getenv(\"LTP_QUIET\");\n \n \tif (!tst_test)\n \t\ttst_brk(TBROK, \"No tests to run\");\n@@ -1429,10 +1427,6 @@ static void do_setup(int argc, char *argv[])\n \t (!strcmp(reproducible_env, \"1\") || !strcmp(reproducible_env, \"y\")))\n \t\treproducible_output = 1;\n \n-\tif (quiet_env &&\n-\t (!strcmp(quiet_env, \"1\") || !strcmp(quiet_env, \"y\")))\n-\t\tquiet_output = 1;\n-\n \tassert_test_fn();\n \n \tTCID = tcid = get_tcid(argv);\n","prefixes":["v5","5/6"]}