{"id":2227038,"url":"http://patchwork.ozlabs.org/api/patches/2227038/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423051804.362095-10-jamin_lin@aspeedtech.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423051804.362095-10-jamin_lin@aspeedtech.com>","list_archive_url":null,"date":"2026-04-23T05:18:16","name":"[v4,09/17] hw/usb/hcd-ehci: Add property to advertise 64-bit addressing capability","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"56cf93ac9c0c41c8484476072e9714b8c45e33cb","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/people/81768/?format=json","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423051804.362095-10-jamin_lin@aspeedtech.com/mbox/","series":[{"id":501145,"url":"http://patchwork.ozlabs.org/api/series/501145/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501145","date":"2026-04-23T05:18:08","name":"hw/usb/ehci: Add 64-bit descriptor addressing support","version":4,"mbox":"http://patchwork.ozlabs.org/series/501145/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227038/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227038/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=f336Q2vI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1PYk57YGz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 15:20:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFmSO-0007XP-6n; Thu, 23 Apr 2026 01:18:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wFmSM-0007Vr-89; Thu, 23 Apr 2026 01:18:30 -0400","from mail-japaneastazlp170130007.outbound.protection.outlook.com\n ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wFmSK-0003DU-Ap; Thu, 23 Apr 2026 01:18:29 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by KUXPR06MB8534.apcprd06.prod.outlook.com (2603:1096:d10:9d::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Thu, 23 Apr\n 2026 05:18:16 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9846.021; Thu, 23 Apr 2026\n 05:18:16 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=xQsGJtzp6JfL4EZfyf80agdBG67hFhKih/UKXJIjGgzrNbEYtZWf4/PAg1xWfU5NwSK0Nqjj++koBcs/ymObNK+0TAjawvuHY0gqlegY7FK+Je1+JyIioU2ZktTH8fZbOYlo7HvQluPId0vwUuINHfoYyRdyFvFXg6Dq7aZdrpJK0EWYvZEDT1Fi1Mks4DMn0F/kh68XjETcmGpvwNhWytFJe26/cW96Hy2NnP9hhaTnFqH4t/r/5NAYTh0EITpqn4RynCmB+LrkyVACCNg2wUVUUQnYSLRQTP787RRSZ6SW2LYB2lgYBZ6FgaFsjDL22JqXJvtzLec4a0kZwxjXyg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RXoR4UdLkGjcJ3WfUu+Cs03fPTbZxQW3bPIQfbCHMKc=;\n b=gQmlKPWr1HIevPfUDP78RpYkVIQYEylVvvlgHQ5XHKQ9EfD1O2GeQV6ot3KivZ7Kh4IQbFAXLHbPgR6QdTulSZmzNY3J7CLLtOsT4HaegbpR8v1rIN4uLk26RokgASBD/K4jjmjuZPJCbX4WgXWwxSj4ryvmd1/c3Wrw7PcXH5XjsXqDEUJUT1x4zqz4jPsIo0ACrFSKnd2+/g9lJQMLivbzc3L/RRfNxr0ZzsUrht3v+zg+uJ1HAIV58nRMd1umrFxdzozs7cppSmp6SDAmU12eAn2tp4nug0nFz+mkZjWVejgK1SFKJSpNq1qwt1y3KtVvpdEqMyjUEg+dIFhv0w==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RXoR4UdLkGjcJ3WfUu+Cs03fPTbZxQW3bPIQfbCHMKc=;\n b=f336Q2vIr7EJNt7RN/conm8fWQoYn8Eyko1gLtoEzgLoe+xooDutp0NMwyxzg/RgLsysTNGNzGeWwoYFiAT0TXKyFCk+rmTmYLlMbxDjAkkjjWoaSxOlPoYV41bbpW7SJNbuTO1qJ/4JQ43SdLUq8ruo1ss3Phsbdn8fhpnmpLGxGWBXQ8bNCWfUjvxRa/9g/6ih086YrRPF5KmroLF9q6xN5Jo3mIU/Ki0FaQTpGHPYKfVBVE9diTimgvknqhG9HY4jDy40sRioCSQISfWQuq77iJpeWV6082iIeXcg3ZAPnHPNqfuBbCoM1B1cnDYF0jGOmto2swKQ2uKz8KBFiA==","From":"Jamin Lin <jamin_lin@aspeedtech.com>","To":"\"philmd@linaro.org\" <philmd@linaro.org>,\n \"peterx@redhat.com\" <peterx@redhat.com>,\n =?iso-8859-1?q?C=E9dric_Le_Goater?= <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n  Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>","CC":"Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>,\n  \"flwu@google.com\" <flwu@google.com>,\n \"nabihestefan@google.com\" <nabihestefan@google.com>,\n \"farosas@suse.de\" <farosas@suse.de>,\n =?iso-8859-1?q?C=E9dric_Le_Goater?= <clg@redhat.com>","Subject":"[PATCH v4 09/17] hw/usb/hcd-ehci: Add property to advertise 64-bit\n addressing capability","Thread-Topic":"[PATCH v4 09/17] hw/usb/hcd-ehci: Add property to advertise\n 64-bit addressing capability","Thread-Index":"AQHc0uCXaAHzE37+KEGxtHY8z15QVA==","Date":"Thu, 23 Apr 2026 05:18:16 +0000","Message-ID":"<20260423051804.362095-10-jamin_lin@aspeedtech.com>","References":"<20260423051804.362095-1-jamin_lin@aspeedtech.com>","In-Reply-To":"<20260423051804.362095-1-jamin_lin@aspeedtech.com>","Accept-Language":"zh-TW, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=f336Q2vI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|KUXPR06MB8534:EE_","x-ms-office365-filtering-correlation-id":"b4130c4b-b35d-4c6c-5c58-08dea0f7b9c7","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|38070700021|921020|18002099003|22082099003|56012099003;","x-microsoft-antispam-message-info":"\n WiS88gWLtdxCwmeG1zKXQZYvjvM0ckEAck9aQ+1Ygk6DfLpaEMmsaCclaUsKpjbgrsObgOVcTQ9M9WLXU8fGNRPwdUuudsKctKniJ8oGwVBcH52o0GT3q5M8hgV474QVgc0QVd3LFmES2A3vpY2qn+zEoIMbExJno6Dj9j6FK726AGWa4i3zrbKCkrWHOckOyWBAXOC/M89PTxwlgBVEgBA5QR1IreqmhTMoOwuV+pB17ZjKL7mOwloM6Aw5dQMXL/8H+RWJE2VEoWqUnfLOD4qZ5SXwSchg91ukZ1ezU92cogu61EPxK/nzI232aClIIbiDUS3v8o86QZCGHQnyyT3a02mNy5KPGRHDgj7MPWN/iiJgU2GiFddRfSZDKOSGk3Zl6GbCCQMdSzz/OAJj0Qqydxe92o/V7kOeQZVLMhDSha8igqzy/zx7rWxyKCN+bgqyCxoscf0KSrpKdvkGWfpSBQEErebTVtyD+HsZ0AxGkGVIAZT3T3U+Fhza3iF09sxG7/FrST1eib6kiAKwXjaRAhcjJ1NdW9SSTcHJaApdvikOctDRD9jXetjV0aSylx5ZnkagyAh0jb/M5vekt3bHdVVkKsu/H6X9+kxbgxZBkTn4O36ptuDb4+ECqSm8DHdK3ImNorCr9tZ6HHdDCJU3K5Xv98Urpv+fx8zC3p/SDNjWAaLrNHZhgrqiLAYCvb1W7c1HIR8o/CTp2ia6RxArX/AEHBDeUc2oS5vFn69+kzf0edXPSpc+6z8P8FLM3Ihm8THgu7/6io5J/uJcXj3NYiWlNsNtY1XynVO1OwVEbwr7gd2Zvj1Y6l4kF7nZ","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(38070700021)(921020)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?BMIUP2C/Riq/8Uyfy8Ngy2K?=\n\t=?iso-8859-1?q?4dgcCc2mgF5mf5bpiNnjOfdZHauBJzvIGcB9bWbuGWdlBk+f9kFZSkFo/cF7?=\n\t=?iso-8859-1?q?6jL6m6jLc5dfsu5mzNy1+GZ4NR70TxieVIJv46mI4LXe1q7n9AvkeNbHNK09?=\n\t=?iso-8859-1?q?vFdYduLo45v5WzmtRFQiapemBHvU0O26bxrjUa2Y/h/UlfBRS9uL11y4Ld5/?=\n\t=?iso-8859-1?q?tMcoyggtMcGHmRqfw+lDKd0CA2fNzhaVwbqYnTrZHuLC3oDeeqhaW6BwrKXC?=\n\t=?iso-8859-1?q?qQ95+VnGTY2T1l6HDhd3YgzF8Pg02Y97iDH+IjHCtopyKzP+eNEl+Ep30M7d?=\n\t=?iso-8859-1?q?yeXuxoWlHA2a2MJRA0xaa8uyeF92JZdJO48fkz9riZh3wBwNmO6UP64AoZ+l?=\n\t=?iso-8859-1?q?jfuqaP9DE/j6TzsPsrsVgbm+f50igFeIc7XySXm9JRl+cZbsN3dSUVydH2jq?=\n\t=?iso-8859-1?q?DMQGwErLA/pNw9nYVHQHJN1mirQ1cBhxVjJlfxNYM+bxMFIXj+wtVL8l00Xo?=\n\t=?iso-8859-1?q?uyT7Wi1OOXAusJEYZKb8nMo4N4ECX5gYEn6oRXALHUp1A5hiiKhzq3LYbzhN?=\n\t=?iso-8859-1?q?k+V9WcTy2kytfDpV/tm1PLy1FKckYHTkT/d0BD/1KwlrAyAaGkOBIkcfxBEB?=\n\t=?iso-8859-1?q?dRt25YMCluf7qZ8YjC3L0+scWZxONQTNup3EkuP0Ex/MqwHjqFIIf8IaQT71?=\n\t=?iso-8859-1?q?bY/oBBcZ0dIYQvxd6Gd2uE1YJyTFl4cIF+LLcRAzc/gaAb/5zOwykiDEe5Ys?=\n\t=?iso-8859-1?q?uyKz7LIQW6+R+yr8Z7lZ3t1/jxttsV9GYarLwsol7tkLtYvj1FhnCxbTseJv?=\n\t=?iso-8859-1?q?rhtf285hgZPXxZ0lb5ZhskWJASXTjJmmDV4XycnU5Ah+aHQkryI8aW44lNpz?=\n\t=?iso-8859-1?q?dX/PTeRqShN1AQ2GLRhWCoqfNo2zr+pgVR0T7W+Wmm3j+lDzURUHjPAwcReK?=\n\t=?iso-8859-1?q?nawoGty51jCNFYSItTevpUPJGNXSdHwCleL2Qn75rAXm6K4i4zodAlQ2RlHD?=\n\t=?iso-8859-1?q?QYSVehUwB068K7A/4o1IBf8a6+/VIQZqSdExPpflg5L90fj+8/k+IpBUsaS1?=\n\t=?iso-8859-1?q?2d3Jl3gazmVsteELiYAINM+W6wjA8jEJc9s/Ajb+27sQdIEmAP3Eiqc3ddy4?=\n\t=?iso-8859-1?q?XqYnRt0xCO2YTTowRZyTRVo1gRUVaETqCRaLau3G5Bf1vGu+QEtLCaHcCLTj?=\n\t=?iso-8859-1?q?Z6jFu4hHagktSwPY92zBtBUWb3MXSbxcDcJYFhQpkxuhiaUK/w1RIKSIEkqB?=\n\t=?iso-8859-1?q?xwdUKxmQnUgdm2vqjWgA/qJo4zvtPgiHPh78axOel/qsv4FnYLS/eZuAAoR0?=\n\t=?iso-8859-1?q?ECi1WzqTo0b8OFDGa7G2cxDk8LzqgGDRmHPav5C4LxSJPGoTKfiqBX7njaD8?=\n\t=?iso-8859-1?q?n/jU0mfYFCtkAO6X/muxj+H2OmMQCz9cXs1CBNyJEOy+6VPoKCK62x+OKl7p?=\n\t=?iso-8859-1?q?QbKeVIuIWl2uGK7jT1kgomx86oG9AijTVlVFYqT3EBzR6i05pnB8mpWCzsAR?=\n\t=?iso-8859-1?q?K0FhCdt9MGXD4+LdH76iox5GWOyuVWCTU4HWMdc0URfrieHI2Opw8zccZADy?=\n\t=?iso-8859-1?q?Zt87wniKXEFosVTQVI+Yg6gXSEgejMkjgxTq+dl/gOZ8JaYgn95cG0niidYA?=\n\t=?iso-8859-1?q?ZL7hScuDD1W8/KNsoIstgrK1Z/5gmBvBvoae0SXlsuu9lMdK7A0s0tNRLVEF?=\n\t=?iso-8859-1?q?wRgl3UJajrgVk32kEnXmUCJSeixEo/zB0Z8PA74HxXM4NuXvcZ/GMDVELJP2?=\n\t=?iso-8859-1?q?hvltFsct7NXXlEt2WrZbN7AEZw8Z4jeoCh6qvYdfUH3VFAA=3D=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n VZYlXnGHgREI8zvE+JzJK+Ob3wZM8C86zRynFy7v3RPwmUbjkHxcSQ6FhiwYmUvzyp5Z4hKVswfWUX9Omjuut6Sk4ih7VzYyKhPVJ35LYR/Rv2xPxwSHyrLFe7DUmIc6k2Uzf1L/QrlK9xwIB4U4dvdqFdemI3WOb4Z851YyE431oQK97qBV0YDo8M4pkVsFBmpm0ZejzEj7H0wuHzxBlMDF7OzHM+h4n/DkZbSbfTF/BPa5aVCvHOjq70vNOA0U2yS9IxUkiSbLGxLNgdz8z1U5NbYJHWlSL2k4J0e2j//cGk4vaX6OAi2YwvaoDV+jyTRTg8crrQ+Ga7ZiNKYqIQ==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n b4130c4b-b35d-4c6c-5c58-08dea0f7b9c7","X-MS-Exchange-CrossTenant-originalarrivaltime":"23 Apr 2026 05:18:16.7150 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n bJzCKXIenlurktva3H0Vvyf34HXFlEkOQtVkIO7lZvgWXpsLX8nK1im6JzHOPKZu9beskPvlYngCs/1sFQhKrmGHqMBooLeBqOTf3IC0dVk=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"KUXPR06MB8534","Received-SPF":"pass client-ip=2a01:111:f403:c405::7;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYDPR03CU002.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Introduce a new boolean property, \"caps-64bit-addr\", to control\nHCCPARAMS[0] (64-bit Addressing Capability).\n\nWhen enabled, the EHCI controller advertises support for 64-bit\naddress memory pointers as defined in the EHCI specification\n(Table 2-7, HCCPARAMS). This allows software to use the 64-bit\ndata structure formats described in Appendix B.\n\nWhen disabled (default), the controller reports 32-bit addressing\ncapability and uses the standard 32-bit data structures.\n\nThe EHCI CTRLDSSEGMENT register provides the upper 32 bits [63:32] used to\nform 64-bit addresses for EHCI control data structures. Per EHCI 1.0\nspec section 2.3.5, when the HCCPARAMS 64-bit Addressing Capability bit\nis zero, CTRLDSSEGMENT is not used: software cannot write it and reads\nmust return zero.\n\nAdd a capability check in the operational register write handler and\nreject guest writes to CTRLDSSEGMENT when 64-bit addressing is\nnot enabled.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\nReviewed-by: Cédric Le Goater <clg@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/usb/hcd-ehci.h |  5 ++++-\n hw/usb/hcd-ehci.c | 14 +++++++++++++-\n 2 files changed, 17 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\nindex 3acbddfc5c..f1f2fde578 100644\n--- a/hw/usb/hcd-ehci.h\n+++ b/hw/usb/hcd-ehci.h\n@@ -257,6 +257,7 @@ struct EHCIState {\n     /* properties */\n     uint32_t maxframes;\n     bool migrate_fetch_addr_64bit;\n+    bool caps_64bit_addr;\n \n     /*\n      *  EHCI spec version 1.0 Section 2.3\n@@ -313,7 +314,9 @@ struct EHCIState {\n #define DEFINE_EHCI_COMMON_PROPERTIES(_state) \\\n     DEFINE_PROP_UINT32(\"maxframes\", _state, ehci.maxframes, 128), \\\n     DEFINE_PROP_BOOL(\"x-migrate-fetch-addr-64bit\", _state, \\\n-                     ehci.migrate_fetch_addr_64bit, true)\n+                     ehci.migrate_fetch_addr_64bit, true), \\\n+    DEFINE_PROP_BOOL(\"caps-64bit-addr\", _state, \\\n+                     ehci.caps_64bit_addr, false)\n \n extern const VMStateDescription vmstate_ehci;\n \ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 0c8bdb48ad..b23ff92e12 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -1109,6 +1109,15 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n         }\n         break;\n \n+    case CTRLDSSEGMENT:\n+        if (!s->caps_64bit_addr) {\n+            qemu_log_mask(LOG_GUEST_ERROR,\n+                          \"ehci: write to CTRLDSSEGMENT while \"\n+                          \"      64-bit addressing capability is disabled\\n\");\n+            return;\n+        }\n+        break;\n+\n     case ASYNCLISTADDR:\n         if (ehci_async_enabled(s)) {\n             qemu_log_mask(LOG_GUEST_ERROR,\n@@ -2554,6 +2563,9 @@ void usb_ehci_realize(EHCIState *s, DeviceState *dev, Error **errp)\n                    s->maxframes);\n         return;\n     }\n+    if (s->caps_64bit_addr) {\n+        s->caps[0x08] |= BIT(0);\n+    }\n \n     memory_region_add_subregion(&s->mem, s->capsbase, &s->mem_caps);\n     memory_region_add_subregion(&s->mem, s->opregbase, &s->mem_opreg);\n@@ -2613,7 +2625,7 @@ void usb_ehci_init(EHCIState *s, DeviceState *dev)\n     s->caps[0x05] = 0x00;        /* No companion ports at present */\n     s->caps[0x06] = 0x00;\n     s->caps[0x07] = 0x00;\n-    s->caps[0x08] = 0x80;        /* We can cache whole frame, no 64-bit */\n+    s->caps[0x08] = 0x80;        /* We can cache whole frame */\n     s->caps[0x0a] = 0x00;\n     s->caps[0x0b] = 0x00;\n \n","prefixes":["v4","09/17"]}