{"id":2226974,"url":"http://patchwork.ozlabs.org/api/patches/2226974/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422-case-sensitivity-v9-1-be023cc070e2@oracle.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422-case-sensitivity-v9-1-be023cc070e2@oracle.com>","list_archive_url":null,"date":"2026-04-22T23:29:55","name":"[v9,01/17] fs: Move file_kattr initialization to callers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8399402ad232bd593fad6e92814fdac3177491c6","submitter":{"id":86689,"url":"http://patchwork.ozlabs.org/api/people/86689/?format=json","name":"Chuck Lever","email":"cel@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422-case-sensitivity-v9-1-be023cc070e2@oracle.com/mbox/","series":[{"id":501130,"url":"http://patchwork.ozlabs.org/api/series/501130/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501130","date":"2026-04-22T23:29:54","name":"Exposing case folding behavior","version":9,"mbox":"http://patchwork.ozlabs.org/series/501130/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226974/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226974/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=M3ZxNZDI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11014-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"M3ZxNZDI\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1FpZ6cm3z1yD5\n\tfor ; Thu, 23 Apr 2026 09:31:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id DC0AE3070F13\n\tfor ; Wed, 22 Apr 2026 23:30:20 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 09EF63A4511;\n\tWed, 22 Apr 2026 23:30:20 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D6F32395D99;\n\tWed, 22 Apr 2026 23:30:19 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 51D5FC2BCAF;\n\tWed, 22 Apr 2026 23:30:17 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776900619; cv=none;\n b=g251bEe58zLYVC6rAXJFKS/4MgikeOLYmCFZJJJJ1n8HbFwXwOeFSG9M1ZrL2L3r2r0QngH2vZr+WJaRuN3rqem6a/uzQdayJ6/EfGssmEIR1+kKBR8SQxTc9UgO9ljErCQ/AzX6/bwtPGHZm+ZMyWLtFAuHLU11g21yQ96o2kM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776900619; c=relaxed/simple;\n\tbh=bctXXTPbBEuad4Pxq4bP9lSf9quyJ0lnmg+KuyXxPH0=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=OVJqjiP7mKzEuDZnuJewz7SqQfcSQ08ctXxsWuuOXy9ryXxjIZuZmxT7V9s+3zlgoTNJeUf3mb3VS+78Z+jlGaLEFmHWtLMC0wZfHlcNhIgqACnrue24OilmV5F2JxhxpkgwWe2fQ76RKFLyOFxVoeFn5ujSA6Kr15YiyFu92BY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=M3ZxNZDI; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776900619;\n\tbh=bctXXTPbBEuad4Pxq4bP9lSf9quyJ0lnmg+KuyXxPH0=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=M3ZxNZDIeZhKMd2X9+NlQlR577y1NpSl01J2FVXN03pWa3CBeSLxdQ9DUQ6f9Y4sw\n\t UMi9BgF0IpRMZVW/toOsMY2defUR4VHWR/IwSqkSbcsgOInXbmIgUZ21m4cNNtUDjl\n\t 5d/BI3BFEp9bkrt2MgaXMcBcYxUISQTZzr2+uktLrkBBJMoH+nonIuhGVud0I5PGiO\n\t 2vHzgh6+UgAr9AGqq7KifwNOJ/wVnVdhvWwyMtRWaprSzYHu7oLhI6rcwkcpQTJwlr\n\t hHy4JgcZKsuFjGYBzXYFlQWYBsgcdhjrVpsY1MO/TWyFeTjOrMK6ReLmlmdF5Btz4x\n\t vlnYzNOMAxREw==","From":"Chuck Lever ","Date":"Wed, 22 Apr 2026 19:29:55 -0400","Subject":"[PATCH v9 01/17] fs: Move file_kattr initialization to callers","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260422-case-sensitivity-v9-1-be023cc070e2@oracle.com>","References":"<20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com>","In-Reply-To":"<20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com>","To":"Al Viro ,\n Christian Brauner , Jan Kara ","Cc":"linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,\n linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,\n linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,\n linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp,\n linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com,\n almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,\n glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,\n adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,\n pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com,\n trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org,\n hansg@kernel.org, senozhatsky@chromium.org,\n Chuck Lever , \"Darrick J. Wong\" ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3501;\n i=chuck.lever@oracle.com; h=from:subject:message-id;\n bh=tI06eoaKz9315rXjbGykMIxbiHJmdgGU8s/nGVMwtnA=;\n b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp6VoFA3fAjX74FSJ4imm2PqqdSRR23lY9hRXdR\n H8tIE2EgfqJAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCaelaBQAKCRAzarMzb2Z/\n lzkGD/wPvBSeGWtLxCSOZNi/+/xYdOyxsFXcUJHyozmi+gSkQc7kE8CBS/h/E04hWxe+jumJLYc\n 5isVzwGsG47c/YCSbsJ05QXTlXdbDIlnhdMrjD81dhtOGU49mWssVMdR+HNe7QMGgHTdeNteK8m\n 8xLQ8DLGOJadTfo1vil0z4FVIVOKIcB3kGPmp7Ze0JWoFm9Fn/b6Zddy7/5nQSma+S2fgzGrVQA\n +u6SV5xXGdCIKOCOCQVdfHP3VqfO0JbrmMvOzOLC4ZvWw+h/roCoFoKbTuFib6uTayXf524jOFZ\n 1+11lz9L7vEvbGretw87tWH+HTUTmnycdGW6xM0c12NzcE1DwZhBGwu5SVyJxDUpkfIAFkDUHbH\n 7a73p6w0SaEv3lRaKc9aS4LDGg9Eih7ZDcO21+OA4/NdiQGvhY5gAlbVjJQpiiYydqu8AtkL6Xl\n i07wNoI598Q+erp8RLgYgO25xuOgohaMvzUzQ45UyS7xnIsRaQhWzyNEwfOGWDkaJUr2zzlX9ob\n zTta1H1PWaru8vK6xCNF6D9m9wHi7IJIPtC/VCqLt7On40mipe8SwaGlFAiDvHDD1n2tB/cLvoU\n usmAoioCylaoAj7jIXEVYcFvpWuDU8bnL7Co0DhUO9UXTLJEnktM9czBhSe+wXHAr0mf2SNBRSj\n 8N1Ovw8vYuS5zVw==","X-Developer-Key":"i=chuck.lever@oracle.com; a=openpgp;\n fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97"},"content":"From: Chuck Lever \n\nfileattr_fill_xflags() and fileattr_fill_flags() memset the\nentire file_kattr struct before populating select fields, so\ncallers cannot pre-set fields in fa->fsx_xflags without having\ntheir values clobbered. Darrick Wong noted that a function\nnamed \"fill_xflags\" touching more than xflags forces callers\nto know implementation details beyond its apparent scope.\n\nDrop the memset from both fill functions and initialize at the\nentry points instead: ioctl_setflags(), ioctl_fssetxattr(),\nthe file_setattr() syscall, and xfs_ioc_fsgetxattra() now\ndeclare fa with an aggregate initializer. ioctl_getflags(),\nioctl_fsgetxattr(), and the file_getattr() syscall already\naggregate-initialize fa to pass flags_valid/fsx_valid hints\ninto vfs_fileattr_get().\n\nSubsequent patches rely on this so that ->fileattr_get()\nhandlers can set case-sensitivity flags (FS_XFLAG_CASEFOLD,\nFS_XFLAG_CASENONPRESERVING) in fa->fsx_xflags before the fill\nfunctions run.\n\nSuggested-by: Darrick J. Wong \nReviewed-by: Jan Kara \nSigned-off-by: Chuck Lever \n---\n fs/file_attr.c | 12 ++++--------\n fs/xfs/xfs_ioctl.c | 2 +-\n 2 files changed, 5 insertions(+), 9 deletions(-)","diff":"diff --git a/fs/file_attr.c b/fs/file_attr.c\nindex da983e105d70..f429da66a317 100644\n--- a/fs/file_attr.c\n+++ b/fs/file_attr.c\n@@ -15,12 +15,10 @@\n * @fa:\t\tfileattr pointer\n * @xflags:\tFS_XFLAG_* flags\n *\n- * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). All\n- * other fields are zeroed.\n+ * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags).\n */\n void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->fsx_valid = true;\n \tfa->fsx_xflags = xflags;\n \tif (fa->fsx_xflags & FS_XFLAG_IMMUTABLE)\n@@ -48,11 +46,9 @@ EXPORT_SYMBOL(fileattr_fill_xflags);\n * @flags:\tFS_*_FL flags\n *\n * Set ->flags, ->flags_valid and ->fsx_xflags (translated flags).\n- * All other fields are zeroed.\n */\n void fileattr_fill_flags(struct file_kattr *fa, u32 flags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->flags_valid = true;\n \tfa->flags = flags;\n \tif (fa->flags & FS_SYNC_FL)\n@@ -325,7 +321,7 @@ int ioctl_setflags(struct file *file, unsigned int __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tunsigned int flags;\n \tint err;\n \n@@ -357,7 +353,7 @@ int ioctl_fssetxattr(struct file *file, void __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint err;\n \n \terr = copy_fsxattr_from_user(&fa, argp);\n@@ -431,7 +427,7 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename,\n \tstruct path filepath __free(path_put) = {};\n \tunsigned int lookup_flags = 0;\n \tstruct file_attr fattr;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint error;\n \n \tBUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0);\ndiff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c\nindex 46e234863644..ed9b4846c05f 100644\n--- a/fs/xfs/xfs_ioctl.c\n+++ b/fs/xfs/xfs_ioctl.c\n@@ -517,7 +517,7 @@ xfs_ioc_fsgetxattra(\n \txfs_inode_t\t\t*ip,\n \tvoid\t\t\t__user *arg)\n {\n-\tstruct file_kattr\tfa;\n+\tstruct file_kattr\tfa = {};\n \n \txfs_ilock(ip, XFS_ILOCK_SHARED);\n \txfs_fill_fsxattr(ip, XFS_ATTR_FORK, &fa);\n","prefixes":["v9","01/17"]}