{"id":2226957,"url":"http://patchwork.ozlabs.org/api/patches/2226957/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/177689989330.3821152.4019461882726051373.stgit@frogsfrogsfrogs/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<177689989330.3821152.4019461882726051373.stgit@frogsfrogsfrogs>","list_archive_url":null,"date":"2026-04-22T23:23:00","name":"[1/3] libext2fs: always fsync the device when flushing the cache","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"76fc62a075f1fb008509cbdc1c5df132ae71d9bf","submitter":{"id":77032,"url":"http://patchwork.ozlabs.org/api/people/77032/?format=json","name":"Darrick J. Wong","email":"djwong@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/177689989330.3821152.4019461882726051373.stgit@frogsfrogsfrogs/mbox/","series":[{"id":501126,"url":"http://patchwork.ozlabs.org/api/series/501126/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=501126","date":"2026-04-22T23:23:00","name":"[1/3] libext2fs: always fsync the device when flushing the cache","version":1,"mbox":"http://patchwork.ozlabs.org/series/501126/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226957/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226957/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=UMXiyJoY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=s7kh=cv=vger.kernel.org=linux-ext4+bounces-16002-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=UMXiyJoY;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16002-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"UMXiyJoY\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1FdQ4PfXz1y2d\n\tfor ; Thu, 23 Apr 2026 09:23:06 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g1FdQ3qz5z4wCM\n\tfor ; Thu, 23 Apr 2026 09:23:06 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4g1FdQ3Ptcz4wKB; Thu, 23 Apr 2026 09:23:06 +1000 (AEST)","from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g1FdM0Qtbz4wCM\n\tfor ; Thu, 23 Apr 2026 09:23:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id AA939302C6C0\n\tfor ; Wed, 22 Apr 2026 23:23:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1E3A536E473;\n\tWed, 22 Apr 2026 23:23:01 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B1C352FA5\n\tfor ; Wed, 22 Apr 2026 23:23:00 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B231BC19425;\n\tWed, 22 Apr 2026 23:23:00 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776900186; cv=pass;\n\tb=of9Cpz8SoQPjrLGdQN2EfVOO5eeoQmHbvZ92VFB7BHxtdvSLjvi6/W9/L5U5M6zB7z7SskDuYaahMkW9mmyPuGPkHJtqhA77P/P2HgO1bTK99wABrbDAkYryi3MJHhGnfMbjAmep13rb4QdEiCohYdeuTekq+WwPT4+Ku5Mw6FjpTeUl/+s5nwIbBzT7zJIX4V04CBi6NOuxSA733KeqUr9wAFQBCQRFxdtZq5tfBR6UfHRRg+NSpbfmbXMerb7USMK3Wq0o/XVjCaexg115hmKv9FUkV5ijPRnsXJ0ccVOWCPNRUMOXCoz/eOMotSlPBuoQiKjvBhdlckJ7DFPpVQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776900180; cv=none;\n b=l5Hvw1mRr4RXPn24wSup7YX1sU9WeJsiQ0vWoFT4ah8mYMmizUOywLXmwh1r4vKUGudHy/2mLBy6WhQ+vX/H4xjAnYKekSrNrX86gZMbyd7gzskLOpi0FzJyYT8ksizUB1wsj/mCLZSqKwq2AoIXRdKXtmkAJI9HeqjhOjgf/z0="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776900186; c=relaxed/relaxed;\n\tbh=eNF+9g03n9g4shmUdt4YwknMuc5b1mSLrquhXby7I+s=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=rX7zYNrlfztELgtY9ziiK+MvlPZmFA/5Z6TTPyCJb4VswVujTHVWqwrw18bBfg5uhoGvIPALn3vGA4QrTYcV2ekxJ9lB4VurYw9F1pcDriebKYBJxX2dUSooyrWiYxEaWLZj5HQ+g5tta/5Q79iw/sd00U45l36XzcrfCclZbTbsSAV9VlodSEGt2clxV4tDAgrQWhPjXU7ZxFcWkmCB/9TM+MPW6Krv3QG69vkhOIpNUuj4pDExsjh/yWZ3yfCEcMfdB+4GAPcVlk5VxQyd34jmJhyw2NmILs+Ncjt/8GEuGBme89RxjoM0/j73SkwMvHrvU1GI/rq0YWd2h2BURA==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776900180; c=relaxed/simple;\n\tbh=CPVapfxOdzK79ldUNiY74kvv1H/1tR7u2G/bXa+WsOY=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=Xi0DYq06z2m+S59EavmR9p2qQGIXmgXmejDjHGJnarTGOP+NVxR/mTB7+tS0IYrxOgPrqx8XNdZMVSXlLrjHRO9v7KtD5wQqitj6TDpiWNUsObWPdEZG5A6gT4p/Isd6c3hQpONdJZ+xy1uB15WNltjITQrWuuTC2VU6BrE4QwU="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=UMXiyJoY; dkim-atps=neutral;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16002-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=UMXiyJoY; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776900180;\n\tbh=CPVapfxOdzK79ldUNiY74kvv1H/1tR7u2G/bXa+WsOY=;\n\th=Date:Subject:From:To:Cc:In-Reply-To:References:From;\n\tb=UMXiyJoYx7Wm4SnpdytNjjZ6YYcDzaN+BluosFU/HIFrQa6VCbHyC9czldV4De8UB\n\t Zk6WEbVaaV35e/xz+AV+fV5Qx0sFdPxD2LWV1klCmc5hw0Mf+30eB7ofZaGypDP8um\n\t xiF+NDVXBKH5YRtwKaIVnBRq6qoVzqm1Xbvs4FsLLd4mTtiBi87LjOXDikmCvrmPHw\n\t 8dgqqwfBZ77J5vymlHHVf3k96ZpqgFtvMewrXB4KTsPZUY/Xo4Mrndo2wwW/YlXwwS\n\t +ZVedQ+7ak37pp0ZxRgA3gZKc8wQuEXssJjm1Ci90NX9BZ+FlDE4fb+ZEK1lOgglXd\n\t Lbh2UT0S8Y47A==","Date":"Wed, 22 Apr 2026 16:23:00 -0700","Subject":"[PATCH 1/3] libext2fs: always fsync the device when flushing the\n cache","From":"\"Darrick J. Wong\" ","To":"tytso@mit.edu","Cc":"linux-ext4@vger.kernel.org","Message-ID":"<177689989330.3821152.4019461882726051373.stgit@frogsfrogsfrogs>","In-Reply-To":"<177689989303.3821152.12873703999139555043.stgit@frogsfrogsfrogs>","References":"<177689989303.3821152.12873703999139555043.stgit@frogsfrogsfrogs>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"From: Darrick J. Wong \n\nWhen we're flushing the unix IO manager's buffer cache, we should always\nfsync the block device, because something could have written to the\nblock device -- either the buffer cache itself, or a direct write.\nRegardless, the callers all want all dirtied regions to be persisted to\nstable media.\n\nSigned-off-by: \"Darrick J. Wong\" \n---\n lib/ext2fs/unix_io.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/lib/ext2fs/unix_io.c b/lib/ext2fs/unix_io.c\nindex abd33ba839f7e9..b6feebef93fa5b 100644\n--- a/lib/ext2fs/unix_io.c\n+++ b/lib/ext2fs/unix_io.c\n@@ -1531,7 +1531,8 @@ static errcode_t unix_flush(io_channel channel)\n \tretval = flush_cached_blocks(channel, data, 0);\n #endif\n #ifdef HAVE_FSYNC\n-\tif (!retval && fsync(data->dev) != 0)\n+\t/* always fsync the device, even if flushing our own cache failed */\n+\tif (fsync(data->dev) != 0 && !retval)\n \t\treturn errno;\n #endif\n \treturn retval;\n","prefixes":["1/3"]}