{"id":2226926,"url":"http://patchwork.ozlabs.org/api/patches/2226926/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-31-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422214225.2242-31-mohamed@unpredictable.fr>","list_archive_url":null,"date":"2026-04-22T21:42:18","name":"[v3,30/37] whpx: i386: set APIC ID only when APIC present","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"160427a8ee6ff775220baa436869f4d3beb52657","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-31-mohamed@unpredictable.fr/mbox/","series":[{"id":501116,"url":"http://patchwork.ozlabs.org/api/series/501116/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501116","date":"2026-04-22T21:41:48","name":"[v3,01/37] target/i386: emulate: include name of unhandled instruction","version":3,"mbox":"http://patchwork.ozlabs.org/series/501116/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226926/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226926/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=NiejURub;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1CSf5YBvz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 07:45:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFfMJ-0000Dn-Nq; Wed, 22 Apr 2026 17:43:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfM5-00007X-0E\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:36 -0400","from p-east2-cluster5-host8-snip4-1.eps.apple.com ([57.103.79.34]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfM2-0007bS-OP\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:32 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n 850CF180095E; Wed, 22 Apr 2026 21:43:26 +0000 (UTC)","from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n 0758A18000C7; Wed, 22 Apr 2026 21:43:23 +0000 (UTC)"],"X-ICL-Out-Info":"\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJAU1fDl4fBBdGGVUERx5dVkAZGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVKA18BWwZCC0oCWQVZB14LSgdfGlgDXVQXWwxaDlYwTBZDH1IPWxNNGVEBUkVUAgdYRxRHDg8TTAtHAlo0Vh9UGVoD","Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776894209; x=1779486209;\n bh=Yb8MZdG4bYTj2R/5rdlrYd3KIDfipgWFm4dgORDLS64=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=NiejURubwGAzPHgkH2zUURbDernhu4xp4grF89QpiIbsphH6lAelQGx9HTaRRhobBPDvIS7rh2XsphpmkAQn4vYOebJd9G82+3hThOpyq6AXaJXXZf1r6QcyvKW/s18AgfD/bkazLwFQntrpVegaqAJ3b5WOmexe/R/uP50gXt3TwcKBUkfifqHiZvXMZRG3WouYbmZkm9BygWhARMyoPwQQGRKpyjQX63s7mGlZXSCe181hmLtsFQ03n+xAg9qWP3LQaARqE7FT+ITo8EDWNzlYbOPKBRiTIOAaL8R2QOAUssYIRKwyf7T33vn/kcNCtzObcXSA4yV+9DHxU18uHA==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni <mohamed@unpredictable.fr>","To":"qemu-devel@nongnu.org","Cc":"Pedro Barbuda <pbarbuda@microsoft.com>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Roman Bolshakov <rbolshakov@ddn.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Wei Liu <wei.liu@kernel.org>,\n Phil Dennis-Jordan <phil@philjordan.eu>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>","Subject":"[PATCH v3 30/37] whpx: i386: set APIC ID only when APIC present","Date":"Wed, 22 Apr 2026 23:42:18 +0200","Message-ID":"<20260422214225.2242-31-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260422214225.2242-1-mohamed@unpredictable.fr>","References":"<20260422214225.2242-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDIxMSBTYWx0ZWRfX8HXVzbI6fgpv\n Dc5pzPuTC9qMswKaBlfVtHcZeN/v9bRSGHkuFvd8eHLVX3tIO74z+FycHqP0GYp4FDU8Sb/2Niy\n xyU7S12kO8rw/haVpCfkphB1W0yvrClI/jxf2+d18TiA7B6gRykyOuzfkRA7OD8rcb3wtSCk31v\n hY5WFkmCkqpyroMWDFAisdsaAgo/vjyjue/eSktI6SMAV9EbRjx1LSjMSXRIY5/epwOr9/NwKMY\n 8XL6cJinntoxfOLl2C7jiqwZS098pObZI+YADtjmlSW7TkpC+rvoZp4SOD9R82a/mmGa5LoXEbO\n sN0gMGRB+voo8ASN6khCytAeQpHxyxJ9IgaxuXtfap9OkE2ci18cGdFMTglBi8=","X-Authority-Info-Out":"v=2.4 cv=PvGergM3 c=1 sm=1 tr=0 ts=69e94100\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=WHe3jrWR342bzmf78BwA:9","X-Proofpoint-GUID":"ByAdUR_rIvyG8ygm3eGx0EJl1h2EMu4z","X-Proofpoint-ORIG-GUID":"ByAdUR_rIvyG8ygm3eGx0EJl1h2EMu4z","Received-SPF":"pass client-ip=57.103.79.34;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"-M isapc doesn't have an APIC\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 3562decfaf..53ff0d3f7c 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -2643,7 +2643,7 @@ int whpx_init_vcpu(CPUState *cpu)\n         goto error;\n     }\n \n-    if (!whpx_irqchip_in_kernel()) {\n+    if (!whpx_irqchip_in_kernel() && x86_cpu->apic_state != NULL) {\n         WHV_REGISTER_VALUE apic_id = {.Reg64 = x86_cpu->apic_state->initial_apic_id};\n         whpx_set_reg(cpu, WHvX64RegisterInitialApicId, apic_id);\n     }\n","prefixes":["v3","30/37"]}