{"id":2226923,"url":"http://patchwork.ozlabs.org/api/patches/2226923/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-18-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422214225.2242-18-mohamed@unpredictable.fr>","list_archive_url":null,"date":"2026-04-22T21:42:05","name":"[v3,17/37] whpx: i386: unknown MSR configurability","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7d0b6d2a880b0ed478e619c22581fd3411e57899","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-18-mohamed@unpredictable.fr/mbox/","series":[{"id":501116,"url":"http://patchwork.ozlabs.org/api/series/501116/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501116","date":"2026-04-22T21:41:48","name":"[v3,01/37] target/i386: emulate: include name of unhandled instruction","version":3,"mbox":"http://patchwork.ozlabs.org/series/501116/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226923/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226923/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=ZS+if+h0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1CS61n3hz1yDD\n\tfor ; Thu, 23 Apr 2026 07:44:54 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFfLp-0008Et-1O; Wed, 22 Apr 2026 17:43:17 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFfLf-00086X-D0\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:08 -0400","from p-east2-cluster1-host12-snip4-1.eps.apple.com ([57.103.76.54]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFfLb-0007J4-Uk\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:07 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n F3C3B1800232; Wed, 22 Apr 2026 21:43:01 +0000 (UTC)","from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n D1AE91800950; Wed, 22 Apr 2026 21:42:59 +0000 (UTC)"],"X-ICL-Out-Info":"\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJAU1fDl4fBBdGGVUERx5dVkAZGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVKA18BWwZCC0oCWQVZB14LSgdfGloKXVQXWwxaDlYwTBZDH1IPWxNNGVEBUkVUAgdYRxRHDg8TTAtHAlo0Vh9UGVoD","Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776894183; x=1779486183;\n bh=a4bAw1HDBgRU0T/rl/EmfzkgG6FT8af3C1AcP0W3dJM=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=ZS+if+h0jlXQhDcZj7ZqjSsDX1R/rjyvnoyahsxVqQg/0b44kk9Upzy3rCGONx4zFfCbLc+ivuyWRkAQuYiTlBE9jgJCFBqgibWqcGaDFC3C0grhKDjE3YsUNAF8lo3EJMPQXl2QXqm+dWxfJrYbiNx86dyTJ3YmK+dsTwMEDLF0AVfh/PMT4FYLbG+Pmv5EGZYdCZo+AJdV711zkMWpAHoMtfXV1xgnJSvrw3ruEQXYaI3435O4P34D/VXYIfmDKgK0gV8H88tqc4+LWesdkFDY80GjSH2bp6320V4uxMWWP1+CiR+UkGUVANbciBXYAIyUAdCZNR/La0/LGDW0jw==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Pedro Barbuda , qemu-arm@nongnu.org,\n Pierrick Bouvier ,\n Mohamed Mediouni ,\n Roman Bolshakov ,\n \"Michael S. Tsirkin\" , Wei Liu ,\n Phil Dennis-Jordan ,\n Peter Maydell , Zhao Liu ,\n Paolo Bonzini ","Subject":"[PATCH v3 17/37] whpx: i386: unknown MSR configurability","Date":"Wed, 22 Apr 2026 23:42:05 +0200","Message-ID":"<20260422214225.2242-18-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260422214225.2242-1-mohamed@unpredictable.fr>","References":"<20260422214225.2242-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Authority-Info-Out":"v=2.4 cv=JK02csKb c=1 sm=1 tr=0 ts=69e940e7\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=XlFqsGflGfdv-AKn0wkA:9","X-Proofpoint-ORIG-GUID":"qjlvJY7nUid2hSQe8IWh0Ic60j_pSCgl","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIyMDIxMSBTYWx0ZWRfX+dvJ6D8g5jNF\n ndtfi03LhcR8b/VsbQ2l8AWcxpQkiSIErswDAjjcG4alGjUREkvDj4brrAaCTHC+SXc8pv9Mb3L\n hWPT/G9DBpeynoww/gJYt2eSU12GuFYaPuFcFfwf+rInNxtxJpQ5DMPK6QrkwKlvTTLskVx0C4V\n wOwwlHGn+4zmmWUUDPLLm788KQtF2sO0FzfEo70n2hIzBvt8GgBnLOpt3ir2nvlc2eWiRe0K2xM\n mcKB9oVP7kQ2vxI+uwtR0AlpYYTWjxm8b3Bat+Or4iE6SidItn//fqF7hks7ajXB885QZFeSphd\n uQ8lgwM5/wVLI/hrjmZajQh/gTIZDqmY/UkZSBoLJMm1aOKQveGQDu24PF5G2o=","X-Proofpoint-GUID":"qjlvJY7nUid2hSQe8IWh0Ic60j_pSCgl","Received-SPF":"pass client-ip=57.103.76.54;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add an option to inject back a GPF for unknown MSRs.\n\nKeep it on by default for now as Linux expects accesses to some\nAMD-specific MSRs to always succeed when on an AMD host.\n\nSigned-off-by: Mohamed Mediouni \n---\n accel/whpx/whpx-common.c | 3 +++\n include/system/whpx-all.h | 1 +\n include/system/whpx-internal.h | 1 +\n target/arm/whpx/whpx-all.c | 4 +++\n target/i386/whpx/whpx-all.c | 45 ++++++++++++++++++++++++++++++++++\n 5 files changed, 54 insertions(+)","diff":"diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c\nindex 59be996aef..497c03138e 100644\n--- a/accel/whpx/whpx-common.c\n+++ b/accel/whpx/whpx-common.c\n@@ -538,6 +538,8 @@ static void whpx_accel_class_init(ObjectClass *oc, const void *data)\n NULL, NULL);\n object_class_property_set_description(oc, \"hyperv\",\n \"Configure Hyper-V enlightenments\");\n+\n+ whpx_arch_accel_class_init(oc);\n }\n \n static void whpx_accel_instance_init(Object *obj)\n@@ -552,6 +554,7 @@ static void whpx_accel_instance_init(Object *obj)\n whpx->hyperv_enlightenments_required = false;\n /* Value determined at whpx_accel_init */\n whpx->hyperv_enlightenments_enabled = false;\n+ whpx->ignore_unknown_msr = true;\n }\n \n static const TypeInfo whpx_accel_type = {\ndiff --git a/include/system/whpx-all.h b/include/system/whpx-all.h\nindex 2cbea71b14..4022571fff 100644\n--- a/include/system/whpx-all.h\n+++ b/include/system/whpx-all.h\n@@ -20,6 +20,7 @@ void whpx_translate_cpu_breakpoints(\n CPUState *cpu,\n int cpu_breakpoint_count);\n void whpx_arch_destroy_vcpu(CPUState *cpu);\n+void whpx_arch_accel_class_init(ObjectClass *oc);\n \n /* called by whpx-accel-ops */\n bool whpx_arch_supports_guest_debug(void);\ndiff --git a/include/system/whpx-internal.h b/include/system/whpx-internal.h\nindex cf782cf5f8..86639627b3 100644\n--- a/include/system/whpx-internal.h\n+++ b/include/system/whpx-internal.h\n@@ -47,6 +47,7 @@ struct whpx_state {\n bool hyperv_enlightenments_required;\n bool hyperv_enlightenments_enabled;\n \n+ bool ignore_unknown_msr;\n };\n \n extern struct whpx_state whpx_global;\ndiff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c\nindex 4019a513aa..94304a4230 100644\n--- a/target/arm/whpx/whpx-all.c\n+++ b/target/arm/whpx/whpx-all.c\n@@ -823,6 +823,10 @@ void whpx_cpu_instance_init(CPUState *cs)\n {\n }\n \n+void whpx_arch_accel_class_init(ObjectClass *oc)\n+{\n+}\n+\n int whpx_accel_init(AccelState *as, MachineState *ms)\n {\n struct whpx_state *whpx;\ndiff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 3426811c48..7f0ad6a24f 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -2133,6 +2133,10 @@ int whpx_vcpu_run(CPUState *cpu)\n vcpu->exit_ctx.MsrAccess.AccessInfo.IsWrite);\n }\n \n+ if (!is_known_msr && !whpx->ignore_unknown_msr) {\n+ x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ }\n+\n hr = whp_dispatch.WHvSetVirtualProcessorRegisters(\n whpx->partition,\n cpu->cpu_index,\n@@ -2532,6 +2536,47 @@ void whpx_cpu_instance_init(CPUState *cs)\n * Partition support\n */\n \n+static void whpx_set_unknown_msr(Object *obj, Visitor *v,\n+ const char *name, void *opaque,\n+ Error **errp)\n+{\n+ struct whpx_state *whpx = &whpx_global;\n+ OnOffAuto mode;\n+\n+ if (!visit_type_OnOffAuto(v, name, &mode, errp)) {\n+ return;\n+ }\n+\n+ switch (mode) {\n+ case ON_OFF_AUTO_ON:\n+ whpx->ignore_unknown_msr = true;\n+ break;\n+\n+ case ON_OFF_AUTO_OFF:\n+ whpx->ignore_unknown_msr = false;\n+ break;\n+\n+ case ON_OFF_AUTO_AUTO:\n+ whpx->ignore_unknown_msr = true;\n+ break;\n+ default:\n+ /*\n+ * The value was checked in visit_type_OnOffAuto() above. If\n+ * we get here, then something is wrong in QEMU.\n+ */\n+ abort();\n+ }\n+}\n+\n+void whpx_arch_accel_class_init(ObjectClass *oc)\n+{\n+ object_class_property_add(oc, \"ignore-unknown-msr\", \"OnOffAuto\",\n+ NULL, whpx_set_unknown_msr,\n+ NULL, NULL);\n+ object_class_property_set_description(oc, \"ignore-unknown-msr\",\n+ \"Configure unknown MSR behavior\");\n+}\n+\n int whpx_accel_init(AccelState *as, MachineState *ms)\n {\n struct whpx_state *whpx;\n","prefixes":["v3","17/37"]}