{"id":2226856,"url":"http://patchwork.ozlabs.org/api/patches/2226856/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422202646.272081-1-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422202646.272081-1-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2026-04-22T20:26:46","name":"ui/console: remove console from global list on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3aa3a878e4489b62580fd5b496a8b00adb691379","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422202646.272081-1-marcandre.lureau@redhat.com/mbox/","series":[{"id":501103,"url":"http://patchwork.ozlabs.org/api/series/501103/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501103","date":"2026-04-22T20:26:46","name":"ui/console: remove console from global list on finalization","version":1,"mbox":"http://patchwork.ozlabs.org/series/501103/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226856/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226856/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JJkdCNyp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g19kN2LJ2z1yD5\n\tfor ; Thu, 23 Apr 2026 06:27:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFe9y-0005JT-4l; Wed, 22 Apr 2026 16:26:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFe9w-0005JK-VW\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:26:56 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFe9v-0007UM-Gq\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:26:56 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-xq3skhz5OTKUTjBFHH6rFg-1; Wed,\n 22 Apr 2026 16:26:52 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 041A019560B7\n for ; Wed, 22 Apr 2026 20:26:52 +0000 (UTC)","from localhost (unknown [10.44.22.21])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A3DAF30001BE; Wed, 22 Apr 2026 20:26:49 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776889614;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=0mii0mnRtaDc1CmXFegMYX9tvRFhCT1ymqZhMmQAPr4=;\n b=JJkdCNypJBtDejIB4x6SmOvKwFyiSE6UNmXLcywdrwC3Pq4or7g3oE3EBt8za+/pdSGIzK\n m1KitvA7NCdNoX41MlUdbXS5XQQrHV0mrvmWWjihh79y3p6ylgpCe7853zZXuBZE7PGWqY\n kmAiZUc1SNTVlAsncNcl3bVx2PmLh/s=","X-MC-Unique":"xq3skhz5OTKUTjBFHH6rFg-1","X-Mimecast-MFC-AGG-ID":"xq3skhz5OTKUTjBFHH6rFg_1776889612","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PATCH] ui/console: remove console from global list on finalization","Date":"Thu, 23 Apr 2026 00:26:46 +0400","Message-ID":"<20260422202646.272081-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau \n\nThis commit removes the QemuConsole from the global \"consoles\" list when\nit is finalized.\n\nPreviously, there was a TODO comment indicating this path needed\nchecking. The assertions added ensure that `dcls`, `gl_block`, and the\n`dump_queue` are empty before removal, confirming the console is in a\nclean state.\n\nFix potential use-after-free crashes when a display console is removed.\n\nReported-by: Markus Armbruster \nSigned-off-by: Marc-André Lureau \n---\n ui/console.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/ui/console.c b/ui/console.c\nindex f445db11389..b64e2122f34 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -394,10 +394,13 @@ qemu_console_finalize(Object *obj)\n {\n QemuConsole *c = QEMU_CONSOLE(obj);\n \n- /* TODO: check this code path, and unregister from consoles */\n+ assert(c->dcls == 0);\n+ assert(c->gl_block == 0);\n+ assert(qemu_co_queue_empty(&c->dump_queue));\n g_clear_pointer(&c->surface, qemu_free_displaysurface);\n g_clear_pointer(&c->gl_unblock_timer, timer_free);\n g_clear_pointer(&c->ui_timer, timer_free);\n+ QTAILQ_REMOVE(&consoles, c, next);\n }\n \n static void\n","prefixes":[]}