{"id":2226802,"url":"http://patchwork.ozlabs.org/api/patches/2226802/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhupath8dc.gcc.gcc-TEST.tkaminsk.107.1.6@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-22T18:55:22","name":"[v1,06/13] Test for assigments","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c426b15516bae4146f9b8eb0e9f0cd7e7d8684d0","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/?format=json","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhupath8dc.gcc.gcc-TEST.tkaminsk.107.1.6@forge-stage.sourceware.org/mbox/","series":[{"id":501097,"url":"http://patchwork.ozlabs.org/api/series/501097/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501097","date":"2026-04-22T18:55:20","name":"libstdc++: optional (P2988R12)","version":1,"mbox":"http://patchwork.ozlabs.org/series/501097/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226802/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226802/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g197k73KTz1yD5\n\tfor ; Thu, 23 Apr 2026 06:00:34 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 00C3343492D1\n\tfor ; Wed, 22 Apr 2026 20:00:33 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 60AF4436590D\n for ; Wed, 22 Apr 2026 18:56:25 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 3B632435B7\n for ; Wed, 22 Apr 2026 18:56:23 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 00C3343492D1","OpenDKIM Filter v2.11.0 sourceware.org 60AF4436590D"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 60AF4436590D","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 60AF4436590D","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776884185; cv=none;\n b=WYZNbYApNG393kpYd/9nhyfnS0dBbAsXNXn/37/rgtsWeSMovT1rCckq+sIS1x/gowpCHaRAQFSVvIGEGNmwqnY+kfL2PvtbBkRsWiK4edZ47ebfN+oJU4QVTjJ0mUZXh/jdlOjAEdFfdDE3JvzTJLd+meE/sM0HfNppiUUAK3I=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776884185; c=relaxed/simple;\n bh=VfqqpFYq7tPb1VE+kIrOb/MHgo/+ezXMaqvKAdYE7/M=;\n h=From:Date:Subject:MIME-Version:To:Message-ID;\n b=AOGgqjaZ01HrWPO5X+UOq7g1y9SA2HIVCEMhaAnNbEmrNwTMas3ZxxbD/gfsHzFDsL02xoIy3RfbjKCW6HUo6K++vTG5TRtBGahghSmWn1HIKC4OMDtJa0KnCy3j+OivDCETnP8K6r6gCE3KUigrdWlknr+mrp24EYLsEUAtrr0=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"tkaminsk via Sourceware Forge\n ","Date":"Wed, 22 Apr 2026 18:55:22 +0000","Subject":"[PATCH v1 06/13] Test for assigments","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","To":"gcc-patches mailing list ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/107","References":"\n ","In-Reply-To":"\n ","X-Patch-URL":"\n https://forge.sourceware.org/tkaminsk/gcc/commit/485cc1880ea36692c96e29aefef0b708d3dce6fe","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"gcc-patches mailing list ,\n tkaminsk@gcc.gnu.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Tomasz Kamiński \n\n---\n libstdc++-v3/include/std/optional | 7 +-\n .../testsuite/20_util/optional/ref/assign.cc | 430 ++++++++++++++++++\n 2 files changed, 432 insertions(+), 5 deletions(-)\n create mode 100644 libstdc++-v3/testsuite/20_util/optional/ref/assign.cc","diff":"diff --git a/libstdc++-v3/include/std/optional b/libstdc++-v3/include/std/optional\nindex 7572f231ff42..fc39127a3e26 100644\n--- a/libstdc++-v3/include/std/optional\n+++ b/libstdc++-v3/include/std/optional\n@@ -1618,8 +1618,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n template\n \trequires is_constructible_v<_Tp&, _Up>\n \t && (!reference_constructs_from_temporary_v<_Tp&, _Up>)\n-\tconstexpr\n-\t_Tp&\n+\tconstexpr _Tp&\n \templace(_Up&& __u)\n \tnoexcept(is_nothrow_constructible_v<_Tp&, _Up>)\n \t{\n@@ -1631,9 +1630,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \n // Swap.\n constexpr void swap(optional& __rhs) noexcept\n- {\n-\tswap(_M_val, __rhs._M_val);\n- }\n+ { std::swap(_M_val, __rhs._M_val); }\n \n // Iterator support.\n constexpr iterator begin() const noexcept\ndiff --git a/libstdc++-v3/testsuite/20_util/optional/ref/assign.cc b/libstdc++-v3/testsuite/20_util/optional/ref/assign.cc\nnew file mode 100644\nindex 000000000000..c6d0e3fe0ec2\n--- /dev/null\n+++ b/libstdc++-v3/testsuite/20_util/optional/ref/assign.cc\n@@ -0,0 +1,430 @@\n+// { dg-do run { target c++26 } }\n+\n+#include \n+#include \n+#include \n+\n+struct NonTrivial\n+{\n+ constexpr NonTrivial() {}\n+ constexpr NonTrivial(NonTrivial const&) {};\n+ constexpr ~NonTrivial() {};\n+};\n+\n+struct NonMovable\n+{\n+ NonMovable() = default;\n+ NonMovable(NonMovable&&) = delete;\n+};\n+\n+template\n+struct Conv\n+{\n+ T t;\n+\n+ constexpr operator T() const noexcept\n+ { return t; }\n+};\n+\n+struct Tracker\n+{\n+ struct Counter\n+ { \n+ int copy;\n+ int move;\n+ };\n+\n+ Counter ctor{0,0};\n+ Counter assign{0,0};\n+\n+ Tracker() = default;\n+\n+ constexpr Tracker(Tracker const& o)\n+ : ctor(o.ctor), assign(o.assign)\n+ {\n+ ctor.copy += 1;\n+ }\n+\n+ constexpr Tracker(Tracker&& o)\n+ : ctor(o.ctor), assign(o.assign)\n+ {\n+ ctor.move += 1;\n+ }\n+\n+ constexpr Tracker& operator=(const Tracker& o)\n+ {\n+ assign.copy += 1;\n+ return *this;\n+ }\n+\n+ constexpr Tracker& operator=(Tracker&& o)\n+ {\n+ assign.move += 1;\n+ return *this;\n+ }\n+\n+};\n+\n+template\n+void\n+test_trivial()\n+{\n+ static_assert(std::is_copy_assignable_v>);\n+ static_assert(std::is_move_assignable_v>);\n+}\n+\n+constexpr void\n+test_trivial_all()\n+{\n+ test_trivial();\n+ test_trivial();\n+ test_trivial>();\n+}\n+\n+constexpr void\n+test_copy()\n+{\n+ Tracker t, u;\n+ std::optional e;\n+ std::optional o1(t);\n+ std::optional o2(u);\n+ \n+ o2 = o1;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &t );\n+ VERIFY( o2.has_value() );\n+ VERIFY( &o2.value() == &t );\n+ VERIFY( t.ctor.copy == 0 );\n+ VERIFY( t.ctor.move == 0 );\n+ VERIFY( t.assign.copy == 0 );\n+ VERIFY( t.assign.move == 0 );\n+\n+ o2 = e;\n+ VERIFY( !o2.has_value() );\n+\n+ o2 = std::move(o1);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &t );\n+ VERIFY( o2.has_value() );\n+ VERIFY( &o2.value() == &t );\n+ VERIFY( t.ctor.copy == 0 );\n+ VERIFY( t.ctor.move == 0 );\n+ VERIFY( t.assign.copy == 0 );\n+ VERIFY( t.assign.move == 0 );\n+\n+ o2 = std::move(e);\n+ VERIFY( !o2.has_value() );\n+}\n+\n+template\n+concept can_emplace = requires (T t, U&& u)\n+{ t.emplace(std::forward(u)); };\n+\n+constexpr void\n+test_from_value()\n+{\n+ NonTrivial v, u;\n+ const NonTrivial& cv = v;\n+ const std::optional s(u);\n+ std::optional o1;\n+ std::optional co1;\n+ \n+ o1 = s;\n+ o1 = v;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ \n+ o1.reset();\n+ VERIFY( !o1.has_value() );\n+\n+ o1 = v;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const NonTrivial&> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t NonTrivial> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const NonTrivial> );\n+\n+ o1 = s;\n+ o1.emplace(v);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+\n+ o1 = std::nullopt;\n+ VERIFY( !o1.has_value() );\n+\n+ o1.emplace(v);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+\n+ static_assert( !can_emplace, const NonTrivial&> );\n+ static_assert( !can_emplace, NonTrivial> );\n+ static_assert( !can_emplace, const NonTrivial> );\n+ \n+ co1 = s;\n+ co1 = v;\n+ VERIFY( co1.has_value() );\n+ VERIFY( &co1.value() == &v );\n+\n+ co1 = std::nullopt;\n+ co1 = cv;\n+ VERIFY( co1.has_value() );\n+ VERIFY( &co1.value() == &v );\n+ // No binding to rvalue\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t NonTrivial> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const NonTrivial> );\n+\n+ co1 = std::nullopt;\n+ co1.emplace(v);\n+ VERIFY( co1.has_value() );\n+ VERIFY( &co1.value() == &v );\n+ \n+ co1 = s;\n+ co1.emplace(cv);\n+ VERIFY( co1.has_value() );\n+ VERIFY( &co1.value() == &v );\n+ // No binding to rvalue\n+ static_assert( !can_emplace, const NonTrivial> );\n+ static_assert( !can_emplace, NonTrivial> );\n+\n+\n+ // Conversion create a pr-value that would bind to temporary\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t Conv&> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const Conv&> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t Conv> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const Conv> );\n+\n+ static_assert( !can_emplace, Conv&> );\n+ static_assert( !can_emplace, const Conv&> );\n+ static_assert( !can_emplace, Conv> );\n+ static_assert( !can_emplace, const Conv> );\n+\n+ Conv rw(v);\n+ const Conv crw(v);\n+\n+ o1 = std::nullopt;\n+ o1 = rw;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ o1 = s;\n+ o1 = crw;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ o1 = s;\n+ o1 = std::move(rw);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ o1 = std::nullopt;\n+ o1 = std::move(crw);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+\n+ o1 = s;\n+ o1.emplace(rw);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ o1 = std::nullopt;\n+ o1.emplace(crw);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ o1 = std::nullopt;\n+ o1.emplace(std::move(rw));\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+ o1 = s;\n+ o1.emplace(std::move(crw));\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v );\n+}\n+\n+constexpr void\n+test_from_opt_value()\n+{\n+ NonTrivial u;\n+ std::optional v(std::in_place);\n+ const std::optional& cv = v;\n+\n+ const std::optional s(u);\n+ std::optional o1;\n+ std::optional co1;\n+\n+ o1 = s;\n+ o1 = v;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v.value() );\n+ o1 = std::nullopt;\n+ o1 = v;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v.value() );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const std::optional&> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t std::optional> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const std::optional> );\n+\n+ co1 = s;\n+ co1 = v;\n+ VERIFY( co1.has_value() );\n+ VERIFY( &co1.value() == &v.value() );\n+ co1 = std::nullopt;\n+ co1 = cv;\n+ VERIFY( co1.has_value() );\n+ VERIFY( &co1.value() == &v.value() );\n+ // No binding to rvalue\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t std::optional> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const std::optional> );\n+\n+ // Conversion create a pr-value that would bind to temporary\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t std::optional>&> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const std::optional>&> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t std::optional>> );\n+ static_assert( !std::is_assignable_v,\n+\t\t\t\t const std::optional>> );\n+\n+ std::optional> rw(*v);\n+ std::optional> crw(*v);\n+\n+ o1 = std::nullopt;\n+ o1 = rw;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v.value() );\n+ o1 = s;\n+ o1 = crw;\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v.value() );\n+ o1 = s;\n+ o1 = std::move(rw);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v.value() );\n+ o1 = std::nullopt;\n+ o1 = std::move(crw);\n+ VERIFY( o1.has_value() );\n+ VERIFY( &o1.value() == &v.value() );\n+}\n+\n+constexpr void\n+test_to_opt_value()\n+{\n+ Tracker t;\n+ std::optional er;\n+ std::optional r(t);\n+ const std::optional cr(t);\n+\n+ std::optional o1;\n+ o1 = r;\n+ VERIFY( o1.has_value() );\n+ VERIFY( o1->ctor.copy == 1 );\n+ VERIFY( o1->ctor.move == 0 );\n+ VERIFY( o1->assign.copy == 0 );\n+ VERIFY( o1->assign.move == 0 );\n+\n+ o1 = r;\n+ VERIFY( o1.has_value() );\n+ VERIFY( o1->ctor.copy == 1 );\n+ VERIFY( o1->ctor.move == 0 );\n+ VERIFY( o1->assign.copy == 1 );\n+ VERIFY( o1->assign.move == 0 );\n+\n+ o1 = er;\n+ VERIFY( !o1.has_value() );\n+\n+ o1 = cr;\n+ VERIFY( o1.has_value() );\n+ VERIFY( o1->ctor.copy == 1 );\n+ VERIFY( o1->ctor.move == 0 );\n+ VERIFY( o1->assign.copy == 0 );\n+ VERIFY( o1->assign.move == 0 );\n+\n+ o1 = cr;\n+ VERIFY( o1.has_value() );\n+ VERIFY( o1->ctor.copy == 1 );\n+ VERIFY( o1->ctor.move == 0 );\n+ VERIFY( o1->assign.copy == 1 );\n+ VERIFY( o1->assign.move == 0 );\n+ \n+ o1 = std::move(er);\n+\n+ o1 = std::move(r);\n+ VERIFY( o1.has_value() );\n+ VERIFY( o1->ctor.copy == 1 );\n+ VERIFY( o1->ctor.move == 0 );\n+ VERIFY( o1->assign.copy == 0 );\n+ VERIFY( o1->assign.move == 0 );\n+\n+ o1 = std::move(cr);\n+ VERIFY( o1.has_value() );\n+ VERIFY( o1->ctor.copy == 1 );\n+ VERIFY( o1->ctor.move == 0 );\n+ VERIFY( o1->assign.copy == 1 );\n+ VERIFY( o1->assign.move == 0 );\n+}\n+\n+constexpr void\n+test_swap()\n+{\n+ NonMovable a, b;\n+ std::optional oa(a), ob(b);\n+\n+ oa.swap(ob);\n+ static_assert(noexcept(oa.swap(ob)));\n+ VERIFY( oa.has_value() );\n+ VERIFY( &oa.value() == &b );\n+ VERIFY( ob.has_value() );\n+ VERIFY( &ob.value() == &a );\n+\n+ swap(oa, ob);\n+ static_assert(std::is_nothrow_swappable_v>);\n+ VERIFY( oa.has_value() );\n+ VERIFY( &oa.value() == &a );\n+ VERIFY( ob.has_value() );\n+ VERIFY( &ob.value() == &b );\n+\n+ ob.reset();\n+ oa.swap(ob);\n+ VERIFY( !oa.has_value() );\n+ VERIFY( ob.has_value() );\n+ VERIFY( &ob.value() == &a );\n+\n+ ob.reset();\n+ std::swap(oa, ob);\n+ VERIFY( !oa.has_value() );\n+ VERIFY( !ob.has_value() );\n+\n+ std::optional ca(a), cb(b);\n+ swap(ca, cb);\n+ VERIFY( ca.has_value() );\n+ VERIFY( &ca.value() == &b );\n+ VERIFY( cb.has_value() );\n+ VERIFY( &cb.value() == &a );\n+\n+ static_assert(!std::is_swappable_with_v&, std::optional&>);\n+}\n+\n+int main()\n+{\n+ auto test_all = [] {\n+ test_copy();\n+ test_from_value();\n+ test_from_opt_value();\n+ test_to_opt_value();\n+ test_swap();\n+ return true;\n+ };\n+\n+ test_all();\n+ static_assert(test_all());\n+}\n","prefixes":["v1","06/13"]}