{"id":2226775,"url":"http://patchwork.ozlabs.org/api/patches/2226775/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260422193621.707020-1-dmitry.mityugov@gmail.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422193621.707020-1-dmitry.mityugov@gmail.com>","list_archive_url":null,"date":"2026-04-22T19:34:48","name":"[ovs-dev,v3] expr: Fix an old copy/paste error.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c2813785d779654830829a124b8589c6022b396c","submitter":{"id":92493,"url":"http://patchwork.ozlabs.org/api/people/92493/?format=json","name":"Dmitry Mityugov","email":"dmitry.mityugov@gmail.com"},"delegate":{"id":94943,"url":"http://patchwork.ozlabs.org/api/users/94943/?format=json","username":"dceara","first_name":"Dumitru","last_name":"Ceara","email":"dceara@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260422193621.707020-1-dmitry.mityugov@gmail.com/mbox/","series":[{"id":501095,"url":"http://patchwork.ozlabs.org/api/series/501095/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=501095","date":"2026-04-22T19:34:48","name":"[ovs-dev,v3] expr: Fix an old copy/paste error.","version":3,"mbox":"http://patchwork.ozlabs.org/series/501095/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226775/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2226775/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=V472wfMZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=V472wfMZ","smtp4.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g18cV35pxz1y2d\n\tfor ; Thu, 23 Apr 2026 05:36:58 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4DB3B4058B;\n\tWed, 22 Apr 2026 19:36:56 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id q5WvbCnvdNRI; Wed, 22 Apr 2026 19:36:55 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 626B94057A;\n\tWed, 22 Apr 2026 19:36:55 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 2BC4DC058E;\n\tWed, 22 Apr 2026 19:36:55 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id C0A8BC058D\n for ; Wed, 22 Apr 2026 19:36:53 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id ABDED4057A\n for ; Wed, 22 Apr 2026 19:36:53 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ERRET4cn2qkv for ;\n Wed, 22 Apr 2026 19:36:53 +0000 (UTC)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n [IPv6:2a00:1450:4864:20::335])\n by smtp4.osuosl.org (Postfix) with ESMTPS id CB54240578\n for ; Wed, 22 Apr 2026 19:36:52 +0000 (UTC)","by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-4891c00e7aeso35555855e9.2\n for ; Wed, 22 Apr 2026 12:36:52 -0700 (PDT)","from localhost.localdomain ([5.8.36.110])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc0f82bbsm791851335e9.3.2026.04.22.12.36.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 12:36:49 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 626B94057A","OpenDKIM Filter v2.11.0 smtp4.osuosl.org CB54240578"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com;\n envelope-from=dmitry.mityugov@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org CB54240578","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776886610; x=1777491410; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=7bq2heeJ7mTa8uYD5w5GzpnGxwGuiANWXBPu72J+1e4=;\n b=V472wfMZMdhpN3MeLV8OjJvBZFFBfc0nX9wODWf2TItHe6L7mNDlSsvhv8tZoKC3az\n sMnT/GxTr9FJn4dIy+TF41tchNGwsB5kgNMnW8hPo08/IUUKPLhVrzIJJfJe3qgDe6gK\n 0PnsX3Bucf49Hifq6udu3V2phWgFIa6qyJ+kM5F9TNYQcy7aRseQYULLmUgpR6vekYH3\n /Pzc2JHjnYbgvpE9J2pchnL4JsbyoE2cdyd0/XJBBEGGv3hODYqZ5BTMtUQvW38P52nA\n UakssXdz+PLXV+CKsOlkpH9U/vPm12tSn/3dh47RwNnOfwfGLi4WHcwM2BH214+pnIv/\n s6nA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776886610; x=1777491410;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7bq2heeJ7mTa8uYD5w5GzpnGxwGuiANWXBPu72J+1e4=;\n b=puuivpQmAKp1rjzt7VOIhD/rmLJFNhWGV0n1GFh9o473ExGTmNow/Uzov9/Nzrke7C\n sbZMYactMhMoNNs4elQ7a9wpf7R+pawNcsngCI7IQU7FFPyYr/w6s4yeKo24vNLRJw5u\n 0pSOu7aflUNpQG7FuAS+Uj4ha4FsrU4BKcxSBV8/Udqm7AvHxx1cEYG7fwBUC7Tm3vM5\n VBCzWteo49MgcwQzKCzpfv3ufJFEXPjDyQBmf8CXTD0U9JELLLC6JAo7k4mgVCUasTeD\n mi8jtIiX6U0BvNnGnldVx1sYtEXyzusZO0pd15fiSCITN6+QY8YjHfYKYyxTSRqbv51y\n /oSg==","X-Gm-Message-State":"AOJu0Yz5Q8LYENJ19fQtOxaoJicTTdlcbbdp2jJE/Gn4RSK/hu1MKq+w\n CUMmsgc3VsovPTCkmYQXik0Zmd2hOA5p7dmJLg8zKQ+W7NlsX8uCGeQlzecw36bOGin/dHnG","X-Gm-Gg":"AeBDiet6xcTouxkZ2l9IknA1kLBAoL31eP/Bfare+GeruovQ5KJwdgzYLivqoRvAVt7\n Ab5v3LenuOOWekP2QAPHyhVGysRMY085ArrvlZyg+tzvY214apbYyuyE/vhVlSYSo46vySUVlal\n oBFSr+3/0oPSCxshjxBYeo3fYOmvHo/ZQm6f89rmjaNBluhbTeUnp2pF6wPEXkyFqMrA1Xfqs40\n 7+17no6Bazdh7HIHzsFG/sfAfuSn1k6mjvGxdcX2onJRfN7zXRDsbPrC/rS6QoXYRzvg31pbSGJ\n Y1Q4n5CLp7ssJNxoEyyT9Y4XrM7f3Yozqc800VIxJn6b0zVg6CEBQxqOdXoxzMil2ho1uDDBBCR\n Z9BBX/ZqwKvfiL0mUPugp/9xSrCRIiX5jgurlsP1Zre8E4s0nuHXLjEdkQpPX3tNcIxSkX6D124\n 2H9w65pTOMI8Rvit3Z0cYY/DLmGAluSuOT9Z0CIbd7auQ9mfBrsg==","X-Received":"by 2002:a05:600c:890c:b0:485:3ff1:d5ed with SMTP id\n 5b1f17b1804b1-488fb739cd9mr284779885e9.1.1776886610003;\n Wed, 22 Apr 2026 12:36:50 -0700 (PDT)","From":"Dmitry Mityugov ","To":"ovs-dev@openvswitch.org","Date":"Wed, 22 Apr 2026 22:34:48 +0300","Message-ID":"<20260422193621.707020-1-dmitry.mityugov@gmail.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH ovn v3] expr: Fix an old copy/paste error.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Without this fix, expression\n\na_type < b_type ? -1 : a_type > b_type\n\nalways evaluates to 0.\n\nOriginally discovered with cppcheck.\n\nSigned-off-by: Dmitry Mityugov \n---\nFixed the remaining warning from the bot, resending with the patch\nversion bumped up.\n\n lib/expr.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/lib/expr.c b/lib/expr.c\nindex 288e245c6..3c506c42c 100644\n--- a/lib/expr.c\n+++ b/lib/expr.c\n@@ -2366,7 +2366,7 @@ compare_expr_sort(const void *a_, const void *b_)\n }\n \n enum expr_type a_type = a->expr->type;\n- enum expr_type b_type = a->expr->type;\n+ enum expr_type b_type = b->expr->type;\n return a_type < b_type ? -1 : a_type > b_type;\n } else if (a->type == EXPR_T_AND || a->type == EXPR_T_OR) {\n size_t a_len = ovs_list_size(&a->expr->andor);\n","prefixes":["ovs-dev","v3"]}