{"id":2226769,"url":"http://patchwork.ozlabs.org/api/patches/2226769/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhup55wx16.gcc.gcc-TEST.tkaminsk.85.1.10@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-22T18:49:47","name":"[v1,10/10] Small cleanups","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1adf6a4be94e472a1040b1370ae6a0704cedcd19","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/?format=json","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhup55wx16.gcc.gcc-TEST.tkaminsk.85.1.10@forge-stage.sourceware.org/mbox/","series":[{"id":501094,"url":"http://patchwork.ozlabs.org/api/series/501094/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501094","date":"2026-04-22T18:49:39","name":"WIP: libstdc++: add support for cv-qualified types in atomic_ref (P3323R1)","version":1,"mbox":"http://patchwork.ozlabs.org/series/501094/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226769/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226769/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g18Xj383Sz1yD5\n\tfor ; Thu, 23 Apr 2026 05:33:41 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 765E7442FC33\n\tfor ; Wed, 22 Apr 2026 19:33:39 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id CF708407EE05\n for ; Wed, 22 Apr 2026 18:51:10 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 60A2B43599\n for ; Wed, 22 Apr 2026 18:51:08 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 765E7442FC33","OpenDKIM Filter v2.11.0 sourceware.org CF708407EE05"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org CF708407EE05","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org CF708407EE05","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776883870; cv=none;\n b=mMnsKGfkll5lk1buEtLS+G9/QSKYc8XBoh2QvCsG7Q96YW7ugHq1NnTXbd4dPNgCusIDVZFUSbZR+SCLgU1eWgc2mlMD/WQoNAb39/IIMFqzLSq00SuUiL+XLqOKXVFBqfSdPeZeomaliHqdTzd8TYhhjNkzssbA+RKYux2Njxs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776883870; c=relaxed/simple;\n bh=dnxVa481ze70oSE28MGlV4g594PgBcM4uSk7ayCzxIw=;\n h=From:Date:Subject:MIME-Version:To:Message-ID;\n b=F4mpW/7EhYJaQ4ArcygPigC43nNugB3m1TLY65FdnfsIW/T0tCJg2Ip0QX+iUEIfjz2Z+J83v2/wkI1xces+FujHmLS44WCKnejl4xNqOOkBhYjMuKKrd3Hqxb6I18q/fpiC58o8MMJZuz9X53dRfoSWcV/3M6zS7p71NfTLQhY=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"tkaminsk via Sourceware Forge\n ","Date":"Wed, 22 Apr 2026 18:49:47 +0000","Subject":"[PATCH v1 10/10] Small cleanups","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","To":"gcc-patches mailing list ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/85","References":"\n ","In-Reply-To":"\n ","X-Patch-URL":"\n https://forge.sourceware.org/tkaminsk/gcc/commit/65be5d0f035c0ac888b149feb12492eaff04492c","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"gcc-patches mailing list ,\n tkaminsk@gcc.gnu.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Tomasz Kamiński \n\n---\n libstdc++-v3/include/bits/atomic_base.h | 20 ++++++++++---------\n libstdc++-v3/include/std/atomic | 5 ++++-\n .../29_atomics/atomic_ref/cv_qual.cc | 4 ++--\n .../29_atomics/atomic_ref/op_support.cc | 4 ++--\n .../29_atomics/atomic_ref/requirements_neg.cc | 2 +-\n 5 files changed, 20 insertions(+), 15 deletions(-)","diff":"diff --git a/libstdc++-v3/include/bits/atomic_base.h b/libstdc++-v3/include/bits/atomic_base.h\nindex d3a935b0ba88..5b8c2d49e9bc 100644\n--- a/libstdc++-v3/include/bits/atomic_base.h\n+++ b/libstdc++-v3/include/bits/atomic_base.h\n@@ -1552,7 +1552,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n static_assert(is_trivially_copyable_v);\n \n static constexpr bool is_always_lock_free = _S_is_always_lock_free();\n- static_assert(is_always_lock_free || !is_volatile_v<_Tp>);\n+ static_assert(is_always_lock_free || !is_volatile_v<_Tp>,\n+\t\"atomic_ref of volatile-qualified type is only sypported if operations are lock-free\");\n \n static constexpr size_t required_alignment = _S_required_aligment();\n \n@@ -1561,7 +1562,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \n explicit\n __atomic_ref_base(const _Tp& __t)\n- : _M_ptr(const_cast<_Tp*>(std::__addressof(__t)))\n+\t: _M_ptr(const_cast<_Tp*>(std::__addressof(__t)))\n {\n \t__glibcxx_assert(((__UINTPTR_TYPE__)_M_ptr % required_alignment) == 0);\n }\n@@ -1581,8 +1582,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n #if __glibcxx_atomic_wait\n _GLIBCXX_ALWAYS_INLINE void\n wait(value_type __old, memory_order __m = memory_order_seq_cst) const noexcept\n- { \n- // TODO remove when volatile is supported\n+ {\n+\t// TODO remove when volatile is supported\n \tstatic_assert(!is_volatile_v<_Tp>, \"atomics wait on volatile are not supported\");\n \t__atomic_impl::wait(_M_ptr, __old, __m);\n }\n@@ -1601,6 +1602,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n explicit\n __atomic_ref_base(_Tp& __t) : __atomic_ref_base(__t)\n { }\n+\n value_type\n operator=(value_type __t) const noexcept\n {\n@@ -1641,7 +1643,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n const noexcept\n {\n \treturn compare_exchange_weak(__expected, __desired, __order,\n- __cmpexch_failure_order(__order));\n+\t\t\t\t __cmpexch_failure_order(__order));\n }\n \n bool\n@@ -1657,7 +1659,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n _GLIBCXX_ALWAYS_INLINE void\n notify_one() const noexcept\n {\n- // TODO remove when volatile is supported\n+\t// TODO remove when volatile is supported\n \tstatic_assert(!is_volatile_v<_Tp>, \"atomics wait on volatile are not supported\");\n \t__atomic_impl::notify_one(this->_M_ptr);\n }\n@@ -1665,9 +1667,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n _GLIBCXX_ALWAYS_INLINE void\n notify_all() const noexcept\n {\n- // TODO remove when volatile is supported\n+\t// TODO remove when volatile is supported\n \tstatic_assert(!is_volatile_v<_Tp>, \"atomics wait on volatile are not supported\");\n- __atomic_impl::notify_all(this->_M_ptr);\n+\t__atomic_impl::notify_all(this->_M_ptr);\n }\n #endif // __glibcxx_atomic_wait\n };\n@@ -1785,7 +1787,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \n using __atomic_ref_base<_Fp>::__atomic_ref_base;\n using __atomic_ref_base<_Fp>::operator=;\n- \n+\n value_type\n fetch_add(value_type __i,\n \t\tmemory_order __m = memory_order_seq_cst) const noexcept\ndiff --git a/libstdc++-v3/include/std/atomic b/libstdc++-v3/include/std/atomic\nindex 17b4e61b3319..1ea28b1d7429 100644\n--- a/libstdc++-v3/include/std/atomic\n+++ b/libstdc++-v3/include/std/atomic\n@@ -216,7 +216,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \n static_assert(sizeof(_Tp) > 0,\n \t\t \"Incomplete or zero-sized types are not supported\");\n- static_assert(is_same_v<_Tp, remove_cv_t<_Tp>>,\n+\n+ // _GLIBCXX_RESOLVE_LIB_DEFECTS\n+ // 4069. std::atomic should be ill-formed\n+ static_assert(is_same<_Tp, typename remove_cv<_Tp>::type>::value,\n \t\t \"cv-qualified types are not supported\");\n \n #if __cplusplus > 201703L\ndiff --git a/libstdc++-v3/testsuite/29_atomics/atomic_ref/cv_qual.cc b/libstdc++-v3/testsuite/29_atomics/atomic_ref/cv_qual.cc\nindex cc397de6ec61..dfc6a5599451 100644\n--- a/libstdc++-v3/testsuite/29_atomics/atomic_ref/cv_qual.cc\n+++ b/libstdc++-v3/testsuite/29_atomics/atomic_ref/cv_qual.cc\n@@ -42,13 +42,13 @@ test01(V v0, V v1)\n {\n std::atomic_ref a(value);\n VERIFY( a.is_lock_free() );\n- \n+\n a = v0;\n VERIFY( V(a) == v0 );\n VERIFY( a.load() == v0 );\n \n a.store(v1);\n- VERIFY( a.load() == v1 ); \n+ VERIFY( a.load() == v1 );\n \n V last = a.exchange(v0);\n VERIFY( a.load() == v0 );\ndiff --git a/libstdc++-v3/testsuite/29_atomics/atomic_ref/op_support.cc b/libstdc++-v3/testsuite/29_atomics/atomic_ref/op_support.cc\nindex 8865345a0416..93c65dce2636 100644\n--- a/libstdc++-v3/testsuite/29_atomics/atomic_ref/op_support.cc\n+++ b/libstdc++-v3/testsuite/29_atomics/atomic_ref/op_support.cc\n@@ -87,11 +87,11 @@ struct S\n int y;\n };\n \n-int main() \n+int main()\n {\n no_mutations();\n no_mutations();\n- \n+\n no_bitops();\n no_bitops();\n no_mutations();\ndiff --git a/libstdc++-v3/testsuite/29_atomics/atomic_ref/requirements_neg.cc b/libstdc++-v3/testsuite/29_atomics/atomic_ref/requirements_neg.cc\nindex 9aa4123a0654..8b0abbde023f 100644\n--- a/libstdc++-v3/testsuite/29_atomics/atomic_ref/requirements_neg.cc\n+++ b/libstdc++-v3/testsuite/29_atomics/atomic_ref/requirements_neg.cc\n@@ -6,7 +6,7 @@ template\n struct NonTrivial\n {\n NonTrivial() = default;\n- NonTrivial(NonTrivial const&) { }; \n+ NonTrivial(NonTrivial const&) { };\n };\n \n template\n","prefixes":["v1","10/10"]}