{"id":2226751,"url":"http://patchwork.ozlabs.org/api/patches/2226751/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuozlstss.gcc.gcc-TEST.tkaminsk.78.1.12@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-22T18:44:10","name":"[v1,12/12] libstdc++: Simplify std::erase functions for sequence containers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9bc6bf3b56e9133e8d809d6f3e8c3ed178d1ff29","submitter":{"id":93223,"url":"http://patchwork.ozlabs.org/api/people/93223/?format=json","name":"tkaminsk via Sourceware Forge","email":"forge-bot+tkaminsk@forge-stage.sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuozlstss.gcc.gcc-TEST.tkaminsk.78.1.12@forge-stage.sourceware.org/mbox/","series":[{"id":501087,"url":"http://patchwork.ozlabs.org/api/series/501087/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501087","date":"2026-04-22T18:44:01","name":"remove-predefined-ops","version":1,"mbox":"http://patchwork.ozlabs.org/series/501087/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226751/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226751/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g18DW6Qz0z1yD5\n\tfor ; Thu, 23 Apr 2026 05:19:38 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id CCE474AB088C\n\tfor ; Wed, 22 Apr 2026 19:19:36 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 71A3F40A0CF5\n for ; Wed, 22 Apr 2026 18:45:35 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id C753F4352C\n for ; Wed, 22 Apr 2026 18:45:33 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org CCE474AB088C","OpenDKIM Filter v2.11.0 sourceware.org 71A3F40A0CF5"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 71A3F40A0CF5","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 71A3F40A0CF5","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776883535; cv=none;\n b=hBqD+VCrgBXtepN/Gu8fjcbd/8XPna3q+KqIkYfMgwNH1gs/nLEroLGpY8/8KQQA0Nxf8ee9p3d26o/qlecy34elyj/STzib2NXdytUTPZtKeLFOM8zloR03gl7cr2RdH2sMEl/yMt1GSOgHTfyZkDV9he4cWIYBVf9572yVDrM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776883535; c=relaxed/simple;\n bh=09V8NarUWrNjV8cbhPhD/sxy+y9OOx3deDHVHHNm80M=;\n h=From:Date:Subject:To:Message-ID;\n b=wDvgwMXfdfMRUMUnRon2sP1z1rgjoCCBbUHeINuX3CBKWdaGc7MGZLDHkE9vbkv+Jug62oonPZMRnvwUFHpDtRaKPtruMmNa+gRqwkG+b22iyzBKeX0K7oDxAYmmAE65vNA6NRQz92VqJPVSRg/1KWaB1rslkdq9tdj4enlGAuw=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"tkaminsk via Sourceware Forge\n ","Date":"Wed, 22 Apr 2026 18:44:10 +0000","Subject":"[PATCH v1 12/12] libstdc++: Simplify std::erase functions for\n sequence containers","To":"gcc-patches mailing list ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"fdumont","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/78","References":"\n ","In-Reply-To":"\n ","X-Patch-URL":"\n https://forge.sourceware.org/redi/gcc/commit/4d4a7dd885afca17a526caf504463310b3159587","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"gcc-patches mailing list ,\n tkaminsk@gcc.gnu.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Jonathan Wakely \n\nlibstdc++-v3/ChangeLog:\n\n\t* include/std/deque (erase_if): Move predicate instead of\n\twrapping with std::ref.\n\t(erase): Forward to erase_if.\n\t* include/std/inplace_vector (erase_if, erase): Likewise.\n\t* include/std/string (erase_if, erase): Likewise.\n\t* include/std/vector (erase_if, erase): Likewise.\n---\n libstdc++-v3/include/std/deque | 18 ++----------------\n libstdc++-v3/include/std/inplace_vector | 17 ++---------------\n libstdc++-v3/include/std/string | 13 +++----------\n libstdc++-v3/include/std/vector | 18 ++----------------\n 4 files changed, 9 insertions(+), 57 deletions(-)","diff":"diff --git a/libstdc++-v3/include/std/deque b/libstdc++-v3/include/std/deque\nindex 3b1a7dea2b10..e2725f3273d1 100644\n--- a/libstdc++-v3/include/std/deque\n+++ b/libstdc++-v3/include/std/deque\n@@ -109,7 +109,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n const auto __osz = __cont.size();\n const auto __end = __ucont.end();\n auto __removed = std::__remove_if(__ucont.begin(), __end,\n-\t\t\t\t\tstd::ref(__pred));\n+\t\t\t\t\tstd::move(__pred));\n if (__removed != __end)\n \t{\n \t __cont.erase(__niter_wrap(__cont.begin(), __removed),\n@@ -124,22 +124,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t typename _Up _GLIBCXX26_DEF_VAL_T(_Tp)>\n inline typename deque<_Tp, _Alloc>::size_type\n erase(deque<_Tp, _Alloc>& __cont, const _Up& __value)\n- {\n- using namespace __gnu_cxx;\n- _GLIBCXX_STD_C::deque<_Tp, _Alloc>& __ucont = __cont;\n- const auto __osz = __cont.size();\n- const auto __end = __ucont.end();\n- auto __removed = std::__remove_if(__ucont.begin(), __end,\n-\t\t\t\t\t__ops::__equal_to(__value));\n- if (__removed != __end)\n-\t{\n-\t __cont.erase(__niter_wrap(__cont.begin(), __removed),\n-\t\t __cont.end());\n-\t return __osz - __cont.size();\n-\t}\n+ { return std::erase_if(__cont, __gnu_cxx::__ops::__equal_to(__value)); }\n \n- return 0;\n- }\n _GLIBCXX_END_NAMESPACE_VERSION\n } // namespace std\n #endif // __cpp_lib_erase_if\ndiff --git a/libstdc++-v3/include/std/inplace_vector b/libstdc++-v3/include/std/inplace_vector\nindex b32aa4f3708c..e93332d919c1 100644\n--- a/libstdc++-v3/include/std/inplace_vector\n+++ b/libstdc++-v3/include/std/inplace_vector\n@@ -1343,7 +1343,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n const auto __osz = __cont.size();\n const auto __end = __cont.end();\n auto __removed = std::__remove_if(__cont.begin(), __end,\n-\t\t\t\t\tstd::ref(__pred));\n+\t\t\t\t\tstd::move(__pred));\n if (__removed != __end)\n \t{\n \t __cont.erase(__niter_wrap(__cont.begin(), __removed),\n@@ -1357,20 +1357,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n template\n constexpr size_t\n erase(inplace_vector<_Tp, _Nm>& __cont, const _Up& __value)\n- {\n- using namespace __gnu_cxx;\n- const auto __osz = __cont.size();\n- const auto __end = __cont.end();\n- auto __removed = std::__remove_if(__cont.begin(), __end,\n-\t\t\t\t\t__ops::__equal_to(__value));\n- if (__removed != __end)\n-\t{\n-\t __cont.erase(__niter_wrap(__cont.begin(), __removed),\n-\t\t __cont.end());\n-\t return __osz - __cont.size();\n-\t}\n- return 0;\n- }\n+ { return std::erase_if(__cont, __gnu_cxx::__ops::__equal_to(__value)); }\n \n _GLIBCXX_END_NAMESPACE_VERSION\n } // namespace\ndiff --git a/libstdc++-v3/include/std/string b/libstdc++-v3/include/std/string\nindex 74e0c7f2be58..58f6f33d38ad 100644\n--- a/libstdc++-v3/include/std/string\n+++ b/libstdc++-v3/include/std/string\n@@ -104,7 +104,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n const auto __osz = __cont.size();\n const auto __end = __cont.end();\n auto __removed = std::__remove_if(__cont.begin(), __end,\n-\t\t\t\t\tstd::ref(__pred));\n+\t\t\t\t\tstd::move(__pred));\n __cont.erase(__removed, __end);\n return __osz - __cont.size();\n }\n@@ -114,15 +114,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n _GLIBCXX20_CONSTEXPR\n inline typename basic_string<_CharT, _Traits, _Alloc>::size_type\n erase(basic_string<_CharT, _Traits, _Alloc>& __cont, const _Up& __value)\n- {\n- using namespace __gnu_cxx;\n- const auto __osz = __cont.size();\n- const auto __end = __cont.end();\n- auto __removed = std::__remove_if(__cont.begin(), __end,\n-\t\t\t\t\t__ops::__equal_to(__value));\n- __cont.erase(__removed, __end);\n- return __osz - __cont.size();\n- }\n+ { return std::erase_if(__cont, __gnu_cxx::__ops::__equal_to(__value)); }\n+\n _GLIBCXX_END_NAMESPACE_VERSION\n } // namespace std\n #endif // __cpp_lib_erase_if\ndiff --git a/libstdc++-v3/include/std/vector b/libstdc++-v3/include/std/vector\nindex 47105210bc0c..d693ec1156bd 100644\n--- a/libstdc++-v3/include/std/vector\n+++ b/libstdc++-v3/include/std/vector\n@@ -122,7 +122,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n const auto __osz = __cont.size();\n const auto __end = __ucont.end();\n auto __removed = std::__remove_if(__ucont.begin(), __end,\n-\t\t\t\t\tstd::ref(__pred));\n+\t\t\t\t\tstd::move(__pred));\n if (__removed != __end)\n \t{\n \t __cont.erase(__niter_wrap(__cont.begin(), __removed),\n@@ -138,22 +138,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n _GLIBCXX20_CONSTEXPR\n inline typename vector<_Tp, _Alloc>::size_type\n erase(vector<_Tp, _Alloc>& __cont, const _Up& __value)\n- {\n- using namespace __gnu_cxx;\n- _GLIBCXX_STD_C::vector<_Tp, _Alloc>& __ucont = __cont;\n- const auto __osz = __cont.size();\n- const auto __end = __ucont.end();\n- auto __removed = std::__remove_if(__ucont.begin(), __end,\n-\t\t\t\t\t__ops::__equal_to(__value));\n- if (__removed != __end)\n-\t{\n-\t __cont.erase(__niter_wrap(__cont.begin(), __removed),\n-\t\t __cont.end());\n-\t return __osz - __cont.size();\n-\t}\n+ { return std::erase_if(__cont, __gnu_cxx::__ops::__equal_to(__value)); }\n \n- return 0;\n- }\n _GLIBCXX_END_NAMESPACE_VERSION\n } // namespace std\n #endif // __cpp_lib_erase_if\n","prefixes":["v1","12/12"]}