{"id":2226739,"url":"http://patchwork.ozlabs.org/api/patches/2226739/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260422191039.706714-1-dmitry.mityugov@gmail.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422191039.706714-1-dmitry.mityugov@gmail.com>","list_archive_url":null,"date":"2026-04-22T19:06:34","name":"[ovs-dev,v2] expr: fix an old copy/paste error.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c2813785d779654830829a124b8589c6022b396c","submitter":{"id":92493,"url":"http://patchwork.ozlabs.org/api/people/92493/?format=json","name":"Dmitry Mityugov","email":"dmitry.mityugov@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260422191039.706714-1-dmitry.mityugov@gmail.com/mbox/","series":[{"id":501089,"url":"http://patchwork.ozlabs.org/api/series/501089/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=501089","date":"2026-04-22T19:06:34","name":"[ovs-dev,v2] expr: fix an old copy/paste error.","version":2,"mbox":"http://patchwork.ozlabs.org/series/501089/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226739/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2226739/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Bgw7XgGA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=Bgw7XgGA","smtp3.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g182f35FWz1yGs\n\tfor ; Thu, 23 Apr 2026 05:11:06 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 3B985605BD;\n\tWed, 22 Apr 2026 19:11:04 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id B_WObJG6_YBN; Wed, 22 Apr 2026 19:11:03 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 64759605A9;\n\tWed, 22 Apr 2026 19:11:03 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 3F1AAC058E;\n\tWed, 22 Apr 2026 19:11:03 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id EC37DC058D\n for ; Wed, 22 Apr 2026 19:11:01 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id DE310605A9\n for ; Wed, 22 Apr 2026 19:11:01 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id dQaE1NF9GAhO for ;\n Wed, 22 Apr 2026 19:11:01 +0000 (UTC)","from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com\n [IPv6:2a00:1450:4864:20::12d])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E8E7D605B1\n for ; Wed, 22 Apr 2026 19:11:00 +0000 (UTC)","by mail-lf1-x12d.google.com with SMTP id\n 2adb3069b0e04-59dcdf60427so5214703e87.3\n for ; Wed, 22 Apr 2026 12:11:00 -0700 (PDT)","from localhost.localdomain ([5.8.36.110])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a4185ad0b8sm4644462e87.15.2026.04.22.12.10.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 12:10:56 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 64759605A9","OpenDKIM Filter v2.11.0 smtp3.osuosl.org E8E7D605B1"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::12d; helo=mail-lf1-x12d.google.com;\n envelope-from=dmitry.mityugov@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org E8E7D605B1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776885058; x=1777489858; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=0q4GNmBlIrX1MRnzvdg72PWDwJlhJvyeqdIlt6GKbnA=;\n b=Bgw7XgGA+W+a24CVORQYOQJfhRU/2kovD9n10lzw1mZIPe3r1yvkrNYWyBAAASwGoC\n rsr7NA3NbylXOPrBEjQV2dMfbCUhp3sTxGZAF8aTFY+FZQxOSKL3bB+nfPbhvce2fmaA\n V4HWZqkmeNt5CEZrI80ROxz2Dii6lxGdmYNaNFU2ZEgBjrlq4ExsNfQit6n8xlshxDrg\n cKMJXGKZuYpnThIh+9R4kUIFP6SoO3DLVqo7gT2wbOw4Bwi1la1Q0ET9LQy9o6I0YN2i\n 4WR8tcPYlANXfRe282wf2bsZMs1Br9ooGIck0fZcVVhW5ujjJcIIsByeIATa5PeASYwO\n ajgw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776885058; x=1777489858;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0q4GNmBlIrX1MRnzvdg72PWDwJlhJvyeqdIlt6GKbnA=;\n b=h8rjvYXUIwA999y1K2TRwA2h8oaN0sJ6rOGehX73MseI1AHTCKghBlM0SmMjwIf4mB\n REBRwzsqCUL1ucClJDjuSq16VZcElhZAIgnLeozwHjdGPEMTb97NRedEkzLvH3rFgjy8\n nwtg4qQOh2UM64wJdFxDeiilw0NjsgmVByxCrQeCNi5CnBCBPamUy6vsHayvUrb96jUC\n P7uvN38JdA82cbtRM8DtQxQlT+GCxDZWi5DcjvCb5hpAruzLX4kqsnOcS3EvEvzJyIqy\n /ped7AXAhGHpkeyMTHHeZAbUtMIOKlRheVAS/w0d+jFirp0SEXse+DkTbmKVgbNYySHO\n mCvQ==","X-Gm-Message-State":"AOJu0YzorHPLEolW3d8FDEaNAGUk25w04VabazYrFRzHhlaW+zeS9R/o\n sxAZX4GaUIhulq+ZrarTWpWk7jRuLbQJcVx/ZzQao3+Q1EuB1hA3I2HosNvbY+F1i/peDFhz","X-Gm-Gg":"AeBDietnlFU7b4T868b+j6L1lhg/FEWIcUOwcE4a+9C6leUsnfiYZRFjbG9J/TaMHZF\n TQb8lySEiZ84WtkABd5abPi2F1mkZGe10LEiiXuwL+z7SJ0QsMMQ6MCQgBY5RWbgQrDJt0V4ceT\n +ZLAkY7oNxcXuvb3Z9L5wr9Df2vVcNFe9qsItZ+DuiuXwZ88gTT0ErL+sTPup2PHEhPsih/NeKa\n upGSzCM+kXkxHvUtjVfsFZQ7cyCOceqv5vJWI7dbFFGEy3NBEnALOT3Lq1Y/Jx5WK7gr+gu2qeR\n 3F9xGDpiZhH9q5MNV/+3WuspbXRlGhEiU11Y2n7BU04P/YULsoEiLjgBZe6bvrbypNumvd7JUuF\n xCGWDS+LS8cqQclOCdkX7Logh4T7JlBVJX+FHc+T7hrnm0AMV49NarXbCvdi+aREeZdix4qVXaY\n tz1oG6nmCFyBRUgJ0c2JcU8hTSsASZi0Kg95tyAniSF+ZfCsEx","X-Received":"by 2002:a05:6512:3da5:b0:5a4:8b:a067 with SMTP id\n 2adb3069b0e04-5a4172cae1dmr7441392e87.9.1776885057618;\n Wed, 22 Apr 2026 12:10:57 -0700 (PDT)","From":"Dmitry Mityugov ","To":"ovs-dev@openvswitch.org","Date":"Wed, 22 Apr 2026 22:06:34 +0300","Message-ID":"<20260422191039.706714-1-dmitry.mityugov@gmail.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH ovn v2] expr: fix an old copy/paste error.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Without this fix, expression\n\na_type < b_type ? -1 : a_type > b_type\n\nalways evaluates to 0.\n\nOriginally discovered with cppcheck.\n\nSigned-off-by: Dmitry Mityugov \n---\nThis new version of the patch correctly specifies in the subject line\nthat it is intended to OVN project. Hopefully, this will help the robot\nwith sha1 information errors.\n lib/expr.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/lib/expr.c b/lib/expr.c\nindex 288e245c6..3c506c42c 100644\n--- a/lib/expr.c\n+++ b/lib/expr.c\n@@ -2366,7 +2366,7 @@ compare_expr_sort(const void *a_, const void *b_)\n }\n \n enum expr_type a_type = a->expr->type;\n- enum expr_type b_type = a->expr->type;\n+ enum expr_type b_type = b->expr->type;\n return a_type < b_type ? -1 : a_type > b_type;\n } else if (a->type == EXPR_T_AND || a->type == EXPR_T_OR) {\n size_t a_len = ovs_list_size(&a->expr->andor);\n","prefixes":["ovs-dev","v2"]}