{"id":2226728,"url":"http://patchwork.ozlabs.org/api/patches/2226728/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuom29jc4.gcc.gcc-TEST.pinskia.61.1.4@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-22T18:30:29","name":"[v1,4/6] Copy prop into args","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ada5fd29d883668c76951fc1e7d872c3cf6ec067","submitter":{"id":93219,"url":"http://patchwork.ozlabs.org/api/people/93219/?format=json","name":"Andrew Pinski via Sourceware Forge","email":"forge-bot+pinskia@forge-stage.sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuom29jc4.gcc.gcc-TEST.pinskia.61.1.4@forge-stage.sourceware.org/mbox/","series":[{"id":501080,"url":"http://patchwork.ozlabs.org/api/series/501080/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501080","date":"2026-04-22T18:30:28","name":"copy-propv3","version":1,"mbox":"http://patchwork.ozlabs.org/series/501080/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226728/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226728/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g17j50SJ8z1yGs\n\tfor ; Thu, 23 Apr 2026 04:55:53 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 3A3F940A086B\n\tfor ; Wed, 22 Apr 2026 18:55:51 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 3F90C4BC8943\n for ; Wed, 22 Apr 2026 18:32:05 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 15667434D0\n for ; Wed, 22 Apr 2026 18:32:05 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 3A3F940A086B","OpenDKIM Filter v2.11.0 sourceware.org 3F90C4BC8943"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 3F90C4BC8943","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 3F90C4BC8943","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776882725; cv=none;\n b=m+wZkD7GBjD4TXU/5HlcVKxbmb+cYEh7fWu6y2KZDszmhdIsAiptqOnxLXwtPWMMRBiy5gJqlqTiqQeC/d6Oiq+NU46W1+hYhYoAAIaC0zw+NK//CrOj2rUJolgIBcqb2Oug7xNCI7a7LscSWynP/i1yIpaB/0oJVukkQtDYrFk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776882725; c=relaxed/simple;\n bh=3pST/uOkXa3dtblbCM6Tc1fMZcWGjzkkBMW1NC/N42E=;\n h=From:Date:Subject:To:Message-ID;\n b=LTm+pcStDlorRTW4UlVQadMPdGibcXl+JJWM8ZwYiv+PS7l0vzXBHA9ubYei+2MFasFFJia74dLp1p7NOh2smHCaxOt45iX3w29rRp6bbqbGBdUsuAiZsqcN5VK0/8JBQFo0w8mZUsbNljqtqoP/n/nnt+1uuflErA1EI3xbNIA=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"Andrew Pinski via Sourceware Forge\n ","Date":"Wed, 22 Apr 2026 18:30:29 +0000","Subject":"[PATCH v1 4/6] Copy prop into args","To":"gcc-patches mailing list ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/61","References":"\n ","In-Reply-To":"\n ","X-Patch-URL":"\n https://forge.sourceware.org/pinskia/gcc-TEST/commit/4c4e13da956cca477a4511ca1bb1260f753d6103","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"gcc-patches mailing list ,\n pinskia@gcc.gnu.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Andrew Pinski \n\ngcc/ChangeLog:\n\n\t* tree-ssa-forwprop.cc (optimize_agr_copyprop_1):\n\t(optimize_agr_copyprop_arg):\n\t(optimize_agr_copyprop):\n\nSigned-off-by: Andrew Pinski \n---\n gcc/tree-ssa-forwprop.cc | 151 ++++++++++++++++++++++++++-------------\n 1 file changed, 101 insertions(+), 50 deletions(-)","diff":"diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc\nindex ca2faf5468cc..852ef21b3acc 100644\n--- a/gcc/tree-ssa-forwprop.cc\n+++ b/gcc/tree-ssa-forwprop.cc\n@@ -1388,6 +1388,103 @@ optimize_aggr_zeroprop (gimple_stmt_iterator *gsip)\n \n return changed;\n }\n+\n+\n+static bool\n+optimize_agr_copyprop_1 (gimple *stmt, gimple *use_stmt,\n+\t\t\t tree dest, tree src)\n+{\n+ if (!gimple_assign_load_p (use_stmt)\n+ || !gimple_store_p (use_stmt))\n+ return false;\n+ if (gimple_has_volatile_ops (use_stmt))\n+ return false;\n+ tree dest2 = gimple_assign_lhs (use_stmt);\n+ tree src2 = gimple_assign_rhs1 (use_stmt);\n+ /* If the new store is `src2 = src2;` skip over it. */\n+ if (operand_equal_p (src2, dest2, 0))\n+ return false;\n+ if (!operand_equal_p (dest, src2, 0))\n+ return false;\n+ /* For 2 memory refences and using a temporary to do the copy,\n+ don't remove the temporary as the 2 memory references might overlap.\n+ Note t does not need to be decl as it could be field.\n+ See PR 22237 for full details.\n+ E.g.\n+ t = *a; #DEST = SRC;\n+ *b = t; #DEST2 = SRC2;\n+ Cannot be convert into\n+ t = *a;\n+ *b = *a;\n+ Though the following is allowed to be done:\n+ t = *a;\n+ *a = t;\n+ And convert it into:\n+ t = *a;\n+ *a = *a;\n+ */\n+ if (!operand_equal_p (dest2, src, 0)\n+ && !DECL_P (dest2) && !DECL_P (src))\n+ return false;\n+ \n+ if (dump_file && (dump_flags & TDF_DETAILS))\n+ {\n+ fprintf (dump_file, \"Simplified\\n \");\n+ print_gimple_stmt (dump_file, use_stmt, 0, dump_flags);\n+ fprintf (dump_file, \"after previous\\n \");\n+ print_gimple_stmt (dump_file, stmt, 0, dump_flags);\n+ }\n+ gimple_stmt_iterator gsi = gsi_for_stmt (use_stmt);\n+ gimple_assign_set_rhs_from_tree (&gsi, unshare_expr (src));\n+ update_stmt (use_stmt);\n+\n+ if (dump_file && (dump_flags & TDF_DETAILS))\n+ {\n+ fprintf (dump_file, \"into\\n \");\n+ print_gimple_stmt (dump_file, use_stmt, 0, dump_flags);\n+ }\n+ statistics_counter_event (cfun, \"copy prop for aggregate\", 1);\n+ return true;\n+}\n+\n+\n+static bool\n+optimize_agr_copyprop_arg (gimple *defstmt, gimple *use_stmt,\n+\t\t\t tree dest, tree src)\n+{\n+ gcall *call = dyn_cast(use_stmt);\n+ if (!call)\n+ return false;\n+ bool changed = false;\n+ for (unsigned arg = 0; arg < gimple_call_num_args (call); arg++)\n+ {\n+ tree *argptr = gimple_call_arg_ptr (call, arg);\n+ if (TREE_CODE (*argptr) == SSA_NAME\n+\t || is_gimple_min_invariant (*argptr)\n+\t || TYPE_VOLATILE (TREE_TYPE (*argptr)))\n+\tcontinue;\n+ if (!operand_equal_p (*argptr, dest, 0))\n+\tcontinue;\n+ if (dump_file && (dump_flags & TDF_DETAILS))\n+\t{\n+\t fprintf (dump_file, \"Simplified\\n \");\n+\t print_gimple_stmt (dump_file, call, 0, dump_flags);\n+\t fprintf (dump_file, \"after previous\\n \");\n+\t print_gimple_stmt (dump_file, defstmt, 0, dump_flags);\n+\t}\n+ *argptr = unshare_expr (src);\n+ changed = true;\n+ if (dump_file && (dump_flags & TDF_DETAILS))\n+\t{\n+\t fprintf (dump_file, \"into\\n \");\n+\t print_gimple_stmt (dump_file, call, 0, dump_flags);\n+\t}\n+ }\n+ if (changed)\n+ update_stmt (call);\n+ return changed;\n+}\n+\n /* Optimizes\n DEST = SRC;\n DEST2 = DEST; # DEST2 = SRC2;\n@@ -1420,56 +1517,10 @@ optimize_agr_copyprop (gimple_stmt_iterator *gsip)\n bool changed = false;\n FOR_EACH_IMM_USE_STMT (use_stmt, iter, vdef)\n {\n- if (!gimple_assign_load_p (use_stmt)\n-\t || !gimple_store_p (use_stmt))\n-\tcontinue;\n- if (gimple_has_volatile_ops (use_stmt))\n-\tcontinue;\n- tree dest2 = gimple_assign_lhs (use_stmt);\n- tree src2 = gimple_assign_rhs1 (use_stmt);\n- /* If the new store is `src2 = src2;` skip over it. */\n- if (operand_equal_p (src2, dest2, 0))\n-\tcontinue;\n- if (!operand_equal_p (dest, src2, 0))\n-\tcontinue;\n- /* For 2 memory refences and using a temporary to do the copy,\n-\t don't remove the temporary as the 2 memory references might overlap.\n-\t Note t does not need to be decl as it could be field.\n-\t See PR 22237 for full details.\n-\t E.g.\n-\t t = *a; #DEST = SRC;\n-\t *b = t; #DEST2 = SRC2;\n-\t Cannot be convert into\n-\t t = *a;\n-\t *b = *a;\n-\t Though the following is allowed to be done:\n-\t t = *a;\n-\t *a = t;\n-\t And convert it into:\n-\t t = *a;\n-\t *a = *a;\n- */\n- if (!operand_equal_p (dest2, src, 0)\n-\t && !DECL_P (dest2) && !DECL_P (src))\n-\tcontinue;\n- if (dump_file && (dump_flags & TDF_DETAILS))\n-\t{\n-\t fprintf (dump_file, \"Simplified\\n \");\n-\t print_gimple_stmt (dump_file, use_stmt, 0, dump_flags);\n-\t fprintf (dump_file, \"after previous\\n \");\n-\t print_gimple_stmt (dump_file, stmt, 0, dump_flags);\n-\t}\n- gimple_stmt_iterator gsi = gsi_for_stmt (use_stmt);\n- gimple_assign_set_rhs_from_tree (&gsi, unshare_expr (src));\n- update_stmt (use_stmt);\n-\n- if (dump_file && (dump_flags & TDF_DETAILS))\n-\t{\n-\t fprintf (dump_file, \"into\\n \");\n-\t print_gimple_stmt (dump_file, use_stmt, 0, dump_flags);\n-\t}\n- statistics_counter_event (cfun, \"copy prop for aggregate\", 1);\n- changed = true;\n+ if (optimize_agr_copyprop_1 (stmt, use_stmt, dest, src))\n+\tchanged = true;\n+ else if (optimize_agr_copyprop_arg (stmt, use_stmt, dest, src))\n+\tchanged = true;\n }\n return changed;\n }\n","prefixes":["v1","4/6"]}