{"id":2226718,"url":"http://patchwork.ozlabs.org/api/patches/2226718/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuom29jc4.gcc.gcc-TEST.pinskia.61.1.6@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-22T18:30:31","name":"[v1,6/6] Copy prop for references","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4364ab1bc7b7d3bf7544ff544fb650b27669f46c","submitter":{"id":93219,"url":"http://patchwork.ozlabs.org/api/people/93219/?format=json","name":"Andrew Pinski via Sourceware Forge","email":"forge-bot+pinskia@forge-stage.sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuom29jc4.gcc.gcc-TEST.pinskia.61.1.6@forge-stage.sourceware.org/mbox/","series":[{"id":501080,"url":"http://patchwork.ozlabs.org/api/series/501080/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501080","date":"2026-04-22T18:30:28","name":"copy-propv3","version":1,"mbox":"http://patchwork.ozlabs.org/series/501080/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226718/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226718/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g17Zg2yQsz1y2d\n\tfor ; Thu, 23 Apr 2026 04:50:19 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 6E80F41AC5D7\n\tfor ; Wed, 22 Apr 2026 18:50:17 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id E6B7C4CCCA3A\n for ; Wed, 22 Apr 2026 18:32:06 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 31EB9434D3\n for ; Wed, 22 Apr 2026 18:32:05 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 6E80F41AC5D7","OpenDKIM Filter v2.11.0 sourceware.org E6B7C4CCCA3A"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org E6B7C4CCCA3A","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org E6B7C4CCCA3A","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776882727; cv=none;\n b=oi/ermZ1TQabdftApuaYzRi2g2kd9031iXtCTHFqEma+P3xM9OqJ337NUsEaWnAVhJKCESBKEogo5HZxeRtmKP4eWr41basqzao7P5zGaJGAgbAL1oKCVRpn9ehKN25tTtxhEYH0gVnOYSalnufCZVyMHWlnBVFO2i7BD6KNoCY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776882727; c=relaxed/simple;\n bh=YKGDpxmG3hZni1iS9MaccHCzVC7M2NsNhqh97VknNOk=;\n h=From:Date:Subject:To:Message-ID;\n b=MIMBb9bRzH7QNhzcTcbdouG/xRucY22GChoH7diHYQbV/kXrVBNwenuzqaKmvKKP1egKux+o2DFeAuSZXd5Pl63I787x03SyhKp6ckkn4qRASOIfFx81fDppwSoUOkBWnIKQUVfjmuW/EgmXvHfWU0rmz9AKxWInKNHoLSFl6EI=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"Andrew Pinski via Sourceware Forge\n ","Date":"Wed, 22 Apr 2026 18:30:31 +0000","Subject":"[PATCH v1 6/6] Copy prop for references","To":"gcc-patches mailing list ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/61","References":"\n ","In-Reply-To":"\n ","X-Patch-URL":"\n https://forge.sourceware.org/pinskia/gcc-TEST/commit/9bcf6cb51e0de0dbc93595cbeea9b65ae3068c2b","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"gcc-patches mailing list ,\n pinskia@gcc.gnu.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Andrew Pinski \n\ngcc/ChangeLog:\n\n\t* gimple-fold.cc (maybe_canonicalize_mem_ref_addr):\n\t* gimple-fold.h (maybe_canonicalize_mem_ref_addr):\n\t* tree-ssa-forwprop.cc (optimize_agr_copyprop_access):\n\t(optimize_agr_copyprop):\n\nSigned-off-by: Andrew Pinski \n---\n gcc/gimple-fold.cc | 19 +++++++--\n gcc/gimple-fold.h | 2 +\n gcc/tree-ssa-forwprop.cc | 87 ++++++++++++++++++++++++++++++++++++++++\n 3 files changed, 105 insertions(+), 3 deletions(-)","diff":"diff --git a/gcc/gimple-fold.cc b/gcc/gimple-fold.cc\nindex 49e344094fd6..48656682e4fd 100644\n--- a/gcc/gimple-fold.cc\n+++ b/gcc/gimple-fold.cc\n@@ -6262,8 +6262,8 @@ replace_stmt_with_simplification (gimple_stmt_iterator *gsi,\n \n /* Canonicalize MEM_REFs invariant address operand after propagation. */\n \n-static bool\n-maybe_canonicalize_mem_ref_addr (tree *t, bool is_debug = false)\n+bool\n+maybe_canonicalize_mem_ref_addr (tree *t, bool is_debug)\n {\n bool res = false;\n tree *orig_t = t;\n@@ -6333,7 +6333,20 @@ maybe_canonicalize_mem_ref_addr (tree *t, bool is_debug = false)\n \t gcc_unreachable ();\n \t }\n \n-\t TREE_OPERAND (*t, 0) = build_fold_addr_expr (base);\n+\t /* For MEM[&MEM[ssa + CST0] + CST1] just reduce it to\n+\t MEM[ssa + (CST0 + CST1)]. */\n+\t if (TREE_CODE (base) == MEM_REF)\n+\t {\n+\t TREE_OPERAND (*t, 0) = TREE_OPERAND (base, 0);\n+\t poly_offset_int off = mem_ref_offset (base);\n+\t coffset += off.force_shwi ();\n+\t }\n+\t else\n+\t {\n+\t TREE_OPERAND (*t, 0) = build_fold_addr_expr (base);\n+\t STRIP_USELESS_TYPE_CONVERSION (TREE_OPERAND (*t, 0));\n+\t }\n+\n \t TREE_OPERAND (*t, 1) = int_const_binop (PLUS_EXPR,\n \t\t\t\t\t\t TREE_OPERAND (*t, 1),\n \t\t\t\t\t\t size_int (coffset));\ndiff --git a/gcc/gimple-fold.h b/gcc/gimple-fold.h\nindex e3cf1f651c2d..cb1545d14d29 100644\n--- a/gcc/gimple-fold.h\n+++ b/gcc/gimple-fold.h\n@@ -39,6 +39,8 @@ extern tree maybe_fold_or_comparisons (tree, enum tree_code, tree, tree,\n \t\t\t\t basic_block = nullptr);\n extern bool optimize_atomic_compare_exchange_p (gimple *);\n extern void fold_builtin_atomic_compare_exchange (gimple_stmt_iterator *);\n+extern bool maybe_canonicalize_mem_ref_addr (tree *t, bool is_debug = false);\n+\n extern tree no_follow_ssa_edges (tree);\n extern tree follow_single_use_edges (tree);\n extern tree follow_all_ssa_edges (tree);\ndiff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc\nindex 60354ab03ad1..e1ee1e9735b1 100644\n--- a/gcc/tree-ssa-forwprop.cc\n+++ b/gcc/tree-ssa-forwprop.cc\n@@ -1485,6 +1485,91 @@ optimize_agr_copyprop_arg (gimple *defstmt, gimple *use_stmt,\n return changed;\n }\n \n+static bool\n+optimize_agr_copyprop_access (gimple *defstmt, gimple *use_stmt,\n+\t\t\t tree dest, tree src)\n+{\n+ if (!gimple_assign_single_p (use_stmt))\n+ return false;\n+ tree rhs = gimple_assign_rhs1 (use_stmt);\n+ if (!REFERENCE_CLASS_P (rhs))\n+ return false;\n+ bool was_inside_mem = false;\n+ tree val = unshare_expr (rhs);\n+ tree *rhsptr = &val;\n+ gimple_stmt_iterator gsi = gsi_for_stmt (use_stmt);\n+ while (handled_component_p (*rhsptr))\n+ rhsptr = &TREE_OPERAND (*rhsptr, 0);\n+ if (TREE_CODE (*rhsptr) == MEM_REF\n+ && TREE_CODE (TREE_OPERAND (*rhsptr, 0)) == ADDR_EXPR)\n+ {\n+ was_inside_mem = true;\n+ rhsptr = &TREE_OPERAND (TREE_OPERAND (*rhsptr, 0), 0);\n+ }\n+ if (!DECL_P (*rhsptr))\n+ return false;\n+ if (!operand_equal_p (*rhsptr, dest, 0))\n+ return false;\n+ /* Check that the alignment is ok for the replacement. */\n+ unsigned new_inner_align = DECL_P (src) ? DECL_ALIGN (src) : TYPE_ALIGN (TREE_TYPE (src));\n+ unsigned old_inner_align = DECL_ALIGN (*rhsptr);\n+ unsigned old_outer_align = TYPE_ALIGN (TREE_TYPE (rhs));\n+ /* FIXME: Handle doing unaligned loads. */\n+ if (old_inner_align > new_inner_align\n+ && old_outer_align > new_inner_align)\n+ {\n+ if (dump_file && (dump_flags & TDF_DETAILS))\n+\t{\n+\t fprintf (dump_file, \"Rejected due to alignment (%u > %u).\\n\",\n+\t\t old_inner_align, new_inner_align);\n+\t}\n+ return false;\n+ }\n+ poly_int64 coffset;\n+ /* If this was `MEM_REF[&a]`, want to replace\n+ a with MEM_REF[&nrhs] so maybe_canonicalize_mem_ref_addr\n+ can re-canonicalized the mem ref and the correct the ADDR_EXPR. */\n+ if (was_inside_mem)\n+ {\n+ tree tnrhs = unshare_expr (src);\n+ /* VCE in this case can be removed is because we are building MEM_REF[&a]. */\n+ if (TREE_CODE (src) == VIEW_CONVERT_EXPR)\n+\tsrc = TREE_OPERAND (src, 0);\n+ src = build_fold_addr_expr (src);\n+ STRIP_USELESS_TYPE_CONVERSION (src);\n+ /* Since we are replacing inside a MEM_REF,\n+ the address needs simple and can't\n+\t have non constant parts to it. */\n+ if (!get_addr_base_and_unit_offset (tnrhs, &coffset))\n+\tsrc = force_gimple_operand_gsi (&gsi, src, true,\n+\t\t\t\t\t NULL_TREE, true,\n+\t\t\t\t\t GSI_SAME_STMT);\n+ tree srcptrtype = build_pointer_type_for_mode (TREE_TYPE (src), ptr_mode, true);\n+ src = fold_build2 (MEM_REF, TREE_TYPE (*rhsptr),\n+\t\t\t src,\n+\t\t\t build_zero_cst (srcptrtype));\n+ }\n+ else\n+ src = unshare_expr (src);\n+ *rhsptr = src;\n+ if (dump_file && (dump_flags & TDF_DETAILS))\n+\t{\n+\t fprintf (dump_file, \"Simplified\\n \");\n+\t print_gimple_stmt (dump_file, use_stmt, 0, dump_flags);\n+\t fprintf (dump_file, \"after previous\\n \");\n+\t print_gimple_stmt (dump_file, defstmt, 0, dump_flags);\n+\t}\n+ maybe_canonicalize_mem_ref_addr (&val);\n+ gimple_assign_set_rhs_from_tree (&gsi, val);\n+ update_stmt (use_stmt);\n+ if (dump_file && (dump_flags & TDF_DETAILS))\n+\t{\n+\t fprintf (dump_file, \"into\\n \");\n+\t print_gimple_stmt (dump_file, use_stmt, 0, dump_flags);\n+\t}\n+ return true;\n+}\n+\n /* Optimizes\n DEST = SRC;\n DEST2 = DEST; # DEST2 = SRC2;\n@@ -1543,6 +1628,8 @@ optimize_agr_copyprop (gimple_stmt_iterator *gsip)\n \t changed = true;\n else if (optimize_agr_copyprop_arg (stmt, use_stmt, dest, src))\n \t changed = true;\n+ else if (optimize_agr_copyprop_access (stmt, use_stmt, dest, src))\n+\t changed = true;\n }\n }\n \n","prefixes":["v1","6/6"]}