{"id":2226715,"url":"http://patchwork.ozlabs.org/api/patches/2226715/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260422184757.706485-1-dmitry.mityugov@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422184757.706485-1-dmitry.mityugov@gmail.com>","list_archive_url":null,"date":"2026-04-22T18:47:53","name":"[ovs-dev,v1] expr: fix an old copy/paste error.","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"c2813785d779654830829a124b8589c6022b396c","submitter":{"id":92493,"url":"http://patchwork.ozlabs.org/api/people/92493/?format=json","name":"Dmitry Mityugov","email":"dmitry.mityugov@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260422184757.706485-1-dmitry.mityugov@gmail.com/mbox/","series":[{"id":501081,"url":"http://patchwork.ozlabs.org/api/series/501081/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=501081","date":"2026-04-22T18:47:53","name":"[ovs-dev,v1] expr: fix an old copy/paste error.","version":1,"mbox":"http://patchwork.ozlabs.org/series/501081/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226715/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2226715/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FpvqsxcH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=FpvqsxcH","smtp2.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp2.osuosl.org; dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FpvqsxcH"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g17XP076Sz1yD5\n\tfor ; Thu, 23 Apr 2026 04:48:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id DB96484B68;\n\tWed, 22 Apr 2026 18:48:16 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xkdnevDdik-h; Wed, 22 Apr 2026 18:48:14 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id C93FE84B4B;\n\tWed, 22 Apr 2026 18:48:14 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 99033C058E;\n\tWed, 22 Apr 2026 18:48:14 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 94FC3C058D\n for ; Wed, 22 Apr 2026 18:48:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 8012740671\n for ; Wed, 22 Apr 2026 18:48:13 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id W3q0WGqimVvA for ;\n Wed, 22 Apr 2026 18:48:13 +0000 (UTC)","from mail-lf1-x136.google.com (mail-lf1-x136.google.com\n [IPv6:2a00:1450:4864:20::136])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 962734019E\n for ; Wed, 22 Apr 2026 18:48:12 +0000 (UTC)","by mail-lf1-x136.google.com with SMTP id\n 2adb3069b0e04-5a2c77c62d7so6454879e87.0\n for ; Wed, 22 Apr 2026 11:48:12 -0700 (PDT)","from localhost.localdomain ([5.8.36.110])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a4185bc25csm4651292e87.26.2026.04.22.11.48.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 11:48:07 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org C93FE84B4B","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 962734019E"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::136; helo=mail-lf1-x136.google.com;\n envelope-from=dmitry.mityugov@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 962734019E","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776883690; x=1777488490; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=xn4loAhYRMgplEAh2qm1G5AcCNLYMKz/w7uJebr2ORM=;\n b=FpvqsxcHp4D+yB8qJ7VabMrCX5p8quSegPezmrlcuPDZ0Ksc3kQ9rwxB7ZHunUUZyb\n J6noFFekqHvAWn0AwTGZ6xkpaIWFxyunUHgOrnGtctFfCHsqQ+TZau8mTBUu90uFNDWM\n raSwTYXuXg0PzIjAfxC8l9K46LPlLX2KJ/9xcdPuEYmubyuIOBi5oKt00h6fLTt5X4TZ\n JQt5Odmy1ASqsfyMb6YQrAs2j+bTgU5q3Zef7GX7ryo54zVjC0ANrI5kvfJuMwmoAHaM\n /8tgvzSYhS9ro/AaZHwYlWPLCU8EZr1t1PmtbVG6tt2A+kTuMzGdVahTlTry2hgI/c75\n qSlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776883690; x=1777488490;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xn4loAhYRMgplEAh2qm1G5AcCNLYMKz/w7uJebr2ORM=;\n b=F0v2qCr36VPGaEgggtY+dx37AA6M02pAlGHQahW/fLRe88aF+vhx1NwtOOL0C3V9CK\n wpDnBj2KtRxNQEJr7TY5QRCXiLvI+Z8bk8uLr0hMK0zzoooGylC/6Y/57wHZwSt99LY4\n XvIA6aGl0wXKHDFds1BQvdGyTyMnBHPZDSypyYAMs/cn8p7NOHNoROEM5hiAr0yTRhSr\n Kfg//zBn161zKQc19f58Xk9sY3lw8f2iCm50rNllGLWgwsog9LEFrFqYKTghLfXXUDIq\n dFbv/hsrLYHAI1KkQHO4Zq4QiCxRs3h7L7p9wLLdIkJRARSmcM+aLbmnsPoLEc2TtNZP\n dugw==","X-Gm-Message-State":"AOJu0YzDGeH8zWJR7/sIMdxxXM5Fj636mwXQRKCNTY+BB6PKOetyLwPK\n SUcPOR4PzpSJf5fXfmH8Ek39dp6KpI7sKFIPVbLZTjrm9Jx4tqMfkOm7k3Z0oEn838N0B/M6","X-Gm-Gg":"AeBDievW32Dw+DRsofu3Gs2mEaNeyrrXibOcVnQhvwNiMogK/OiF6Mh+hO1ALm9g7wt\n Vr5tncgfGUrz496tEYL7srlQuPxm01xaCRfgpJ809ZIxjFIgzzIDzZjAI7G2s70yvDguiO4LuXG\n T/Qiwb/siyUiF6dc8P1Q8Qsm7hhJmlbh9epj2PyolHgmPh3823Z+nkGpzC6cg2qh2zKOKeoUM1f\n qtEwuT1L8y41oGvo1RQzPC7ZUBRY0v6XE7F6CGP6KUOVaHNnKBAr7ABoEKDynDeolgBPZ2e12ZI\n NPFrrmXI42jddkI2xLdTbjDgO7vt2m6jrMVyAa8tV0KB/cHuPsHG/479BiCn8D+O8pzznsX6xKD\n m1m9ytwofJR8J5qaJA9rhV1oTJQIS6hV2uqlVnO417OE96PtXs8hO0ovZCvwXcdQsLZF+4C/zb9\n 3950PQ0K113LI5KpnHk3q5yT8BNyLWYL6RvWchzpXyC5Fx4tAc","X-Received":"by 2002:a05:6512:2308:b0:5a2:b51a:6a55 with SMTP id\n 2adb3069b0e04-5a4172dd839mr6249245e87.29.1776883689616;\n Wed, 22 Apr 2026 11:48:09 -0700 (PDT)","From":"Dmitry Mityugov ","To":"ovs-dev@openvswitch.org","Date":"Wed, 22 Apr 2026 21:47:53 +0300","Message-ID":"<20260422184757.706485-1-dmitry.mityugov@gmail.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH v1] expr: fix an old copy/paste error.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Without this fix, expression\n\na_type < b_type ? -1 : a_type > b_type\n\nalways evaluates to 0.\n\nOriginally discovered with cppcheck.\n\nSigned-off-by: Dmitry Mityugov \n---\n lib/expr.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/lib/expr.c b/lib/expr.c\nindex 288e245c6..3c506c42c 100644\n--- a/lib/expr.c\n+++ b/lib/expr.c\n@@ -2366,7 +2366,7 @@ compare_expr_sort(const void *a_, const void *b_)\n }\n \n enum expr_type a_type = a->expr->type;\n- enum expr_type b_type = a->expr->type;\n+ enum expr_type b_type = b->expr->type;\n return a_type < b_type ? -1 : a_type > b_type;\n } else if (a->type == EXPR_T_AND || a->type == EXPR_T_OR) {\n size_t a_len = ovs_list_size(&a->expr->andor);\n","prefixes":["ovs-dev","v1"]}