{"id":2226681,"url":"http://patchwork.ozlabs.org/api/patches/2226681/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuodmon6a.gcc.gcc-TEST.alfie.richards.49.1.1@forge-stage.sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-22T18:21:49","name":"[v1,01/13] cgraph: Add clone_identifier function.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"167277d81b7d4d33ae2a703a3277c32ad1635a87","submitter":{"id":93228,"url":"http://patchwork.ozlabs.org/api/people/93228/?format=json","name":"\\\"alfie.richards via Sourceware Forge\\\"","email":"forge-bot+alfie.richards@forge-stage.sourceware.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuodmon6a.gcc.gcc-TEST.alfie.richards.49.1.1@forge-stage.sourceware.org/mbox/","series":[{"id":501072,"url":"http://patchwork.ozlabs.org/api/series/501072/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501072","date":"2026-04-22T18:21:54","name":"FMV refactor and ACLE compliance for C++","version":1,"mbox":"http://patchwork.ozlabs.org/series/501072/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226681/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226681/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g174F6vmZz1yGs\n\tfor ; Thu, 23 Apr 2026 04:27:25 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 24F514BAE7DE\n\tfor ; Wed, 22 Apr 2026 18:27:24 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 59C974422AA3\n for ; Wed, 22 Apr 2026 18:23:30 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 2F53943454\n for ; Wed, 22 Apr 2026 18:23:30 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 24F514BAE7DE","OpenDKIM Filter v2.11.0 sourceware.org 59C974422AA3"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 59C974422AA3","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 59C974422AA3","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776882210; cv=none;\n b=bgBRTGrJAkqAIG1t+5hdY7FF2rtpWkd8XoLPhoduOyjEOS3No06A8KQKP1IKpgDveoXGI/KakZj0h/kWXfC8m7R1QnusHx3rYzM/qHjaXppEMUoVTteMYB/5HjTKyrKnvIZLTDQMrdUdzN1pj58c2dBgePM4LW1hucVayTpozj0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776882210; c=relaxed/simple;\n bh=bw+iPJEf2Vo14KoBpX1t3271U4K9E00cdKJr83RXha0=;\n h=From:Date:Subject:To:Message-ID;\n b=nOojZP/HFmWSYf3ziH3TYv1OBf+t4v4pjXHjmD8vET/5r7BBRsTX/ABk4BL3t7mT9bJ0sO0a8/uRbwkTvOzjsRGzf6pn7SO0BL1EKFpVzapwduX8EVlBe974neAPOes66YCJAB0iPQOMIDFcol80dlvVXZ+ggisL3HhIpkAnGOA=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"\"\\\"alfie.richards via Sourceware Forge\\\"\"\n ","Date":"Wed, 22 Apr 2026 18:21:49 +0000","Subject":"[PATCH v1 01/13] cgraph: Add clone_identifier function.","To":"gcc-patches mailing list ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":["rsandifo","rearnsha"],"X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/49","References":"\n ","In-Reply-To":"\n ","X-Patch-URL":"\n https://forge.sourceware.org/alfie.richards/gcc-TEST/commit/3da1de4fa21d0fe8f34bcfdf325b2724717b41eb","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"gcc-patches mailing list ,\n alfierichards@sourceware.org","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Alfie Richards \n\nThis is similar to clone_function_name and its siblings but takes an\nidentifier tree node rather than a function declaration.\n\nThis is to be used in conjunction with the identifier node stored in\ncgraph_function_version_info::assembler_name to mangle FMV functions in\nlater patches.\n\ngcc/ChangeLog:\n\n\t* cgraph.h (clone_identifier): New function.\n\t* cgraphclones.cc (clone_identifier): New function.\n\t(clone_function_name): Refactored to use clone_identifier.\n\t(is_valid_asm_symbol): New helper function.\n---\n gcc/cgraph.h | 2 ++\n gcc/cgraphclones.cc | 58 +++++++++++++++++++++++++++++++++++++++------\n 2 files changed, 53 insertions(+), 7 deletions(-)","diff":"diff --git a/gcc/cgraph.h b/gcc/cgraph.h\nindex deca564a8e37..189fa74497bf 100644\n--- a/gcc/cgraph.h\n+++ b/gcc/cgraph.h\n@@ -2644,6 +2644,8 @@ tree clone_function_name (const char *name, const char *suffix,\n tree clone_function_name (tree decl, const char *suffix,\n \t\t\t unsigned long number);\n tree clone_function_name (tree decl, const char *suffix);\n+tree clone_identifier (tree decl, const char *suffix,\n+\t\t bool filter_suffix = false);\n \n void tree_function_versioning (tree, tree, vec *,\n \t\t\t ipa_param_adjustments *,\ndiff --git a/gcc/cgraphclones.cc b/gcc/cgraphclones.cc\nindex c160e8b6985b..e23ced168607 100644\n--- a/gcc/cgraphclones.cc\n+++ b/gcc/cgraphclones.cc\n@@ -570,6 +570,32 @@ clone_function_name (tree decl, const char *suffix)\n /* For consistency this needs to behave the same way as\n ASM_FORMAT_PRIVATE_NAME does, but without the final number\n suffix. */\n+ return clone_identifier (identifier, suffix);\n+}\n+\n+/* Return true if symbol is valid in assembler name. */\n+\n+static bool\n+is_valid_asm_symbol (char c)\n+{\n+ if ('a' <= c && c <= 'z')\n+ return true;\n+ if ('A' <= c && c <= 'Z')\n+ return true;\n+ if ('0' <= c && c <= '9')\n+ return true;\n+ if (c == '_')\n+ return true;\n+ return false;\n+}\n+\n+/* Return a new clone of ID ending with the string SUFFIX.\n+ If FILTER_SUFFIX is true, any illegal asm characters in the SUFFIX are\n+ replaced with _. */\n+\n+tree\n+clone_identifier (tree id, const char *suffix, bool filter_suffix)\n+{\n char *separator = XALLOCAVEC (char, 2);\n separator[0] = symbol_table::symbol_suffix_separator ();\n separator[1] = 0;\n@@ -578,14 +604,32 @@ clone_function_name (tree decl, const char *suffix)\n #else\n const char *prefix = \"\";\n #endif\n- char *result = ACONCAT ((prefix,\n-\t\t\t IDENTIFIER_POINTER (identifier),\n-\t\t\t separator,\n-\t\t\t suffix,\n-\t\t\t (char*)0));\n- return get_identifier (result);\n-}\n+ if (!suffix)\n+ suffix = \"\";\n \n+ if (!filter_suffix)\n+ {\n+ char *result = ACONCAT (\n+\t(prefix, IDENTIFIER_POINTER (id), separator, suffix, (char *) 0));\n+ return get_identifier (result);\n+ }\n+ else\n+ {\n+ /* Replace any illegal chars with _. */\n+ int suffix_len = strlen (suffix);\n+ char *converted_suffix = XALLOCAVEC (char, suffix_len + 1);\n+ for (int i = 0; i < suffix_len; i++)\n+\tif (!is_valid_asm_symbol (suffix[i]))\n+\t converted_suffix[i] = '_';\n+\telse\n+\t converted_suffix[i] = suffix[i];\n+ converted_suffix[suffix_len] = '\\0';\n+\n+ char *result = ACONCAT ((prefix, IDENTIFIER_POINTER (id), separator,\n+\t\t\t converted_suffix, (char *) 0));\n+ return get_identifier (result);\n+ }\n+}\n \n /* Create callgraph node clone with new declaration. The actual body will be\n copied later at compilation stage. The name of the new clone will be\n","prefixes":["v1","01/13"]}